RFR: 8350314: Shenandoah: Capture thread state sync times in GC timings [v7]

Xiaolong Peng xpeng at openjdk.org
Wed Feb 26 22:23:24 UTC 2025


On Wed, 26 Feb 2025 22:14:44 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use ShenandoahTimingsTracker instead of ShenandoahGCPhase to track the timings of gc state propagation
>
> src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp line 60:
> 
>> 58:   f(init_transfer_satb,                             "  Transfer Old From SATB")        \
>> 59:   f(init_update_region_states,                      "  Update Region States")          \
>> 60:   f(init_propagate_gc_state,                        "  Propagate GC state")            \
> 
> Sorry, one last thing. Note how all our counters are Capitalized, so all these should be `Propagate GC State`.

Fixed, thanks! sorry I should have noticed the naming convention here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23759#discussion_r1972502610


More information about the shenandoah-dev mailing list