RFR: 8349094: GenShen: Race between control and regulator threads may violate assertions [v17]
William Kemper
wkemper at openjdk.org
Thu Feb 27 18:47:24 UTC 2025
> There are several changes to the operation of Shenandoah's control threads here.
> * The reason for cancellation is now recorded in `ShenandoahHeap::_cancelled_gc` as a `GCCause`, instead of various member variables in the control thread.
> * The cancellation handling is driven entirely by the cancellation cause
> * The graceful shutdown, alloc failure, humongous alloc failure and preemption requested flags are all removed
> * The shutdown sequence is simpler
> * The generational control thread uses a lock to coordinate updates to the requested cause and generation
> * APIs have been simplified to avoid converting between the generation `type` and the actual generation instance
> * The old heuristic, rather than the control thread itself, is now responsible for resuming old generation cycles
> * The control thread doesn't loop on its own (unless the pacer is enabled).
>
> ## Testing
> * jtreg hotspot_gc_shenandoah
> * dacapo, extremem, diluvian, specjbb2015, specjvm2018, heapothesys
William Kemper has updated the pull request incrementally with one additional commit since the last revision:
Don't check for shutdown in control thread loop condition
It may cause the thread to exit before it is requested to stop
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23475/files
- new: https://git.openjdk.org/jdk/pull/23475/files/d2e90dde..150cb798
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23475&range=16
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23475&range=15-16
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/23475.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23475/head:pull/23475
PR: https://git.openjdk.org/jdk/pull/23475
More information about the shenandoah-dev
mailing list