RFR: 8347804: GenShen: Crash with small GCCardSizeInBytes and small Java heap [v2]

[Kelvin Nilsen]

On Thu, 27 Feb 2025 17:49:16 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to reviewer feedback
>
> src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp line 192:
> 
>> 190: 
>> 191:   if (GCCardSizeInBytes < ShenandoahMinCardSizeInBytes) {
>> 192:     char buf[512];
> 
> It looks like using `err_msg` here is more idiomatic than `os:snprintf` for errors during initialization.

Thanks.  I've made this change.

> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 950:
> 
>> 948:   ShenandoahHeap* const heap = ShenandoahHeap::heap();
>> 949:   assert(heap->is_concurrent_weak_root_in_progress(), "Only during this phase");
>> 950:   {
> 
> This looks like it came from https://github.com/openjdk/jdk/pull/23604. Did you cherry-pick that into this branch? Not sure why it shows in the diff here.

Looks like I accidentally did cherry-pick into my gitfarm variant of this branch, and then merged into the github version of the branch.  The merge history must have gotten confused.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23373#discussion_r1974210655
PR Review Comment: https://git.openjdk.org/jdk/pull/23373#discussion_r1974206670