RFR: 8345169: Implement JEP XXX: Remove the 32-bit x86 Port

David Holmes dholmes at openjdk.org
Thu Jan 9 01:21:15 UTC 2025


On Tue, 7 Jan 2025 09:13:06 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/interpreter/abstractInterpreter.cpp line 137:
>> 
>>> 135:       case vmIntrinsics::_floatToRawIntBits: return java_lang_Float_floatToRawIntBits;
>>> 136:       case vmIntrinsics::_longBitsToDouble:  return java_lang_Double_longBitsToDouble;
>>> 137:       case vmIntrinsics::_doubleToRawLongBits: return java_lang_Double_doubleToRawLongBits;
>> 
>> Why are these intrinsics for the Java methods disappearing?
>
> These are interpreter "intrinsics" that are only implemented on x86_32 to handle x87 FPU pecularities. Look around for `TemplateInterpreterGenerator::generate_Float_intBitsToFloat_entry`, for example.

Hmmm ... okay ... I see something "special" is done only on x86_32, but what is done seems to have nothing to do with x87 code.

Just to be clear these Java methods still get intrinsified, it is just handled in a different way - right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22567#discussion_r1908061750


More information about the shenandoah-dev mailing list