RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v6]

David Holmes dholmes at openjdk.org
Tue Jan 14 01:18:43 UTC 2025


On Mon, 13 Jan 2025 15:49:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> There are a lot of format modifiers that are noisy and unnecessary in the code.  This change removes the INTX variants.  It's not that disruptive even for backporting because %z modifier has been available for a long time so should backport fine.  This was mostly done with a sed script plus some hand fixups.
>> 
>> Testing mach5 and other platform cross compilations in progress.  Opening this for GHA testing.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add Oracle copyright to shenandoah files for this change.

We have belatedly discovered that `0x%zx` and `%#zx` behave differently in their handling of zero. The former prints `0x0` while the latter just prints `0`. This has broken the compiler replay tests as the parsing of 0 no longer works.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22916#issuecomment-2588550581


More information about the shenandoah-dev mailing list