RFR: 8360707: Globally enumerate all blobs, stubs and entries

Andrew Dinn adinn at openjdk.org
Tue Jul 1 08:52:42 UTC 2025


On Mon, 30 Jun 2025 20:54:45 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Use the blob, stub and entry declarations to generate a single global enumeration for all blobs, likewise for all stubs and all entries. Modify stub generators in shared runtime, c1 runtime, c2 runtime and stub generator subsystems and their clients to use those enumerations consistently.
>
> src/hotspot/share/runtime/stubRoutines.cpp line 235:
> 
>> 233: SharedRuntime::_jbyte_array_copy_ctr++;      // Slow-path byte array copy
>> 234: #endif // !PRODUCT
>> 235: Copy::conjoint_jbytes_atomic(src, dest, count);
> 
> Why you removed leading spaces here and in the following methods?

Sorry, I mistakenly reformatted more a larger region than I should. Reverted.

> src/hotspot/share/runtime/stubRoutines.cpp line 378:
> 
>> 376: #define RETURN_STUB_PARM(xxx_arraycopy, parm) {                 \
>> 377:     name = parm ? #xxx_arraycopy "_uninit": #xxx_arraycopy;     \
>> 378:     return StubRoutines::xxx_arraycopy(parm); }
> 
> No need these spacing changes - it was fine.

Same issue. All restored.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2176878410
PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2176879334


More information about the shenandoah-dev mailing list