RFR: 8360775: Fix Shenandoah GC test failures when APX is enabled [v2]
Srinivas Vamsi Parasa
sparasa at openjdk.org
Tue Jul 1 21:27:41 UTC 2025
On Tue, 1 Jul 2025 06:04:18 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> restore the orginal contents of rax
>
> src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp line 387:
>
>> 385: __ movptr(Address(rsp, (--slot) * wordSize), r29);
>> 386: __ movptr(Address(rsp, (--slot) * wordSize), r30);
>> 387: __ movptr(Address(rsp, (--slot) * wordSize), r31);
>
> I think you should use pushp2 / pop2p for these instructions also , maybe it can be handled along with
> https://github.com/openjdk/jdk/pull/25889
Thanks Jatin (@jatin-bhateja) for the review and approval! This modification will be pursued in another PR (say #25889).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26009#discussion_r2178557739
More information about the shenandoah-dev
mailing list