RFR: 8360707: Globally enumerate all blobs, stubs and entries [v5]

Andrew Dinn adinn at openjdk.org
Sun Jul 6 15:25:47 UTC 2025


On Thu, 3 Jul 2025 19:27:05 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - save blobs using blob ids
>>  - make arg in declaration consistent with definition
>
> src/hotspot/share/opto/compile.cpp line 976:
> 
>> 974:   // try to reuse an existing stub
>> 975:   {
>> 976:     StubId stub_id = static_cast<StubId>(_stub_id);
> 
> `static_cast` can be avoided if `_stub_id` type is changed from `int` to `StubId`. And there is a similar `static_cast` in output.cpp as well.

I think this conversion to int was done to avoid a problem with include dependencies. It is certainly not an issue now that StubId is statically generated in a header already included in all affected files. I have pushed a fix to remove the int casts and use StubId instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2188392663


More information about the shenandoah-dev mailing list