RFR: 8361349: Fix visibility of CollectedHeap::stop() and ::print_tracing_info() [v2]
Ivan Walulya
iwalulya at openjdk.org
Mon Jul 7 16:36:39 UTC 2025
On Mon, 7 Jul 2025 16:21:57 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this refactoring to improve the visibility of `CollectedHeap::stop()` and `CH::print_tracing_info()`.
>>
>> The change moves these methods to `protected` visibility.
>>
>> Testing: gha
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> * iwalulya suggested to make leaf classes use private; although probably one wants to use final, but Hotspot does not seem to use that
Nit:
src/hotspot/share/gc/epsilon/epsilonHeap.hpp line 52:
> 50: volatile size_t _last_heap_print;
> 51:
> 52: private:
private: can be removed.
-------------
Marked as reviewed by iwalulya (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26160#pullrequestreview-2994627357
PR Review Comment: https://git.openjdk.org/jdk/pull/26160#discussion_r2190587513
More information about the shenandoah-dev
mailing list