From andrew at openjdk.org Sun Jun 1 20:10:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 20:10:26 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 18 new changesets Message-ID: Changeset: f3c87ce7 Branch: master Author: Andrew John Hughes Date: 2022-05-30 15:12:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f3c87ce70bcc8421ec40e393e9649dfac30d2336 8287521: Bump update version of OpenJDK: 8u352 Reviewed-by: sgehwolf ! .jcheck/conf ! common/autoconf/version-numbers Changeset: 820ab134 Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-05-31 06:21:10 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/820ab134927cb76c61cf9c144637d18e0e2a4f2c 8235385: Crash on aarch64 JDK due to long offset 8287508: The tests added to jdk-8 by 8235385 are to be ported to jdk-11 Co-authored-by: Wang Zhuo Co-authored-by: Andrew Haley Reviewed-by: aph, andrew Backport-of: 156c486e920b1ca406064dd189562b830990f7f9 ! hotspot/src/cpu/aarch64/vm/aarch64.ad ! hotspot/src/cpu/aarch64/vm/ad_encode.m4 + hotspot/test/compiler/8235385/NonVolatileMemoryAccessWithLongOffset.java Changeset: 83e90957 Branch: master Author: Alex Kasko Date: 2022-06-15 11:25:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/83e90957bef15267bed792ee5d8d65899a2487e8 8280963: Incorrect PrintFlags formatting on Windows Reviewed-by: andrew ! hotspot/src/share/vm/runtime/globals.cpp + hotspot/test/runtime/CommandLine/PrintFlagsUintxTest.java Changeset: cf6b6282 Branch: master Author: yibo.yl Committer: Denghui Dong Date: 2022-06-27 12:27:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/cf6b6282c4836e561e88a114a8d72db4180b160c 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*) Reviewed-by: zgu Backport-of: a9d2267f8d306522522c999ff584ccaa34c46456 ! hotspot/src/share/vm/jfr/recorder/checkpoint/types/jfrTypeSet.cpp ! hotspot/src/share/vm/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp ! hotspot/src/share/vm/jfr/recorder/checkpoint/types/traceid/jfrTraceId.hpp ! hotspot/src/share/vm/jfr/support/jfrTraceIdExtension.hpp ! hotspot/src/share/vm/oops/typeArrayKlass.cpp + jdk/test/jdk/jfr/jvm/TestPrimitiveClasses.java Changeset: 1b4f32d6 Branch: master Author: Dongbo He Date: 2022-06-29 16:30:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1b4f32d61e3b0460c82598f24dbd5c4dd0fc3bbe 8173361: various crashes in JvmtiExport::post_compiled_method_load Don't post information that uses metadata from unloaded nmethods Reviewed-by: andrew, sspitsyn Backport-of: b1d915ef80ebdf511dc2897b20ada78b3dc44241 ! hotspot/src/share/vm/code/nmethod.cpp ! hotspot/src/share/vm/oops/instanceKlass.cpp ! hotspot/src/share/vm/prims/jvmtiExport.cpp ! hotspot/src/share/vm/prims/jvmtiImpl.cpp ! hotspot/src/share/vm/prims/jvmtiImpl.hpp ! hotspot/src/share/vm/runtime/serviceThread.cpp ! hotspot/src/share/vm/runtime/serviceThread.hpp ! hotspot/src/share/vm/runtime/thread.hpp Changeset: a3c0ed26 Branch: master Author: Yuri Nesterenko Date: 2022-06-30 11:10:31 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a3c0ed269c37879c4763f2a58b5d469b7797e3c3 8087283: Add support for the XML Signature here() function to the JDK XPath implementation Reviewed-by: andrew Backport-of: 22fad64529a890dd3ae8b07c7981d9a720cf8e96 ! jaxp/src/com/sun/org/apache/xpath/internal/compiler/FunctionTable.java ! jaxp/src/com/sun/org/apache/xpath/internal/compiler/Keywords.java + jaxp/src/com/sun/org/apache/xpath/internal/functions/FuncHere.java ! jdk/src/share/classes/com/sun/org/apache/xml/internal/security/utils/XalanXPathAPI.java Changeset: ce73401e Branch: master Author: Takakuri Committer: Paul Hohensee Date: 2022-07-07 11:40:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ce73401ef42bbe758aa1ed6e6b3412bf70ef63b4 8136354: [TEST_BUG] Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script Backport-of: da688f57c3822e0327ad717290bed88baa73bd17 ! jdk/test/java/awt/image/RescaleOp/RescaleAlphaTest.java Changeset: 6e8292f1 Branch: master Author: Jaroslav Bachorik Date: 2022-07-08 14:29:12 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6e8292f1d997aa160a9826967ee4467e93585bc7 8283849: AsyncGetCallTrace may crash JVM on guarantee Reviewed-by: phh Backport-of: 19639855311a47ed532547743ea3873eb8b016d3 ! hotspot/src/share/vm/code/codeCache.cpp ! hotspot/src/share/vm/prims/forte.cpp ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/share/vm/runtime/thread.hpp Changeset: eeef4de5 Branch: master Author: Dongbo He Committer: Paul Hohensee Date: 2022-07-08 17:58:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/eeef4de5dcf3bd9c5aff971ac9181c13c64a66f8 8150669: C1 intrinsic for Class.isPrimitive Reviewed-by: phh Backport-of: 890f94d7e6be731ac2ebae2f1ad3cc20ec836115 ! hotspot/src/share/vm/c1/c1_Canonicalizer.cpp ! hotspot/src/share/vm/c1/c1_GraphBuilder.cpp ! hotspot/src/share/vm/c1/c1_LIRGenerator.cpp ! hotspot/src/share/vm/c1/c1_LIRGenerator.hpp + hotspot/test/compiler/intrinsics/klass/TestIsPrimitive.java Changeset: e0051850 Branch: master Author: Dongbo He Committer: Andrew John Hughes Date: 2022-07-10 15:19:42 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e005185072cbf0b79b62bcfa7a37f9e1a2e03af2 8235218: Minimal VM is broken after JDK-8173361 Reviewed-by: sgehwolf, andrew Backport-of: c10f731b11f314c97660df08c62f3c3d2f718f54 ! hotspot/src/share/vm/prims/jvmtiImpl.hpp Changeset: 972112ed Branch: master Author: Dongbo He Committer: Fei Yang Date: 2022-07-11 02:49:54 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/972112ed520b8f5465ae15c47e6af2db92aa3a58 8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit Reviewed-by: phh Backport-of: b67ca938f37f952e53f73d2e0b8ebcaf96139fda ! hotspot/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp ! hotspot/src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! hotspot/src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! hotspot/src/share/vm/c1/c1_LIRGenerator.cpp ! hotspot/test/compiler/intrinsics/klass/TestIsPrimitive.java Changeset: 4f7dd0ca Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-07-11 06:25:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4f7dd0ca1625e9b870174ee21f9423cb4ff7ae09 8256722: handle VC++:1927 VS2019 in abstract_vm_version Backport-of: 146fe86ff68095b5eb0ce1387061699738280c06 ! hotspot/src/share/vm/runtime/vm_version.cpp Changeset: 0de66bd8 Branch: master Author: Olga Mikhaltsova Committer: Yuri Nesterenko Date: 2022-07-11 11:11:05 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0de66bd811c89d8648d3751f60fe46aaa2eb26fc 8282538: PKCS11 tests fail on CentOS Stream 9 Backport-of: d8fd22239bafecdaaedb8985ab6d709ed846e808 = jdk/test/sun/security/pkcs11/nss/db/cert9.db = jdk/test/sun/security/pkcs11/nss/db/key4.db Changeset: de9f1497 Branch: master Author: Olga Mikhaltsova Committer: Yuri Nesterenko Date: 2022-07-11 11:11:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/de9f14976a285fcf1ea073c374582d6965e4f0dd 8194873: right ALT key hotkeys no longer work in Swing components 8155742: [Windows] robot.keyPress(KeyEvent.VK_ALT_GRAPH) throws java.lang.IllegalArgumentException in windows Reviewed-by: alitvinov, yan, serb Backport-of: 91f281c8d713e489ddc282f935ebd879485c4b41 ! jdk/src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! jdk/src/share/classes/javax/swing/plaf/basic/BasicButtonListener.java ! jdk/src/share/classes/javax/swing/plaf/basic/BasicLabelUI.java ! jdk/src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! jdk/src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! jdk/src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! jdk/src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! jdk/src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! jdk/src/share/classes/sun/swing/SwingUtilities2.java ! jdk/src/windows/native/sun/windows/awt_Component.cpp ! jdk/src/windows/native/sun/windows/awt_Robot.cpp ! jdk/test/java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java ! jdk/test/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java + jdk/test/javax/swing/event/RightAltKeyTest.java Changeset: 40a18594 Branch: master Author: Takakuri Committer: Paul Hohensee Date: 2022-07-12 12:03:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/40a18594ba21d7a345ff82792fc361f7e691e669 8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9 Backport-of: 4140fd05a447c888856c54aee22c475173030833 ! jdk/src/share/classes/java/awt/KeyboardFocusManager.java ! jdk/src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java Changeset: f7f6d9d0 Branch: master Author: Andrew John Hughes Date: 2022-07-21 02:31:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f7f6d9d07fa3f166fe0155f80c61730c1c788ac5 Merge Changeset: 1460bfaf Branch: master Author: Andrew John Hughes Date: 2022-08-01 20:16:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1460bfaf8a3be7c4772bfbb75b8a3a31560a2c2c Merge Changeset: 86c4e6f6 Branch: master Author: Andrew John Hughes Date: 2025-06-01 20:39:52 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/86c4e6f64d93e7eda29b0e15a48041cc5c4d4c66 Merge jdk8u352-b01 Added tag jdk8u352-b01 for changeset 1460bfaf8a3 ! .jcheck/conf ! hotspot/src/cpu/aarch64/vm/aarch64.ad ! hotspot/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp ! hotspot/src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! hotspot/src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! hotspot/src/share/vm/c1/c1_LIRGenerator.cpp ! hotspot/src/share/vm/c1/c1_LIRGenerator.hpp ! hotspot/src/share/vm/code/codeCache.cpp ! hotspot/src/share/vm/code/nmethod.cpp ! hotspot/src/share/vm/oops/instanceKlass.cpp ! hotspot/src/share/vm/runtime/globals.cpp ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/share/vm/runtime/thread.hpp ! .jcheck/conf ! hotspot/src/cpu/aarch64/vm/aarch64.ad ! hotspot/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp ! hotspot/src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! hotspot/src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! hotspot/src/share/vm/c1/c1_LIRGenerator.cpp ! hotspot/src/share/vm/c1/c1_LIRGenerator.hpp ! hotspot/src/share/vm/code/codeCache.cpp ! hotspot/src/share/vm/code/nmethod.cpp ! hotspot/src/share/vm/oops/instanceKlass.cpp ! hotspot/src/share/vm/runtime/globals.cpp ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/share/vm/runtime/thread.hpp From andrew at openjdk.org Sun Jun 1 20:10:40 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 20:10:40 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b01 for changeset 1460bfaf Message-ID: Tagged by: Andrew John Hughes Date: 2022-08-04 02:19:03 +0000 Added tag jdk8u352-b01 for changeset 1460bfaf8a3 Changeset: 1460bfaf Author: Andrew John Hughes Date: 2022-08-01 20:16:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1460bfaf8a3be7c4772bfbb75b8a3a31560a2c2c From andrew at openjdk.org Sun Jun 1 21:18:00 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 21:18:00 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u352-b02 ------------- Commit messages: - Merge jdk8u352-b02 - 8287132: Retire Runtime.runFinalizersOnExit so that it always throws UOE - 8288865: [aarch64] LDR instructions must use legitimized addresses - 8290000: Bump macOS GitHub actions to macOS 11 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=24&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=24&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/24/files Stats: 770 lines in 29 files changed: 247 ins; 367 del; 156 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/24.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/24/head:pull/24 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/24 From andrew at openjdk.org Sun Jun 1 21:29:07 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 21:29:07 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sun, 1 Jun 2025 21:13:09 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b02 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/24#issuecomment-2927921609 From andrew at openjdk.org Sun Jun 1 21:46:42 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 21:46:42 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 4 new changesets Message-ID: <4857874b-bcd8-498f-9bff-c63ab369708a@openjdk.org> Changeset: 39fa6fb1 Branch: master Author: George Adams Committer: Christoph Langer Date: 2022-08-04 07:11:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/39fa6fb17215d823aacad51669750b76c987973d 8290000: Bump macOS GitHub actions to macOS 11 Reviewed-by: sgehwolf Backport-of: 4e6cd67fec3d978f4c8c1aed95a1d09b544eff68 ! .github/workflows/submit.yml Changeset: deae94f8 Branch: master Author: Alexey Pavlyutkin Committer: Severin Gehwolf Date: 2022-08-04 13:40:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/deae94f8e3805cf806967d7b320c20d87c0ffab0 8288865: [aarch64] LDR instructions must use legitimized addresses Reviewed-by: adinn Backport-of: 1f4028960a3934853104efd1d95991b137b5f520 ! hotspot/src/cpu/aarch64/vm/aarch64.ad ! hotspot/src/cpu/aarch64/vm/ad_encode.m4 ! hotspot/test/compiler/8235385/NonVolatileMemoryAccessWithLongOffset.java Changeset: b52eb70f Branch: master Author: David Holmes Date: 2022-08-05 21:04:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b52eb70faf9f4e2646400c9565af67e6916c5ac9 8287132: Retire Runtime.runFinalizersOnExit so that it always throws UOE Reviewed-by: hseigel, iris, andrew Backport-of: 0d4cfc090c651786535529acfe5acb0209cb1d3d ! hotspot/make/aix/makefiles/mapfile-vers-debug ! hotspot/make/aix/makefiles/mapfile-vers-product ! hotspot/make/bsd/makefiles/mapfile-vers-debug ! hotspot/make/bsd/makefiles/mapfile-vers-product ! hotspot/make/linux/makefiles/mapfile-vers-debug ! hotspot/make/linux/makefiles/mapfile-vers-product ! hotspot/make/solaris/makefiles/mapfile-vers ! hotspot/src/share/vm/classfile/vmSymbols.hpp ! hotspot/src/share/vm/memory/universe.cpp ! hotspot/src/share/vm/memory/universe.hpp ! hotspot/src/share/vm/prims/jvm.cpp ! hotspot/src/share/vm/prims/jvm.h ! hotspot/src/share/vm/runtime/java.hpp ! hotspot/src/share/vm/runtime/thread.cpp ! jdk/make/mapfiles/libjava/mapfile-vers ! jdk/src/share/classes/java/lang/Runtime.java ! jdk/src/share/classes/java/lang/Shutdown.java ! jdk/src/share/classes/java/lang/System.java ! jdk/src/share/classes/java/lang/ref/Finalizer.java ! jdk/src/share/javavm/export/jvm.h ! jdk/src/share/native/java/lang/Shutdown.c - jdk/test/java/lang/System/ExitFinalizersAndJIT.java - jdk/test/java/lang/System/finalization/FinExit.java - jdk/test/java/lang/System/finalization/FinExit.sh + jdk/test/java/lang/System/finalization/RunFinalizersOnExit.java Changeset: 84d7ca88 Branch: master Author: Andrew John Hughes Date: 2025-06-01 21:07:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/84d7ca884f12de35471c17430b192b30c6db7e77 Merge jdk8u352-b02 Added tag jdk8u352-b02 for changeset b52eb70faf9 ! hotspot/src/cpu/aarch64/vm/aarch64.ad ! hotspot/src/share/vm/memory/universe.cpp ! hotspot/src/share/vm/prims/jvm.cpp ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/cpu/aarch64/vm/aarch64.ad ! hotspot/src/share/vm/memory/universe.cpp ! hotspot/src/share/vm/prims/jvm.cpp ! hotspot/src/share/vm/runtime/thread.cpp From andrew at openjdk.org Sun Jun 1 21:46:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 21:46:59 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b01 for changeset 86c4e6f6 Message-ID: <04351092-a389-43a0-8305-5725038c6a3c@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-01 21:07:14 +0000 Added tag shenandoah8u352-b01 for changeset 86c4e6f64d9 Changeset: 86c4e6f6 Author: Andrew John Hughes Date: 2025-06-01 20:39:52 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/86c4e6f64d93e7eda29b0e15a48041cc5c4d4c66 From andrew at openjdk.org Sun Jun 1 21:47:02 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 21:47:02 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b02 for changeset b52eb70f Message-ID: <1ea80f54-ef23-4a7a-8a9a-071fdb60cd35@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-08-11 04:10:47 +0000 Added tag jdk8u352-b02 for changeset b52eb70faf9 Changeset: b52eb70f Author: David Holmes Date: 2022-08-05 21:04:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b52eb70faf9f4e2646400c9565af67e6916c5ac9 From andrew at openjdk.org Sun Jun 1 21:47:08 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 21:47:08 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b02 for changeset 84d7ca88 Message-ID: <6508a580-60c6-48a5-8fc1-b8e31ddacc4f@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-01 22:11:45 +0000 Added tag shenandoah8u352-b02 for changeset 84d7ca884f1 Changeset: 84d7ca88 Author: Andrew John Hughes Date: 2025-06-01 21:07:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/84d7ca884f12de35471c17430b192b30c6db7e77 From andrew at openjdk.org Sun Jun 1 21:48:51 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 21:48:51 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u352-b02 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/24/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/24/files/84d7ca88..84d7ca88 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=24&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=24&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/24.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/24/head:pull/24 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/24 From iris at openjdk.org Sun Jun 1 21:48:51 2025 From: iris at openjdk.org (Iris Clark) Date: Sun, 1 Jun 2025 21:48:51 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sun, 1 Jun 2025 21:13:09 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b02 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/24 From andrew at openjdk.org Sun Jun 1 22:49:32 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 22:49:32 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u352-b03 ------------- Commit messages: - Merge jdk8u352-b03 - 8071507: (ref) Clear phantom reference as soft and weak references do The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=25&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=25&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/25/files Stats: 173 lines in 10 files changed: 105 ins; 48 del; 20 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/25.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/25/head:pull/25 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/25 From andrew at openjdk.org Sun Jun 1 22:51:16 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 22:51:16 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 2 new changesets Message-ID: <3c947aff-7525-4b63-9f79-60e5e0087075@openjdk.org> Changeset: 0869fc01 Branch: master Author: Poonam Bajaj Date: 2022-08-11 13:56:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0869fc0153bde09c41ad37c3c46f715e23b41966 8071507: (ref) Clear phantom reference as soft and weak references do 8143847: Remove REF_CLEANER reference category Reviewed-by: iris, dholmes, mchung, andrew Backport-of: ad6cdea5ae385623afa86251a8278c9c5274f4c1 ! hotspot/src/share/vm/classfile/systemDictionary.cpp ! hotspot/src/share/vm/classfile/systemDictionary.hpp ! hotspot/src/share/vm/classfile/vmSymbols.hpp ! hotspot/src/share/vm/memory/referenceProcessor.cpp ! hotspot/src/share/vm/memory/referenceProcessor.hpp ! hotspot/src/share/vm/memory/referenceType.hpp ! hotspot/src/share/vm/runtime/vmStructs.cpp ! jdk/src/share/classes/java/lang/ref/PhantomReference.java ! jdk/src/share/classes/java/lang/ref/package.html + jdk/test/java/lang/ref/PhantomReferentClearing.java Changeset: 98bd5e30 Branch: master Author: Andrew John Hughes Date: 2025-06-01 23:16:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/98bd5e301fa3c205734e00b19a8461086a3399ff Merge jdk8u352-b03 Added tag jdk8u352-b03 for changeset HEAD^ ! hotspot/src/share/vm/memory/referenceProcessor.cpp ! hotspot/src/share/vm/memory/referenceProcessor.hpp ! hotspot/src/share/vm/runtime/vmStructs.cpp ! hotspot/src/share/vm/memory/referenceProcessor.cpp ! hotspot/src/share/vm/memory/referenceProcessor.hpp ! hotspot/src/share/vm/runtime/vmStructs.cpp From andrew at openjdk.org Sun Jun 1 22:51:25 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 22:51:25 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b03 for changeset 0869fc01 Message-ID: Tagged by: Andrew John Hughes Date: 2022-08-17 17:07:29 +0000 Added tag jdk8u352-b03 for changeset HEAD^ Changeset: 0869fc01 Author: Poonam Bajaj Date: 2022-08-11 13:56:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0869fc0153bde09c41ad37c3c46f715e23b41966 From andrew at openjdk.org Sun Jun 1 22:51:28 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 22:51:28 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b03 for changeset 98bd5e30 Message-ID: <97471943-0de6-4d5e-ba69-7575d0d13f61@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-01 23:36:30 +0000 Added tag shenandoah8u352-b03 for changeset 98bd5e301fa Changeset: 98bd5e30 Author: Andrew John Hughes Date: 2025-06-01 23:16:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/98bd5e301fa3c205734e00b19a8461086a3399ff From andrew at openjdk.org Sun Jun 1 22:52:31 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 22:52:31 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u352-b03 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/25/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/25/files/98bd5e30..98bd5e30 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=25&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=25&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/25.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/25/head:pull/25 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/25 From andrew at openjdk.org Sun Jun 1 22:52:31 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 22:52:31 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sun, 1 Jun 2025 22:45:14 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b03 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/25#issuecomment-2928049775 From iris at openjdk.org Sun Jun 1 22:52:31 2025 From: iris at openjdk.org (Iris Clark) Date: Sun, 1 Jun 2025 22:52:31 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sun, 1 Jun 2025 22:45:14 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b03 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/25 From andrew at openjdk.org Sun Jun 1 23:40:11 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 23:40:11 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u352-b04 ------------- Commit messages: - Merge jdk8u352-b04 - 8214427: probable bug in logic of ConcurrentHashMap.addCount() - 8288763: Pack200 extraction failure with invalid size - 8245263: Enable TLSv1.3 by default on JDK 8u for Client roles The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/26/files Stats: 41 lines in 17 files changed: 5 ins; 3 del; 33 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/26.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/26/head:pull/26 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/26 From andrew at openjdk.org Sun Jun 1 23:40:12 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 23:40:12 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: <-UU8Bezt2kN_kJFOqZMOHp-xsjW9jxWiPydBlbRkQ08=.d7689167-bded-4ebb-b46e-405f430f317e@github.com> On Sun, 1 Jun 2025 23:35:10 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b04 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/26#issuecomment-2928120933 From andrew at openjdk.org Sun Jun 1 23:41:40 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 23:41:40 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 4 new changesets Message-ID: Changeset: 8e2c4984 Branch: master Author: Alexey Bakhtin Date: 2022-08-16 18:47:09 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8e2c498478231661a10f88854ce8afe26f0c0cd0 8245263: Enable TLSv1.3 by default on JDK 8u for Client roles Reviewed-by: mbalao ! jdk/src/share/classes/sun/security/ssl/SSLContextImpl.java ! jdk/test/javax/net/ssl/SSLSession/ResumeTLS13withSNI.java ! jdk/test/javax/net/ssl/SSLSocket/Tls13PacketSize.java ! jdk/test/javax/net/ssl/Stapling/HttpsUrlConnClient.java ! jdk/test/javax/net/ssl/Stapling/SSLEngineWithStapling.java ! jdk/test/javax/net/ssl/Stapling/SSLSocketWithStapling.java ! jdk/test/javax/net/ssl/Stapling/StapleEnableProps.java ! jdk/test/javax/net/ssl/TLS/TLSClientPropertyTest.java ! jdk/test/javax/net/ssl/sanity/ciphersuites/CheckCipherSuites.java ! jdk/test/sun/security/ssl/HandshakeHash/HandshakeHashCloneExhaustion.java ! jdk/test/sun/security/ssl/SSLContextImpl/CustomizedServerDefaultProtocols.java ! jdk/test/sun/security/ssl/SSLContextImpl/DefaultEnabledProtocols.java ! jdk/test/sun/security/ssl/SSLSessionImpl/ResumeChecksClient.java ! jdk/test/sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java ! jdk/test/sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java Changeset: 645b6c81 Branch: master Author: Tyler Steele Committer: Paul Hohensee Date: 2022-08-17 19:48:31 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/645b6c81bc9230ce5808fc4bd70240fc1311cdd4 8288763: Pack200 extraction failure with invalid size Reviewed-by: phh Backport-of: 5e1ce54d6a11eac153a6e6487bc0b4ed89741b5b ! jdk/src/share/classes/com/sun/java/util/jar/pack/Utils.java Changeset: 4cc462ab Branch: master Author: Poison Committer: Paul Hohensee Date: 2022-08-20 11:31:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4cc462abdd39f24e7f09b13f64af74bc2f1318d2 8214427: probable bug in logic of ConcurrentHashMap.addCount() Reviewed-by: phh, andrew Backport-of: 8846159987f902bb6e2b966eb4656da4b6d9469d ! jdk/src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: 0562578d Branch: master Author: Andrew John Hughes Date: 2025-06-01 23:49:46 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0562578d232e635431886990cdedc07545bb55a9 Merge jdk8u352-b04 Added tag jdk8u352-b04 for changeset 4cc462abdd39f24e7f09b13f64af74bc2f1318d2 From andrew at openjdk.org Sun Jun 1 23:41:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 23:41:50 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b04 for changeset 4cc462ab Message-ID: <30c4bea4-7e38-4127-9f58-ded49ebf898a@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-08-26 14:40:43 +0000 Added tag jdk8u352-b04 for changeset 4cc462abdd39f24e7f09b13f64af74bc2f1318d2 Changeset: 4cc462ab Author: Poison Committer: Paul Hohensee Date: 2022-08-20 11:31:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4cc462abdd39f24e7f09b13f64af74bc2f1318d2 From andrew at openjdk.org Sun Jun 1 23:41:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 23:41:53 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b04 for changeset 0562578d Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-02 00:24:22 +0000 Added tag shenandoah8u352-b04 for changeset 0562578d232 Changeset: 0562578d Author: Andrew John Hughes Date: 2025-06-01 23:49:46 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0562578d232e635431886990cdedc07545bb55a9 From andrew at openjdk.org Sun Jun 1 23:43:44 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 1 Jun 2025 23:43:44 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: <32xuyFiBlJNm_aGN00LXJmylM0W5vQSpaN1fS2sivYA=.9a6dcfe9-7aa5-4718-b591-10a4cf4776ef@github.com> > Merge jdk8u352-b04 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/26/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/26/files/0562578d..0562578d Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=26&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=26&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/26.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/26/head:pull/26 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/26 From iris at openjdk.org Sun Jun 1 23:43:45 2025 From: iris at openjdk.org (Iris Clark) Date: Sun, 1 Jun 2025 23:43:45 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sun, 1 Jun 2025 23:35:10 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b04 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/26 From andrew at openjdk.org Mon Jun 2 00:13:16 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:13:16 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u352-b05 ------------- Commit messages: - Merge jdk8u352-b05 - 8292688: Support Security properties in security.testlibrary.Proc - 7131823: bug in GIFImageReader - 8139668: Generate README-build.html from markdown - 8173339: AArch64: Fix minimum stack size computations - 8049228: Improve multithreaded scalability of InetAddress cache - 8285497: Add system property for Java SE specification maintenance version - 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures. - 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000] - 8254318: Remove .hgtags - ... and 5 more: https://git.openjdk.org/shenandoah-jdk8u/compare/0562578d...81d58f87 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/27/files Stats: 15497 lines in 53 files changed: 2258 ins; 12004 del; 1235 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/27.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/27/head:pull/27 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/27 From andrew at openjdk.org Mon Jun 2 00:20:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:20:45 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u352-b05 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/27/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/27/files/81d58f87..81d58f87 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=27&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=27&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/27.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/27/head:pull/27 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/27 From iris at openjdk.org Mon Jun 2 00:20:46 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 2 Jun 2025 00:20:46 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Mon, 2 Jun 2025 00:09:17 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b05 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/27 From andrew at openjdk.org Mon Jun 2 00:21:16 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:21:16 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 15 new changesets Message-ID: Changeset: 5323ef6c Branch: master Author: George Adams Committer: Paul Hohensee Date: 2022-08-22 12:40:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5323ef6ca1bbf0a6e333565f97526fc5494081dc 8254178: Remove .hgignore Reviewed-by: phh, andrew Backport-of: 736e077335ec53c3804537a6abefa79087efd3ad - .hgignore - corba/.hgignore - hotspot/.hgignore - jaxp/.hgignore - jaxws/.hgignore - jdk/.hgignore - langtools/.hgignore - nashorn/.hgignore Changeset: e633df1b Branch: master Author: Poonam Bajaj Date: 2022-08-22 13:45:13 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e633df1b629c4045e792623dbbb36b1b263f3683 8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing 8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored 8193780: (ref) Remove the undocumented "jdk.lang.ref.disableClearBeforeEnqueue" system property Reviewed-by: mchung, dholmes, iris, andrew Backport-of: 330d63d2f9e18ba069e11868d4381059c66f480f ! jdk/src/share/classes/java/lang/ref/FinalReference.java ! jdk/src/share/classes/java/lang/ref/Reference.java ! jdk/test/java/lang/ref/ReferenceEnqueue.java Changeset: 1b52b014 Branch: master Author: Zdenek Zambersky Committer: Paul Hohensee Date: 2022-08-22 16:10:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1b52b014b6150efd480810d6561414c782c1f8c7 8183107: PKCS11 regression regarding checkKeySize Changed key size check in PKCS11 provider to only enforce positive return values Reviewed-by: phh, andrew Backport-of: 67ca52873f088a08705baeef3e66319de1600576 ! jdk/src/share/classes/sun/security/pkcs11/P11KeyGenerator.java ! jdk/src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java ! jdk/src/share/classes/sun/security/pkcs11/P11Signature.java ! jdk/src/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM_INFO.java Changeset: 3a5b2cdc Branch: master Author: Poonam Bajaj Date: 2022-08-22 19:53:40 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3a5b2cdc101f501fb7681d6c1ce20f68db08f004 8201793: (ref) Reference object should not support cloning Reviewed-by: mchung, iris, andrew Backport-of: 58ec25de2f383144417eb000efacecb78b30395c ! jdk/src/share/classes/java/lang/ref/Reference.java + jdk/test/java/lang/ref/ReferenceClone.java Changeset: 8ad9018e Branch: master Author: Poonam Bajaj Date: 2022-08-22 20:06:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8ad9018e42916b683e163c1c7629a9ba9962aed4 8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3 Reviewed-by: mchung, iris, andrew Backport-of: 3740d05c063e1f80a0808a969a2cc136cafa48cb ! jdk/src/share/classes/java/security/Signature.java ! jdk/src/share/classes/java/security/interfaces/RSAKey.java ! jdk/src/share/classes/java/security/spec/MGF1ParameterSpec.java ! jdk/src/share/classes/java/security/spec/PSSParameterSpec.java ! jdk/src/share/classes/java/security/spec/RSAKeyGenParameterSpec.java ! jdk/src/share/classes/java/security/spec/RSAMultiPrimePrivateCrtKeySpec.java ! jdk/src/share/classes/java/security/spec/RSAPrivateCrtKeySpec.java ! jdk/src/share/classes/java/security/spec/RSAPrivateKeySpec.java ! jdk/src/share/classes/java/security/spec/RSAPublicKeySpec.java ! jdk/src/share/classes/javax/net/ssl/SSLEngine.java ! jdk/src/share/classes/javax/net/ssl/SSLParameters.java ! jdk/src/share/classes/javax/net/ssl/SSLSocket.java Changeset: a4d49735 Branch: master Author: George Adams Committer: Christoph Langer Date: 2022-08-24 08:01:12 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a4d497350218b38070164a71acc7502110567547 8254318: Remove .hgtags Reviewed-by: andrew Backport-of: 62a7f5d3236ab2248518a475b1d8b71cb4bf1313 - .hgtags - .hgtags-top-repo - corba/.hgtags - hotspot/.hgtags - jaxp/.hgtags - jaxws/.hgtags - jdk/.hgtags - langtools/.hgtags - nashorn/.hgtags Changeset: 41c7d2d7 Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-08-24 17:33:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/41c7d2d74d328f1b75a8271fbdc834679edbbae6 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000] Backport-of: 3555038f51fbf7f908b7346a8329f4da44a7cde5 ! jdk/test/jdk/lambda/LambdaTranslationTest1.java ! jdk/test/jdk/lambda/LambdaTranslationTest2.java Changeset: e3251a22 Branch: master Author: Zdenek Zambersky Committer: Andrew John Hughes Date: 2022-08-24 17:44:49 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e3251a2293f2eeb286e3075269b1d132acae22bf 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures. Fixed to treat the queried key size values as bits instead of bytes Reviewed-by: andrew Backport-of: f14e3a60b26f0488da26abf3ae6c0521d5f616e5 ! jdk/src/share/classes/sun/security/pkcs11/P11PSSSignature.java Changeset: d0ad2422 Branch: master Author: Joe Darcy Date: 2022-08-24 19:35:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d0ad2422d172bc436dad619adf78ce51285c2388 8285497: Add system property for Java SE specification maintenance version Reviewed-by: dholmes, iris, mchung, andrew Backport-of: 31a63ba5f255e09349b3842984ac5bb3ad8e6c0b ! jdk/src/share/classes/java/lang/System.java ! jdk/src/share/classes/sun/security/provider/PolicyFile.java ! jdk/src/share/lib/security/java.policy ! jdk/src/share/native/java/lang/System.c Changeset: 22230588 Branch: master Author: Peter Levart Committer: Paul Hohensee Date: 2022-08-26 12:25:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/222305888bda3f0e225839d832cdf8983996a229 8049228: Improve multithreaded scalability of InetAddress cache 7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate Reviewed-by: andrew, phh Backport-of: 250fbb065a789a303d692d698c9b69117bf6cd2c ! jdk/src/share/classes/java/net/InetAddress.java ! jdk/src/share/classes/sun/net/InetAddressCachePolicy.java Changeset: de32daa3 Branch: master Author: Dongbo He Committer: Andrew John Hughes Date: 2022-08-26 14:26:06 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/de32daa3efba67db204e86c8ed4380603432b3c6 8173339: AArch64: Fix minimum stack size computations Reviewed-by: aph Backport-of: 540ec375c30e973ceb1a944d5cc60cc8532e88ec ! hotspot/src/cpu/aarch64/vm/globals_aarch64.hpp Changeset: d102764b Branch: master Author: Andrew John Hughes Date: 2022-08-26 15:22:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d102764ba4675280113f2dd96908ed13ee5a37a8 8139668: Generate README-build.html from markdown Reviewed-by: phh Backport-of: 17c896827dbf1a54ab6539cc2b506f973dbde246 ! README-builds.html + README-builds.md + common/bin/update-build-readme.sh Changeset: 026a6c58 Branch: master Author: Dan Lutker Committer: Paul Hohensee Date: 2022-08-26 17:41:08 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/026a6c58afe2ff4ec851c5ea4905c68c87b4d7c0 7131823: bug in GIFImageReader Reviewed-by: phh Backport-of: a31130fd4056907edcb420761722c629a33273eb ! jdk/src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java + jdk/test/javax/imageio/plugins/gif/GIFLargeTableIndexTest.java Changeset: 0d5ea9d2 Branch: master Author: Martin Balao Date: 2022-08-26 21:48:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0d5ea9d29e97f1e4adcc1e1d36bc109fc5cee506 8292688: Support Security properties in security.testlibrary.Proc Reviewed-by: sgehwolf ! jdk/test/java/security/testlibrary/Proc.java Changeset: 81d58f87 Branch: master Author: Andrew John Hughes Date: 2025-06-02 00:41:52 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/81d58f874b1390adcb6a6db936512e739eb47a67 Merge jdk8u352-b05 Added tag jdk8u352-b05 for changeset 0d5ea9d29e97f1e4adcc1e1d36bc109fc5cee506 From andrew at openjdk.org Mon Jun 2 00:21:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:21:26 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b00 for changeset 0d5ea9d2 Message-ID: Tagged by: Andrew John Hughes Date: 2022-09-01 18:32:28 +0000 Added tag jdk8u362-b00 for changeset 0d5ea9d29e9 Changeset: 0d5ea9d2 Author: Martin Balao Date: 2022-08-26 21:48:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0d5ea9d29e97f1e4adcc1e1d36bc109fc5cee506 From andrew at openjdk.org Mon Jun 2 00:21:30 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:21:30 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b00 for changeset 81d58f87 Message-ID: <4ec13143-6e41-4d75-a55e-150f94e6a672@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-02 01:07:22 +0000 Added tag shenandoah8u362-b00 for changeset 81d58f874b1 Changeset: 81d58f87 Author: Andrew John Hughes Date: 2025-06-02 00:41:52 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/81d58f874b1390adcb6a6db936512e739eb47a67 From andrew at openjdk.org Mon Jun 2 00:21:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:21:35 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b05 for changeset 0d5ea9d2 Message-ID: <2a656f15-78c3-478b-af9b-e2329693cd54@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-08-31 02:27:37 +0000 Added tag jdk8u352-b05 for changeset 0d5ea9d29e97f1e4adcc1e1d36bc109fc5cee506 Changeset: 0d5ea9d2 Author: Martin Balao Date: 2022-08-26 21:48:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0d5ea9d29e97f1e4adcc1e1d36bc109fc5cee506 From andrew at openjdk.org Mon Jun 2 00:21:42 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:21:42 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b05 for changeset 81d58f87 Message-ID: <4005cbde-4660-476a-9d12-0f3e426437ae@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-02 01:05:36 +0000 Added tag shenandoah8u352-b05 for changeset 81d58f874b1 Changeset: 81d58f87 Author: Andrew John Hughes Date: 2025-06-02 00:41:52 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/81d58f874b1390adcb6a6db936512e739eb47a67 From andrew at openjdk.org Mon Jun 2 00:25:06 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 00:25:06 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: On Mon, 2 Jun 2025 00:20:45 GMT, Andrew John Hughes wrote: >> Merge jdk8u352-b05 > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/27#issuecomment-2928188371 From tschatzl at openjdk.org Mon Jun 2 07:41:52 2025 From: tschatzl at openjdk.org (Thomas Schatzl) Date: Mon, 2 Jun 2025 07:41:52 GMT Subject: RFR: 8357944: Remove unused CollectedHeap::is_maximal_no_gc In-Reply-To: References: Message-ID: <2QWPYqes70JwJ-5k9C91yuFeLb-aVFKClOgyovWLFwY=.8faa61a4-a9f5-4a75-83fb-2cde568d71a0@github.com> On Wed, 28 May 2025 07:17:14 GMT, Albert Mingkun Yang wrote: > Removing effectively dead code/API for all GCs except G1. Marked as reviewed by tschatzl (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/25482#pullrequestreview-2887146273 From andrew at openjdk.org Mon Jun 2 08:25:21 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 08:25:21 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u352-b06 ------------- Commit messages: - Merge jdk8u352-b06 - 8028265: Add legacy tz tests to OpenJDK The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/28/files Stats: 1221 lines in 9 files changed: 1221 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/28.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/28/head:pull/28 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/28 From andrew at openjdk.org Mon Jun 2 08:25:21 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 08:25:21 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Mon, 2 Jun 2025 08:20:42 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b06 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/28#issuecomment-2929385560 From ayang at openjdk.org Mon Jun 2 08:28:04 2025 From: ayang at openjdk.org (Albert Mingkun Yang) Date: Mon, 2 Jun 2025 08:28:04 GMT Subject: RFR: 8357944: Remove unused CollectedHeap::is_maximal_no_gc In-Reply-To: References: Message-ID: On Wed, 28 May 2025 07:17:14 GMT, Albert Mingkun Yang wrote: > Removing effectively dead code/API for all GCs except G1. Thanks for review. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25482#issuecomment-2929388616 From ayang at openjdk.org Mon Jun 2 08:28:04 2025 From: ayang at openjdk.org (Albert Mingkun Yang) Date: Mon, 2 Jun 2025 08:28:04 GMT Subject: Integrated: 8357944: Remove unused CollectedHeap::is_maximal_no_gc In-Reply-To: References: Message-ID: On Wed, 28 May 2025 07:17:14 GMT, Albert Mingkun Yang wrote: > Removing effectively dead code/API for all GCs except G1. This pull request has now been integrated. Changeset: 64183062 Author: Albert Mingkun Yang URL: https://git.openjdk.org/jdk/commit/6418306211be47063a9b06bad8003dee1d81570c Stats: 51 lines in 12 files changed: 0 ins; 50 del; 1 mod 8357944: Remove unused CollectedHeap::is_maximal_no_gc Reviewed-by: jsikstro, tschatzl ------------- PR: https://git.openjdk.org/jdk/pull/25482 From andrew at openjdk.org Mon Jun 2 08:31:32 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 08:31:32 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 2 new changesets Message-ID: <83fbef78-244e-4cb6-9ca0-2ff98dba7656@openjdk.org> Changeset: e2cbfd5a Branch: master Author: Andrew John Hughes Date: 2022-09-16 16:42:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e2cbfd5acaae9a98921dc29363bce3a037cacc43 8028265: Add legacy tz tests to OpenJDK Backport-of: 92deab546549ca549408a983fe361d9536d2cd37 + jdk/test/java/util/TimeZone/AssureTzdataVersion.java + jdk/test/java/util/TimeZone/Bug6329116.java + jdk/test/java/util/TimeZone/TextFileReader.java + jdk/test/java/util/TimeZone/TimeZoneData/VERSION + jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt + jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt + jdk/test/java/util/TimeZone/tools/share/CompareYearData.pl + jdk/test/java/util/TimeZone/tools/share/Makefile + jdk/test/java/util/TimeZone/tools/share/makeZoneData.pl Changeset: 010985d2 Branch: master Author: Andrew John Hughes Date: 2025-06-02 08:26:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/010985d2bdada99b477c99290f4d71b7e82b8f05 Merge jdk8u352-b06 Added tag jdk8u352-b06 for changeset e2cbfd5acaa From andrew at openjdk.org Mon Jun 2 08:31:43 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 08:31:43 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b06 for changeset e2cbfd5a Message-ID: <15eedbfd-1202-4b6b-8d7d-1bc2117000a7@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-09-22 01:31:19 +0000 Added tag jdk8u352-b06 for changeset e2cbfd5acaa Changeset: e2cbfd5a Author: Andrew John Hughes Date: 2022-09-16 16:42:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e2cbfd5acaae9a98921dc29363bce3a037cacc43 From andrew at openjdk.org Mon Jun 2 08:31:48 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 08:31:48 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b06 for changeset 010985d2 Message-ID: <627867b5-5eaa-4f83-855a-7219fd84a401@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-02 09:19:06 +0000 Added tag shenandoah8u352-b06 for changeset 010985d2bda Changeset: 010985d2 Author: Andrew John Hughes Date: 2025-06-02 08:26:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/010985d2bdada99b477c99290f4d71b7e82b8f05 From andrew at openjdk.org Mon Jun 2 08:32:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 08:32:26 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u352-b06 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/28/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/28/files/010985d2..010985d2 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=28&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=28&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/28.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/28/head:pull/28 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/28 From iris at openjdk.org Mon Jun 2 08:32:26 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 2 Jun 2025 08:32:26 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Mon, 2 Jun 2025 08:20:42 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b06 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/28 From andrew at openjdk.org Mon Jun 2 11:29:21 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 11:29:21 GMT Subject: RFR: Merge jdk8u:master Message-ID: <0y32GXec6MdnS_J2ZR-WvxXclZuslKIt23oWB995lR8=.15c6f575-eb06-4197-85cd-4a1fc666644c@github.com> Merge jdk8u352-b07 ------------- Commit messages: - Merge jdk8u352-b07 - 8292579: (tz) Update Timezone Data to 2022c The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/29/files Stats: 2007 lines in 27 files changed: 490 ins; 1222 del; 295 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/29.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/29/head:pull/29 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/29 From andrew at openjdk.org Mon Jun 2 11:32:22 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Jun 2025 11:32:22 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: <0y32GXec6MdnS_J2ZR-WvxXclZuslKIt23oWB995lR8=.15c6f575-eb06-4197-85cd-4a1fc666644c@github.com> References: <0y32GXec6MdnS_J2ZR-WvxXclZuslKIt23oWB995lR8=.15c6f575-eb06-4197-85cd-4a1fc666644c@github.com> Message-ID: On Mon, 2 Jun 2025 11:25:30 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b07 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/29#issuecomment-2930163040 From rwestrel at redhat.com Mon Jun 2 15:52:02 2025 From: rwestrel at redhat.com (Roland Westrelin) Date: Mon, 02 Jun 2025 17:52:02 +0200 Subject: C2 Jit compiler fails accessing off-heap memory via Unsafe with ShenandoahGC In-Reply-To: <136180f2-df08-444b-8d80-63a10296a85f@gmail.com> References: <136180f2-df08-444b-8d80-63a10296a85f@gmail.com> Message-ID: <87plfm6t0d.fsf@redhat.com> Hi Sergey, Thanks for the bug report. I created https://bugs.openjdk.org/browse/JDK-8358334 to track that one. I'm having a look. Roland. From wkemper at openjdk.org Mon Jun 2 16:51:34 2025 From: wkemper at openjdk.org (William Kemper) Date: Mon, 2 Jun 2025 16:51:34 GMT Subject: Integrated: 8358102: GenShen: Age tables could be seeded with cumulative values Message-ID: When dynamic tenuring threshold is disabled, or the age census is configured to be computed during evacuation, the first cohort is seeded with the cumulative counts, rather than the current cycle's counts. This is not the default configuration so this is not an urgent issue. ------------- Commit messages: - Use census data from current cycle, rather than cumulative values Changes: https://git.openjdk.org/jdk/pull/25535/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25535&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358102 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25535.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25535/head:pull/25535 PR: https://git.openjdk.org/jdk/pull/25535 From ysr at openjdk.org Mon Jun 2 16:51:34 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Mon, 2 Jun 2025 16:51:34 GMT Subject: Integrated: 8358102: GenShen: Age tables could be seeded with cumulative values In-Reply-To: References: Message-ID: <2QwNjBKqo7q-vwQGJpyIJPc5RsEAwzqzBmZk1erJ9yE=.f3be64f5-3937-48e2-abd0-aea71a6e4081@github.com> On Fri, 30 May 2025 01:25:11 GMT, William Kemper wrote: > When dynamic tenuring threshold is disabled, or the age census is configured to be computed during evacuation, the first cohort is seeded with the cumulative counts, rather than the current cycle's counts. This is not the default configuration so this is not an urgent issue. LGTM. Thanks for finding and fixing the issue. ------------- Marked as reviewed by ysr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25535#pullrequestreview-2881868083 From wkemper at openjdk.org Mon Jun 2 16:51:35 2025 From: wkemper at openjdk.org (William Kemper) Date: Mon, 2 Jun 2025 16:51:35 GMT Subject: Integrated: 8358102: GenShen: Age tables could be seeded with cumulative values In-Reply-To: References: Message-ID: On Fri, 30 May 2025 01:25:11 GMT, William Kemper wrote: > When dynamic tenuring threshold is disabled, or the age census is configured to be computed during evacuation, the first cohort is seeded with the cumulative counts, rather than the current cycle's counts. This is not the default configuration so this is not an urgent issue. This pull request has now been integrated. Changeset: 99a4b22a Author: William Kemper URL: https://git.openjdk.org/jdk/commit/99a4b22ae7dc2755df1780cc7d74c5d6e3cd4cd4 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8358102: GenShen: Age tables could be seeded with cumulative values Reviewed-by: ysr ------------- PR: https://git.openjdk.org/jdk/pull/25535 From xpeng at openjdk.org Tue Jun 3 05:36:23 2025 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 3 Jun 2025 05:36:23 GMT Subject: RFR: 8354555: Add generic JFR events for TaskTerminator [v6] In-Reply-To: <_7FP2wNe8p3N8SxKdmCN1x4zKO8TT5JWRcWEt51i35c=.4fbac292-3cb7-48b9-922e-1114f74e0549@github.com> References: <_7FP2wNe8p3N8SxKdmCN1x4zKO8TT5JWRcWEt51i35c=.4fbac292-3cb7-48b9-922e-1114f74e0549@github.com> Message-ID: > The purpose of the PR is to add generic JFR events for TaskTerminator to track the attempts and timings that GC threads have tried to terminate GC tasks. > > Today only G1 emits JFR event with name `Termination` from [G1ParEvacuateFollowersClosure](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/g1/g1YoungCollector.cpp#L555-L563), all other garbage collectors don't emit any JFR event for the termination attempt at all. > > By adding this, it gives performance engineers the visibility to the termination attempts and termination time when GC threads trying to finish GC tasks, we could build tool to analyze the jfr events to determine if there is potential data structure issue in application code, e.g. very large LinkedList or LinkedBlockingQueue. > > For the test, I have manually tested different GCs with Flight Recording enabled and verified the events: > G1: > > jdk.GCPhaseParallel { > startTime = 23:09:34.124 (2025-05-22) > duration = 0.0108 ms > gcId = 0 > gcWorkerId = 8 > name = "Termination" > eventThread = "GC Thread#4" (osThreadId = 20483) > } > > jdk.GCPhaseParallel { > startTime = 23:09:34.124 (2025-05-22) > duration = 0.0467 ms > gcId = 0 > gcWorkerId = 2 > name = "Termination" > eventThread = "GC Thread#2" (osThreadId = 21251) > } > > jdk.GCPhaseParallel { > startTime = 23:09:34.124 (2025-05-22) > duration = 0.0474 ms > gcId = 0 > gcWorkerId = 1 > name = "Termination" > eventThread = "GC Thread#8" (osThreadId = 36359) > } > jdk.GCPhaseParallel { > startTime = 23:09:41.925 (2025-05-22) > duration = 0.000834 ms > gcId = 14 > gcWorkerId = 7 > name = "Termination: Parallel Marking" > eventThread = "GC Thread#1" (osThreadId = 21507) > } > > jdk.GCPhaseParallel { > startTime = 23:09:41.925 (2025-05-22) > duration = 0.000166 ms > gcId = 14 > gcWorkerId = 7 > name = "Termination: Parallel Marking" > eventThread = "GC Thread#1" (osThreadId = 21507) > } > > > Shenandoah: > > jdk.GCPhaseParallel { > startTime = 23:39:58.890 (2025-05-22) > duration = 0.0202 ms > gcId = 0 > gcWorkerId = 0 > name = "Termination: Concurrent Mark" > eventThread = "Shenandoah GC Threads#3" (osThreadId = 13827) > } > > jdk.GCPhaseParallel { > startTime = 23:39:58.890 (2025-05-22) > duration = 0.0205 ms > gcId = 0 > gcWorkerId = 1 > name = "Termination: Concurrent Mark" > eventThread = "Shenandoah GC Threads#1" (osThreadId = 14339) > } > > jdk.GCPhaseParallel { > startTime = 23:39:58.890 (2025-05-22) > duration = 0.0127 ms > gcId = 0 > gcWorkerId = 5 > name = "Termination: Final Mark" > eventThread = "Shenandoah G... Xiaolong Peng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 30 commits: - Merge branch 'openjdk:master' into JDK-8354555 - Merge branch 'openjdk:master' into JDK-8354555 - Fix jft test failure - Merge branch 'master' into JDK-8354555 - Patch to fix the PR concerns - Emit exact same events for G1 as G1 is emitting today from G1EvacuateRegionsBaseTask and G1STWRefProcProxyTask - Add include "workerThread.hpp" - Touch up - Move TERMINATION_EVENT_NAME_PREFIX_ASSERT to taskTerminator.cpp - Fix ident - ... and 20 more: https://git.openjdk.org/jdk/compare/832c5b06...8fb9a402 ------------- Changes: https://git.openjdk.org/jdk/pull/24676/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24676&range=05 Stats: 90 lines in 10 files changed: 68 ins; 7 del; 15 mod Patch: https://git.openjdk.org/jdk/pull/24676.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/24676/head:pull/24676 PR: https://git.openjdk.org/jdk/pull/24676 From andrew at openjdk.org Tue Jun 3 16:46:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 3 Jun 2025 16:46:50 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 2 new changesets Message-ID: <9900e586-2f50-419d-a9ea-bd5a51ea0ae8@openjdk.org> Changeset: 46da2c31 Branch: master Author: David Alvarez Committer: Andrew John Hughes Date: 2022-09-25 21:38:03 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/46da2c31efef73b7c2914c8d252554556145b00b 8292579: (tz) Update Timezone Data to 2022c Reviewed-by: andrew Backport-of: 98d85e6f594bf34b97407c470b14791af0a2bc53 ! jdk/make/data/tzdata/VERSION ! jdk/make/data/tzdata/africa ! jdk/make/data/tzdata/antarctica ! jdk/make/data/tzdata/asia ! jdk/make/data/tzdata/australasia ! jdk/make/data/tzdata/backward ! jdk/make/data/tzdata/etcetera ! jdk/make/data/tzdata/europe ! jdk/make/data/tzdata/leapseconds ! jdk/make/data/tzdata/northamerica ! jdk/make/data/tzdata/southamerica ! jdk/make/data/tzdata/zone.tab ! jdk/test/java/util/TimeZone/TimeZoneData/VERSION ! jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt ! jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt ! jdk/test/sun/util/calendar/zi/tzdata/VERSION ! jdk/test/sun/util/calendar/zi/tzdata/africa ! jdk/test/sun/util/calendar/zi/tzdata/antarctica ! jdk/test/sun/util/calendar/zi/tzdata/asia ! jdk/test/sun/util/calendar/zi/tzdata/australasia ! jdk/test/sun/util/calendar/zi/tzdata/backward ! jdk/test/sun/util/calendar/zi/tzdata/etcetera ! jdk/test/sun/util/calendar/zi/tzdata/europe ! jdk/test/sun/util/calendar/zi/tzdata/leapseconds ! jdk/test/sun/util/calendar/zi/tzdata/northamerica ! jdk/test/sun/util/calendar/zi/tzdata/southamerica ! jdk/test/sun/util/calendar/zi/tzdata/zone.tab Changeset: 67129e99 Branch: master Author: Andrew John Hughes Date: 2025-06-02 09:30:08 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/67129e99cc0107981f90b7f5b18362c1c138e632 Merge jdk8u352-b07 Added tag jdk8u352-b07 for changeset 46da2c31efe From andrew at openjdk.org Tue Jun 3 16:46:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 3 Jun 2025 16:46:59 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b07 for changeset 46da2c31 Message-ID: <2177b467-0c90-479b-9d2f-6a093ae8f013@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-09-26 16:13:09 +0000 Added tag jdk8u352-b07 for changeset 46da2c31efe Changeset: 46da2c31 Author: David Alvarez Committer: Andrew John Hughes Date: 2022-09-25 21:38:03 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/46da2c31efef73b7c2914c8d252554556145b00b From andrew at openjdk.org Tue Jun 3 16:47:01 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 3 Jun 2025 16:47:01 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b07 for changeset 67129e99 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-02 12:22:09 +0000 Added tag shenandoah8u352-b07 for changeset 67129e99cc0 Changeset: 67129e99 Author: Andrew John Hughes Date: 2025-06-02 09:30:08 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/67129e99cc0107981f90b7f5b18362c1c138e632 From andrew at openjdk.org Tue Jun 3 16:49:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 3 Jun 2025 16:49:59 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: <0y32GXec6MdnS_J2ZR-WvxXclZuslKIt23oWB995lR8=.15c6f575-eb06-4197-85cd-4a1fc666644c@github.com> References: <0y32GXec6MdnS_J2ZR-WvxXclZuslKIt23oWB995lR8=.15c6f575-eb06-4197-85cd-4a1fc666644c@github.com> Message-ID: > Merge jdk8u352-b07 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/29/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/29/files/67129e99..67129e99 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=29&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=29&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/29.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/29/head:pull/29 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/29 From iris at openjdk.org Tue Jun 3 16:50:00 2025 From: iris at openjdk.org (Iris Clark) Date: Tue, 3 Jun 2025 16:50:00 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: <0y32GXec6MdnS_J2ZR-WvxXclZuslKIt23oWB995lR8=.15c6f575-eb06-4197-85cd-4a1fc666644c@github.com> References: <0y32GXec6MdnS_J2ZR-WvxXclZuslKIt23oWB995lR8=.15c6f575-eb06-4197-85cd-4a1fc666644c@github.com> Message-ID: On Mon, 2 Jun 2025 11:25:30 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b07 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/29 From duke at openjdk.org Tue Jun 3 21:52:22 2025 From: duke at openjdk.org (duke) Date: Tue, 3 Jun 2025 21:52:22 GMT Subject: Withdrawn: 8344116: C2: remove slice parameter from LoadNode::make In-Reply-To: References: Message-ID: On Wed, 26 Mar 2025 15:18:25 GMT, Zihao Lin wrote: > This patch remove slice parameter from LoadNode::make > > Mention in https://github.com/openjdk/jdk/pull/21834#pullrequestreview-2429164805 > > Hi team, I am new, I'd appreciate any guidance. Thank a lot! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/24258 From andrew at openjdk.org Wed Jun 4 13:14:29 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 13:14:29 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u352-b08 ------------- Commit messages: - Merge jdk8u352-b08 - 8288508: Enhance ECDSA usage - 8286918: Better HttpServer service - 8147862: Null check too late in sun.net.httpserver.ServerImpl - 8286910: Improve JNDI lookups - 8286533: Key X509 usages - 8286526: Improve NTLM support - 8286519: Better memory handling - 8286511: Improve macro allocation - 8285662: Better permission resolution - ... and 1 more: https://git.openjdk.org/shenandoah-jdk8u/compare/67129e99...d00219b5 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/30/files Stats: 933 lines in 22 files changed: 654 ins; 85 del; 194 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/30.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/30/head:pull/30 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/30 From andrew at openjdk.org Wed Jun 4 13:18:39 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 13:18:39 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: <4uoNXzxejTg9FEtXSXSE88zpY-w8-PeMTIqcROya1IE=.9d73c12a-7742-41e2-96f7-e1fc7189e7f7@github.com> On Wed, 4 Jun 2025 11:58:32 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b08 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/30#issuecomment-2940004558 From andrew at openjdk.org Wed Jun 4 16:55:31 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 16:55:31 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 11 new changesets Message-ID: <9dec78eb-1156-4f04-8fed-b6677defd64e@openjdk.org> Changeset: 987c7384 Branch: master Author: Ekaterina Vergizova Committer: Andrew John Hughes Date: 2022-06-23 11:51:13 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/987c7384267be18fe86d3bd2514d389a5d62306c 8282252: Improve BigInteger/Decimal validation Reviewed-by: mbalao, andrew Backport-of: e863e256f9e7465a97d3fb2a109299987e990b7c ! jdk/src/share/classes/java/math/BigDecimal.java ! jdk/src/share/classes/java/math/BigInteger.java + jdk/test/java/math/BigDecimal/ConstructorUnscaledValue.java ! jdk/test/java/math/BigDecimal/SerializationTests.java + jdk/test/java/math/BigInteger/SerializationTests.java Changeset: b916428d Branch: master Author: Aleksei Voitylov Committer: Andrew John Hughes Date: 2022-09-12 22:40:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b916428d331b2513041002b76613e447dc88485b 8285662: Better permission resolution Reviewed-by: mbalao, andrew Backport-of: 18c17a1391aaa67c71da13f034674fc294c25d5a ! jdk/src/share/classes/java/security/UnresolvedPermission.java Changeset: f793489d Branch: master Author: Sergey Bylokhov Committer: Andrew John Hughes Date: 2022-07-22 04:30:14 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f793489d9d5780cb4a2387f9d877756b6f9f5111 8286511: Improve macro allocation Reviewed-by: mbalao, andrew Backport-of: 4ab7ce961a95d7ba350b1cbca584a8e698186047 ! jdk/src/share/native/common/sizecalc.h Changeset: d9f1978b Branch: master Author: David Alvarez Committer: Andrew John Hughes Date: 2022-10-03 07:21:10 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d9f1978b82a1d2fad89c84b04686b163c4ac30e7 8286519: Better memory handling Co-authored-by: Oli Gillespie Reviewed-by: mbalao, andrew Backport-of: adfc2b195a84867fc2a66e00fad7f3c95693bc3b ! hotspot/src/share/vm/runtime/os.cpp Changeset: 62b1b3e5 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2022-09-01 17:13:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/62b1b3e5de6285a95a912d5bc62331bad35c151c 8286526: Improve NTLM support Reviewed-by: andrew Backport-of: 2d1bc2e55c7ed5f123f3ab5d505b7866a28ba4c7 ! jdk/src/share/classes/com/sun/security/ntlm/Client.java ! jdk/src/share/classes/com/sun/security/ntlm/NTLM.java ! jdk/src/share/classes/com/sun/security/ntlm/NTLMException.java ! jdk/src/share/classes/com/sun/security/ntlm/Server.java ! jdk/test/sun/net/www/protocol/http/NULLTargetInfoTest.java Changeset: e09162ae Branch: master Author: Alexey Bakhtin Committer: Andrew John Hughes Date: 2022-09-09 07:20:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e09162aec2a124325126720bf559eb31a16d03ed 8286533: Key X509 usages Reviewed-by: mbalao, andrew Backport-of: c2a13eef3642987386db1b4759507e30796c0acc ! jdk/src/share/classes/sun/security/util/DerInputStream.java Changeset: a2fb4c15 Branch: master Author: David Alvarez Committer: Andrew John Hughes Date: 2022-10-03 05:01:01 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a2fb4c151714ae4203cb6d024fcbf9c1ea590bdb 8286910: Improve JNDI lookups Reviewed-by: mbalao, andrew Backport-of: daf133f773ea567d66663ce6916541bc0df1421a ! jdk/src/share/classes/com/sun/jndi/dns/DNSDatagramSocketFactory.java Changeset: 83d9d818 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2016-01-24 22:27:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/83d9d81848772805aac2a70deed0f36b38d0d824 8147862: Null check too late in sun.net.httpserver.ServerImpl Reviewed-by: andrew Backport-of: 1cbdf12c056362cc6ac85239de7c8d93a356ee0f ! jdk/src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: c0d68041 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2022-09-08 10:11:45 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c0d680413deb88912bbc4ba706fa1d2056d90169 8286918: Better HttpServer service Reviewed-by: andrew Backport-of: 6f2ad19b82f90c11a16b4f33ecf130190e2cf616 ! jdk/src/share/classes/sun/net/httpserver/HttpConnection.java ! jdk/src/share/classes/sun/net/httpserver/SSLStreams.java ! jdk/src/share/classes/sun/net/httpserver/ServerConfig.java ! jdk/src/share/classes/sun/net/httpserver/ServerImpl.java - jdk/src/share/classes/sun/net/httpserver/TimeSource.java ! jdk/test/com/sun/net/httpserver/bugs/6725892/Test.java Changeset: dfa5f148 Branch: master Author: Aleksei Voitylov Committer: Andrew John Hughes Date: 2022-09-06 20:45:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dfa5f14848df6b4b41f839004d6baf37ca2f4f8d 8288508: Enhance ECDSA usage Reviewed-by: mbalao, andrew Backport-of: efd603063e60ca6861b41309445d7b8e20768d9b ! jdk/src/share/native/sun/security/ec/impl/ec.c Changeset: d00219b5 Branch: master Author: Andrew John Hughes Date: 2025-06-03 17:46:31 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d00219b5dc87be0ac161a6a2def114ed7b840201 Merge jdk8u352-b08 Added tag jdk8u352-b08 for changeset dfa5f14848d From andrew at openjdk.org Wed Jun 4 16:55:41 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 16:55:41 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-b08 for changeset dfa5f148 Message-ID: <43ab1860-04d2-4c6f-a500-d35dc60c1b89@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-10-11 01:32:50 +0000 Added tag jdk8u352-b08 for changeset dfa5f14848d Changeset: dfa5f148 Author: Aleksei Voitylov Committer: Andrew John Hughes Date: 2022-09-06 20:45:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dfa5f14848df6b4b41f839004d6baf37ca2f4f8d From andrew at openjdk.org Wed Jun 4 16:55:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 16:55:45 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-b08 for changeset d00219b5 Message-ID: <700d2cfd-703d-449f-89c3-8eb98f509072@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-03 22:51:29 +0000 Added tag shenandoah8u352-b08 for changeset d00219b5dc8 Changeset: d00219b5 Author: Andrew John Hughes Date: 2025-06-03 17:46:31 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d00219b5dc87be0ac161a6a2def114ed7b840201 From andrew at openjdk.org Wed Jun 4 16:55:49 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 16:55:49 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u352-ga for changeset dfa5f148 Message-ID: <15010e7c-4035-48c7-a4bd-7cd6d457252b@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-10-20 01:51:55 +0000 Added tag jdk8u352-ga for changeset dfa5f14848d Changeset: dfa5f148 Author: Aleksei Voitylov Committer: Andrew John Hughes Date: 2022-09-06 20:45:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dfa5f14848df6b4b41f839004d6baf37ca2f4f8d From andrew at openjdk.org Wed Jun 4 16:55:55 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 16:55:55 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u352-ga for changeset d00219b5 Message-ID: <8d23898f-8307-46e2-852a-13f5640b41d9@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-03 22:51:37 +0000 Added tag shenandoah8u352-ga for changeset d00219b5dc8 Changeset: d00219b5 Author: Andrew John Hughes Date: 2025-06-03 17:46:31 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d00219b5dc87be0ac161a6a2def114ed7b840201 From andrew at openjdk.org Wed Jun 4 16:56:29 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jun 2025 16:56:29 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u352-b08 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/30/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/30/files/d00219b5..d00219b5 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=30&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=30&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/30.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/30/head:pull/30 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/30 From iris at openjdk.org Wed Jun 4 16:56:29 2025 From: iris at openjdk.org (Iris Clark) Date: Wed, 4 Jun 2025 16:56:29 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 4 Jun 2025 11:58:32 GMT, Andrew John Hughes wrote: > Merge jdk8u352-b08 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/30 From andrew at openjdk.org Sat Jun 7 14:51:04 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 14:51:04 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u362-b01 ------------- Commit messages: - Merge jdk8u362-b01 - 8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport - 8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems - Merge - 8054066: com/sun/jdi/DoubleAgentTest.java fails with timeout - Merge - 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity - 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 - 8295164: JDK 8 jdi tests should not use tasklist command on Windows - 8253702: BigSur version number reported as 10.16, should be 11.nn - ... and 14 more: https://git.openjdk.org/shenandoah-jdk8u/compare/d00219b5...f28a46ae The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=31&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=31&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/31/files Stats: 862 lines in 32 files changed: 356 ins; 339 del; 167 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/31.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/31/head:pull/31 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/31 From andrew at openjdk.org Sat Jun 7 14:54:29 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 14:54:29 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 24 new changesets Message-ID: <41a05eae-87f6-414f-b5fd-360293c4272a@openjdk.org> Changeset: 266918d1 Branch: master Author: Rui Li Committer: Severin Gehwolf Date: 2022-08-30 09:12:20 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/266918d1d384f0fa002c6f5f508b84835fe57c13 8071530: Update OS detection code to reflect Windows 10 version change Backport-of: fa47cc3e215fe4bb7531ff1a78f3965e2e84ac9f ! hotspot/src/os/windows/vm/os_windows.cpp Changeset: bd946fa7 Branch: master Author: Rui Li Committer: Severin Gehwolf Date: 2022-08-30 17:35:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/bd946fa751cc3b979bb9906941b4570d1750471f 8274840: Update OS detection code to recognize Windows 11 Reviewed-by: phh Backport-of: 97ea9dd2f24f9f1fb9b9345a4202a825ee28e014 ! hotspot/src/os/windows/vm/os_windows.cpp ! jdk/src/windows/native/java/lang/java_props_md.c Changeset: 2be37c31 Branch: master Author: George Adams Committer: Paul Hohensee Date: 2022-08-30 19:02:09 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2be37c31bbd26e0aa8d1e7d3cc3bf333b64eeaa0 8292762: Remove .jcheck directories from jdk8u subcomponents Reviewed-by: phh - corba/.jcheck/conf - hotspot/.jcheck/conf - jaxp/.jcheck/conf - jaxws/.jcheck/conf - jdk/.jcheck/conf - langtools/.jcheck/conf - nashorn/.jcheck/conf Changeset: daccfee6 Branch: master Author: Andrew John Hughes Date: 2022-08-31 17:43:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/daccfee68e4a18461ab79bb18930d8ad8044b2cb 8293181: Bump update version of OpenJDK: 8u362 Reviewed-by: sgehwolf ! .jcheck/conf ! common/autoconf/version-numbers Changeset: 65b1748a Branch: master Author: Alexey Pavlyutkin Committer: Andrew John Hughes Date: 2022-09-01 01:17:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/65b1748adfc0843bbc8c0d7dcddb7c5490256b31 8273176: handle latest VS2019 in abstract_vm_version Reviewed-by: andrew Backport-of: 0e14bf70cf6e482a2ec7d13ed37df0bee911740d ! hotspot/src/share/vm/runtime/vm_version.cpp Changeset: 9f037b06 Branch: master Author: bobpengxie Committer: Andrew John Hughes Date: 2022-09-01 01:18:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9f037b06fe380b22cfb5665b3b9539d65b463914 8283903: GetContainerCpuLoad does not return the correct result in share mode Reviewed-by: andrew Backport-of: a625bfdba45d49bc717bcc9be4112db93b50f50a ! jdk/src/solaris/classes/sun/management/OperatingSystemImpl.java Changeset: fa340ab0 Branch: master Author: Dongbo He Committer: Andrew John Hughes Date: 2022-09-01 01:23:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/fa340ab0e5d4f95bdd6b8c05b39517eb34239594 8067941: [TESTBUG] Fix tests for OS with 64K page size. Reviewed-by: andrew Backport-of: 8e2df5f543522866e7c27ff95ea6fb6458393682 ! hotspot/src/share/vm/memory/metaspace.cpp ! hotspot/test/compiler/6865265/StackOverflowBug.java ! hotspot/test/compiler/8009761/Test8009761.java ! hotspot/test/compiler/exceptions/TestRecursiveReplacedException.java ! hotspot/test/compiler/uncommontrap/StackOverflowGuardPagesOff.java ! hotspot/test/compiler/uncommontrap/TestStackBangMonitorOwned.java ! hotspot/test/compiler/uncommontrap/TestStackBangRbp.java ! hotspot/test/gc/arguments/TestMaxHeapSizeTools.java ! hotspot/test/gc/g1/TestHumongousAllocInitialMark.java Changeset: ba408e55 Branch: master Author: Sergey Bylokhov Date: 2022-09-07 00:24:27 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ba408e5553f3692e18e0933352cfa3a333528a3a 8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) Reviewed-by: phh, andrew ! jdk/src/share/native/sun/awt/libpng/pnglibconf.h Changeset: f0ac3199 Branch: master Author: Martin Balao Date: 2022-09-09 18:07:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f0ac31998d8396d92b4ce99aa345c05e6fd0f02a 8195607: sun/security/pkcs11/Secmod/TestNssDbSqlite.java failed with "NSS initialization failed" on NSS 3.34.1 Reviewed-by: andrew Backport-of: b44c24d290362e4edf5b0bf18b1ecce1583daeff ! jdk/src/share/classes/sun/security/pkcs11/Secmod.java ! jdk/src/share/native/sun/security/pkcs11/j2secmod.c ! jdk/src/solaris/native/sun/security/pkcs11/j2secmod_md.h + jdk/test/sun/security/pkcs11/Secmod/pkcs11.txt ! jdk/test/sun/security/pkcs11/SecmodTest.java Changeset: d2853822 Branch: master Author: Sergey Bylokhov Date: 2022-09-28 20:01:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d285382278fcb76ceddfb61cf8bb047ff269de44 8293461: Add a test for JDK-8290832 Reviewed-by: phh + jdk/test/java/io/File/ChangeDefaultUserDir.java Changeset: a93344b2 Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-10-11 12:13:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a93344b27d4b3df6cbca7185bcfca1410b51a984 8294863: Enable partial tier1 testing in GHA for JDK8 Reviewed-by: sgehwolf ! .github/workflows/submit.yml Changeset: 859c057c Branch: master Author: Nikita Ivanov Committer: Paul Hohensee Date: 2022-10-11 14:15:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/859c057c87ad15920c28f495094f8de6953b2e99 8148005: One byte may be corrupted by get_datetime_string() Reviewed-by: phh Backport-of: 395a248587b5bd16c3e61c4cefb73799ade0af95 ! hotspot/src/share/vm/utilities/ostream.cpp Changeset: 4a25b00a Branch: master Author: Joshua Cao Committer: Paul Hohensee Date: 2022-10-11 15:09:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4a25b00aba29dd45529be805c4ec135f20228d80 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening Reviewed-by: phh Backport-of: 47bfc8aa9367ff852ea5d901f1fa3c6ef316913e ! jdk/test/jdk/jfr/event/oldobject/TestClassLoaderLeak.java Changeset: 861ac32e Branch: master Author: Victor Rudometov Committer: Paul Hohensee Date: 2022-10-11 19:53:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/861ac32e43a425b682d18a2cc748a8b82435148f 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening Reviewed-by: phh Backport-of: 5002eaa5cc7301b91a45f8c0f65b5943fea225d8 ! jdk/test/jdk/jfr/event/oldobject/TestClassLoaderLeak.java Changeset: 05b249d6 Branch: master Author: Olga Mikhaltsova Committer: Yuri Nesterenko Date: 2022-10-13 09:59:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/05b249d61aac56c1d4bb346649b6cb8d157deaef 8253702: BigSur version number reported as 10.16, should be 11.nn Backport-of: 66757750a2adf0739d0f5bf98a3f50a123b7adcf ! jdk/src/solaris/native/java/lang/java_props_macosx.c Changeset: 8280a89a Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-10-13 12:09:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8280a89a1e4748ca6b7534dceca8c2b1fd17697a 8295164: JDK 8 jdi tests should not use tasklist command on Windows Also enable jdk_tier1 GHA tests on Windows Reviewed-by: sgehwolf ! .github/workflows/submit.yml ! jdk/test/com/sun/jdi/ShellScaffold.sh Changeset: 43cfe27f Branch: master Author: Olga Mikhaltsova Committer: Yuri Nesterenko Date: 2022-10-13 15:20:54 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 Backport-of: 3b1b8fc646493eae5f4df828afe29abb75fa5e60 ! jdk/src/solaris/native/java/lang/java_props_macosx.c Changeset: dfeeceb2 Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-10-14 09:23:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dfeeceb224a62bd7ffbe5adfd36eebe6c853935a 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity Reviewed-by: roland Backport-of: 844c504bc18fa8a79ceacc6b6f235650f5e643bf ! hotspot/src/share/vm/opto/stringopts.cpp Changeset: 5b5e548f Branch: master Author: Andrew John Hughes Date: 2022-10-15 00:26:36 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5b5e548fba1073a1f87df3c71f0d09b63e033ced Merge Changeset: 58d0281c Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-10-19 08:56:06 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/58d0281c52f8c1e9642c6fc5bd696235498b0ae2 8054066: com/sun/jdi/DoubleAgentTest.java fails with timeout The test changed to use testlibrary Reviewed-by: dsamersoff, sgehwolf Backport-of: 3e3dcfb635bb7dc956f406ca2db6f375ee1b76a8 ! jdk/test/com/sun/jdi/DoubleAgentTest.java Changeset: 60930770 Branch: master Author: Andrew John Hughes Date: 2022-10-19 20:07:32 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/60930770b9238e55d72689092b9e127bc619ce87 Merge Changeset: 1f8eafd8 Branch: master Author: Jonathan Dowland Date: 2022-10-21 16:31:24 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1f8eafd8a05ce979eefd9ed45f5e7c6fb5fc5f2d 8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems The changes to MetricsTester.java in the original commit were merged in "8223147: JFR Backport". Reviewed-by: sgehwolf Backport-of: 6fc4db4799599df66a2cf5207068336ce68136ff ! jdk/test/jdk/internal/platform/docker/MetricsCpuTester.java Changeset: f04ad96c Branch: master Author: Peter Zhelezniakov Date: 2022-10-26 05:37:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f04ad96cf53385c9f8aa071a4167ad7790cb8466 8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport Reviewed-by: sgehwolf ! langtools/test/tools/javac/diags/examples.not-yet.txt ! langtools/test/tools/javac/diags/examples/WhereIntersection.java Changeset: f28a46ae Branch: master Author: Andrew John Hughes Date: 2025-06-04 17:55:14 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f28a46ae0890a43f7e73ae0883afd1c7438dd90c Merge jdk8u362-b01 Added tag jdk8u362-b01 for changeset f04ad96cf53 ! .jcheck/conf ! .jcheck/conf From andrew at openjdk.org Sat Jun 7 14:54:44 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 14:54:44 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b01 for changeset f04ad96c Message-ID: <44caab15-503f-48d1-9021-0585b17a56f7@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-11-01 19:37:17 +0000 Added tag jdk8u362-b01 for changeset f04ad96cf53 Changeset: f04ad96c Author: Peter Zhelezniakov Date: 2022-10-26 05:37:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f04ad96cf53385c9f8aa071a4167ad7790cb8466 From andrew at openjdk.org Sat Jun 7 14:54:56 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 14:54:56 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b01 for changeset f28a46ae Message-ID: <8a522acd-7d78-4206-bef7-544280fa6f1d@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-07 15:45:18 +0000 Added tag shenandoah8u362-b01 for changeset f28a46ae089 Changeset: f28a46ae Author: Andrew John Hughes Date: 2025-06-04 17:55:14 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f28a46ae0890a43f7e73ae0883afd1c7438dd90c From andrew at openjdk.org Sat Jun 7 14:55:55 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 14:55:55 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u362-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/31/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/31/files/f28a46ae..f28a46ae Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=31&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=31&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/31.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/31/head:pull/31 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/31 From andrew at openjdk.org Sat Jun 7 14:55:56 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 14:55:56 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 7 Jun 2025 14:46:02 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b01 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/31#issuecomment-2952598048 From iris at openjdk.org Sat Jun 7 14:55:56 2025 From: iris at openjdk.org (Iris Clark) Date: Sat, 7 Jun 2025 14:55:56 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 7 Jun 2025 14:46:02 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/31 From andrew at openjdk.org Sat Jun 7 19:29:11 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 19:29:11 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u362-b02 ------------- Commit messages: - Merge jdk8u362-b02 - 8295950: Enable langtools/tier1 in GHA for 8u - 8295173: (tz) Update Timezone Data to 2022e - 8294357: (tz) Update Timezone Data to 2022d The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/32/files Stats: 375 lines in 20 files changed: 107 ins; 129 del; 139 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/32.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/32/head:pull/32 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/32 From andrew at openjdk.org Sat Jun 7 19:29:11 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 19:29:11 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 7 Jun 2025 19:24:59 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b02 GHA builds will not work until [JDK-8284622](https://bugs.openjdk.org/browse/JDK-8284622) is merged in 8u362-b03 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/32#issuecomment-2952916831 From andrew at openjdk.org Sat Jun 7 19:33:54 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 19:33:54 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 4 new changesets Message-ID: <7998369f-761a-4e54-95f7-e670cb517dc6@openjdk.org> Changeset: 28cc8358 Branch: master Author: Andrew John Hughes Date: 2022-11-02 15:12:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/28cc835812298471e2b62d0ddd4d57edfd70d72d 8294357: (tz) Update Timezone Data to 2022d Reviewed-by: sgehwolf Backport-of: f67b4de8a07b8158be1dfb5b09cdb4cc5b7ac93b ! jdk/make/data/tzdata/VERSION ! jdk/make/data/tzdata/asia ! jdk/make/data/tzdata/backward ! jdk/make/data/tzdata/europe ! jdk/make/data/tzdata/southamerica ! jdk/make/data/tzdata/zone.tab ! jdk/src/share/classes/sun/util/calendar/ZoneInfoFile.java ! jdk/test/java/util/TimeZone/TimeZoneData/VERSION ! jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt ! jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt ! jdk/test/sun/util/calendar/zi/TestZoneInfo310.java ! jdk/test/sun/util/calendar/zi/tzdata/VERSION ! jdk/test/sun/util/calendar/zi/tzdata/asia ! jdk/test/sun/util/calendar/zi/tzdata/backward ! jdk/test/sun/util/calendar/zi/tzdata/europe ! jdk/test/sun/util/calendar/zi/tzdata/southamerica ! jdk/test/sun/util/calendar/zi/tzdata/zone.tab Changeset: 64faf400 Branch: master Author: Andrew John Hughes Date: 2022-11-02 16:41:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/64faf4000c81982119a54b86926786d076989b9d 8295173: (tz) Update Timezone Data to 2022e Reviewed-by: sgehwolf Backport-of: 21407dec0156301871a83328615e4d975c4287c4 ! jdk/make/data/tzdata/VERSION ! jdk/make/data/tzdata/asia ! jdk/make/data/tzdata/europe ! jdk/make/data/tzdata/northamerica ! jdk/test/java/util/TimeZone/TimeZoneData/VERSION ! jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt ! jdk/test/sun/util/calendar/zi/tzdata/VERSION ! jdk/test/sun/util/calendar/zi/tzdata/asia ! jdk/test/sun/util/calendar/zi/tzdata/europe ! jdk/test/sun/util/calendar/zi/tzdata/northamerica Changeset: ae6d30db Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-11-03 16:45:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ae6d30dba462ee53eb89999b7b24a72693737c03 8295950: Enable langtools/tier1 in GHA for 8u Reviewed-by: sgehwolf ! .github/workflows/submit.yml Changeset: ef53b93b Branch: master Author: Andrew John Hughes Date: 2025-06-07 19:25:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ef53b93b5edae5daeef581c1180de316ae29b205 Merge jdk8u362-b02 Added tag jdk8u362-b02 for changeset HEAD^ From andrew at openjdk.org Sat Jun 7 19:34:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 19:34:03 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b02 for changeset ae6d30db Message-ID: <8104c6a3-50dd-4333-8196-3db1569e319e@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-11-07 18:34:20 +0000 Added tag jdk8u362-b02 for changeset HEAD^ Changeset: ae6d30db Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-11-03 16:45:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ae6d30dba462ee53eb89999b7b24a72693737c03 From andrew at openjdk.org Sat Jun 7 19:34:06 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 19:34:06 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b02 for changeset ef53b93b Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-07 20:21:01 +0000 Added tag shenandoah8u362-b02 for changeset ef53b93b5ed Changeset: ef53b93b Author: Andrew John Hughes Date: 2025-06-07 19:25:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ef53b93b5edae5daeef581c1180de316ae29b205 From andrew at openjdk.org Sat Jun 7 19:34:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 19:34:59 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u362-b02 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/32/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/32/files/ef53b93b..ef53b93b Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=32&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=32&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/32.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/32/head:pull/32 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/32 From iris at openjdk.org Sat Jun 7 19:35:00 2025 From: iris at openjdk.org (Iris Clark) Date: Sat, 7 Jun 2025 19:35:00 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 7 Jun 2025 19:24:59 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b02 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/32 From andrew at openjdk.org Sat Jun 7 20:09:00 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 20:09:00 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u362-b03 ------------- Commit messages: - Merge jdk8u362-b03 - 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java - 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64 - 8284622: Update versions of some Github Actions used in JDK workflow - 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS - 8295288: Some vm_flags tests associate with a wrong BugID - 7124218: [TEST_BUG] [macosx] Space should select cell in the JTable - 8159720: Failure of C2 compilation with tiered prevents some C1 compilations - 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137 - 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u - ... and 2 more: https://git.openjdk.org/shenandoah-jdk8u/compare/ef53b93b...47035be5 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=33&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=33&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/33/files Stats: 525 lines in 19 files changed: 387 ins; 26 del; 112 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/33.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/33/head:pull/33 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/33 From andrew at openjdk.org Sat Jun 7 20:17:14 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 20:17:14 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 7 Jun 2025 20:03:27 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b03 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/33#issuecomment-2952962476 From andrew at openjdk.org Sat Jun 7 20:20:27 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 20:20:27 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 12 new changesets Message-ID: Changeset: 2cd66fb9 Branch: master Author: Alexey Bakhtin Date: 2022-11-07 11:50:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2cd66fb929dd6716dae33cd05d112ec2fb0ea6f3 8270344: Session resumption errors Reviewed-by: mbalao Backport-of: 04a806ec86a388b8de31d42f904c4321beb69e14 ! jdk/src/share/classes/sun/security/ssl/ClientHello.java ! jdk/src/share/classes/sun/security/ssl/HandshakeContext.java + jdk/test/sun/security/ssl/SSLSessionImpl/InvalidateSession.java Changeset: fb984187 Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-11-08 12:46:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/fb98418773b63dcbf9fea17d5e660bf4a135017e 8295915: Problemlist compiler/rtm failures specific to 8u Reviewed-by: phh, sgehwolf ! hotspot/test/ProblemList.txt Changeset: c605aa3f Branch: master Author: Zdenek Zambersky Committer: Paul Hohensee Date: 2022-11-08 18:50:54 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c605aa3f5aa3e2370edcc9b3feb01f6f16541e2e 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u Reviewed-by: phh, sgehwolf ! .github/workflows/submit.yml Changeset: 01f7d1e3 Branch: master Author: Severin Gehwolf Date: 2022-11-08 18:52:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/01f7d1e3735ddddd4bd1796b962cf14395d6f4b2 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137 Backport-of: 1719c0cc12e094856955c2a3294521b79b17ba7c ! jdk/test/jdk/internal/platform/docker/TestDockerMemoryMetrics.java Changeset: 6e563e59 Branch: master Author: Yi Yang Committer: Paul Hohensee Date: 2022-11-09 15:30:20 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6e563e59f3b4a9b25b4d52975daf4047f52d5b61 8159720: Failure of C2 compilation with tiered prevents some C1 compilations If C2 fails to compile a method with tiered compilation, then it should mark the method as not compileable on the C2 tier only. Reviewed-by: phh Backport-of: cc10eca0b07f03d4765713d86eae39959f555c1f ! hotspot/src/share/vm/opto/compile.cpp ! hotspot/src/share/vm/opto/compile.hpp ! hotspot/src/share/vm/opto/matcher.cpp ! hotspot/src/share/vm/opto/parse1.cpp Changeset: 0f9095fb Branch: master Author: Victor Rudometov Committer: Paul Hohensee Date: 2022-11-09 17:43:26 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0f9095fbc3f61cc376ef6d6c793b5761eb64433b 7124218: [TEST_BUG] [macosx] Space should select cell in the JTable Backport-of: 2e94af3f3d7010e89852721d1fda7a226e8ffb6c + jdk/test/javax/swing/JTable/7124218/SelectEditTableCell.java Changeset: 736c1fb1 Branch: master Author: Joshua Cao Committer: Paul Hohensee Date: 2022-11-09 19:12:12 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/736c1fb18fd8a5ee146ac0437193c4d59317161b 8295288: Some vm_flags tests associate with a wrong BugID Backport-of: 3dbc38a2c903f533ace847a3bc0d2687f263fafd ! hotspot/test/testlibrary_tests/whitebox/vm_flags/BooleanTest.java ! hotspot/test/testlibrary_tests/whitebox/vm_flags/DoubleTest.java ! hotspot/test/testlibrary_tests/whitebox/vm_flags/StringTest.java ! hotspot/test/testlibrary_tests/whitebox/vm_flags/Uint64Test.java ! hotspot/test/testlibrary_tests/whitebox/vm_flags/UintxTest.java Changeset: 3a1a2e02 Branch: master Author: Victor Rudometov Committer: Paul Hohensee Date: 2022-11-09 19:38:52 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3a1a2e02d6f410a59fa163da2f1d30204beaa379 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS Reviewed-by: phh Backport-of: 9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898 ! jdk/test/javax/swing/JTable/7124218/SelectEditTableCell.java Changeset: 3bfde7d0 Branch: master Author: Christoph Langer Committer: Severin Gehwolf Date: 2022-11-10 12:56:25 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3bfde7d03d594ea37dab54c73ee24c13c29b1150 8284622: Update versions of some Github Actions used in JDK workflow Reviewed-by: sgehwolf Backport-of: 61b8c91249fb4c6d594d4a0240c92e8607caf171 ! .github/workflows/submit.yml Changeset: f6d869f0 Branch: master Author: Dan Lutker Committer: Paul Hohensee Date: 2022-11-11 16:46:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f6d869f02569754431e4eaf69e4f66ee357ba425 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64 Reviewed-by: sgehwolf Backport-of: 71ac3d952b6d5bf9eb08ec7daf07225b1ab66216 ! hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java ! jdk/test/lib/jdk/test/lib/containers/docker/DockerfileConfig.java Changeset: 2f509c70 Branch: master Author: Joshua Cao Committer: Paul Hohensee Date: 2022-11-11 17:09:23 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2f509c7070b96e2de02b27d5f752e775980cb75c 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java Reviewed-by: phh Backport-of: f5beafa53f93a6ec03278dfd7063d7b3b0b9d241 ! jdk/test/java/awt/Focus/SimpleWindowActivationTest/SimpleWindowActivationTest.java Changeset: 47035be5 Branch: master Author: Andrew John Hughes Date: 2025-06-07 20:31:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/47035be599253a3a12e0d310f36ff75973d07ae3 Merge jdk8u362-b03 Added tag jdk8u362-b03 for changeset HEAD^ ! hotspot/src/share/vm/opto/compile.cpp ! hotspot/src/share/vm/opto/compile.hpp ! hotspot/src/share/vm/opto/matcher.cpp ! hotspot/src/share/vm/opto/compile.cpp ! hotspot/src/share/vm/opto/compile.hpp ! hotspot/src/share/vm/opto/matcher.cpp From andrew at openjdk.org Sat Jun 7 20:20:37 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 20:20:37 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b03 for changeset 2f509c70 Message-ID: Tagged by: Andrew John Hughes Date: 2022-11-15 02:26:36 +0000 Added tag jdk8u362-b03 for changeset HEAD^ Changeset: 2f509c70 Author: Joshua Cao Committer: Paul Hohensee Date: 2022-11-11 17:09:23 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2f509c7070b96e2de02b27d5f752e775980cb75c From andrew at openjdk.org Sat Jun 7 20:20:41 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 20:20:41 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b03 for changeset 47035be5 Message-ID: <76711394-2897-4799-ab0d-fb19bbc969fc@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-07 20:59:47 +0000 Added tag shenandoah8u362-b03 for changeset 47035be5992 Changeset: 47035be5 Author: Andrew John Hughes Date: 2025-06-07 20:31:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/47035be599253a3a12e0d310f36ff75973d07ae3 From andrew at openjdk.org Sat Jun 7 20:21:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 20:21:18 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: <9l3MqAOC07ZvDeRlVeJ1tPSnN13Si7669GD4WNBYKJM=.586db54c-4c35-459b-803c-451452afd919@github.com> > Merge jdk8u362-b03 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/33/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/33/files/47035be5..47035be5 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=33&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=33&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/33.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/33/head:pull/33 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/33 From iris at openjdk.org Sat Jun 7 20:21:18 2025 From: iris at openjdk.org (Iris Clark) Date: Sat, 7 Jun 2025 20:21:18 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: <1XsieHA426AOaDA9C2FiPWZadM6L0hBEjOu2W8E2wWM=.ebdd3cf8-ba75-4532-a364-ba95768595df@github.com> On Sat, 7 Jun 2025 20:03:27 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b03 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/33 From andrew at openjdk.org Sat Jun 7 21:17:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 21:17:36 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 8 new changesets Message-ID: Changeset: 17fd40ac Branch: master Author: Zdenek Zambersky Committer: Paul Hohensee Date: 2022-11-14 15:14:04 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/17fd40ac17b1bbcee302797961c67e38986a3ffd 8295714: GHA ::set-output is deprecated and will be removed Reviewed-by: sgehwolf Backport-of: b35922be6de7b848a2982d6a278dbd205fc39e6a ! .github/workflows/submit.yml Changeset: 7024bf0a Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-11-15 13:02:58 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7024bf0af8169ea8e36d812860072c40d5371327 8296959: Fix hotspot shell tests of 8u on multilib systems Reviewed-by: sgehwolf ! hotspot/test/compiler/criticalnatives/argumentcorruption/Test8167409.sh ! hotspot/test/runtime/7107135/Test7107135.sh ! hotspot/test/runtime/InitialThreadOverflow/testme.sh ! hotspot/test/runtime/StackGap/testme.sh ! hotspot/test/runtime/jni/CallWithJNIWeak/test.sh ! hotspot/test/runtime/jni/ReturnJNIWeak/test.sh ! hotspot/test/runtime/jsig/Test8017498.sh ! hotspot/test/test_env.sh Changeset: 6849667e Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-11-15 13:29:22 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6849667e9be3f46d91ff8c2a645b9435a2b420de 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer Reviewed-by: sgehwolf Backport-of: 869b25975288398a1d60601daacf00a99f51cd56 ! .github/workflows/submit.yml Changeset: 7ae002ca Branch: master Author: Sergey Bylokhov Date: 2022-11-16 02:51:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7ae002caba9ef17db5c105f76478424ce4cde04a 8286582: Build fails on macos aarch64 when using --with-zlib=bundled Reviewed-by: phh, sgehwolf Backport-of: 8363d9db801314f13e708db62993da5b73634f69 ! jdk/make/lib/CoreLibraries.gmk Changeset: b98d485d Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-11-17 09:01:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b98d485df4db6b5adf074444f9a94d2510faf5a0 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp Use and on Windows instead of emulation. Reviewed-by: phh Backport-of: b8ab854bdcf625772e965a5e476e0a9db1b91f3f ! hotspot/src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 9cb87521 Branch: master Author: Joshua Cao Committer: Paul Hohensee Date: 2022-11-18 15:00:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9cb87521c3eb693f4131fe575de50028eed2a8d9 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only Backport-of: e52bc6a831807006a20720f849e975428353cd17 + jdk/test/java/awt/Robot/RobotWheelTest/RobotWheelTest.java Changeset: 91d8b89a Branch: master Author: Joshua Cao Committer: Paul Hohensee Date: 2022-11-18 20:15:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/91d8b89ab976a8c25484da23ded6cdbb86f7b1e5 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails Reviewed-by: phh Backport-of: a1efb95536fb3995780336604cc727f921770c63 ! jdk/test/java/awt/Robot/RobotWheelTest/RobotWheelTest.java Changeset: 1d45f856 Branch: master Author: Andrew John Hughes Date: 2025-06-07 21:19:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1d45f8566bbb7e564711764b7f1057a2368fbe1c Merge jdk8u362-b04 Added tag jdk8u362-b04 for changeset 91d8b89ab97 From andrew at openjdk.org Sat Jun 7 21:17:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 21:17:45 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b04 for changeset 91d8b89a Message-ID: <9b57d7f5-94c7-4541-a583-0b222f6234c3@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-11-21 20:24:31 +0000 Added tag jdk8u362-b04 for changeset 91d8b89ab97 Changeset: 91d8b89a Author: Joshua Cao Committer: Paul Hohensee Date: 2022-11-18 20:15:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/91d8b89ab976a8c25484da23ded6cdbb86f7b1e5 From andrew at openjdk.org Sat Jun 7 21:17:49 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 21:17:49 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b04 for changeset 1d45f856 Message-ID: <10e22936-d9ad-4cfc-bffa-94389dbc66f9@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-07 21:42:25 +0000 Added tag shenandoah8u362-b04 for changeset 1d45f8566bb Changeset: 1d45f856 Author: Andrew John Hughes Date: 2025-06-07 21:19:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1d45f8566bbb7e564711764b7f1057a2368fbe1c From andrew at openjdk.org Sat Jun 7 22:08:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:08:59 GMT Subject: RFR: Merge jdk8u:master Message-ID: <3lnMwdhj-T6UYC37seZMBt8eiAGKsvNKx_rH_koMiQA=.0f498085-05e4-4570-a431-c2c5d93809f6@github.com> Merge jdk8u362-b05 ------------- Commit messages: - Merge jdk8u362-b05 - 8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI() - 8073464: GC workers do not have thread names - 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods - 8269039: Disable SHA-1 Signed JARs - 8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u - 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=35&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=35&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/35/files Stats: 801 lines in 48 files changed: 357 ins; 289 del; 155 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/35.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/35/head:pull/35 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/35 From andrew at openjdk.org Sat Jun 7 22:13:02 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:13:02 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: <3lnMwdhj-T6UYC37seZMBt8eiAGKsvNKx_rH_koMiQA=.0f498085-05e4-4570-a431-c2c5d93809f6@github.com> References: <3lnMwdhj-T6UYC37seZMBt8eiAGKsvNKx_rH_koMiQA=.0f498085-05e4-4570-a431-c2c5d93809f6@github.com> Message-ID: <7ZWJPeGBfUyZQ1VhAYfkft99EUj0GFufW1ccnJ2aB10=.4fe76592-f24e-4cd9-b2bb-f92b9980dabf@github.com> On Sat, 7 Jun 2025 22:04:45 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b05 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/35#issuecomment-2953151344 From andrew at openjdk.org Sat Jun 7 22:16:56 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:16:56 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 7 new changesets Message-ID: Changeset: da0c3828 Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-11-22 15:31:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/da0c382888809c4e0e9b2c0a492e96647a5f103c 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows Reviewed-by: sgehwolf Backport-of: 0cf828153cf8ee337645645b0632e77b8733a734 ! hotspot/test/runtime/NMT/HugeArenaTracking.java Changeset: 5a32484f Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-11-22 15:49:49 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5a32484f0f3be91ccaef76271361ef2fbfdf7558 8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u Reviewed-by: sgehwolf ! hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java Changeset: c501bfaa Branch: master Author: Alexey Bakhtin Date: 2022-11-23 15:16:22 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c501bfaa5fc2502942b228c907372dccd58c4a20 8269039: Disable SHA-1 Signed JARs Reviewed-by: mbalao Backport-of: 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7 ! jdk/src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java ! jdk/src/share/classes/sun/security/provider/certpath/CertPathConstraintsParameters.java ! jdk/src/share/classes/sun/security/provider/certpath/PKIX.java ! jdk/src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! jdk/src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java ! jdk/src/share/classes/sun/security/tools/jarsigner/Main.java ! jdk/src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java ! jdk/src/share/classes/sun/security/util/JarConstraintsParameters.java ! jdk/src/share/lib/security/java.security-aix ! jdk/src/share/lib/security/java.security-linux ! jdk/src/share/lib/security/java.security-macosx ! jdk/src/share/lib/security/java.security-solaris ! jdk/src/share/lib/security/java.security-windows - jdk/test/java/security/Security/signedfirst/Dyn.sh + jdk/test/java/security/Security/signedfirst/DynStatic.java - jdk/test/java/security/Security/signedfirst/Static.sh + jdk/test/java/security/Security/signedfirst/com/sun/exp/provider/EXP.java + jdk/test/java/security/Security/signedfirst/com/sun/exp/provider/SHA.java - jdk/test/java/security/Security/signedfirst/exp.jar - jdk/test/java/security/Security/signedfirst/keystore.jks ! jdk/test/java/util/jar/JarFile/Signed.jar ! jdk/test/java/util/jar/JarFile/test.jar ! jdk/test/java/util/jar/JarInputStream/signed.jar ! jdk/test/lib/security/SecurityUtils.java + jdk/test/sun/security/tools/jarsigner/OldSig.props ! jdk/test/sun/security/tools/jarsigner/Test4431684.java ! jdk/test/sun/security/tools/jarsigner/TimestampCheck.java ! jdk/test/sun/security/tools/jarsigner/diffend.sh ! jdk/test/sun/security/tools/jarsigner/oldsig.sh Changeset: 9f2f0c22 Branch: master Author: Volker Simonis Date: 2022-11-25 10:51:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9f2f0c220b44d0693dc05c915fe62e824bceaddf 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods Eliminating duplicated code by introducing print_on(outputStream* st) methods in NamedThread Reviewed-by: phh, andrew Backport-of: 16a3e2f16d3ffc4dd66e93aa9d75055279499282 ! hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! hotspot/src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! hotspot/src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! hotspot/src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! hotspot/src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! hotspot/src/share/vm/gc_implementation/g1/g1StringDedupThread.cpp ! hotspot/src/share/vm/gc_implementation/g1/g1StringDedupThread.hpp ! hotspot/src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! hotspot/src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/share/vm/runtime/thread.hpp ! hotspot/src/share/vm/runtime/vmThread.cpp ! hotspot/src/share/vm/runtime/vmThread.hpp Changeset: df44cbff Branch: master Author: Volker Simonis Date: 2022-11-25 11:49:47 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/df44cbff663e6415ff75a5cf1a59d9836961ef27 8073464: GC workers do not have thread names Reviewed-by: phh, andrew Backport-of: a827cdfa1047ee0af30bb454aad2067420103bae ! hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! hotspot/src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! hotspot/src/share/vm/gc_implementation/shared/concurrentGCThread.cpp ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/share/vm/runtime/thread.hpp ! hotspot/src/share/vm/runtime/vmThread.cpp ! hotspot/src/share/vm/utilities/workgroup.cpp Changeset: 41159a51 Branch: master Author: Andrew John Hughes Date: 2022-11-25 16:34:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/41159a51b418405e634aa08deed07d47611af37f 8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI() Backport-of: d53072236c503295b893efa6372c869ac84fa688 ! jdk/src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java Changeset: 9708f6d9 Branch: master Author: Andrew John Hughes Date: 2025-06-07 22:15:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9708f6d9eddcedd2c2ff78252e3977a78bb503b5 Merge jdk8u362-b05 Added tag jdk8u362-b05 for changeset 41159a51b41 ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/share/vm/runtime/thread.hpp ! hotspot/src/share/vm/runtime/thread.cpp ! hotspot/src/share/vm/runtime/thread.hpp From andrew at openjdk.org Sat Jun 7 22:17:05 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:17:05 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b00 for changeset 41159a51 Message-ID: <1f05922d-f83e-4cc7-8b5d-ec076a5199db@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-01-30 14:30:48 +0000 Added tag jdk8u372-b00 for changeset 41159a51b41 Changeset: 41159a51 Author: Andrew John Hughes Date: 2022-11-25 16:34:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/41159a51b418405e634aa08deed07d47611af37f From andrew at openjdk.org Sat Jun 7 22:17:09 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:17:09 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b00 for changeset 9708f6d9 Message-ID: <4385a20f-995d-499c-a251-f351cfdc855d@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-07 23:05:02 +0000 Added tag shenandoah8u372-b00 for changeset 9708f6d9edd Changeset: 9708f6d9 Author: Andrew John Hughes Date: 2025-06-07 22:15:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9708f6d9eddcedd2c2ff78252e3977a78bb503b5 From andrew at openjdk.org Sat Jun 7 22:17:13 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:17:13 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b05 for changeset 41159a51 Message-ID: <96ad51e8-ab34-426e-8cf2-b16f52f2796e@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-11-28 10:47:05 +0000 Added tag jdk8u362-b05 for changeset 41159a51b41 Changeset: 41159a51 Author: Andrew John Hughes Date: 2022-11-25 16:34:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/41159a51b418405e634aa08deed07d47611af37f From andrew at openjdk.org Sat Jun 7 22:17:20 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:17:20 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b05 for changeset 9708f6d9 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-07 22:36:07 +0000 Added tag shenandoah8u362-b05 for changeset 9708f6d9edd Changeset: 9708f6d9 Author: Andrew John Hughes Date: 2025-06-07 22:15:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9708f6d9eddcedd2c2ff78252e3977a78bb503b5 From andrew at openjdk.org Sat Jun 7 22:17:46 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 7 Jun 2025 22:17:46 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: <3lnMwdhj-T6UYC37seZMBt8eiAGKsvNKx_rH_koMiQA=.0f498085-05e4-4570-a431-c2c5d93809f6@github.com> References: <3lnMwdhj-T6UYC37seZMBt8eiAGKsvNKx_rH_koMiQA=.0f498085-05e4-4570-a431-c2c5d93809f6@github.com> Message-ID: > Merge jdk8u362-b05 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/35/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/35/files/9708f6d9..9708f6d9 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=35&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=35&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/35.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/35/head:pull/35 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/35 From iris at openjdk.org Sat Jun 7 22:17:46 2025 From: iris at openjdk.org (Iris Clark) Date: Sat, 7 Jun 2025 22:17:46 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: <3lnMwdhj-T6UYC37seZMBt8eiAGKsvNKx_rH_koMiQA=.0f498085-05e4-4570-a431-c2c5d93809f6@github.com> References: <3lnMwdhj-T6UYC37seZMBt8eiAGKsvNKx_rH_koMiQA=.0f498085-05e4-4570-a431-c2c5d93809f6@github.com> Message-ID: On Sat, 7 Jun 2025 22:04:45 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b05 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/35 From kdnilsen at openjdk.org Mon Jun 9 22:20:53 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Mon, 9 Jun 2025 22:20:53 GMT Subject: RFR: 8357471: GenShen: Share collector reserves between young and old [v3] In-Reply-To: References: Message-ID: > Genshen independently reserves memory to hold evacuations into young and old generations. We have found that under duress, it is sometimes difficult for mixed evacuations to make progress because the reserves in old are too small and we cannot expand old because young is running so frequently that it does not have the excess memory required to justify expansion of old (and shrinking of young). > > This PR exploits the fact that the reserves in young are often much larger than young requires to carry out its anticipated next GC cycle. In this case, we can share the young collector reserves with the old generation. This allows much more effective operation of mixed evacuations when GC is running at or near its full capacity. > > The following spreadsheet snapshots highlight the benefits of this change. In control with 6G heap size, we perform large numbers of mixed evacuations, but each mixed evacuation has very low productivity (e.g. one region at a time). This causes excessive delays in reclaiming the garbage from old, which is required to shrink old and expand young. This is why we see the large number of unproductive GC cycles, many of which degenerate and a few of which upgrade to full GC. In the experiment with 6G heap size, there are far fewer mixed cycles, but they are each much more productive. The total number of GC cycles decreases significantly. > > ![image](https://github.com/user-attachments/assets/782f7285-2b26-4f3b-ba3e-58465abb2c3a) > > With 7G heap size, the benefits of this PR manifest as a decrease in mixed evacuations, which also allows us to decrease total GC cycles. By more quickly reclaiming old garbage, we are able to more quickly expand young, which decreases the number of young GC cycles. This reduces CPU load. The impact on response times is not as significant as with the 6G heap size. We see slight improvement at p50-p99.9, with slight degradation at p99.99 through p100. > > ![image](https://github.com/user-attachments/assets/54fb5eae-2ae8-4679-ac78-c88bc5c16c2f) > > At 8G heap size, the GC is not at all stressed. We see approximately the same numbers of GC cycles, slight degradation of response times at p50-p99, slight improvement in response times at p99.9-p100. > > ![image](https://github.com/user-attachments/assets/50a48564-7f32-4c48-80e9-78e9a3a3d63c) > > The command line for these comparisons follows: > > > ~/github/jdk.share-collector-reserves/build/linux-x86_64-server-release/images/jdk/bin/java \ > -XX:+Unlock... Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision: Fix assert_bounds() assertions when old_trash_not_in_bounds ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25357/files - new: https://git.openjdk.org/jdk/pull/25357/files/ae8c83c9..8ec6ea06 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25357&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25357&range=01-02 Stats: 48 lines in 3 files changed: 32 ins; 2 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/25357.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25357/head:pull/25357 PR: https://git.openjdk.org/jdk/pull/25357 From duke at openjdk.org Tue Jun 10 13:36:50 2025 From: duke at openjdk.org (Jonas Norlinder) Date: Tue, 10 Jun 2025 13:36:50 GMT Subject: RFR: 8359110: Log accumulated GC and process CPU time upon VM exit Message-ID: Add support to log CPU cost for GC during VM exit with `-Xlog:gc`. ------------- Commit messages: - Measure GC vtime on VM exit Changes: https://git.openjdk.org/jdk/pull/25724/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25724&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359110 Stats: 178 lines in 15 files changed: 178 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25724.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25724/head:pull/25724 PR: https://git.openjdk.org/jdk/pull/25724 From roland at openjdk.org Tue Jun 10 14:20:14 2025 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 10 Jun 2025 14:20:14 GMT Subject: RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe Message-ID: When a barrier is expanded, some control is picked as a location for the barrier. The control input of data nodes that depend on that control are updated so the nodes are after the expanded barrier unless the barrier itself depends on some of those nodes. In this particular failure, a raw memoy `Store` is the input memory to the barrier. That `Store` has an anti-dependent `Load`. All 3 nodes (barrier, `Load` and `Store`) are at the same control. The `Store` is an input to the barrier so it stays before the barrier. The `Load`'s control is updated to be after the barrier which breaks the anti-dependency. The bug is that the logic that sorts nodes that need to be before the barrier and those that can be after ignores anti-dependencies. The fix simply extends that logic to take them into account. ------------- Commit messages: - whitespaces - fix & test Changes: https://git.openjdk.org/jdk/pull/25729/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25729&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358334 Stats: 153 lines in 3 files changed: 117 ins; 26 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/25729.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25729/head:pull/25729 PR: https://git.openjdk.org/jdk/pull/25729 From wkemper at openjdk.org Tue Jun 10 20:20:01 2025 From: wkemper at openjdk.org (William Kemper) Date: Tue, 10 Jun 2025 20:20:01 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean Message-ID: Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. ------------- Commit messages: - Merge remote-tracking branch 'jdk/master' into clean-read-table-for-degen - Clean the read table before swapping during a degenerated cycle Changes: https://git.openjdk.org/jdk/pull/25735/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25735&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357976 Stats: 17 lines in 2 files changed: 10 ins; 4 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/25735.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25735/head:pull/25735 PR: https://git.openjdk.org/jdk/pull/25735 From xpeng at openjdk.org Tue Jun 10 20:31:28 2025 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 10 Jun 2025 20:31:28 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 20:14:49 GMT, William Kemper wrote: > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 646: > 644: if (heap->mode()->is_generational()) { > 645: heap->old_generation()->card_scan()->mark_read_table_as_clean(); > 646: } I guess swap_card_tables has to be done at safe-point, otherwise we can move this to the place right before swap_card_tables is called in `op_init_mark` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25735#discussion_r2138715859 From kdnilsen at openjdk.org Tue Jun 10 20:47:26 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Tue, 10 Jun 2025 20:47:26 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 20:14:49 GMT, William Kemper wrote: > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. Thanks. LGTM ------------- Marked as reviewed by kdnilsen (Committer). PR Review: https://git.openjdk.org/jdk/pull/25735#pullrequestreview-2914990916 From xpeng at openjdk.org Tue Jun 10 21:13:31 2025 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 10 Jun 2025 21:13:31 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 20:14:49 GMT, William Kemper wrote: > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. src/hotspot/share/gc/shenandoah/shenandoahDegeneratedGC.cpp line 142: > 140: // Clean the read table before swapping it. The end goal here is to have a clean > 141: // write table, and to have the read table updated with the previous write table. > 142: heap->old_generation()->card_scan()->mark_read_table_as_clean(); Should we clean only when _generation is young, given we swap card tables when _generation is young? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25735#discussion_r2138774860 From cslucas at openjdk.org Tue Jun 10 23:05:27 2025 From: cslucas at openjdk.org (Cesar Soares Lucas) Date: Tue, 10 Jun 2025 23:05:27 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 20:14:49 GMT, William Kemper wrote: > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. Marked as reviewed by cslucas (Committer). ------------- PR Review: https://git.openjdk.org/jdk/pull/25735#pullrequestreview-2915227439 From ysr at openjdk.org Tue Jun 10 23:33:27 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Tue, 10 Jun 2025 23:33:27 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 20:14:49 GMT, William Kemper wrote: > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. Suggest moving the reset to a more consolidated natural point rather than piecemeal as done in this solution. ------------- Changes requested by ysr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25735#pullrequestreview-2915255444 From ysr at openjdk.org Tue Jun 10 23:33:28 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Tue, 10 Jun 2025 23:33:28 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 20:28:21 GMT, Xiaolong Peng wrote: >> Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. > > src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 646: > >> 644: if (heap->mode()->is_generational()) { >> 645: heap->old_generation()->card_scan()->mark_read_table_as_clean(); >> 646: } > > I guess swap_card_tables has to be done at safe-point, otherwise we can move this to the place right before swap_card_tables is called in `op_init_mark` To the point that Xiaolong is making in his other comment, I think we can move this cleaning into the `prepare_gc()` for the young generation which would be called above. Similarly, see my comment at the other place in degen collection, we'd have the prepare_gc() in the op_reset() clear the rad table along that path. I think that is the right place to do this resetting as we "prepare" the generation for a future collection at the conclusion of this one. > src/hotspot/share/gc/shenandoah/shenandoahDegeneratedGC.cpp line 142: > >> 140: // Clean the read table before swapping it. The end goal here is to have a clean >> 141: // write table, and to have the read table updated with the previous write table. >> 142: heap->old_generation()->card_scan()->mark_read_table_as_clean(); > > Should we clean only when _generation is young, given we swap card tables when _generation is young? If we started out with a clean read table, each concurrent gc cleaned the read table after it completed, then if we degenerate outside a cycle, we should find the read table clean already. Unless I am missing something, we should be able to assert here that the read table is clean (which the swap already does). Do we need the reset? It would seem that in the event that we degenerated within a concurrent cycle then we may not have done the reset and that's where we'd need to do an explicit reset further below where we call `op_reset()` which then calls `prepare_gc()` on the generation that was subject to this collection cycle, addressing the point that Xiaolong makes. See my comment in the other file as well. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25735#discussion_r2138918518 PR Review Comment: https://git.openjdk.org/jdk/pull/25735#discussion_r2138919561 From cslucas at openjdk.org Wed Jun 11 00:20:28 2025 From: cslucas at openjdk.org (Cesar Soares Lucas) Date: Wed, 11 Jun 2025 00:20:28 GMT Subject: RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: <7ZHTFi99uOLv_qY4m0bsX8UY9uP2J0NGpfMl6uLcsTE=.0c34fe48-5ee8-407c-b51c-1290099b6761@github.com> On Tue, 10 Jun 2025 14:13:21 GMT, Roland Westrelin wrote: > When a barrier is expanded, some control is picked as a location for > the barrier. The control input of data nodes that depend on that > control are updated so the nodes are after the expanded barrier unless > the barrier itself depends on some of those nodes. > > In this particular failure, a raw memoy `Store` is the input memory to > the barrier. That `Store` has an anti-dependent `Load`. All 3 nodes > (barrier, `Load` and `Store`) are at the same control. The `Store` is > an input to the barrier so it stays before the barrier. The `Load`'s > control is updated to be after the barrier which breaks the > anti-dependency. The bug is that the logic that sorts nodes that need > to be before the barrier and those that can be after ignores > anti-dependencies. The fix simply extends that logic to take them into > account. LGTM. Thanks. ------------- PR Review: https://git.openjdk.org/jdk/pull/25729#pullrequestreview-2915306013 From wkemper at openjdk.org Wed Jun 11 18:38:29 2025 From: wkemper at openjdk.org (William Kemper) Date: Wed, 11 Jun 2025 18:38:29 GMT Subject: RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: <_vTHjSU4jSzcb7EgFzGOk3Tp_uRff502Tfb_JViarl0=.08d55130-b250-4476-8805-8c114f940248@github.com> On Tue, 10 Jun 2025 14:13:21 GMT, Roland Westrelin wrote: > When a barrier is expanded, some control is picked as a location for > the barrier. The control input of data nodes that depend on that > control are updated so the nodes are after the expanded barrier unless > the barrier itself depends on some of those nodes. > > In this particular failure, a raw memoy `Store` is the input memory to > the barrier. That `Store` has an anti-dependent `Load`. All 3 nodes > (barrier, `Load` and `Store`) are at the same control. The `Store` is > an input to the barrier so it stays before the barrier. The `Load`'s > control is updated to be after the barrier which breaks the > anti-dependency. The bug is that the logic that sorts nodes that need > to be before the barrier and those that can be after ignores > anti-dependencies. The fix simply extends that logic to take them into > account. Thank you for this! ------------- Marked as reviewed by wkemper (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25729#pullrequestreview-2918306489 From shade at openjdk.org Wed Jun 11 19:09:28 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Jun 2025 19:09:28 GMT Subject: RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 14:13:21 GMT, Roland Westrelin wrote: > When a barrier is expanded, some control is picked as a location for > the barrier. The control input of data nodes that depend on that > control are updated so the nodes are after the expanded barrier unless > the barrier itself depends on some of those nodes. > > In this particular failure, a raw memoy `Store` is the input memory to > the barrier. That `Store` has an anti-dependent `Load`. All 3 nodes > (barrier, `Load` and `Store`) are at the same control. The `Store` is > an input to the barrier so it stays before the barrier. The `Load`'s > control is updated to be after the barrier which breaks the > anti-dependency. The bug is that the logic that sorts nodes that need > to be before the barrier and those that can be after ignores > anti-dependencies. The fix simply extends that logic to take them into > account. The patch makes sense. I ran `make test TEST=all TEST_VM_OPTS=-XX:+UseShenandoahGC` without new failures. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25729#pullrequestreview-2918386137 From dlong at openjdk.org Thu Jun 12 01:56:34 2025 From: dlong at openjdk.org (Dean Long) Date: Thu, 12 Jun 2025 01:56:34 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead Message-ID: This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. ------------- Commit messages: - cleanup - wip Changes: https://git.openjdk.org/jdk/pull/25764/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358821 Stats: 251 lines in 19 files changed: 90 ins; 131 del; 30 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From dlong at openjdk.org Thu Jun 12 02:01:47 2025 From: dlong at openjdk.org (Dean Long) Date: Thu, 12 Jun 2025 02:01:47 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v2] In-Reply-To: References: Message-ID: <8oM2Y0kAMRN6wxtjAmpXDWTcHDZ6gPrNM-8PPtukwAA=.dde201dd-8c2a-4a16-96e5-ca92604e6edd@github.com> > This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. > > We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. > > The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. > > For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. > > This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. Dean Long has updated the pull request incrementally with two additional commits since the last revision: - ... and stale code - removed stale comment ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25764/files - new: https://git.openjdk.org/jdk/pull/25764/files/b20fb26f..0780d156 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From duke at openjdk.org Thu Jun 12 11:28:35 2025 From: duke at openjdk.org (Jonas Norlinder) Date: Thu, 12 Jun 2025 11:28:35 GMT Subject: Withdrawn: 8359110: Log accumulated GC and process CPU time upon VM exit In-Reply-To: References: Message-ID: <24ib50kFQIUcwJ1BlMmQPdDDZI2wDSV0aHdR1_ratQE=.7c283605-89a7-491b-802b-86958b78e801@github.com> On Tue, 10 Jun 2025 13:24:37 GMT, Jonas Norlinder wrote: > Add support to log CPU cost for GC during VM exit with `-Xlog:gc`. > > > [1.500s][info ][gc] GC CPU cost: 1.75% > > > Additionally, detailed information may be retrieved with `-Xlog:gc=trace` > > > [1.500s][trace][gc] Process CPU time: 4.945370s > [1.500s][trace][gc] GC CPU time: 0.086382s > [1.500s][info ][gc] GC CPU cost: 1.75% This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/25724 From mdoerr at openjdk.org Thu Jun 12 12:53:31 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 12 Jun 2025 12:53:31 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v2] In-Reply-To: <8oM2Y0kAMRN6wxtjAmpXDWTcHDZ6gPrNM-8PPtukwAA=.dde201dd-8c2a-4a16-96e5-ca92604e6edd@github.com> References: <8oM2Y0kAMRN6wxtjAmpXDWTcHDZ6gPrNM-8PPtukwAA=.dde201dd-8c2a-4a16-96e5-ca92604e6edd@github.com> Message-ID: On Thu, 12 Jun 2025 02:01:47 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with two additional commits since the last revision: > > - ... and stale code > - removed stale comment I appreciate this PR. I like using the nmethod entry barrier and getting rid of not-entrant patching. I have some change requests. In addition, we can get rid of much more code. I've put my proposal in a Commit: https://github.com/TheRealMDoerr/jdk/commit/4aed569dc353c254a2f4de2d387208a0a1323990 Please take a look! src/hotspot/share/gc/shared/barrierSetNMethod.cpp line 246: > 244: ConditionalMutexLocker ml(NMethodEntryBarrier_lock, !NMethodEntryBarrier_lock->owned_by_self(), Mutex::_no_safepoint_check_flag); > 245: int value = guard_value(nm) | not_entrant; > 246: set_guard_value(nm, value); Same here. src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp line 153: > 151: // Code cache unloading needs to know about on-stack nmethods. Arm the nmethods to get > 152: // mark_as_maybe_on_stack() callbacks when they are used again. > 153: _bs->arm(nm); This breaks the Shenandoah build. `arm` is private. src/hotspot/share/gc/z/zBarrierSetNMethod.cpp line 116: > 114: value |= not_entrant; > 115: } > 116: set_guard_value(nm, value); We can avoid redundant patching since we have the lock: Only update if the value is not already there. This happens quite often. ------------- Changes requested by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25764#pullrequestreview-2920990811 PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2142655962 PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2142641974 PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2142654627 From wkemper at openjdk.org Thu Jun 12 14:29:06 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 14:29:06 GMT Subject: RFR: Merge openjdk/jdk21u:master Message-ID: Merges tag jdk-21.0.8+6 ------------- Commit messages: - 8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization" The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk21u/pull/198/files Stats: 66 lines in 2 files changed: 64 ins; 0 del; 2 mod Patch: https://git.openjdk.org/shenandoah-jdk21u/pull/198.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/198/head:pull/198 PR: https://git.openjdk.org/shenandoah-jdk21u/pull/198 From roland at openjdk.org Thu Jun 12 15:05:35 2025 From: roland at openjdk.org (Roland Westrelin) Date: Thu, 12 Jun 2025 15:05:35 GMT Subject: RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: <7ZHTFi99uOLv_qY4m0bsX8UY9uP2J0NGpfMl6uLcsTE=.0c34fe48-5ee8-407c-b51c-1290099b6761@github.com> References: <7ZHTFi99uOLv_qY4m0bsX8UY9uP2J0NGpfMl6uLcsTE=.0c34fe48-5ee8-407c-b51c-1290099b6761@github.com> Message-ID: On Wed, 11 Jun 2025 00:18:09 GMT, Cesar Soares Lucas wrote: >> When a barrier is expanded, some control is picked as a location for >> the barrier. The control input of data nodes that depend on that >> control are updated so the nodes are after the expanded barrier unless >> the barrier itself depends on some of those nodes. >> >> In this particular failure, a raw memoy `Store` is the input memory to >> the barrier. That `Store` has an anti-dependent `Load`. All 3 nodes >> (barrier, `Load` and `Store`) are at the same control. The `Store` is >> an input to the barrier so it stays before the barrier. The `Load`'s >> control is updated to be after the barrier which breaks the >> anti-dependency. The bug is that the logic that sorts nodes that need >> to be before the barrier and those that can be after ignores >> anti-dependencies. The fix simply extends that logic to take them into >> account. > > LGTM. Thanks. @JohnTortugo @earthling-amzn @shipilev thanks for the reviews and testing. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25729#issuecomment-2967202208 From roland at openjdk.org Thu Jun 12 15:05:36 2025 From: roland at openjdk.org (Roland Westrelin) Date: Thu, 12 Jun 2025 15:05:36 GMT Subject: Integrated: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: <-a0YpfCwzfGZ3VG1Pqgc6c_L1tk4-DPConFxZUu4Mr0=.dbef3b3e-f6b8-448a-b9de-d1b959acee33@github.com> On Tue, 10 Jun 2025 14:13:21 GMT, Roland Westrelin wrote: > When a barrier is expanded, some control is picked as a location for > the barrier. The control input of data nodes that depend on that > control are updated so the nodes are after the expanded barrier unless > the barrier itself depends on some of those nodes. > > In this particular failure, a raw memoy `Store` is the input memory to > the barrier. That `Store` has an anti-dependent `Load`. All 3 nodes > (barrier, `Load` and `Store`) are at the same control. The `Store` is > an input to the barrier so it stays before the barrier. The `Load`'s > control is updated to be after the barrier which breaks the > anti-dependency. The bug is that the logic that sorts nodes that need > to be before the barrier and those that can be after ignores > anti-dependencies. The fix simply extends that logic to take them into > account. This pull request has now been integrated. Changeset: 1fcede05 Author: Roland Westrelin URL: https://git.openjdk.org/jdk/commit/1fcede053cca360c96606c1034b2a365a4fada82 Stats: 153 lines in 3 files changed: 117 ins; 26 del; 10 mod 8358334: C2/Shenandoah: incorrect execution with Unsafe Reviewed-by: wkemper, shade ------------- PR: https://git.openjdk.org/jdk/pull/25729 From wkemper at openjdk.org Thu Jun 12 18:52:50 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 18:52:50 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v2] In-Reply-To: References: Message-ID: <-hSDnHAfYEBYrD639Gd-a7jNOFOlA-XVOEvZqypyzyk=.c64ccff0-b13b-4a5e-b81a-0c1966f32f8e@github.com> > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. William Kemper has updated the pull request incrementally with one additional commit since the last revision: Consolidate read table cleaning ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25735/files - new: https://git.openjdk.org/jdk/pull/25735/files/5e2c20a8..9552021c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25735&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25735&range=00-01 Stats: 20 lines in 3 files changed: 5 ins; 10 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/25735.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25735/head:pull/25735 PR: https://git.openjdk.org/jdk/pull/25735 From dlong at openjdk.org Thu Jun 12 19:54:45 2025 From: dlong at openjdk.org (Dean Long) Date: Thu, 12 Jun 2025 19:54:45 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v3] In-Reply-To: References: Message-ID: > This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. > > We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. > > The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. > > For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. > > This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. Dean Long has updated the pull request incrementally with six additional commits since the last revision: - more cleanup - more TheRealMDoerr suggestions - TheRealMDoerr suggestions - remove trailing space - Fix Shenandoah build - more cleanup ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25764/files - new: https://git.openjdk.org/jdk/pull/25764/files/0780d156..0950fc5e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=01-02 Stats: 330 lines in 25 files changed: 10 ins; 304 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From dlong at openjdk.org Thu Jun 12 19:57:28 2025 From: dlong at openjdk.org (Dean Long) Date: Thu, 12 Jun 2025 19:57:28 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v2] In-Reply-To: <8oM2Y0kAMRN6wxtjAmpXDWTcHDZ6gPrNM-8PPtukwAA=.dde201dd-8c2a-4a16-96e5-ca92604e6edd@github.com> References: <8oM2Y0kAMRN6wxtjAmpXDWTcHDZ6gPrNM-8PPtukwAA=.dde201dd-8c2a-4a16-96e5-ca92604e6edd@github.com> Message-ID: On Thu, 12 Jun 2025 02:01:47 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with two additional commits since the last revision: > > - ... and stale code > - removed stale comment Thanks @TheRealMDoer for the suggestions, I incorporated all of them, however for shenandoahCodeRoots.cpp I decided to make arm() public, so the caller code doesn't need to know about the magic value 0. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2967999465 From mdoerr at openjdk.org Thu Jun 12 20:08:31 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 12 Jun 2025 20:08:31 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v2] In-Reply-To: References: <8oM2Y0kAMRN6wxtjAmpXDWTcHDZ6gPrNM-8PPtukwAA=.dde201dd-8c2a-4a16-96e5-ca92604e6edd@github.com> Message-ID: <15r53QUpAANeu3oucJCrmg3BOqTksEQK24cppfHjQow=.b5848d6f-0bfe-43ce-a4d8-29d57d91e873@github.com> On Thu, 12 Jun 2025 19:54:28 GMT, Dean Long wrote: > Thanks @TheRealMDoer for the suggestions, I incorporated all of them, however for shenandoahCodeRoots.cpp I decided to make arm() public, so the caller code doesn't need to know about the magic value 0. Excellent! Thank you! I'll take another look over it and run tests. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2968024418 From kdnilsen at openjdk.org Thu Jun 12 20:12:50 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Thu, 12 Jun 2025 20:12:50 GMT Subject: RFR: 8357471: GenShen: Share collector reserves between young and old [v4] In-Reply-To: References: Message-ID: > Genshen independently reserves memory to hold evacuations into young and old generations. We have found that under duress, it is sometimes difficult for mixed evacuations to make progress because the reserves in old are too small and we cannot expand old because young is running so frequently that it does not have the excess memory required to justify expansion of old (and shrinking of young). > > This PR exploits the fact that the reserves in young are often much larger than young requires to carry out its anticipated next GC cycle. In this case, we can share the young collector reserves with the old generation. This allows much more effective operation of mixed evacuations when GC is running at or near its full capacity. > > The following spreadsheet snapshots highlight the benefits of this change. In control with 6G heap size, we perform large numbers of mixed evacuations, but each mixed evacuation has very low productivity (e.g. one region at a time). This causes excessive delays in reclaiming the garbage from old, which is required to shrink old and expand young. This is why we see the large number of unproductive GC cycles, many of which degenerate and a few of which upgrade to full GC. In the experiment with 6G heap size, there are far fewer mixed cycles, but they are each much more productive. The total number of GC cycles decreases significantly. > > ![image](https://github.com/user-attachments/assets/782f7285-2b26-4f3b-ba3e-58465abb2c3a) > > With 7G heap size, the benefits of this PR manifest as a decrease in mixed evacuations, which also allows us to decrease total GC cycles. By more quickly reclaiming old garbage, we are able to more quickly expand young, which decreases the number of young GC cycles. This reduces CPU load. The impact on response times is not as significant as with the 6G heap size. We see slight improvement at p50-p99.9, with slight degradation at p99.99 through p100. > > ![image](https://github.com/user-attachments/assets/54fb5eae-2ae8-4679-ac78-c88bc5c16c2f) > > At 8G heap size, the GC is not at all stressed. We see approximately the same numbers of GC cycles, slight degradation of response times at p50-p99, slight improvement in response times at p99.9-p100. > > ![image](https://github.com/user-attachments/assets/50a48564-7f32-4c48-80e9-78e9a3a3d63c) > > The command line for these comparisons follows: > > > ~/github/jdk.share-collector-reserves/build/linux-x86_64-server-release/images/jdk/bin/java \ > -XX:+Unlock... Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision: fix whitespace ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25357/files - new: https://git.openjdk.org/jdk/pull/25357/files/8ec6ea06..aea2b925 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25357&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25357&range=02-03 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25357.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25357/head:pull/25357 PR: https://git.openjdk.org/jdk/pull/25357 From wkemper at openjdk.org Thu Jun 12 20:42:03 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 20:42:03 GMT Subject: RFR: Merge openjdk/jdk21u:master [v2] In-Reply-To: References: Message-ID: > Merges tag jdk-21.0.8+6 William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk21u/pull/198/files - new: https://git.openjdk.org/shenandoah-jdk21u/pull/198/files/e62f2f4f..e62f2f4f Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk21u&pr=198&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk21u&pr=198&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk21u/pull/198.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/198/head:pull/198 PR: https://git.openjdk.org/shenandoah-jdk21u/pull/198 From wkemper at openjdk.org Thu Jun 12 20:42:03 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 20:42:03 GMT Subject: RFR: Merge openjdk/jdk21u:master In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 14:23:55 GMT, William Kemper wrote: > Merges tag jdk-21.0.8+6 Build failure looks infrastructure related. ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk21u/pull/198#issuecomment-2968096397 From wkemper at openjdk.org Thu Jun 12 20:42:03 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 20:42:03 GMT Subject: Integrated: Merge openjdk/jdk21u:master In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 14:23:55 GMT, William Kemper wrote: > Merges tag jdk-21.0.8+6 This pull request has now been integrated. Changeset: 9fb8d5be Author: William Kemper URL: https://git.openjdk.org/shenandoah-jdk21u/commit/9fb8d5be3ee1a9a8334d689016bf69069bc87ba2 Stats: 66 lines in 2 files changed: 64 ins; 0 del; 2 mod Merge ------------- PR: https://git.openjdk.org/shenandoah-jdk21u/pull/198 From wkemper at openjdk.org Thu Jun 12 20:42:53 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 20:42:53 GMT Subject: RFR: 8358102: GenShen: Age tables could be seeded with cumulative values In-Reply-To: References: Message-ID: On Mon, 2 Jun 2025 18:55:37 GMT, William Kemper wrote: > Clean backport, low risk. Test failure looks unrelated. ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk21u/pull/197#issuecomment-2968097290 From wkemper at openjdk.org Thu Jun 12 20:42:53 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 20:42:53 GMT Subject: Integrated: 8358102: GenShen: Age tables could be seeded with cumulative values In-Reply-To: References: Message-ID: On Mon, 2 Jun 2025 18:55:37 GMT, William Kemper wrote: > Clean backport, low risk. This pull request has now been integrated. Changeset: 7172b510 Author: William Kemper URL: https://git.openjdk.org/shenandoah-jdk21u/commit/7172b5105781fddf492726bd4291d50780bf2a15 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8358102: GenShen: Age tables could be seeded with cumulative values Backport-of: 99a4b22ae7dc2755df1780cc7d74c5d6e3cd4cd4 ------------- PR: https://git.openjdk.org/shenandoah-jdk21u/pull/197 From wkemper at openjdk.org Thu Jun 12 22:10:12 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 22:10:12 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: References: Message-ID: > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. William Kemper has updated the pull request incrementally with one additional commit since the last revision: Revert "Consolidate read table cleaning" This reverts commit 9552021cbeec699e7b04db81fa68819c23b7dab7. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25735/files - new: https://git.openjdk.org/jdk/pull/25735/files/9552021c..a313cf8d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25735&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25735&range=01-02 Stats: 20 lines in 3 files changed: 10 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/25735.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25735/head:pull/25735 PR: https://git.openjdk.org/jdk/pull/25735 From wkemper at openjdk.org Thu Jun 12 22:47:28 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 22:47:28 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 22:10:12 GMT, William Kemper wrote: >> Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. > > William Kemper has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Consolidate read table cleaning" > > This reverts commit 9552021cbeec699e7b04db81fa68819c23b7dab7. @pengxiaolong - We don't want to clean the read table during init-mark because that's a safepoint. We can safely clean the read table concurrently because only the GC thread has access to it. @ysramakrishna - The refactoring you suggest is not so simple, alas. We have to be very careful about the ordering of cleaning the `read` table, resetting the mark bitmap and swapping the card tables. Genshen does not clean the `read` table at the end of a concurrent cycle (we _could_ do this, but we'd still need to do the same in a degenerated cycle). The complexity comes from swapping the card tables in a concurrent cycle. We must not let a subsequent degenerated cycle swap them a second time. The degenerated cycle can only clean the `read` table if there was no active concurrent cycle (lest it throw away critical remembered set data). However, the degenerated cycle must also clear the mark bitmaps if the concurrent cycle degenerated during the root scan (the degenerated cycle will rescan the roots). Of course, we cannot clear the mark bitmaps if the concurrent cycle degenerated during the mark phase. So, for the degenerated cycle, clearing the mark bitmaps and cleaning the read table need to happen in two different cases and it doesn't work if they're combined into the same method (and I don't think adding a method parameter to sometimes clear the mark bitmap and sometimes the read table will make the code any easier to understand). ------------- PR Comment: https://git.openjdk.org/jdk/pull/25735#issuecomment-2968354749 From wkemper at openjdk.org Thu Jun 12 23:46:36 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Jun 2025 23:46:36 GMT Subject: RFR: 8359394: Shenandoah: GC cause cleanup Message-ID: We can remove `GCCause::_no_cause_specified` and need to add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are also missing `_shenandoah_humongous_allocation_failure` in the `SA` analog. ------------- Commit messages: - Fix typo - Clean up/fix gc causes for Shenandoah Changes: https://git.openjdk.org/jdk/pull/25789/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25789&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359394 Stats: 18 lines in 5 files changed: 5 ins; 6 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/25789.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25789/head:pull/25789 PR: https://git.openjdk.org/jdk/pull/25789 From wkemper at openjdk.org Fri Jun 13 00:15:29 2025 From: wkemper at openjdk.org (William Kemper) Date: Fri, 13 Jun 2025 00:15:29 GMT Subject: RFR: 8359394: Shenandoah: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > We can remove `GCCause::_no_cause_specified` and need to add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are also missing `_shenandoah_humongous_allocation_failure` in the `SA` analog. src/hotspot/share/gc/shared/gcCause.cpp line 92: > 90: return "Diagnostic Command"; > 91: > 92: case _shenandoah_stop_vm: Just reordered this case to match enum's declaration order. src/hotspot/share/gc/shared/gcCause.hpp line 118: > 116: inline static bool is_allocation_failure_gc(GCCause::Cause cause) { > 117: // _allocation_failure is the generic cause a collection for allocation failure > 118: return cause == GCCause::_allocation_failure; Shenandoah does not use this method. Nobody else needs to know about this Shenandoah specific value. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25789#discussion_r2143900441 PR Review Comment: https://git.openjdk.org/jdk/pull/25789#discussion_r2143904488 From shade at openjdk.org Fri Jun 13 09:45:29 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 13 Jun 2025 09:45:29 GMT Subject: RFR: 8359394: Shenandoah: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > We can remove `GCCause::_no_cause_specified` and need to add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are also missing `_shenandoah_humongous_allocation_failure` in the `SA` analog. Shenandoah parts look good, but we should avoid changing shared code unnecessarily. Changes requested by shade (Reviewer). src/hotspot/share/gc/shared/gcCause.hpp line 58: > 56: /* implementation independent, but reserved for GC use */ > 57: _no_gc, > 58: _no_cause_specified, Code history shows this enum was there since the beginning of OpenJDK. So it is better to leave it alone. It is also less confusing to have only Shenandoah-specific changes in RFE that starts with "Shenandoah: ..." ------------- Changes requested by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2924090662 PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2924091681 PR Review Comment: https://git.openjdk.org/jdk/pull/25789#discussion_r2144632935 From mdoerr at openjdk.org Fri Jun 13 11:57:35 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 13 Jun 2025 11:57:35 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v3] In-Reply-To: References: Message-ID: <0jwlIB4VebRh3dORUSPdbmmE4YWS1Z6t_Ax8ni0_tpg=.f9dd6d19-1c97-43d7-acb2-ad575b61d433@github.com> On Thu, 12 Jun 2025 19:54:45 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with six additional commits since the last revision: > > - more cleanup > - more TheRealMDoerr suggestions > - TheRealMDoerr suggestions > - remove trailing space > - Fix Shenandoah build > - more cleanup LGTM, now. I think `is_sigill_not_entrant` should also be removed completely: https://github.com/TheRealMDoerr/jdk/commit/f61f54a40ad0b952ba8c0a668675b3f315f83a95 I've run tests on some platforms, but will run on more. @offamitkumar, @RealFYang, @bulasevich: You may also want to check your platforms. @fisk: You may want to take a look at the nmethod entry barrier changes. ------------- PR Review: https://git.openjdk.org/jdk/pull/25764#pullrequestreview-2924552667 From andrew at openjdk.org Fri Jun 13 18:09:06 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 18:09:06 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u362-b06 ------------- Commit messages: - Merge jdk8u362-b06 - 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled - 8296108: (tz) Update Timezone Data to 2022f The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/36/files Stats: 2475 lines in 45 files changed: 993 ins; 1277 del; 205 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/36.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/36/head:pull/36 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/36 From andrew at openjdk.org Fri Jun 13 18:09:06 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 18:09:06 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: <6NwedsZ5FbUEQVHOkKTxohCgOI4FZ8iI0iXTFzG1ZaM=.04fad37a-1be3-4bf9-871b-2d0819d3292a@github.com> On Fri, 13 Jun 2025 18:05:25 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b06 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/36#issuecomment-2971153954 From andrew at openjdk.org Fri Jun 13 18:15:23 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 18:15:23 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 3 new changesets Message-ID: <9eb0a1ad-9e05-4dd5-ba3f-c90545a94306@openjdk.org> Changeset: 7297bdfc Branch: master Author: Dmitry Cherepanov Date: 2022-11-30 16:25:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7297bdfcaeb55da8c14560ff352407d114a38bd7 8296108: (tz) Update Timezone Data to 2022f Reviewed-by: andrew Backport-of: 9d3b4ef2ad658afb5379796b7224458c12c81f5d ! jdk/make/data/tzdata/VERSION ! jdk/make/data/tzdata/africa ! jdk/make/data/tzdata/antarctica ! jdk/make/data/tzdata/asia ! jdk/make/data/tzdata/australasia ! jdk/make/data/tzdata/backward ! jdk/make/data/tzdata/etcetera ! jdk/make/data/tzdata/europe ! jdk/make/data/tzdata/northamerica ! jdk/make/data/tzdata/southamerica ! jdk/make/data/tzdata/zone.tab ! jdk/src/share/classes/sun/util/resources/TimeZoneNames.java ! jdk/src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! jdk/src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! jdk/src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! jdk/src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! jdk/src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! jdk/src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! jdk/src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! jdk/src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! jdk/src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! jdk/src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! jdk/test/java/util/TimeZone/TimeZoneData/VERSION ! jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt ! jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt ! jdk/test/sun/util/calendar/zi/tzdata/VERSION ! jdk/test/sun/util/calendar/zi/tzdata/africa ! jdk/test/sun/util/calendar/zi/tzdata/antarctica ! jdk/test/sun/util/calendar/zi/tzdata/asia ! jdk/test/sun/util/calendar/zi/tzdata/australasia ! jdk/test/sun/util/calendar/zi/tzdata/backward ! jdk/test/sun/util/calendar/zi/tzdata/etcetera ! jdk/test/sun/util/calendar/zi/tzdata/europe ! jdk/test/sun/util/calendar/zi/tzdata/northamerica ! jdk/test/sun/util/calendar/zi/tzdata/southamerica ! jdk/test/sun/util/calendar/zi/tzdata/zone.tab Changeset: 53620b38 Branch: master Author: Alexey Bakhtin Date: 2022-12-01 06:17:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/53620b38d3d46344b5d5e9deb017a234828ead28 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled Reviewed-by: phh, andrew Backport-of: 03f8c0fb9363dc1bb07bed1ae0359c029caa0130 ! jdk/src/share/classes/sun/security/pkcs/SignerInfo.java ! jdk/src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java ! jdk/src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! jdk/src/share/classes/sun/security/tools/jarsigner/Main.java ! jdk/src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java ! jdk/src/share/classes/sun/security/util/JarConstraintsParameters.java ! jdk/src/share/classes/sun/security/util/ManifestEntryVerifier.java ! jdk/src/share/classes/sun/security/util/SignatureFileVerifier.java ! jdk/test/sun/security/tools/jarsigner/TimestampCheck.java Changeset: 165b824d Branch: master Author: Andrew John Hughes Date: 2025-06-07 23:14:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/165b824d3442545c17f29a173d1f54b368a24013 Merge jdk8u362-b06 Added tag jdk8u362-b06 for changeset 53620b38d3d From andrew at openjdk.org Fri Jun 13 18:15:33 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 18:15:33 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b06 for changeset 53620b38 Message-ID: <878780bc-5ca1-4e9a-823a-56821c61c63f@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-12-12 14:17:34 +0000 Added tag jdk8u362-b06 for changeset 53620b38d3d Changeset: 53620b38 Author: Alexey Bakhtin Date: 2022-12-01 06:17:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/53620b38d3d46344b5d5e9deb017a234828ead28 From andrew at openjdk.org Fri Jun 13 18:15:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 18:15:35 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b06 for changeset 165b824d Message-ID: <461caeca-7fcb-4841-90f3-9baf03785a9c@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-10 00:43:39 +0000 Added tag shenandoah8u362-b06 for changeset 165b824d344 Changeset: 165b824d Author: Andrew John Hughes Date: 2025-06-07 23:14:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/165b824d3442545c17f29a173d1f54b368a24013 From andrew at openjdk.org Fri Jun 13 18:17:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 18:17:18 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u362-b06 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/36/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/36/files/165b824d..165b824d Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=36&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=36&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/36.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/36/head:pull/36 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/36 From iris at openjdk.org Fri Jun 13 18:17:18 2025 From: iris at openjdk.org (Iris Clark) Date: Fri, 13 Jun 2025 18:17:18 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: <2AikjEKol7w14RGVtGLjAtGqCJcd4Ll1xrl40bXoSoE=.94643e6b-adc6-46aa-982d-c5f57dc83e7f@github.com> On Fri, 13 Jun 2025 18:05:25 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b06 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/36 From dlong at openjdk.org Fri Jun 13 19:18:19 2025 From: dlong at openjdk.org (Dean Long) Date: Fri, 13 Jun 2025 19:18:19 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: > This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. > > We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. > > The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. > > For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. > > This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. Dean Long has updated the pull request incrementally with one additional commit since the last revision: remove is_sigill_not_entrant ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25764/files - new: https://git.openjdk.org/jdk/pull/25764/files/0950fc5e..c1ebde09 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=02-03 Stats: 23 lines in 6 files changed: 0 ins; 22 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From andrew at openjdk.org Fri Jun 13 20:11:09 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 20:11:09 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 4 new changesets Message-ID: Changeset: 518047d8 Branch: master Author: Andrew John Hughes Date: 2022-12-22 00:57:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/518047d8781988191b982b33839c4b4ea9f280e1 8296715: CLDR v42 update for tzdata 2022f Reviewed-by: dcherepanov, sgehwolf Backport-of: da9de488990ff47fe06343439f2180ec1b2a3061 ! jdk/src/share/classes/sun/util/cldr/resources/21_0_1/common/supplemental/metaZones.xml Changeset: c961cb9f Branch: master Author: Andrew John Hughes Date: 2022-12-22 01:07:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c961cb9f676cbb05e8fa28b7ca9d41b02fc83d3d 8297804: (tz) Update Timezone Data to 2022g Reviewed-by: dcherepanov, sgehwolf Backport-of: ce896731d38866c2bf99cd49525062e150d94160 ! jdk/make/data/tzdata/VERSION ! jdk/make/data/tzdata/africa ! jdk/make/data/tzdata/asia ! jdk/make/data/tzdata/backward ! jdk/make/data/tzdata/europe ! jdk/make/data/tzdata/iso3166.tab ! jdk/make/data/tzdata/northamerica ! jdk/make/data/tzdata/southamerica ! jdk/make/data/tzdata/zone.tab ! jdk/src/share/classes/sun/util/cldr/resources/21_0_1/common/main/root.xml ! jdk/src/share/classes/sun/util/cldr/resources/21_0_1/common/supplemental/metaZones.xml ! jdk/src/share/classes/sun/util/resources/TimeZoneNames.java ! jdk/src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! jdk/src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! jdk/src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! jdk/src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! jdk/src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! jdk/src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! jdk/src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! jdk/src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! jdk/src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! jdk/src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! jdk/test/java/util/TimeZone/TimeZoneData/VERSION ! jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt ! jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt ! jdk/test/sun/util/calendar/zi/tzdata/VERSION ! jdk/test/sun/util/calendar/zi/tzdata/africa ! jdk/test/sun/util/calendar/zi/tzdata/asia ! jdk/test/sun/util/calendar/zi/tzdata/backward ! jdk/test/sun/util/calendar/zi/tzdata/europe ! jdk/test/sun/util/calendar/zi/tzdata/iso3166.tab ! jdk/test/sun/util/calendar/zi/tzdata/northamerica ! jdk/test/sun/util/calendar/zi/tzdata/southamerica ! jdk/test/sun/util/calendar/zi/tzdata/zone.tab Changeset: ebc5e190 Branch: master Author: Severin Gehwolf Date: 2022-12-23 17:55:05 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ebc5e190ac7a3b0c143451105d9f9b7d9e780a4b 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Reviewed-by: andrew Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d ! jdk/src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java + jdk/test/java/security/SignedJar/CustomClassLoader.java + jdk/test/java/security/SignedJar/SignedJarWithCustomClassLoader.java Changeset: 3393ce98 Branch: master Author: Andrew John Hughes Date: 2025-06-13 19:13:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3393ce98277b6d7572541bf2c4efb29c7b94b46f Merge jdk8u362-b07 Added tag jdk8u362-b07 for changeset ebc5e190ac7 From andrew at openjdk.org Fri Jun 13 20:11:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 20:11:19 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b07 for changeset ebc5e190 Message-ID: <77221e1c-0e60-4de6-9987-0b1f48681223@openjdk.org> Tagged by: Andrew John Hughes Date: 2022-12-29 00:48:44 +0000 Added tag jdk8u362-b07 for changeset ebc5e190ac7 Changeset: ebc5e190 Author: Severin Gehwolf Date: 2022-12-23 17:55:05 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ebc5e190ac7a3b0c143451105d9f9b7d9e780a4b From andrew at openjdk.org Fri Jun 13 20:11:23 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 20:11:23 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b07 for changeset 3393ce98 Message-ID: <7cc34340-a39f-4e5a-9467-3b9b2bc9866b@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-13 20:51:30 +0000 Added tag shenandoah8u362-b07 for changeset 3393ce98277 Changeset: 3393ce98 Author: Andrew John Hughes Date: 2025-06-13 19:13:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3393ce98277b6d7572541bf2c4efb29c7b94b46f From ysr at openjdk.org Fri Jun 13 20:52:28 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Fri, 13 Jun 2025 20:52:28 GMT Subject: RFR: 8359394: Shenandoah: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > We can remove `GCCause::_no_cause_specified` and need to add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are also missing `_shenandoah_humongous_allocation_failure` in the `SA` analog. Reviewed -- would be good to go from my standpoint after separating into a separate ticket as suggested by Aleksey the collapse of `no_cause_specified` into its putative synonym `_no_gc`. Approving in advance, subject to that change, and re-review by Aleksey. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GCCause.java line 42: > 40: > 41: _no_gc ("No GC"), > 42: _no_cause_specified ("Unknown GCCause"), I agree that "no cause specified" and "no gc" almost sound like synonyms, and any uses of one could be replaced with the other. However, with @shipilev , I agree that may be you split the changes to this kind of shared code into a separate ticket, in keeping with hotspot dev practices. ------------- Marked as reviewed by ysr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2926250505 PR Review Comment: https://git.openjdk.org/jdk/pull/25789#discussion_r2146013368 From andrew at openjdk.org Fri Jun 13 20:52:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 20:52:50 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u362-b08 ------------- Commit messages: - Merge jdk8u362-b08 - 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR - 8296239: ISO 4217 Amendment 174 Update - 8294307: ISO 4217 Amendment 173 Update - 8289549: ISO 4217 Amendment 172 Update - 8283277: ISO 4217 Amendment 171 Update - 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error - 8295687: Better BMP bounds - 8293742: Better Banking of Sounds - 8293734: Improve BMP image handling - ... and 7 more: https://git.openjdk.org/shenandoah-jdk8u/compare/3393ce98...e0ea7202 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=38&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=38&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/38/files Stats: 424 lines in 40 files changed: 193 ins; 108 del; 123 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/38.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/38/head:pull/38 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/38 From andrew at openjdk.org Fri Jun 13 20:52:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 20:52:50 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Fri, 13 Jun 2025 20:48:09 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b08 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/38#issuecomment-2971649174 From andrew at openjdk.org Fri Jun 13 21:12:55 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:12:55 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 17 new changesets Message-ID: Changeset: 259a33e4 Branch: master Author: Paul Hohensee Committer: Andrew John Hughes Date: 2023-01-13 03:18:49 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/259a33e4e11236f26ecebb4239771aafe59a0229 8285021: Improve CORBA communication Co-authored-by: Joshua Cao Reviewed-by: mbalao, bae, andrew ! corba/src/share/classes/com/sun/corba/se/impl/orbutil/ORBConstants.java ! corba/src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/Stub.java Changeset: 8d0c25d3 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2023-01-13 03:51:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8d0c25d3c43bd33173dc7f66fbc4f3bd3d55d341 8286496: Improve Thread labels Reviewed-by: andrew Backport-of: e733e55de88e63e129f15edefc602c050339b38a ! hotspot/src/share/vm/jfr/recorder/checkpoint/jfrCheckpointManager.cpp ! hotspot/src/share/vm/jfr/recorder/storage/jfrBuffer.cpp ! hotspot/src/share/vm/jfr/recorder/storage/jfrBuffer.hpp ! hotspot/src/share/vm/jfr/recorder/storage/jfrMemorySpace.hpp ! hotspot/src/share/vm/jfr/writers/jfrWriterHost.inline.hpp ! hotspot/src/share/vm/prims/jni.cpp ! hotspot/src/share/vm/utilities/macros.hpp Changeset: d2f3eda7 Branch: master Author: Yuri Nesterenko Committer: Andrew John Hughes Date: 2022-10-28 09:52:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d2f3eda788f83813284358a7dfcb6f8dbf6728e7 8288516: Enhance font creation Reviewed-by: mbalao, andrew Backport-of: 4c7b057380d7656c8c275b526d1918de6a625cc4 ! jdk/src/windows/native/sun/font/fontpath.c ! jdk/src/windows/native/sun/font/lcdglyph.c ! jdk/src/windows/native/sun/windows/awt_Font.cpp ! jdk/src/windows/native/sun/windows/awt_PrintJob.cpp Changeset: 0f2b98ef Branch: master Author: Alexei Voitylov Committer: Andrew John Hughes Date: 2022-12-07 11:55:43 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0f2b98efc8068abb65db3ce8c90209bbdf107662 8289350: Better media supports Reviewed-by: mbalao, andrew Backport-of: 8278c12ceff28681a8e8cde8dd49ee9a79eaf25e ! hotspot/src/os_cpu/aix_ppc/vm/os_aix_ppc.cpp ! hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! hotspot/src/os_cpu/linux_aarch64/vm/os_linux_aarch64.cpp ! hotspot/src/os_cpu/linux_ppc/vm/os_linux_ppc.cpp ! hotspot/src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! hotspot/src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! hotspot/src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp Changeset: c95512d5 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2022-10-07 23:30:07 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c95512d5029fd54ec7ef879438b2419325cd1c02 8293554: Enhanced DH Key Exchanges Reviewed-by: andrew Backport-of: ca126c9025ad975d9086d5f967d35a76425c13ca ! jdk/src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! jdk/src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! jdk/src/share/classes/sun/security/provider/ParameterCache.java ! jdk/src/share/classes/sun/security/ssl/PredefinedDHParameterSpecs.java ! jdk/src/share/classes/sun/security/util/SecurityProviderConstants.java Changeset: 8633abf2 Branch: master Author: Yuri Nesterenko Committer: Andrew John Hughes Date: 2022-11-01 13:35:47 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8633abf2635b0fe52f1549eaa2df3c104cce8cb5 8293598: Enhance InetAddress address handling Reviewed-by: mbalao, andrew Backport-of: a2668f58ccc3b7c7d74e2903128b08d97aac5798 ! jdk/src/share/classes/java/net/InetAddress.java ! jdk/src/share/classes/sun/net/util/IPAddressUtil.java Changeset: 26dd9f08 Branch: master Author: Yuri Nesterenko Committer: Andrew John Hughes Date: 2022-10-28 13:47:05 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/26dd9f0814af3abc608bff9143585eb8996a9e30 8293717: Objective view of ObjectView Reviewed-by: mbalao, andrew Backport-of: fb692840530fa07174f9ad5c9f77d593e503a155 ! jdk/src/share/classes/javax/swing/text/html/ObjectView.java Changeset: 4f5099ee Branch: master Author: Rui Li Committer: Andrew John Hughes Date: 2022-11-23 23:16:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4f5099ee2b9531288426deecea5eacca4b2d4959 8293734: Improve BMP image handling Reviewed-by: mbalao, andrew Backport-of: 40959ac32b81c333f04628be227107762b78a7da ! jdk/src/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java Changeset: 00dbe881 Branch: master Author: Alexei Voitylov Committer: Andrew John Hughes Date: 2022-11-24 20:39:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/00dbe881f5fb7b74c93762ddd06a33a716f786ce 8293742: Better Banking of Sounds Reviewed-by: mbalao, andrew Backport-of: f1de79f38fcff10ccaf232f79df0a94e84751ff7 ! jdk/src/share/classes/com/sun/media/sound/JARSoundbankReader.java Changeset: 36f0634c Branch: master Author: Alexei Voitylov Committer: Andrew John Hughes Date: 2022-11-24 12:57:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/36f0634c39f042b07075287a760baf2300ceac2b 8295687: Better BMP bounds Reviewed-by: mbalao, andrew Backport-of: 4df2fd2d1ca8ed73de6ac8b2f6a51ff93e3dac6d ! jdk/src/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java Changeset: 957b5f50 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2022-11-10 23:34:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/957b5f50d76117369ebfd67dddbeadb27685658a 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error Reviewed-by: andrew Backport-of: e94ca7d3fc9b5946d5b808f98e334529054c4f39 ! jdk/src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! jdk/src/share/classes/sun/security/provider/ParameterCache.java ! jdk/src/share/classes/sun/security/ssl/PredefinedDHParameterSpecs.java + jdk/src/share/classes/sun/security/util/SafeDHParameterSpec.java ! jdk/src/share/classes/sun/security/util/SecurityProviderConstants.java Changeset: 40ffc346 Branch: master Author: Dmitry Cherepanov Committer: Andrew John Hughes Date: 2023-01-05 07:48:45 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/40ffc346405827dff3684cf518aa0073a21b5805 8283277: ISO 4217 Amendment 171 Update Reviewed-by: phh, andrew Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6 ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/src/share/classes/sun/util/resources/CurrencyNames.properties ! jdk/test/java/util/Currency/ValidateISO4217.java ! jdk/test/java/util/Currency/tablea1.txt ! jdk/test/sun/text/resources/LocaleData ! jdk/test/sun/text/resources/LocaleDataTest.java Changeset: 7dd12ae0 Branch: master Author: Andrew John Hughes Date: 2023-01-10 02:47:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7dd12ae02fdcc373f6dfae3956e024b236ea007e 8289549: ISO 4217 Amendment 172 Update Reviewed-by: dcherepanov Backport-of: 03a5c254d36a51d478b3c1042f0fb6f2c7453dc6 ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/test/java/util/Currency/tablea1.txt Changeset: 6389fde8 Branch: master Author: Andrew John Hughes Date: 2023-01-10 04:30:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6389fde845f5e0c025ba60868fb90fd5a2c12b7a 8294307: ISO 4217 Amendment 173 Update Reviewed-by: dcherepanov Backport-of: e3eccbcbc2e27921c058d43b81fb113d10be2dab ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/test/java/util/Currency/tablea1.txt Changeset: 602d1d47 Branch: master Author: Andrew John Hughes Date: 2023-01-10 18:56:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/602d1d477625a8583a504216698a3dec1cb182e9 8296239: ISO 4217 Amendment 174 Update Reviewed-by: dcherepanov Backport-of: ff60b348813fd7e32bdda322f345f90311a60207 ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/test/java/util/Currency/ValidateISO4217.java ! jdk/test/java/util/Currency/tablea1.txt Changeset: 056d5a79 Branch: master Author: Andrew John Hughes Date: 2023-01-12 17:44:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/056d5a79994cbaa67f901f3d89f5c140d4aa6f11 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java Reviewed-by: dcherepanov, sgehwolf Backport-of: 80eecc50e663155f04dcec1797efb4be4b8ee7b2 ! jdk/src/share/classes/sun/util/resources/hr/CurrencyNames_hr_HR.properties ! jdk/test/java/text/Format/NumberFormat/CurrencySymbols.properties Changeset: e0ea7202 Branch: master Author: Andrew John Hughes Date: 2025-06-13 21:08:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e0ea72026ac1db9a8fea1595c9dcee15ee9da6ce Merge jdk8u362-b08 Added tag jdk8u362-b08 for changeset 056d5a79994 ! hotspot/src/share/vm/prims/jni.cpp ! hotspot/src/share/vm/utilities/macros.hpp ! hotspot/src/share/vm/prims/jni.cpp ! hotspot/src/share/vm/utilities/macros.hpp From andrew at openjdk.org Fri Jun 13 21:13:05 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:13:05 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b08 for changeset 056d5a79 Message-ID: <4529ae9e-3565-4046-8cbd-8c8e3a98dd48@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-01-13 06:02:14 +0000 Added tag jdk8u362-b08 for changeset 056d5a79994 Changeset: 056d5a79 Author: Andrew John Hughes Date: 2023-01-12 17:44:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/056d5a79994cbaa67f901f3d89f5c140d4aa6f11 From andrew at openjdk.org Fri Jun 13 21:13:09 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:13:09 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b08 for changeset e0ea7202 Message-ID: <573ba35e-a66a-40ad-8b1f-695a22aaf5b9@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-13 21:34:55 +0000 Added tag shenandoah8u362-b08 for changeset e0ea72026ac Changeset: e0ea7202 Author: Andrew John Hughes Date: 2025-06-13 21:08:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e0ea72026ac1db9a8fea1595c9dcee15ee9da6ce From andrew at openjdk.org Fri Jun 13 21:14:14 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:14:14 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u362-b08 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/38/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/38/files/e0ea7202..e0ea7202 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=38&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=38&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/38.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/38/head:pull/38 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/38 From iris at openjdk.org Fri Jun 13 21:14:14 2025 From: iris at openjdk.org (Iris Clark) Date: Fri, 13 Jun 2025 21:14:14 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Fri, 13 Jun 2025 20:48:09 GMT, Andrew John Hughes wrote: > Merge jdk8u362-b08 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/38 From andrew at openjdk.org Fri Jun 13 21:49:16 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:49:16 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 3 new changesets Message-ID: Changeset: dfd2fe8e Branch: master Author: Andrew John Hughes Date: 2023-01-16 19:34:47 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dfd2fe8ef599c609d5bfe95519728720b9b92539 8300178: JDK-8286496 causes build failure on older GCC Reviewed-by: sgehwolf ! hotspot/src/share/vm/jfr/writers/jfrWriterHost.inline.hpp Changeset: 36321be7 Branch: master Author: Simon Tooke Committer: Andrew John Hughes Date: 2023-01-16 19:41:13 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/36321be7840c8e044340b8c162a75dce3ae7698f 8300178: JDK-8288516 causes build failure on Windows + VS2010 Reviewed-by: andrew ! jdk/src/windows/native/sun/font/lcdglyph.c Changeset: dcc3a4b0 Branch: master Author: Andrew John Hughes Date: 2025-06-13 22:11:43 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dcc3a4b01216217394476fce4794c526f343505f Merge jdk8u362-b09 Added tag jdk8u362-b09 for changeset 36321be7840 From andrew at openjdk.org Fri Jun 13 21:49:25 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:49:25 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-b09 for changeset 36321be7 Message-ID: Tagged by: Andrew John Hughes Date: 2023-01-16 19:44:56 +0000 Added tag jdk8u362-b09 for changeset 36321be7840 Changeset: 36321be7 Author: Simon Tooke Committer: Andrew John Hughes Date: 2023-01-16 19:41:13 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/36321be7840c8e044340b8c162a75dce3ae7698f From andrew at openjdk.org Fri Jun 13 21:49:28 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:49:28 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-b09 for changeset dcc3a4b0 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-13 22:16:37 +0000 Added tag shenandoah8u362-b09 for changeset dcc3a4b0121 Changeset: dcc3a4b0 Author: Andrew John Hughes Date: 2025-06-13 22:11:43 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dcc3a4b01216217394476fce4794c526f343505f From andrew at openjdk.org Fri Jun 13 21:49:33 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:49:33 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u362-ga for changeset 36321be7 Message-ID: <35f9f391-735e-4b98-886c-e5c9c4282327@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-01-18 15:48:10 +0000 Added tag jdk8u362-ga for changeset 36321be7840 Changeset: 36321be7 Author: Simon Tooke Committer: Andrew John Hughes Date: 2023-01-16 19:41:13 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/36321be7840c8e044340b8c162a75dce3ae7698f From andrew at openjdk.org Fri Jun 13 21:49:39 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 13 Jun 2025 21:49:39 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u362-ga for changeset dcc3a4b0 Message-ID: <7d0e4723-ac48-477b-b22a-8f08089084cc@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-13 22:16:48 +0000 Added tag shenandoah8u362-ga for changeset dcc3a4b0121 Changeset: dcc3a4b0 Author: Andrew John Hughes Date: 2025-06-13 22:11:43 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dcc3a4b01216217394476fce4794c526f343505f From andrew at openjdk.org Sat Jun 14 00:26:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 00:26:03 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u372-b01 ------------- Commit messages: - Merge jdk8u372-b01 - 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error - 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual - 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails - 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java - 8196467: javax/swing/JInternalFrame/Test6325652.java fails - 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail - 8293767: AWT test TestSinhalaChar.java has old SCCS markings - 8301122: [8u] Fix unreliable vs2010 download link - ... and 68 more: https://git.openjdk.org/shenandoah-jdk8u/compare/dcc3a4b0...59178cdb The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=40&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=40&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/40/files Stats: 13987 lines in 151 files changed: 11034 ins; 2569 del; 384 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/40.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/40/head:pull/40 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/40 From andrew at openjdk.org Sat Jun 14 00:26:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 00:26:03 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: <8UIccZAdrgLL5RcPXVoSk6H9f_VlTkbaVevAGNGmZHA=.ff9ffa94-76a8-4bd9-b9de-7b9ab63d6352@github.com> On Sat, 14 Jun 2025 00:20:51 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b01 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/40#issuecomment-2972023991 From iris at openjdk.org Sat Jun 14 01:23:00 2025 From: iris at openjdk.org (Iris Clark) Date: Sat, 14 Jun 2025 01:23:00 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 14 Jun 2025 00:20:51 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/40 From andrew at openjdk.org Sat Jun 14 01:23:00 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 01:23:00 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u372-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/40/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/40/files/59178cdb..59178cdb Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=40&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=40&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/40.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/40/head:pull/40 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/40 From andrew at openjdk.org Sat Jun 14 01:26:46 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 01:26:46 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 78 new changesets Message-ID: Changeset: 3b1bbef3 Branch: master Author: Andrew John Hughes Date: 2022-11-30 14:54:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3b1bbef37be666017bd86b725e1e218dd11f5da6 8297739: Bump update version of OpenJDK: 8u372 Reviewed-by: sgehwolf ! .jcheck/conf ! common/autoconf/version-numbers Changeset: 7eb2803b Branch: master Author: Jonathan Dowland Date: 2022-11-30 20:08:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7eb2803b5b3c769827cf02cc40a15b13b74bf588 8230305: Cgroups v2: Container awareness 8216366: Add rationale to PER_CPU_SHARES define 8229202: Docker reporting causes secondary crashes in error handling 8232207: Linux os::available_memory re-reads cgroup configuration on every invocation 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes Implement Cgroups v2 container awareness in hotspot Reviewed-by: sgehwolf, andrew Backport-of: d462a6b5c9bd3dae5257cca42ea38c19cb742e3c + hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp + hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp + hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.cpp + hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.hpp + hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp + hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.hpp ! hotspot/src/os/linux/vm/osContainer_linux.cpp ! hotspot/src/os/linux/vm/osContainer_linux.hpp ! hotspot/src/os/linux/vm/os_linux.hpp ! hotspot/test/runtime/containers/docker/TestCPUAwareness.java Changeset: e9acfceb Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-12-01 10:24:58 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e9acfceb354b49a00388a46f7f3172b2d90f0680 8295322: Tests for JDK-8271459 were not backported to 11u Reviewed-by: phh Backport-of: 70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015 + hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java Changeset: 7b548500 Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-12-01 10:25:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7b5485004616b596e38f1205be76b91aa426ef65 8297329: [8u] hotspot needs to recognise VS2019 Reviewed-by: phh ! hotspot/make/windows/makefiles/compile.make ! hotspot/make/windows/makefiles/sanity.make ! hotspot/make/windows/makefiles/vm.make Changeset: 918a2ab7 Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-12-01 10:43:27 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/918a2ab7c505aa5b22b26558b92ef4d7d6d6aeb9 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873 Backport-of: 7166e13838a545b1e75307defc2cfa173dc38d20 ! jdk/src/windows/native/sun/windows/awt_DCHolder.cpp ! jdk/src/windows/native/sun/windows/awt_DnDDT.cpp ! jdk/src/windows/native/sun/windows/awt_ole.h Changeset: 1ec79849 Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-12-01 11:00:09 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1ec79849c25aed9fa7f71c6316da62d1441abbaa 8242468: VS2019 build missing vcruntime140_1.dll Reviewed-by: phh Backport-of: 2548ed31aeb255a61644885c501667a74f90ebc7 ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain_windows.m4 ! jdk/make/CopyFiles.gmk ! jdk/make/lib/CoreLibraries.gmk ! jdk/src/windows/bin/java_md.c ! make/devkit/createWindowsDevkit2019.sh Changeset: fcd3c9ce Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-12-01 13:16:30 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/fcd3c9ce6b503e63f2a898467d65893a7c703734 8247676: vcruntime140_1.dll is not needed on 32-bit Windows Reviewed-by: phh Backport-of: 78ba1e5a5f69909ddf073cb014784127b09dd47d ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 8356d04a Branch: master Author: Roman Marchenko Committer: Andrew Brygin Date: 2022-12-01 15:25:12 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8356d04acbbb3c31c4baea034fce2f7bc0691847 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process Reviewed-by: dcherepanov ! jdk/test/sun/security/tools/keytool/WeakAlg.java Changeset: 77403ed2 Branch: master Author: Victor Rudometov Committer: Paul Hohensee Date: 2022-12-01 18:03:20 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/77403ed2500d1560ca71e5db1dbe49401697f7f7 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Backport-of: 7964440dd3274b84713c0debe1846092bb6d6d68 + jdk/test/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java Changeset: 55101454 Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-12-02 08:19:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5510145420117f1f3c4a933021c3675cd2a99051 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails Backport-of: 038f58d4f0782f885547d2b052a47fdf2229cfe3 ! hotspot/src/share/vm/memory/metaspace.cpp Changeset: c9007cd4 Branch: master Author: Jonathan Dowland Date: 2022-12-05 04:14:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c9007cd44db764fbd791218c6f38491f38af70c2 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy 8275713: TestDockerMemoryMetrics test fails on recent runc 8228585: jdk/internal/platform/cgroup/TestCgroupMetrics.java - NumberFormatException because of large long values (memory limit_in_bytes) Reviewed-by: sgehwolf, andrew Backport-of: 4def210a22faaec6b47912dd314e6365ea48d28f ! jdk/make/lib/CoreLibraries.gmk ! jdk/make/mapfiles/libjava/mapfile-linux + jdk/src/linux/classes/jdk/internal/platform/CgroupInfo.java + jdk/src/linux/classes/jdk/internal/platform/CgroupMetrics.java + jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystem.java + jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemController.java + jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java + jdk/src/linux/classes/jdk/internal/platform/CgroupUtil.java + jdk/src/linux/classes/jdk/internal/platform/CgroupV1Metrics.java + jdk/src/linux/classes/jdk/internal/platform/CgroupV1MetricsImpl.java + jdk/src/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1MemorySubSystemController.java + jdk/src/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java + jdk/src/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1SubsystemController.java - jdk/src/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java - jdk/src/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java + jdk/src/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java + jdk/src/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2SubsystemController.java + jdk/src/linux/native/jdk/internal/platform/cgroupv1/CgroupMetrics.c - jdk/src/linux/native/jdk/internal/platform/cgroupv1/Metrics.c ! jdk/src/share/classes/jdk/internal/platform/Metrics.java ! jdk/src/share/classes/sun/launcher/LauncherHelper.java ! jdk/src/solaris/classes/sun/management/OperatingSystemImpl.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupMetrics.java + jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemController.java ! jdk/test/jdk/internal/platform/docker/MetricsCpuTester.java ! jdk/test/jdk/internal/platform/docker/MetricsMemoryTester.java ! jdk/test/jdk/internal/platform/docker/TestDockerCpuMetrics.java ! jdk/test/jdk/internal/platform/docker/TestDockerMemoryMetrics.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/CPUSetsReader.java + jdk/test/lib/jdk/test/lib/containers/cgroup/CgroupMetricsTester.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java + jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java + jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java Changeset: 21a12369 Branch: master Author: Ao Qi Committer: Severin Gehwolf Date: 2022-12-05 13:51:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/21a123695dc17bd7618e9059ec9453bdec5318b0 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Backport-of: b6ea69c06aca7f013e26596cebd039960c5b4d34 ! jdk/test/java/security/cert/pkix/policyChanges/TestPolicy.java Changeset: 4388fa8e Branch: master Author: Ao Qi Committer: Severin Gehwolf Date: 2022-12-05 13:53:20 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4388fa8e9d00248dce0e1af7fa90e55eb74b43d6 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Reviewed-by: phh Backport-of: 520db1eeb18797c782ddfad90467e19bbdd424ac ! jdk/test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java Changeset: a983a003 Branch: master Author: Joshua Cao Committer: Paul Hohensee Date: 2022-12-05 18:22:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a983a003976a98ca4d2041b2550d789792b71801 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows Reviewed-by: phh Backport-of: f56396f1689ea7e13dea78dcb1d14dcce94da898 ! jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java Changeset: 72269ee9 Branch: master Author: Victor Rudometov Committer: Paul Hohensee Date: 2022-12-05 18:45:15 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/72269ee95f2aaea02bf818b4e84cecc5ad23be38 8296632: Write a test to verify the content change of TextArea sends TextEvent Backport-of: 14592778b19af792f7394be381c3e23bf216372d + jdk/test/java/awt/event/ComponentEvent/TextAreaTextEventTest.java Changeset: 2abc2062 Branch: master Author: Ben Taylor Committer: Paul Hohensee Date: 2022-12-05 23:16:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2abc2062b6706d7cdd01a9d95c46de3a63e9c763 8257620: Do not use objc_msgSend_stret to get macOS version Reviewed-by: akozlov, phh, omikhaltcova Backport-of: d4c7db5060978302382549246f9ad6831f19377d ! jdk/src/solaris/native/java/lang/java_props_macosx.c Changeset: d13b8131 Branch: master Author: Sergey Bylokhov Date: 2022-12-06 03:29:04 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d13b8131bf6612de0a83d6e4721d554a74c2f664 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox Backport-of: ebfa27b9f06aee8ceceabc564a78a351903ce9a1 ! jdk/src/macosx/classes/sun/lwawt/macosx/CAccessibleText.java Changeset: da681cf9 Branch: master Author: Sergey Bylokhov Date: 2022-12-06 03:36:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/da681cf9103486eb33319349fa800e79241aea44 8296496: Overzealous check in sizecalc.h prevents large memory allocation Backport-of: 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ! jdk/src/share/native/common/sizecalc.h Changeset: 2ad48cb3 Branch: master Author: Jonathan Dowland Date: 2022-12-06 05:29:01 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2ad48cb3ca0e79346d74dccb5c172a7f017c5c6d 8294767: 8u contains two copies of test/../FileUtils.java, one uses JDK9+ features Reviewed-by: sgehwolf, andrew - jdk/test/lib/jdk/test/lib/util/FileUtils.java Changeset: 3f44b9bf Branch: master Author: Sergey Bylokhov Date: 2022-12-06 05:44:47 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3f44b9bfdd447c3cca889631e529ab57a1310e95 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Backport-of: fb6c992f325981c42c7f75109a6c9db7ca8715d8 ! jdk/src/share/native/common/sizecalc.h Changeset: 40e7b68f Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-12-06 17:55:49 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/40e7b68f2ed4bcba5c270856eadc15720a9d354e 8295952: Problemlist existing compiler/rtm tests also on x86 Reviewed-by: sgehwolf Backport-of: 3f2f128af6ec2f9097af7758bfd41aeaa4354d40 ! hotspot/test/ProblemList.txt Changeset: 633acfab Branch: master Author: Jonathan Dowland Date: 2022-12-07 02:10:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/633acfabf29e73b9f9cffedd2604c6fa652b9ebe 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option. This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well. Reviewed-by: andrew Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc ! hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp ! jdk/src/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java Changeset: 97d00caf Branch: master Author: Severin Gehwolf Date: 2022-12-07 15:03:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/97d00caf3d79f534da431d373dfbae8e93f735cd 8253727: [cgroups v2] Memory and swap limits reported incorrectly Account for interface files for swap and memory being reported independently. The cgroup v1-like value is now reported by adding the memory.max value to the memory.swap.max value, and memory.current and memory.swap.current respectively. Reviewed-by: andrew Backport-of: 3e96721cd9d1e1f46711e70dfc22064bab212b64 ! hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp ! jdk/src/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java Changeset: 362cf762 Branch: master Author: Jonathan Dowland Date: 2022-12-08 20:20:54 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/362cf7628b73f4112bee464cea52a8a29e6671ce 8237479: 8230305 causes slowdebug build failure Declare methods as pure virtual. Reviewed-by: sgehwolf, andrew Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76 ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp Changeset: c84a5b28 Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-12-12 09:42:32 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c84a5b2857aacff54ad0bf31d4bdd3747451d92f 8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u Reviewed-by: sgehwolf ! .github/workflows/submit.yml Changeset: 989d68f1 Branch: master Author: Jonathan Dowland Date: 2022-12-12 14:09:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/989d68f1e1d046829d0b19aadb3453febd0566db 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Return NULL subsystem if no cgroup controllers are mounted. Reviewed-by: sgehwolf Backport-of: add18914fb1294999877b563c734a25b4c17b922 ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp ! hotspot/src/share/vm/prims/whitebox.cpp ! hotspot/src/share/vm/prims/whitebox.hpp + hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java ! hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java ! hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 4ab80ff5 Branch: master Author: Jonathan Dowland Date: 2022-12-12 20:07:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4ab80ff59d51d15432ea2378ae8138d10dccd934 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java When the kernel doesn't support swap limits, expect host values instead. Reviewed-by: sgehwolf Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e ! hotspot/test/runtime/containers/docker/CheckOperatingSystemMXBean.java Changeset: 9cd39a40 Branch: master Author: Jonathan Dowland Date: 2022-12-13 11:11:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9cd39a4018c2126f4cccde07be9482c7a03ce663 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111 Reviewed-by: sgehwolf Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa ! jdk/test/jdk/internal/platform/docker/MetricsCpuTester.java ! jdk/test/jdk/internal/platform/docker/MetricsMemoryTester.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/CgroupMetricsTester.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java Changeset: a318e006 Branch: master Author: Ao Qi Committer: Severin Gehwolf Date: 2022-12-13 14:51:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a318e0067c7bceae124c39794400685b956e37d2 8072770: [TESTBUG] Some Introspector tests fail with a Java heap bigger than 4GB Backport-of: 137f13474383d72a0d2e392bc2f8926ad69d3da6 ! jdk/test/java/beans/Introspector/7064279/Test7064279.java ! jdk/test/java/beans/Introspector/Test7172865.java ! jdk/test/java/beans/Introspector/Test7195106.java Changeset: b0826174 Branch: master Author: Jonathan Dowland Date: 2022-12-13 15:45:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b0826174b78d2acf758b1df8c3233a4885eb1715 8239559: Cgroups: Incorrect detection logic on some systems Adjust heuristic with cgroup mounts according to mountinfo Reviewed-by: sgehwolf Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a ! jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java + jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java ! jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java Changeset: c7599bd2 Branch: master Author: Jonathan Dowland Date: 2022-12-13 19:30:15 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c7599bd217bf4ba638456d9c58c69b33b405199b 8197408: Bad pointer comparison and small cleanup in os_linux.cpp Reviewed-by: sgehwolf Backport-of: 5287d9a366791793b644d765ece783496b011119 ! hotspot/src/os/linux/vm/os_linux.cpp + hotspot/test/runtime/containers/cgroup/PlainRead.java Changeset: 537ff942 Branch: master Author: Leslie Zhai Committer: Severin Gehwolf Date: 2022-12-14 10:05:07 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/537ff942252e33831446d285800e5765a84bc19c 8196196: Headful tests should not be run in headless mode Reviewed-by: sgehwolf Backport-of: 7578044e7107c1914d85894cef5eb712c223252a ! jdk/test/java/awt/FileDialog/FileDialogMemoryLeak/FileDialogLeakTest.java ! jdk/test/java/awt/Gtk/GtkVersionTest/GtkVersionTest.java ! jdk/test/java/awt/JAWT/JAWT.sh ! jdk/test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java ! jdk/test/java/awt/Toolkit/DesktopProperties/rfe4758438.java ! jdk/test/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java ! jdk/test/java/awt/print/PrinterJob/PrintCrashTest.java ! jdk/test/javax/swing/GroupLayout/7071166/bug7071166.java ! jdk/test/javax/swing/JComboBox/6632953/bug6632953.java ! jdk/test/javax/swing/JComboBox/7082443/bug7082443.java ! jdk/test/javax/swing/JFileChooser/6489130/bug6489130.java ! jdk/test/javax/swing/JFileChooser/8080628/bug8080628.java ! jdk/test/javax/swing/Security/6657138/bug6657138.java ! jdk/test/javax/swing/plaf/metal/MetalUtils/bug6190373.java Changeset: 5b01ebb6 Branch: master Author: Jonathan Dowland Date: 2022-12-15 09:56:25 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5b01ebb6aaaa36cc54f14a260dec5a68077aa9e8 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 Reviewed-by: sgehwolf Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp ! hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp Changeset: d9db01cc Branch: master Author: Jonathan Dowland Date: 2022-12-15 10:54:24 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d9db01ccc6253429b62aff71dea54be38be121c5 8252359: HotSpot Not Identifying it is Running in a Container Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1 ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp ! hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java Changeset: 2bee6454 Branch: master Author: Jonathan Dowland Date: 2022-12-15 13:46:36 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2bee6454e81edc18c66f28504dd5502adedf24ab 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist Reviewed-by: sgehwolf Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9 ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp ! hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java Changeset: d2df91dc Branch: master Author: Jonathan Dowland Date: 2022-12-15 14:58:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d2df91dc5cbb83052c9e9f1a1460abf1c9900423 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) Reviewed-by: sgehwolf Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp ! hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java ! jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: 4dfc7421 Branch: master Author: Jonathan Dowland Date: 2022-12-15 18:01:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4dfc7421e8b934f503837659396e21cb4e29e694 8253939: [TESTBUG] Increase coverage of the cgroups detection code Reviewed-by: sgehwolf Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb ! hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: b2619cf5 Branch: master Author: Jonathan Dowland Date: 2022-12-15 18:22:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b2619cf5338fcc536aaa161e44f352e3578513ea 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems Backport-of: 669361117d30c9904813b6f728714f8d6abe8484 ! jdk/src/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java ! jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java Changeset: 1b04ffe9 Branch: master Author: Jonathan Dowland Date: 2022-12-16 10:07:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1b04ffe97c7be3bdcd506e1f69c3eaf4fdd029d0 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection Reviewed-by: sgehwolf Backport-of: a50725db2ab621e1a17cb5505f78e4bc73972a27 ! jdk/src/linux/classes/jdk/internal/platform/CgroupInfo.java ! jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java ! jdk/src/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java ! jdk/src/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: d7b14be2 Branch: master Author: Jonathan Dowland Date: 2022-12-16 10:44:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d7b14be2b944d528679cdc447357dfda82fe3238 8262379: Add regression test for JDK-8257746 Reviewed-by: sgehwolf Backport-of: 4c9adce20d114a3df629fa8c72d88795039ae69a ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: d039c8de Branch: master Author: Jonathan Dowland Date: 2022-12-16 11:34:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d039c8de57bc9ed2263538189547082aee05e599 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u Reviewed-by: andrew Backport-of: 2f0f34ce4cbe0f51a1bcc3145eb4d7ade9287d5d ! hotspot/test/runtime/containers/cgroup/PlainRead.java Changeset: 0662db27 Branch: master Author: Jonathan Dowland Date: 2022-12-16 14:30:24 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0662db27bf72d15b2fdd7ed21ea675d40531aef5 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for microseconds, which is read verbatim. Similarly for cgroups v2 all units in 'cpu.max' are in microseconds. Backport-of: 5166094647f8bfae32ef4bbde2e40f68e073b595 ! hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.cpp ! hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp Changeset: 99ff02e4 Branch: master Author: Jonathan Dowland Date: 2022-12-16 16:57:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/99ff02e404778c69cc7c6d3bd532c0326202d91f 8266391: Replace use of reflection in jdk.internal.platform.Metrics Reviewed-by: sgehwolf Backport-of: 3544a9d0e4a071ad9c82aa17ab113e0101b4020b + jdk/src/linux/classes/jdk/internal/platform/SystemMetrics.java + jdk/src/macosx/classes/jdk/internal/platform/SystemMetrics.java ! jdk/src/share/classes/jdk/internal/platform/Metrics.java + jdk/src/unix/classes/jdk/internal/platform/SystemMetrics.java + jdk/src/windows/classes/jdk/internal/platform/SystemMetrics.java Changeset: d6101df2 Branch: master Author: Paul Hohensee Date: 2022-12-18 16:43:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d6101df29c7069326d26628f131f0ef8882ad68b 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards Reviewed-by: andrew Backport-of: a777e82cd81fb5f02b09c4917b2a44f94c603939 ! jdk/src/share/classes/com/sun/crypto/provider/DESKeyFactory.java ! jdk/src/share/classes/com/sun/crypto/provider/DESedeKeyFactory.java ! jdk/src/share/classes/com/sun/crypto/provider/DHKeyFactory.java ! jdk/src/share/classes/sun/security/ec/ECKeyFactory.java ! jdk/src/share/classes/sun/security/pkcs11/P11DHKeyFactory.java ! jdk/src/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java ! jdk/src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! jdk/src/share/classes/sun/security/pkcs11/P11KeyFactory.java ! jdk/src/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java ! jdk/src/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java ! jdk/src/share/classes/sun/security/provider/DSAKeyFactory.java ! jdk/src/share/classes/sun/security/rsa/RSAKeyFactory.java + jdk/test/java/security/KeyFactory/KeyFactoryGetKeySpecForInvalidSpec.java ! jdk/test/sun/security/rsa/TestKeyFactory.java ! jdk/test/sun/security/rsa/pss/TestPSSKeySupport.java Changeset: 9f76da9c Branch: master Author: Jonathan Dowland Date: 2022-12-19 09:20:32 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9f76da9cab5d58aeaaf52e99364616a1e96993bf 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem The actual native method in use is in CgroupsMetrics after JDK-8231111 Backport-of: 8482b376d6630649728929158233984b11d0e2f7 ! jdk/src/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java Changeset: 06546d78 Branch: master Author: Jonathan Dowland Date: 2022-12-19 11:12:23 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/06546d786ae8cc3e445044ef940cb713494a5a95 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124 Reviewed-by: sgehwolf Backport-of: 245e2f2da0302c9354255219248c2f6793947a6a ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: 78cdc41a Branch: master Author: Vyom Tewari Committer: Kumar Srinivasan Date: 2022-12-19 15:46:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/78cdc41a2dcbe93ba594728bd5115c08be43686e 8234484: Add ability to configure third port for remote JMX Reviewed-by: ksrini Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758 ! jdk/src/share/classes/sun/management/AgentConfigurationError.java ! jdk/src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java ! jdk/src/share/lib/management/management.properties Changeset: b4ef3d33 Branch: master Author: Jonathan Dowland Date: 2022-12-19 16:30:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b4ef3d338a67baae34933c76aaea94fb0a12b631 8292083: Detected container memory limit may exceed physical machine memory Reviewed-by: sgehwolf Backport-of: f694f8a7671002559e7d23fdb65d5e9c768f9c03 ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp ! hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.cpp ! hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.hpp ! hotspot/src/os/linux/vm/osContainer_linux.cpp ! hotspot/src/os/linux/vm/os_linux.cpp ! hotspot/src/os/linux/vm/os_linux.hpp ! hotspot/test/runtime/containers/docker/TestMemoryAwareness.java Changeset: b4a745d2 Branch: master Author: Kurashige Taizo Committer: Severin Gehwolf Date: 2022-12-23 09:46:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b4a745d2f8b7ba78c51b4a4ec837cd636a93fa51 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist Backport-of: 444a0d98ac06ab043e3b11281234fd515abff302 ! jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java Changeset: 47090d6f Branch: master Author: Alexey Pavlyutkin Committer: Yuri Nesterenko Date: 2022-12-23 13:15:25 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/47090d6f9572adec1f31260702ff0039a7a70ee4 8297996: [8u] generated images are broken due to renaming of MSVC runtime DLL's Reviewed-by: phh ! common/autoconf/basics_windows.m4 ! common/autoconf/generated-configure.sh ! jdk/make/Images.gmk Changeset: c5751e60 Branch: master Author: Dan Lutker Committer: Paul Hohensee Date: 2022-12-27 20:28:27 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c5751e60a8f2a9e5f959b1fbc7fb2d91cd20ece4 8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 Reviewed-by: phh Backport-of: a41b9a71acdf69b78104677a1ca899ff36293a60 ! hotspot/test/runtime/containers/docker/TestMemoryAwareness.java ! hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerRunOptions.java ! hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerTestUtils.java Changeset: 7ad517dd Branch: master Author: Dmitry Cherepanov Date: 2023-01-05 07:48:45 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7ad517dd8fdc142827062876da334f53ceb65749 8283277: ISO 4217 Amendment 171 Update Reviewed-by: phh, andrew Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6 ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/src/share/classes/sun/util/resources/CurrencyNames.properties ! jdk/test/java/util/Currency/ValidateISO4217.java ! jdk/test/java/util/Currency/tablea1.txt ! jdk/test/sun/text/resources/LocaleData ! jdk/test/sun/text/resources/LocaleDataTest.java Changeset: 0f698dae Branch: master Author: Zdenek Zambersky Committer: Paul Hohensee Date: 2023-01-09 16:14:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0f698dae3bfee354de3c9bea32f881b4d7d5c73e 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u Reviewed-by: phh ! hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java Changeset: 65fcf619 Branch: master Author: Jonathan Dowland Date: 2023-01-09 20:36:07 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/65fcf61916526f929c1cc2c1d2971451676fc9e9 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present Reviewed-by: sgehwolf Backport-of: 8f3bbe950fb5a3d9f6cae122209df01df0f342f0 ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp ! hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java ! hotspot/test/runtime/containers/docker/TestCPUAwareness.java ! hotspot/test/runtime/containers/docker/TestMemoryAwareness.java Changeset: ca685797 Branch: master Author: Andrew John Hughes Date: 2023-01-10 02:47:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ca6857979dbc90b9f9ecbbea6b55727bc4540a97 8289549: ISO 4217 Amendment 172 Update Reviewed-by: dcherepanov Backport-of: 03a5c254d36a51d478b3c1042f0fb6f2c7453dc6 ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/test/java/util/Currency/tablea1.txt Changeset: 7c51dae1 Branch: master Author: Andrew John Hughes Date: 2023-01-10 04:30:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7c51dae174c4df694b3d9cb072f03ea455066bfd 8294307: ISO 4217 Amendment 173 Update Reviewed-by: dcherepanov Backport-of: e3eccbcbc2e27921c058d43b81fb113d10be2dab ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/test/java/util/Currency/tablea1.txt Changeset: 1694a3aa Branch: master Author: Andrew John Hughes Date: 2023-01-10 18:56:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1694a3aa8fd28739889cca0356e1ec4b4db4b8fb 8296239: ISO 4217 Amendment 174 Update Reviewed-by: dcherepanov Backport-of: ff60b348813fd7e32bdda322f345f90311a60207 ! jdk/src/share/classes/java/util/CurrencyData.properties ! jdk/test/java/util/Currency/ValidateISO4217.java ! jdk/test/java/util/Currency/tablea1.txt Changeset: 5a3fc18e Branch: master Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2023-01-11 13:09:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5a3fc18e92f3b34ad604b4cb269c08a96c021560 8299804: Fix non-portable code in hotspot shell tests in 8u Reviewed-by: phh, sgehwolf ! hotspot/test/compiler/criticalnatives/argumentcorruption/Test8167409.sh ! hotspot/test/compiler/floatingpoint/8165673/TestFloatJNIArgs.sh ! hotspot/test/compiler/floatingpoint/8207838/TestFloatSyncJNIArgs.sh ! hotspot/test/runtime/7107135/Test7107135.sh ! hotspot/test/runtime/jni/CallWithJNIWeak/test.sh ! hotspot/test/runtime/jni/ReturnJNIWeak/test.sh Changeset: 9d954b9f Branch: master Author: Severin Gehwolf Date: 2023-01-11 17:32:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9d954b9ff20185366d394c0971b01fbea70c745f 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Reviewed-by: andrew Backport-of: ac6be165196457a26d837760b5f5030fe010d633 ! hotspot/test/runtime/containers/docker/TestMemoryAwareness.java Changeset: a5c3ebe6 Branch: master Author: Andrew John Hughes Date: 2023-01-12 17:44:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a5c3ebe614d5d1595098bb402ae94e6ba5265171 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java Reviewed-by: dcherepanov, sgehwolf Backport-of: 80eecc50e663155f04dcec1797efb4be4b8ee7b2 ! jdk/src/share/classes/sun/util/resources/hr/CurrencyNames_hr_HR.properties ! jdk/test/java/text/Format/NumberFormat/CurrencySymbols.properties Changeset: 014f21f0 Branch: master Author: Leslie Zhai Committer: Paul Hohensee Date: 2023-01-17 15:40:08 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/014f21f0232b135c978774b8f256edad035ada00 8203485: [freetype] text rotated on 180 degrees is too narrow Reviewed-by: serb Backport-of: db67279f08b2db148958a4faafd19a0d50ff8742 ! jdk/src/share/native/sun/font/freetypeScaler.c + jdk/test/java/awt/font/Rotate/RotatedTextTest.java Changeset: ddb9a5c4 Branch: master Author: Andrew John Hughes Date: 2023-01-18 15:46:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ddb9a5c4625839bdc985ed8d84d216626ef6db55 Merge Changeset: da57ed1b Branch: master Author: Andrew John Hughes Date: 2023-01-18 17:38:39 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/da57ed1b0d541803b5e4c0237449b86c9c26e342 Merge Changeset: a318e48e Branch: master Author: Sergey Bylokhov Date: 2023-01-18 18:31:25 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a318e48e205acd2e15c50afb9c70c4106ed72463 8300014: Some backports placed the tests in the wrong location Reviewed-by: sgehwolf, phh = jdk/test/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java - jdk/test/jdk/java/awt/font/Rotate/RotatedItalicsTest.java Changeset: 55254644 Branch: master Author: Roman Marchenko Committer: Paul Hohensee Date: 2023-01-19 12:55:41 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/55254644f78cc8c67cf6b8bc46cf10676da5fe5e 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled Reviewed-by: yan, andrew Backport-of: a95ee5ada230a0177517efd3a417f319066169dd ! jdk/src/share/classes/sun/security/ssl/Utilities.java ! jdk/src/share/classes/sun/security/ssl/X509TrustManagerImpl.java + jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java + jdk/test/javax/net/ssl/templates/SSLExampleCert.java Changeset: 8d2f7e0c Branch: master Author: Jonathan Dowland Date: 2023-01-19 14:34:12 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8d2f7e0ccb2bf6c3d5bccb35aef39236e5c157d3 8292541: [Metrics] Reported memory limit may exceed physical machine memory 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems Reviewed-by: sgehwolf Backport-of: 9a0d1e7ce86368cdcade713a9e220604f7d77ecf ! hotspot/test/runtime/containers/docker/TestMemoryAwareness.java ! jdk/make/mapfiles/libjava/mapfile-linux ! jdk/src/linux/classes/jdk/internal/platform/CgroupMetrics.java ! jdk/src/linux/native/jdk/internal/platform/cgroupv1/CgroupMetrics.c Changeset: 75fd39f0 Branch: master Author: Roman Marchenko Committer: Paul Hohensee Date: 2023-01-19 15:41:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/75fd39f05e4c090192a5eca1fbdf2b6d1993fc4a 8282398: EndingDotHostname.java test fails because SSL cert expired Reviewed-by: yan, andrew Backport-of: afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e ! jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java ! jdk/test/javax/net/ssl/templates/SSLExampleCert.java Changeset: a5bd9018 Branch: master Author: Jonathan Dowland Date: 2023-01-24 10:41:06 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a5bd9018d5671f2399272b680e83239154443b11 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Reviewed-by: sgehwolf Backport-of: 6d83482a6b5f1898514fd450d8143dbfef57e362 ! hotspot/test/runtime/containers/docker/TestMemoryAwareness.java ! jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java + jdk/test/jdk/internal/platform/docker/TestDockerBasic.java ! jdk/test/jdk/internal/platform/docker/TestDockerCpuMetrics.java ! jdk/test/jdk/internal/platform/docker/TestDockerMemoryMetrics.java Changeset: d0cbcc51 Branch: master Author: Zdenek Zambersky Date: 2023-01-27 14:02:27 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d0cbcc5101f166b0469b889ef6f05b2925f0760c 8301122: [8u] Fix unreliable vs2010 download link Reviewed-by: phh ! make/conf/test-dependencies Changeset: 8192d03b Branch: master Author: Sergey Bylokhov Date: 2023-01-27 19:37:09 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8192d03b0fad34f745addde9408f4aa301dbebef 8293767: AWT test TestSinhalaChar.java has old SCCS markings Backport-of: 141d5f5deec488531e410af875c781f4b70490da ! jdk/test/java/awt/font/TextLayout/TestSinhalaChar.java Changeset: c3c871ee Branch: master Author: Sergey Bylokhov Date: 2023-01-27 19:41:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c3c871eeb1767ad68c26cdf4473cf354149b492a 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail Backport-of: a222aedf0fa1961e902db35cbe4145623c6af999 ! jdk/test/javax/swing/JMenuItem/8152981/MenuItemIconTest.java Changeset: 5274069b Branch: master Author: Sergey Bylokhov Date: 2023-01-27 19:48:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5274069b5258c91cf258f3554a6c131775ec99c6 8196467: javax/swing/JInternalFrame/Test6325652.java fails Backport-of: be762d7ac85910bffd7fd8e91e04d81961c35966 ! jdk/test/javax/swing/JInternalFrame/Test6325652.java Changeset: 92c9aed6 Branch: master Author: Sergey Bylokhov Date: 2023-01-27 20:09:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/92c9aed66cde03c3b4f3188b2ec64ea531316bbd 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java Backport-of: cd8cd68e09370fbf0c3509deaee381417dd12533 ! jdk/test/javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java Changeset: 85050ef8 Branch: master Author: Sergey Bylokhov Date: 2023-01-27 20:13:10 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/85050ef8db4209158e6bb37628eae326dbdcac20 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails Backport-of: 22b7295e75d3bc7ba2c2cd7b871bb2bb5bf290eb ! jdk/test/sun/java2d/OpenGL/CopyAreaOOB.java Changeset: dd8dd7b2 Branch: master Author: Sergey Bylokhov Date: 2023-01-27 20:17:10 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/dd8dd7b20846d18865cdfb3e26c15c8f153b1a09 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows Backport-of: b5769155b4bf453d65c43921dbcae4d115f17df7 ! jdk/test/sun/java2d/AcceleratedXORModeTest.java Changeset: 456d7aca Branch: master Author: Sergey Bylokhov Date: 2023-01-27 20:21:30 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/456d7aca8cc4ccc7fe9330bca92dda0b4ba0d8c0 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual Backport-of: 7cc3ba5f9b188e5dd298dbcde3934d08b6101032 ! jdk/test/java/awt/Desktop/OpenByUNCPathNameTest/OpenByUNCPathNameTest.java Changeset: f1426189 Branch: master Author: Sergey Bylokhov Date: 2023-01-27 20:25:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f14261896825ca5aa14099576a10183f4476508d 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error Backport-of: b0fddb9f8045cca10b4e757d8d187af7fb117405 ! jdk/test/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.java Changeset: 59178cdb Branch: master Author: Andrew John Hughes Date: 2025-06-13 22:52:13 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/59178cdb956843e650c5a3540cf96d52954ad44d Merge jdk8u372-b01 Added tag jdk8u372-b01 for changeset f14261896825ca5aa14099576a10183f4476508d ! .jcheck/conf ! hotspot/make/windows/makefiles/vm.make ! .jcheck/conf ! hotspot/make/windows/makefiles/vm.make From andrew at openjdk.org Sat Jun 14 01:27:07 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 01:27:07 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b01 for changeset f1426189 Message-ID: <24861529-fd1c-4209-a73b-45123ccf555c@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-01-30 14:31:06 +0000 Added tag jdk8u372-b01 for changeset f14261896825ca5aa14099576a10183f4476508d Changeset: f1426189 Author: Sergey Bylokhov Date: 2023-01-27 20:25:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f14261896825ca5aa14099576a10183f4476508d From andrew at openjdk.org Sat Jun 14 01:27:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 01:27:26 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b01 for changeset 59178cdb Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-14 01:17:44 +0000 Added tag shenandoah8u372-b01 for changeset 59178cdb956 Changeset: 59178cdb Author: Andrew John Hughes Date: 2025-06-13 22:52:13 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/59178cdb956843e650c5a3540cf96d52954ad44d From mdoerr at openjdk.org Sat Jun 14 11:10:38 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 14 Jun 2025 11:10:38 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: <0-Re4fyQGaSyOl-bYm1h9LT5a0TKKrgJCHquooXOIkQ=.d6044248-6188-4705-b564-90fa3d2d7762@github.com> On Fri, 13 Jun 2025 19:18:19 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > remove is_sigill_not_entrant Tests look good on our side. I'm only a bit concerned that the lock may become a bottleneck when many Java threads need to patch all nmethods. Especially with ZGC which does that more often. I think we should check performance. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25764#pullrequestreview-2928005394 From andrew at openjdk.org Sat Jun 14 15:30:48 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 15:30:48 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u372-b02 ------------- Commit messages: - Merge jdk8u372-b02 - 7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation - 8301550: [8u] Enable additional linux build testing in GitHub - 8177560: @headful key can be removed from the tests for JavaSound - 8280048: Missing comma in copyright header - 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos - 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete - 8301332: [8u] Fix writing of test files after the cgroups v2 backport - 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller - 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 - ... and 1 more: https://git.openjdk.org/shenandoah-jdk8u/compare/59178cdb...2efa0723 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/41/files Stats: 474 lines in 24 files changed: 229 ins; 108 del; 137 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/41.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/41/head:pull/41 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/41 From andrew at openjdk.org Sat Jun 14 15:30:48 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 14 Jun 2025 15:30:48 GMT Subject: RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 14 Jun 2025 15:26:24 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b02 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- PR Comment: https://git.openjdk.org/shenandoah-jdk8u/pull/41#issuecomment-2972832126 From andrew at openjdk.org Mon Jun 16 00:07:23 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 00:07:23 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 11 new changesets Message-ID: Changeset: ab678bc8 Branch: master Author: Nagata, Haruhito Committer: Paul Hohensee Date: 2023-01-30 03:19:03 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ab678bc8e8b2c55e01151d8349eb086dfcbc3e44 8283606: Tests may fail with zh locale on MacOS Reviewed-by: sgehwolf Backport-of: 7d545084f45af44386cb38172fd783f889a8c4e7 ! hotspot/test/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java ! langtools/test/tools/javadoc/6964914/TestStdDoclet.java ! langtools/test/tools/javadoc/6964914/TestUserDoclet.java ! langtools/test/tools/javah/T6893943.java Changeset: b057084f Branch: master Author: Takakuri Committer: Paul Hohensee Date: 2023-01-30 03:19:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b057084f8f44a6f81059ffa960304526c490aaad 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 Reviewed-by: phh, sgehwolf Backport-of: 32895ac60949ccceb0a3d25c73ec5e3a00c29593 ! jdk/test/ProblemList.txt Changeset: 36f6f17a Branch: master Author: Severin Gehwolf Date: 2023-01-30 15:59:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/36f6f17a9c2ad27a50159c2bf93b7e1fe067d3a8 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller Reviewed-by: phh, andrew Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f ! hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java ! jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: b4ee9f86 Branch: master Author: Severin Gehwolf Date: 2023-01-30 17:12:51 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b4ee9f86a159a3b1969b31e1e77f438b8833cc40 8301332: [8u] Fix writing of test files after the cgroups v2 backport Reviewed-by: andrew ! hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemController.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: 563f7b5d Branch: master Author: Severin Gehwolf Date: 2023-01-30 17:16:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/563f7b5df2f5758e009a38ae373dbd1084ec81b2 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9 ! hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp Changeset: 604e5829 Branch: master Author: Sergey Bylokhov Date: 2023-01-30 19:07:58 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/604e582943f1aa66cce34c2baa0f5516d2d69162 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos Backport-of: a5b42ec8b29249814dda28e751ee363869e98da0 ! jdk/test/javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java Changeset: 65b3bd91 Branch: master Author: Sergey Bylokhov Date: 2023-01-30 19:14:51 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/65b3bd9162c7cd03c7348b45c24e57c8f0087a10 8280048: Missing comma in copyright header Backport-of: 9a18190a4f8e31801d1442d97f247f074a3fd5c0 ! jdk/test/sun/java2d/OpenGL/CopyAreaOOB.java Changeset: 165ce6aa Branch: master Author: Sergey Bylokhov Date: 2023-01-30 19:18:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/165ce6aa0bab08e9fbad3ac2495295278d3cf5c6 8177560: @headful key can be removed from the tests for JavaSound Backport-of: 0b9c38fa6ec2a64d00d244cbe161feb29963ab11 ! jdk/test/javax/sound/midi/Devices/InitializationHang.java ! jdk/test/javax/sound/midi/Sequencer/SeqRecordDoesNotCopy.java ! jdk/test/javax/sound/midi/Sequencer/SeqRecordsRealTimeEvents.java ! jdk/test/javax/sound/midi/Sequencer/SeqStartRecording.java ! jdk/test/javax/sound/midi/Synthesizer/bug4685396.java ! jdk/test/javax/sound/sampled/Clip/ClipCloseLoss.java ! jdk/test/javax/sound/sampled/Clip/bug5070081.java ! jdk/test/javax/sound/sampled/DataLine/LongFramePosition.java ! jdk/test/javax/sound/sampled/DirectAudio/bug6372428.java Changeset: 57bc2093 Branch: master Author: Zdenek Zambersky Date: 2023-02-01 16:18:45 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/57bc2093d3a0fb1c257a0b45b1076a4b32349f74 8301550: [8u] Enable additional linux build testing in GitHub Reviewed-by: andrew ! .github/workflows/submit.yml Changeset: 784f71f2 Branch: master Author: Sergey Bylokhov Date: 2023-02-01 21:09:42 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/784f71f218bdb0e885a03fae35105d2fc96d56ec 7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation Backport-of: af802cb54114616dc74217ac91a65ecdb15d144f - jdk/test/java/awt/dnd/Button2DragTest/Button2DragTest.html ! jdk/test/java/awt/dnd/Button2DragTest/Button2DragTest.java Changeset: 2efa0723 Branch: master Author: Andrew John Hughes Date: 2025-06-14 02:20:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2efa0723a4ac734e530557ae49bd2eb031bb80b0 Merge jdk8u372-b02 Added tag jdk8u372-b02 for changeset 784f71f218b From andrew at openjdk.org Mon Jun 16 00:07:32 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 00:07:32 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b02 for changeset 784f71f2 Message-ID: <1b1a6e0d-108f-467c-a9d7-2dbe3fa386a4@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-02-06 15:44:08 +0000 Added tag jdk8u372-b02 for changeset 784f71f218b Changeset: 784f71f2 Author: Sergey Bylokhov Date: 2023-02-01 21:09:42 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/784f71f218bdb0e885a03fae35105d2fc96d56ec From andrew at openjdk.org Mon Jun 16 00:07:34 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 00:07:34 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b02 for changeset 2efa0723 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-14 16:24:59 +0000 Added tag shenandoah8u372-b02 for changeset 2efa0723a4a Changeset: 2efa0723 Author: Andrew John Hughes Date: 2025-06-14 02:20:28 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2efa0723a4ac734e530557ae49bd2eb031bb80b0 From andrew at openjdk.org Mon Jun 16 00:08:00 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 00:08:00 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u372-b02 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/41/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/41/files/2efa0723..2efa0723 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=41&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=41&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/41.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/41/head:pull/41 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/41 From iris at openjdk.org Mon Jun 16 00:08:00 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 16 Jun 2025 00:08:00 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 14 Jun 2025 15:26:24 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b02 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/41 From andrew at openjdk.org Mon Jun 16 00:56:44 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 00:56:44 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u372-b02 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u372-b03 - 8156581: Cleanup of ProblemList.txt - 8205959: Do not restart close if errno is EINTR - 8298027: Remove SCCS id's from awt jtreg tests - 8301620: [8u] some shell tests are passed but have unexpected operator errors - 8287109: Distrust.java failed with CertificateExpiredException The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/42/files Stats: 195 lines in 10 files changed: 21 ins; 158 del; 16 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/42.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/42/head:pull/42 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/42 From eosterlund at openjdk.org Mon Jun 16 00:59:31 2025 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Mon, 16 Jun 2025 00:59:31 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Fri, 13 Jun 2025 19:18:19 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > remove is_sigill_not_entrant Thanks for doing this! I have been wanting something like this for a while too and it looks great. I have some comments though... src/hotspot/share/gc/z/zBarrierSetNMethod.cpp line 109: > 107: } > 108: > 109: void ZBarrierSetNMethod::arm_with(nmethod* nm, int value) { I don't usually comment on names, but could we call this guard_with instead? We tried to stop saying "arm" about things used also for disarming and we have (hopefully) been consistent about calling that "guard" instead. src/hotspot/share/gc/z/zBarrierSetNMethod.cpp line 114: > 112: // Preserve the sticky bit > 113: if (is_not_entrant(nm)) { > 114: value |= not_entrant; Is it possible to have a race where another thread sets an nmethod to not entrant and the thread calling this making the nmethod entry barrier not entrant? If this was called to disarm a method and then enter it, it seems a bit sneaky in that case that we pass the nmethod entry barrier even though we under the lock see that it is not entrant. Probably okay but still feels like it might be more robust if the thread setting an nmethod to not entrant is always the one that arms the nmethod entry barrier. ------------- PR Review: https://git.openjdk.org/jdk/pull/25764#pullrequestreview-2930412450 PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2148888954 PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2148891702 From andrew at openjdk.org Mon Jun 16 01:14:22 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:14:22 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b03 for changeset 11a96a79 Message-ID: Tagged by: Andrew John Hughes Date: 2023-02-13 15:20:44 +0000 Added tag jdk8u372-b03 for changeset 11a96a7907a0e6692cbf056be6e7ad4dd83e3460 Changeset: 11a96a79 Author: Sergey Bylokhov Date: 2023-02-12 07:24:33 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/11a96a7907a0e6692cbf056be6e7ad4dd83e3460 From andrew at openjdk.org Mon Jun 16 01:14:25 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:14:25 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b03 for changeset e096f4f6 Message-ID: <7bed9480-bda4-4163-b560-c9de5eefe71f@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-16 01:51:11 +0000 Added tag shenandoah8u372-b03 for changeset e096f4f60bf Changeset: e096f4f6 Author: Andrew John Hughes Date: 2025-06-16 01:05:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e096f4f60bf66a3a26715e19cc3d1452fbf70cde From andrew at openjdk.org Mon Jun 16 01:14:13 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:14:13 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 6 new changesets Message-ID: <3c10d1f0-34c1-4b83-b79f-4fcec70bed60@openjdk.org> Changeset: 8c42e201 Branch: master Author: Ao Qi Committer: Severin Gehwolf Date: 2023-02-08 09:26:55 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8c42e201befb10a2600a20f3f00e88f687068325 8287109: Distrust.java failed with CertificateExpiredException Reviewed-by: sgehwolf Backport-of: 5b7d066ca5cb68e07a704d3ce13283761c1cf3ad ! jdk/test/sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java - jdk/test/sun/security/ssl/X509TrustManagerImpl/Symantec/appleistca2g1-chain.pem - jdk/test/sun/security/ssl/X509TrustManagerImpl/Symantec/geotrustglobalca-chain.pem Changeset: fbaabf36 Branch: master Author: Ao Qi Committer: Severin Gehwolf Date: 2023-02-08 09:27:46 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/fbaabf366e48edfd7e2749555544f6ea19f70b03 8301620: [8u] some shell tests are passed but have unexpected operator errors Reviewed-by: sgehwolf ! hotspot/test/runtime/6929067/Test6929067.sh ! hotspot/test/runtime/jsig/Test8017498.sh ! jdk/test/jdk/tools/launcher/JliLaunchTest.sh Changeset: b71f59bd Branch: master Author: Sergey Bylokhov Date: 2023-02-11 00:14:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b71f59bd6065c03e7b3a2de3ce6cde42641b1a9d 8298027: Remove SCCS id's from awt jtreg tests Reviewed-by: phh, andrew Backport-of: ba2d28e911f4f523334f98fd0186680acafb6f0a ! jdk/test/java/awt/font/TextLayout/TestOldHangul.java ! jdk/test/java/awt/font/TextLayout/TestTibetan.java Changeset: fd41600d Branch: master Author: Andrew John Hughes Date: 2023-02-11 14:48:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/fd41600df61d7dc835009cde9dd9b5f9567e09b1 8205959: Do not restart close if errno is EINTR Reviewed-by: serb Backport-of: 45c5c6fda477c04eca1c8fdf9bdff7eab0535751 ! jdk/src/solaris/native/java/net/linux_close.c Changeset: 11a96a79 Branch: master Author: Sergey Bylokhov Date: 2023-02-12 07:24:33 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/11a96a7907a0e6692cbf056be6e7ad4dd83e3460 8156581: Cleanup of ProblemList.txt 8156579: Two JavaBeans tests failed Reviewed-by: sgehwolf, andrew Backport-of: 65713ca08e5fde04a22b25314976ca364916d409 ! jdk/test/ProblemList.txt Changeset: e096f4f6 Branch: master Author: Andrew John Hughes Date: 2025-06-16 01:05:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e096f4f60bf66a3a26715e19cc3d1452fbf70cde Merge jdk8u372-b03 Added tag jdk8u372-b03 for changeset 11a96a7907a0e6692cbf056be6e7ad4dd83e3460 From andrew at openjdk.org Mon Jun 16 01:15:49 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:15:49 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u372-b02 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/42/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/42/files/e096f4f6..e096f4f6 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=42&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=42&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/42.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/42/head:pull/42 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/42 From iris at openjdk.org Mon Jun 16 01:15:49 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 16 Jun 2025 01:15:49 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 00:52:27 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b02 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/42 From andrew at openjdk.org Mon Jun 16 01:41:51 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:41:51 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u372-b04 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u372-b04 - 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked - 8301246: NPE in FcFontManager.getDefaultPlatformFont() on Linux without installed fontconfig - 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper - 8270317: Large Allocation in CipherSuite - 8301760: Fix possible leak in SpNegoContext dispose - 8287463: JFR: Disable TestDevNull.java on Windows - 8282947: JFR: Dump on shutdown live-locks in some conditions - 8142540: [TEST_BUG] Test sun/awt/dnd/8024061/bug8024061.java fails on ubuntu - 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing - ... and 3 more: https://git.openjdk.org/shenandoah-jdk8u/compare/e096f4f6...602e2d7a The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/43/files Stats: 739 lines in 16 files changed: 366 ins; 103 del; 270 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/43.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/43/head:pull/43 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/43 From andrew at openjdk.org Mon Jun 16 01:46:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:46:35 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 13 new changesets Message-ID: <06633710-aeae-4b3d-9c8f-c003d60ca61c@openjdk.org> Changeset: 89953562 Branch: master Author: Sergey Bylokhov Date: 2023-02-13 02:41:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/89953562e5bca442b30e8fbbe228697bcc7ad961 6734341: REGTEST fails: SelectionAutoscrollTest.html Reviewed-by: andrew Backport-of: 3dc3d0c3e52d91bb3a205e6f8c6b1e79d9aa1928 - jdk/test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.html ! jdk/test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.java Changeset: 3af19d3c Branch: master Author: Roman Marchenko Committer: Yuri Nesterenko Date: 2023-02-13 06:31:12 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3af19d3c08d952be63c2c80f5f18aaf5e278907f 8282511: Use fixed certificate validation date in SSLExampleCert template 8299445: EndingDotHostname.java fails because of compilation errors Reviewed-by: yan, andrew Backport-of: 268fa693188b685de6289927ee5a1e99473a50f6 ! jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java ! jdk/test/javax/net/ssl/templates/SSLExampleCert.java Changeset: 29a1b794 Branch: master Author: Sergey Bylokhov Date: 2023-02-13 08:13:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/29a1b794b80c1563fd1674b26f2f278ca382137a 7124238: [macosx] Font in BasicHTML document is bigger than it should be Reviewed-by: andrew Backport-of: 8ccf075f78b5645dd186d11637bd11d7e6938b86 + jdk/test/javax/swing/plaf/basic/BasicHTML/4960629/bug4960629.java Changeset: cbde7449 Branch: master Author: Sergey Bylokhov Date: 2023-02-13 08:30:26 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/cbde7449bd8f027f258b08fbfe786222fa3ed7fe 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing Reviewed-by: andrew Backport-of: 4940e2e8d85f2eef88c6132923b165253c13aa73 ! jdk/test/javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java Changeset: c183dc59 Branch: master Author: Sergey Bylokhov Date: 2023-02-13 08:36:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c183dc59f9027f7fb5253e68fa4ac8df57a9d267 8142540: [TEST_BUG] Test sun/awt/dnd/8024061/bug8024061.java fails on ubuntu Reviewed-by: andrew Backport-of: 84dd5699d5571e586b2763da34d2a76851695854 ! jdk/test/sun/awt/dnd/8024061/bug8024061.java Changeset: ec53e001 Branch: master Author: Ji?? Van?k Committer: Paul Hohensee Date: 2023-02-15 15:38:45 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ec53e00169fabf8f53ca4a5bdd4c92f7b1f10a00 8282947: JFR: Dump on shutdown live-locks in some conditions Reviewed-by: phh Backport-of: 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 ! jdk/src/share/classes/jdk/jfr/internal/ChunksChannel.java ! jdk/src/share/classes/jdk/jfr/internal/PlatformRecording.java + jdk/test/jdk/jfr/api/recording/dump/TestDumpDevNull.java Changeset: 71108a5c Branch: master Author: Ji?? Van?k Committer: Severin Gehwolf Date: 2023-02-15 17:14:01 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/71108a5c86ab709bb4f3fe1f7ad4f72a554b3830 8287463: JFR: Disable TestDevNull.java on Windows Reviewed-by: sgehwolf Backport-of: 0df4748216ab71937cfcfb86a2d66f3568bced1e ! jdk/test/jdk/jfr/api/recording/dump/TestDumpDevNull.java Changeset: 713c020d Branch: master Author: Yuri Nesterenko Date: 2023-02-16 06:38:22 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/713c020dc6d3e28a3d732aee5914f68bd5f67a11 8301760: Fix possible leak in SpNegoContext dispose Reviewed-by: phh Backport-of: 3f3356bcbd2b2fbc545263dc70a48ee931a4e56b ! jdk/src/share/classes/sun/security/jgss/spnego/SpNegoContext.java Changeset: aed31d98 Branch: master Author: Paul Hohensee Date: 2023-02-16 13:34:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/aed31d98c375742bb986e06e19b056cb049a2a38 8270317: Large Allocation in CipherSuite Reviewed-by: simonis, mbalao Backport-of: e627caec84c169c99c04e0d355c29b806a0266ed ! jdk/src/share/classes/sun/security/ssl/CipherSuite.java Changeset: b3e23801 Branch: master Author: Ji?? Van?k Committer: Paul Hohensee Date: 2023-02-16 15:01:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b3e2380183b33a3b1131ad7a5f118e876914f810 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper Reviewed-by: sgehwolf, phh ! jdk/test/jdk/jfr/event/sampling/TestNative.java + jdk/test/jdk/jfr/event/sampling/TestNative.sh Changeset: ca0a6be2 Branch: master Author: Alexander Scherbatiy Date: 2023-02-17 08:58:26 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ca0a6be2d76ce755ccfcce0d45a8943b11868067 8301246: NPE in FcFontManager.getDefaultPlatformFont() on Linux without installed fontconfig Reviewed-by: serb ! jdk/src/solaris/classes/sun/awt/FcFontManager.java Changeset: b51619d2 Branch: master Author: Alexey Bakhtin Date: 2023-02-17 11:26:58 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b51619d24e0643aa0afdba87ac20b371dbb594e8 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked Reviewed-by: phh Backport-of: 3be394e1606dd17c2c14ce806c796f5eb2b1ad6e ! jdk/src/share/classes/com/sun/jndi/ldap/LdapCtxFactory.java Changeset: 602e2d7a Branch: master Author: Andrew John Hughes Date: 2025-06-16 02:12:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/602e2d7acfcd4f976dcfb50a4a975d25a6dc198f Merge jdk8u372-b04 Added tag jdk8u372-b04 for changeset b51619d24e0 From andrew at openjdk.org Mon Jun 16 01:46:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:46:45 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u382-b00 for changeset b51619d2 Message-ID: <7cd9bf8d-da47-46be-b5ae-4485bf4620c1@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-03-01 16:07:57 +0000 Added tag jdk8u382-b00 for changeset b51619d24e0 Changeset: b51619d2 Author: Alexey Bakhtin Date: 2023-02-17 11:26:58 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b51619d24e0643aa0afdba87ac20b371dbb594e8 From andrew at openjdk.org Mon Jun 16 01:46:48 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:46:48 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u382-b00 for changeset 602e2d7a Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-16 02:36:22 +0000 Added tag shenandoah8u382-b00 for changeset 602e2d7acfc Changeset: 602e2d7a Author: Andrew John Hughes Date: 2025-06-16 02:12:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/602e2d7acfcd4f976dcfb50a4a975d25a6dc198f From andrew at openjdk.org Mon Jun 16 01:46:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:46:53 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b04 for changeset b51619d2 Message-ID: Tagged by: Andrew John Hughes Date: 2023-02-20 22:50:42 +0000 Added tag jdk8u372-b04 for changeset b51619d24e0 Changeset: b51619d2 Author: Alexey Bakhtin Date: 2023-02-17 11:26:58 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b51619d24e0643aa0afdba87ac20b371dbb594e8 From andrew at openjdk.org Mon Jun 16 01:47:00 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:47:00 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b04 for changeset 602e2d7a Message-ID: <94b45b6b-43c1-4e10-b550-638bce73bc0d@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-16 02:36:08 +0000 Added tag shenandoah8u372-b04 for changeset 602e2d7acfc Changeset: 602e2d7a Author: Andrew John Hughes Date: 2025-06-16 02:12:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/602e2d7acfcd4f976dcfb50a4a975d25a6dc198f From andrew at openjdk.org Mon Jun 16 01:47:46 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 01:47:46 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u372-b04 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/43/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/43/files/602e2d7a..602e2d7a Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=43&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=43&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/43.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/43/head:pull/43 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/43 From iris at openjdk.org Mon Jun 16 01:47:46 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 16 Jun 2025 01:47:46 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 01:38:21 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b04 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/43 From andrew at openjdk.org Mon Jun 16 02:08:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 02:08:45 GMT Subject: RFR: Merge jdk8u:master Message-ID: <6FOl9JtoCrsgmkbojD8OOcLkVan9E3XasRUIvScPdEQ=.381c90cf-8850-448a-a667-647b04d08247@github.com> Merge jdk8u372-b05 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u372-b05 - 8245654: Add Certigna Root CA - 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked - 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails - 8303408: [AIX] Broken jdk8u build after JDK-8266391 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/44/files Stats: 887 lines in 6 files changed: 342 ins; 37 del; 508 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/44.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/44/head:pull/44 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/44 From andrew at openjdk.org Mon Jun 16 02:12:44 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 02:12:44 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 5 new changesets Message-ID: <458c1ea2-8bc0-47a5-9169-46427193562f@openjdk.org> Changeset: 4a837299 Branch: master Author: Deepa Kumari Committer: Severin Gehwolf Date: 2023-03-03 10:34:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7 8303408: [AIX] Broken jdk8u build after JDK-8266391 Reviewed-by: phh, sgehwolf = jdk/src/aix/classes/jdk/internal/platform/SystemMetrics.java Changeset: 7c0d5b49 Branch: master Author: Severin Gehwolf Date: 2023-03-03 17:29:32 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7c0d5b49c05b5990776584de9b3d9f53b8b55e94 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails Reviewed-by: phh, andrew Backport-of: 45abbeed2f4f2899a3c1595b0cd8e573990a16fa ! jdk/test/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java Changeset: 3b80e877 Branch: master Author: Severin Gehwolf Date: 2023-03-03 17:31:14 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3b80e87798b41453738354aa4be030d420a0562a 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked Reviewed-by: phh, andrew Backport-of: d6bb846159be7e46fba0c3ca2915617f945e0b42 ! jdk/test/security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java Changeset: 5806429f Branch: master Author: Severin Gehwolf Date: 2023-03-03 17:32:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5806429f7ac582c400896a7ac61e147e93ddeac8 8245654: Add Certigna Root CA Reviewed-by: phh, andrew Backport-of: c8ee076241cc7d83f423683d97ec37f9e0d6ebaa + jdk/make/data/cacerts/certignaca + jdk/test/security/infra/java/security/cert/CertPathValidator/certification/CertignaCA.java ! jdk/test/sun/security/lib/cacerts/VerifyCACerts.java Changeset: c3bf9fe3 Branch: master Author: Andrew John Hughes Date: 2025-06-16 02:44:09 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c3bf9fe330d12b9b31dc9ebf2040bf40df6de1e6 Merge jdk8u372-b05 Added tag jdk8u372-b05 for changeset 5806429f7ac From andrew at openjdk.org Mon Jun 16 02:12:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 02:12:53 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b05 for changeset 5806429f Message-ID: <4c376bd0-5818-4ddc-89d4-e09170f108a0@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-03-07 01:43:33 +0000 Added tag jdk8u372-b05 for changeset 5806429f7ac Changeset: 5806429f Author: Severin Gehwolf Date: 2023-03-03 17:32:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5806429f7ac582c400896a7ac61e147e93ddeac8 From andrew at openjdk.org Mon Jun 16 02:12:57 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 02:12:57 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b05 for changeset c3bf9fe3 Message-ID: <33de8828-54ab-4d4a-80d0-533de3a1de9d@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-16 03:03:18 +0000 Added tag shenandoah8u372-b05 for changeset c3bf9fe330d Changeset: c3bf9fe3 Author: Andrew John Hughes Date: 2025-06-16 02:44:09 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c3bf9fe330d12b9b31dc9ebf2040bf40df6de1e6 From andrew at openjdk.org Mon Jun 16 02:13:55 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 02:13:55 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: <6FOl9JtoCrsgmkbojD8OOcLkVan9E3XasRUIvScPdEQ=.381c90cf-8850-448a-a667-647b04d08247@github.com> References: <6FOl9JtoCrsgmkbojD8OOcLkVan9E3XasRUIvScPdEQ=.381c90cf-8850-448a-a667-647b04d08247@github.com> Message-ID: > Merge jdk8u372-b05 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/44/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/44/files/c3bf9fe3..c3bf9fe3 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=44&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=44&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/44.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/44/head:pull/44 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/44 From iris at openjdk.org Mon Jun 16 02:13:55 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 16 Jun 2025 02:13:55 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: <6FOl9JtoCrsgmkbojD8OOcLkVan9E3XasRUIvScPdEQ=.381c90cf-8850-448a-a667-647b04d08247@github.com> References: <6FOl9JtoCrsgmkbojD8OOcLkVan9E3XasRUIvScPdEQ=.381c90cf-8850-448a-a667-647b04d08247@github.com> Message-ID: On Mon, 16 Jun 2025 02:04:25 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b05 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/44 From serge.korotkov at gmail.com Mon Jun 16 03:56:11 2025 From: serge.korotkov at gmail.com (Sergey Korotkov) Date: Mon, 16 Jun 2025 10:56:11 +0700 Subject: C2 Jit compiler fails accessing off-heap memory via Unsafe with ShenandoahGC In-Reply-To: <87plfm6t0d.fsf@redhat.com> References: <136180f2-df08-444b-8d80-63a10296a85f@gmail.com> <87plfm6t0d.fsf@redhat.com> Message-ID: <49fb15af-4525-4df9-b895-e3ae82b30560@gmail.com> Hello Roland, Thanks much for an amazingly fast fix! Are there any chances to get it backported to jdk 17 and 21? Our product (Apache Ignite) heavily relies on off-heap memory operations via Unsafe. I already applied the work around in our code but still not 100% sure that problem wouldn't hit in some other place. I can drive the backport if you would help with steps which needed the JBS user account. WBR, -- Sergey On 6/2/25 22:52, Roland Westrelin wrote: > > Hi Sergey, > > Thanks for the bug report. I created > https://bugs.openjdk.org/browse/JDK-8358334 to track that one. I'm > having a look. > > Roland. > From stefank at openjdk.org Mon Jun 16 07:54:30 2025 From: stefank at openjdk.org (Stefan Karlsson) Date: Mon, 16 Jun 2025 07:54:30 GMT Subject: RFR: 8359394: Shenandoah: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > We can remove `GCCause::_no_cause_specified` and need to add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are also missing `_shenandoah_humongous_allocation_failure` in the `SA` analog. I'm OK with the shared GC changes if you change the title of JBS issue or split it out the shared parts into a separate issue. ------------- PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2930994011 From amitkumar at openjdk.org Mon Jun 16 08:29:34 2025 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 16 Jun 2025 08:29:34 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Fri, 13 Jun 2025 19:18:19 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > remove is_sigill_not_entrant Just FYI, s390 build is broken with this change: # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/amit/jdk/src/hotspot/share/gc/shared/barrierSetNMethod.cpp:196), pid=1779086, tid=1779117 # assert(!nm->is_osr_method() || may_enter) failed: OSR nmethods should always be entrant after migration # # JRE version: OpenJDK Runtime Environment (26.0) (fastdebug build 26-internal-adhoc.amit.jdk) # Java VM: OpenJDK 64-Bit Server VM (fastdebug 26-internal-adhoc.amit.jdk, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-s390x) # Problematic frame: # V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e # # Core dump will be written. Default location: Core dumps may be processed with "/lib/systemd/systemd-coredump %P %u %g %s %t 9223372036854775808 %h %d" (or dumping to /home/amit/jdk/make/core.1779086) # # If you would like to submit a bug report, please visit: # https://bugreport.java.com/bugreport/crash.jsp # stack trace: Stack: [0x000003ff9e580000,0x000003ff9e680000], sp=0x000003ff9e67b068, free space=1004k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e (barrierSetNMethod.cpp:196) v ~StubRoutines::method_entry_barrier 0x000003ff9050cd18 J 282% c2 sun.nio.fs.UnixPath.initOffsets()V java.base (189 bytes) @ 0x000003ff90c4f0c8 [0x000003ff90c4f080+0x0000000000000048] j sun.nio.fs.UnixPath.getFileName()Lsun/nio/fs/UnixPath;+1 java.base j sun.nio.fs.UnixFileSystemProvider.isHidden(Ljava/nio/file/Path;)Z+6 java.base j java.nio.file.Files.isHidden(Ljava/nio/file/Path;)Z+5 java.base j jdk.internal.module.ModulePath.isHidden(Ljava/nio/file/Path;)Z+1 java.base j jdk.internal.module.ModulePath.lambda$explodedPackages$0(Ljava/nio/file/Path;Ljava/nio/file/attribute/BasicFileAttributes;)Z+11 java.base j jdk.internal.module.ModulePath$$Lambda+0x00000000a105cbe0.test(Ljava/lang/Object;Ljava/lang/Object;)Z+12 java.base j java.nio.file.Files.lambda$find$0(Ljava/util/function/BiPredicate;Ljava/nio/file/FileTreeWalker$Event;)Z+9 java.base j java.nio.file.Files$$Lambda+0x00000000a10646c0.test(Ljava/lang/Object;)Z+8 java.base .... ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2975564797 From andrew at openjdk.org Mon Jun 16 13:30:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 13:30:52 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u372-b06 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u372-b06 - 8304053: Revert os specific stubs for SystemMetrics - 8303828: [Solaris] Broken jdk8u build after JDK-8266391 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/45/files Stats: 67 lines in 4 files changed: 4 ins; 62 del; 1 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/45.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/45/head:pull/45 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/45 From sroy at openjdk.org Mon Jun 16 13:53:07 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 16 Jun 2025 13:53:07 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all Message-ID: JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) we found the method names `update_all` of the class `GenerationCounters` and its subclasses are not so good. It is better to rename it to something like `update_capacity` (such as `ZGenerationCounters::update_capacity`). ------------- Commit messages: - copyright - update capacity Changes: https://git.openjdk.org/jdk/pull/25831/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25831&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349077 Stats: 46 lines in 16 files changed: 0 ins; 0 del; 46 mod Patch: https://git.openjdk.org/jdk/pull/25831.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25831/head:pull/25831 PR: https://git.openjdk.org/jdk/pull/25831 From mdoerr at openjdk.org Mon Jun 16 13:59:29 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 16 Jun 2025 13:59:29 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 08:26:38 GMT, Amit Kumar wrote: >> Dean Long has updated the pull request incrementally with one additional commit since the last revision: >> >> remove is_sigill_not_entrant > > Just FYI, s390 build is broken with this change: > > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (/home/amit/jdk/src/hotspot/share/gc/shared/barrierSetNMethod.cpp:196), pid=1779086, tid=1779117 > # assert(!nm->is_osr_method() || may_enter) failed: OSR nmethods should always be entrant after migration > # > # JRE version: OpenJDK Runtime Environment (26.0) (fastdebug build 26-internal-adhoc.amit.jdk) > # Java VM: OpenJDK 64-Bit Server VM (fastdebug 26-internal-adhoc.amit.jdk, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-s390x) > # Problematic frame: > # V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e > # > # Core dump will be written. Default location: Core dumps may be processed with "/lib/systemd/systemd-coredump %P %u %g %s %t 9223372036854775808 %h %d" (or dumping to /home/amit/jdk/make/core.1779086) > # > # If you would like to submit a bug report, please visit: > # https://bugreport.java.com/bugreport/crash.jsp > # > > > stack trace: > > Stack: [0x000003ff9e580000,0x000003ff9e680000], sp=0x000003ff9e67b068, free space=1004k > Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) > V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e (barrierSetNMethod.cpp:196) > v ~StubRoutines::method_entry_barrier 0x000003ff9050cd18 > J 282% c2 sun.nio.fs.UnixPath.initOffsets()V java.base (189 bytes) @ 0x000003ff90c4f0c8 [0x000003ff90c4f080+0x0000000000000048] > j sun.nio.fs.UnixPath.getFileName()Lsun/nio/fs/UnixPath;+1 java.base > j sun.nio.fs.UnixFileSystemProvider.isHidden(Ljava/nio/file/Path;)Z+6 java.base > j java.nio.file.Files.isHidden(Ljava/nio/file/Path;)Z+5 java.base > j jdk.internal.module.ModulePath.isHidden(Ljava/nio/file/Path;)Z+1 java.base > j jdk.internal.module.ModulePath.lambda$explodedPackages$0(Ljava/nio/file/Path;Ljava/nio/file/attribute/BasicFileAttributes;)Z+11 java.base > j jdk.internal.module.ModulePath$$Lambda+0x00000000a105cbe0.test(Ljava/lang/Object;Ljava/lang/Object;)Z+12 java.base > j java.nio.file.Files.lambda$find$0(Ljava/util/function/BiPredicate;Ljava/nio/file/FileTreeWalker$Event;)Z+9 java.base > j java.nio.file.Files$$Lambda+0x00000000a10646c0.test(Ljava/lang/Object;)Z+8 java.base > .... @offamitkumar: The problem is probably the initialization to -1: [`z_cfi(Z_R0_scratch, /* to be patched */ -1);`.](https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp#L183) Should be 0. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2976308103 From mdoerr at openjdk.org Mon Jun 16 13:59:30 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 16 Jun 2025 13:59:30 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Fri, 13 Jun 2025 19:18:19 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > remove is_sigill_not_entrant Seems like arm32 has the same issue: https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/arm/gc/shared/barrierSetAssembler_arm.cpp#L199 The init value shouldn't have the sticky bit set. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2976766766 From sroy at openjdk.org Mon Jun 16 14:04:34 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 16 Jun 2025 14:04:34 GMT Subject: Withdrawn: JDK-8349077 : Rename GenerationCounters::update_all In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 13:31:00 GMT, Suchismith Roy wrote: > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names `update_all` of the class `GenerationCounters` and its subclasses are not so good. It is better to rename it to something like `update_capacity` (such as `ZGenerationCounters::update_capacity`). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/25831 From amitkumar at openjdk.org Mon Jun 16 15:07:29 2025 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 16 Jun 2025 15:07:29 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 08:26:38 GMT, Amit Kumar wrote: >> Dean Long has updated the pull request incrementally with one additional commit since the last revision: >> >> remove is_sigill_not_entrant > > Just FYI, s390 build is broken with this change: > > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (/home/amit/jdk/src/hotspot/share/gc/shared/barrierSetNMethod.cpp:196), pid=1779086, tid=1779117 > # assert(!nm->is_osr_method() || may_enter) failed: OSR nmethods should always be entrant after migration > # > # JRE version: OpenJDK Runtime Environment (26.0) (fastdebug build 26-internal-adhoc.amit.jdk) > # Java VM: OpenJDK 64-Bit Server VM (fastdebug 26-internal-adhoc.amit.jdk, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-s390x) > # Problematic frame: > # V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e > # > # Core dump will be written. Default location: Core dumps may be processed with "/lib/systemd/systemd-coredump %P %u %g %s %t 9223372036854775808 %h %d" (or dumping to /home/amit/jdk/make/core.1779086) > # > # If you would like to submit a bug report, please visit: > # https://bugreport.java.com/bugreport/crash.jsp > # > > > stack trace: > > Stack: [0x000003ff9e580000,0x000003ff9e680000], sp=0x000003ff9e67b068, free space=1004k > Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) > V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e (barrierSetNMethod.cpp:196) > v ~StubRoutines::method_entry_barrier 0x000003ff9050cd18 > J 282% c2 sun.nio.fs.UnixPath.initOffsets()V java.base (189 bytes) @ 0x000003ff90c4f0c8 [0x000003ff90c4f080+0x0000000000000048] > j sun.nio.fs.UnixPath.getFileName()Lsun/nio/fs/UnixPath;+1 java.base > j sun.nio.fs.UnixFileSystemProvider.isHidden(Ljava/nio/file/Path;)Z+6 java.base > j java.nio.file.Files.isHidden(Ljava/nio/file/Path;)Z+5 java.base > j jdk.internal.module.ModulePath.isHidden(Ljava/nio/file/Path;)Z+1 java.base > j jdk.internal.module.ModulePath.lambda$explodedPackages$0(Ljava/nio/file/Path;Ljava/nio/file/attribute/BasicFileAttributes;)Z+11 java.base > j jdk.internal.module.ModulePath$$Lambda+0x00000000a105cbe0.test(Ljava/lang/Object;Ljava/lang/Object;)Z+12 java.base > j java.nio.file.Files.lambda$find$0(Ljava/util/function/BiPredicate;Ljava/nio/file/FileTreeWalker$Event;)Z+9 java.base > j java.nio.file.Files$$Lambda+0x00000000a10646c0.test(Ljava/lang/Object;)Z+8 java.base > .... > @offamitkumar: The problem is probably the initialization to -1: [`z_cfi(Z_R0_scratch, /* to be patched */ -1);`.](https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp#L183) Should be 0. Thank you Martin for the suggestion. @dean-long would you please add this diff, fixing s390x build. I ran tier1 test with fastdebug, test are clean; diff --git a/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp b/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp index e78906708af..2d663061aec 100644 --- a/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp +++ b/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp @@ -180,7 +180,7 @@ void BarrierSetAssembler::nmethod_entry_barrier(MacroAssembler* masm) { __ z_lg(Z_R0_scratch, in_bytes(bs_nm->thread_disarmed_guard_value_offset()), Z_thread); // 6 bytes // Compare to current patched value: - __ z_cfi(Z_R0_scratch, /* to be patched */ -1); // 6 bytes (2 + 4 byte imm val) + __ z_cfi(Z_R0_scratch, /* to be patched */ 0); // 6 bytes (2 + 4 byte imm val) // Conditional Jump __ z_larl(Z_R14, (Assembler::instr_len((unsigned long)LARL_ZOPC) + Assembler::instr_len((unsigned long)BCR_ZOPC)) / 2); // 6 bytes diff --git a/src/hotspot/cpu/s390/stubGenerator_s390.cpp b/src/hotspot/cpu/s390/stubGenerator_s390.cpp index d3f6540a3ea..bb1d9ce6037 100644 --- a/src/hotspot/cpu/s390/stubGenerator_s390.cpp +++ b/src/hotspot/cpu/s390/stubGenerator_s390.cpp @@ -3197,7 +3197,7 @@ class StubGenerator: public StubCodeGenerator { // VM-Call: BarrierSetNMethod::nmethod_stub_entry_barrier(address* return_address_ptr) __ call_VM_leaf(CAST_FROM_FN_PTR(address, BarrierSetNMethod::nmethod_stub_entry_barrier)); - __ z_ltr(Z_R0_scratch, Z_RET); + __ z_ltr(Z_RET, Z_RET); // VM-Call Epilogue __ restore_volatile_regs(Z_SP, frame::z_abi_160_size, true, false); ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2977015369 From sroy at openjdk.org Mon Jun 16 15:09:40 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 16 Jun 2025 15:09:40 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all Message-ID: JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. ------------- Commit messages: - update_capacity exists Changes: https://git.openjdk.org/jdk/pull/25833/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349077 Stats: 45 lines in 15 files changed: 0 ins; 0 del; 45 mod Patch: https://git.openjdk.org/jdk/pull/25833.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833 PR: https://git.openjdk.org/jdk/pull/25833 From rwestrel at redhat.com Mon Jun 16 15:13:55 2025 From: rwestrel at redhat.com (Roland Westrelin) Date: Mon, 16 Jun 2025 17:13:55 +0200 Subject: C2 Jit compiler fails accessing off-heap memory via Unsafe with ShenandoahGC In-Reply-To: <49fb15af-4525-4df9-b895-e3ae82b30560@gmail.com> References: <136180f2-df08-444b-8d80-63a10296a85f@gmail.com> <87plfm6t0d.fsf@redhat.com> <49fb15af-4525-4df9-b895-e3ae82b30560@gmail.com> Message-ID: <87y0troh1o.fsf@redhat.com> Hi Sergey, > Are there any chances to get it backported to jdk 17 and 21? I intend to backport it to 25, 21 and 17. > Our product (Apache Ignite) heavily relies on off-heap memory operations > via Unsafe. I already applied the work around in our code but still not > 100% sure that problem wouldn't hit in some other place. So the bug could affect end users of Apache Ignite? That's useful to know and I'll use that to motivate the backports. Roland. From ayang at openjdk.org Mon Jun 16 15:47:28 2025 From: ayang at openjdk.org (Albert Mingkun Yang) Date: Mon, 16 Jun 2025 15:47:28 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 14:39:26 GMT, Suchismith Roy wrote: > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). > > > > Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. I believe the ticket was only about this method, which handles only capacity. void GenerationCounters::update_all(size_t curr_capacity) { _current_size->set_value(curr_capacity); } However, in the patch, this method is renamed as well. Not sure if this is intentional. void HSpaceCounters::update_all(size_t capacity, size_t used) { update_capacity(capacity); update_used(used); } ------------- PR Comment: https://git.openjdk.org/jdk/pull/25833#issuecomment-2977143602 From yzheng at openjdk.org Mon Jun 16 16:14:28 2025 From: yzheng at openjdk.org (Yudi Zheng) Date: Mon, 16 Jun 2025 16:14:28 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all In-Reply-To: References: Message-ID: <_dbY3cVxby--JIeliaIXLOB8jKH4oPX97JRvj3AqqhM=.30829434-40eb-4113-bce2-de119f26a27b@github.com> On Mon, 16 Jun 2025 14:39:26 GMT, Suchismith Roy wrote: > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). > > > > Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. Since the base is before the branch off, could you please merge master before integration and see if GHA still passes? This also helps us testing libgraal compilation. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25833#issuecomment-2977233601 From sroy at openjdk.org Mon Jun 16 16:36:14 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 16 Jun 2025 16:36:14 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v2] In-Reply-To: References: Message-ID: > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). > > > > Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. Suchismith Roy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into update_memory_state - update_capacity exists ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25833/files - new: https://git.openjdk.org/jdk/pull/25833/files/cf2d66d5..419f3d5f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=00-01 Stats: 202092 lines in 3611 files changed: 122500 ins; 53972 del; 25620 mod Patch: https://git.openjdk.org/jdk/pull/25833.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833 PR: https://git.openjdk.org/jdk/pull/25833 From xpeng at openjdk.org Mon Jun 16 16:47:30 2025 From: xpeng at openjdk.org (Xiaolong Peng) Date: Mon, 16 Jun 2025 16:47:30 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 22:10:12 GMT, William Kemper wrote: >> Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. > > William Kemper has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Consolidate read table cleaning" > > This reverts commit 9552021cbeec699e7b04db81fa68819c23b7dab7. Marked as reviewed by xpeng (Committer). ------------- PR Review: https://git.openjdk.org/jdk/pull/25735#pullrequestreview-2932825279 From xpeng at openjdk.org Mon Jun 16 16:47:30 2025 From: xpeng at openjdk.org (Xiaolong Peng) Date: Mon, 16 Jun 2025 16:47:30 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: References: Message-ID: <5VL86NUy8SQCA02KjzGeF74KhEC7b7uFcKqipeiSJuE=.cca1f9fe-f124-4e5f-bf12-a2a13335db89@github.com> On Thu, 12 Jun 2025 22:44:44 GMT, William Kemper wrote: > We don't want to clean the read table during init-mark because that's a safepoint. We can safely clean the read table concurrently because only the GC thread has access to it. Thanks, we want to minimize the time at safepoint, I understand this part. My question was about swap_card_tables, I we don't have to do it at safepoint, we could move swap_card_tables out of the init-mark safepoint and move to close to mark_read_table_as_clean to make the code slight earlier to understand. @ysramakrishna also suggested this, I saw your attempt and rollback, thanks for the explanations. It looks good to me. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25735#issuecomment-2977329569 From serge.korotkov at gmail.com Mon Jun 16 16:51:02 2025 From: serge.korotkov at gmail.com (Sergey Korotkov) Date: Mon, 16 Jun 2025 23:51:02 +0700 Subject: C2 Jit compiler fails accessing off-heap memory via Unsafe with ShenandoahGC In-Reply-To: <87y0troh1o.fsf@redhat.com> References: <136180f2-df08-444b-8d80-63a10296a85f@gmail.com> <87plfm6t0d.fsf@redhat.com> <49fb15af-4525-4df9-b895-e3ae82b30560@gmail.com> <87y0troh1o.fsf@redhat.com> Message-ID: <05a01774-0e2f-4666-a16f-fcc6477da9d8@gmail.com> Hi Roland, On 6/16/25 22:13, Roland Westrelin wrote: > > Hi Sergey, > >> Are there any chances to get it backported to jdk 17 and 21? > > I intend to backport it to 25, 21 and 17. Thanks for that. > >> Our product (Apache Ignite) heavily relies on off-heap memory operations >> via Unsafe. I already applied the work around in our code but still not >> 100% sure that problem wouldn't hit in some other place. > > So the bug could affect end users of Apache Ignite? That's useful to > know and I'll use that to motivate the backports. Yes, it was a real failure in production for one user recently: https://issues.apache.org/jira/browse/IGNITE-17734 Thanks, -- Sergey From ysr at openjdk.org Mon Jun 16 17:15:30 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Mon, 16 Jun 2025 17:15:30 GMT Subject: RFR: 8359394: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > Remove `GCCause::_no_cause_specified` (only referenced by Shenandoah) and add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string` and the `SA` analog. Thanks for changing the title/summary to broaden scope. Re-approved; ? ------------- Marked as reviewed by ysr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2932895948 From andrew at openjdk.org Mon Jun 16 17:21:54 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 17:21:54 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 3 new changesets Message-ID: <14e473b3-cd10-4ebc-a54a-72658f2ab2e9@openjdk.org> Changeset: ebbd3a87 Branch: master Author: Adam Farley Committer: Andrew John Hughes Date: 2023-03-09 17:15:22 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186 8303828: [Solaris] Broken jdk8u build after JDK-8266391 Reviewed-by: sgehwolf, andrew = jdk/src/solaris/classes/jdk/internal/platform/SystemMetrics.java Changeset: 89aeae16 Branch: master Author: Adam Farley Committer: Severin Gehwolf Date: 2023-03-15 14:11:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99 8304053: Revert os specific stubs for SystemMetrics Reviewed-by: sgehwolf, andrew ! jdk/make/CompileJavaClasses.gmk - jdk/src/aix/classes/jdk/internal/platform/SystemMetrics.java - jdk/src/macosx/classes/jdk/internal/platform/SystemMetrics.java - jdk/src/unix/classes/jdk/internal/platform/SystemMetrics.java Changeset: 0c8f76cd Branch: master Author: Andrew John Hughes Date: 2025-06-16 03:11:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0c8f76cd327bb68279a5388c5858d43dc7591e7b Merge jdk8u372-b06 Added tag jdk8u372-b06 for changeset 89aeae16e85 From andrew at openjdk.org Mon Jun 16 17:22:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 17:22:03 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b06 for changeset 89aeae16 Message-ID: <2385f4c4-fd84-4e85-8bbd-2afd84f340ae@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-03-21 18:09:33 +0000 Added tag jdk8u372-b06 for changeset 89aeae16e85 Changeset: 89aeae16 Author: Adam Farley Committer: Severin Gehwolf Date: 2023-03-15 14:11:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99 From andrew at openjdk.org Mon Jun 16 17:22:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 17:22:03 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: <1ak9hENzPrjCpd3AiPSc7MxqiD-UMHS2w_DxVvwAkH0=.5c4aeeec-4a76-4da7-afcd-4fe586562b3c@github.com> > Merge jdk8u372-b06 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/45/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/45/files/0c8f76cd..0c8f76cd Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=45&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=45&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/45.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/45/head:pull/45 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/45 From andrew at openjdk.org Mon Jun 16 17:22:06 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 17:22:06 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b06 for changeset 0c8f76cd Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-16 03:30:38 +0000 Added tag shenandoah8u372-b06 for changeset 0c8f76cd327 Changeset: 0c8f76cd Author: Andrew John Hughes Date: 2025-06-16 03:11:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0c8f76cd327bb68279a5388c5858d43dc7591e7b From iris at openjdk.org Mon Jun 16 17:22:03 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 16 Jun 2025 17:22:03 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: <6J43LXEy_nWK2t61Y3o9D2Y1FWPB14uyOyPtf37nSLQ=.da5aa21b-47dc-4d51-9946-813e33cba8be@github.com> On Mon, 16 Jun 2025 13:26:40 GMT, Andrew John Hughes wrote: > Merge jdk8u372-b06 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/45 From stefank at openjdk.org Mon Jun 16 18:12:34 2025 From: stefank at openjdk.org (Stefan Karlsson) Date: Mon, 16 Jun 2025 18:12:34 GMT Subject: RFR: 8359394: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > Remove `GCCause::_no_cause_specified` (only referenced by Shenandoah) and add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string` and the `SA` analog. I've reviewed the non-shenandoah parts of this patch. ------------- Marked as reviewed by stefank (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2933048021 From ysr at openjdk.org Mon Jun 16 18:36:29 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Mon, 16 Jun 2025 18:36:29 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 22:10:12 GMT, William Kemper wrote: >> Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. > > William Kemper has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Consolidate read table cleaning" > > This reverts commit 9552021cbeec699e7b04db81fa68819c23b7dab7. Thanks for the explanation; let me digest this and re-review with this background. I'll update before EOD. > @ysramakrishna - The refactoring you suggest is not so simple, alas. We have to be very careful about the ordering of cleaning the `read` table, resetting the mark bitmap and swapping the card tables. Genshen does not clean the `read` table at the end of a concurrent cycle (we _could_ do this, but we'd still need to do the same in a degenerated cycle). The complexity comes from swapping the card tables in a concurrent cycle. We must not let a subsequent degenerated cycle swap them a second time. The degenerated cycle can only clean the `read` table if there was no active concurrent cycle (lest it throw away critical remembered set data). > > However, the degenerated cycle must also clear the mark bitmaps if the concurrent cycle degenerated during the root scan (the degenerated cycle will rescan the roots). Of course, we cannot clear the mark bitmaps if the concurrent cycle degenerated during the mark phase. So, for the degenerated cycle, clearing the mark bitmaps and cleaning the read table need to happen in two different cases and it doesn't work if they're combined into the same method (and I don't think adding a method parameter to sometimes clear the mark bitmap and sometimes the read table will make the code any easier to understand). ------------- PR Comment: https://git.openjdk.org/jdk/pull/25735#issuecomment-2977654895 From andrew at openjdk.org Mon Jun 16 19:09:41 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 19:09:41 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 17 new changesets Message-ID: Changeset: f44ca40a Branch: master Author: Paul Hohensee Committer: Andrew John Hughes Date: 2023-04-13 18:24:54 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f44ca40a433db9c6951f9758cf0e2e5bafbdd0ef 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec Reviewed-by: simonis, mbalao, andrew Backport-of: a5d7de235101696463dba22792703c6809ff7fc4 ! jdk/src/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java ! jdk/src/share/classes/sun/security/rsa/RSAKeyFactory.java ! jdk/test/java/security/KeyFactory/KeyFactoryGetKeySpecForInvalidSpec.java + jdk/test/sun/security/pkcs11/nss/p11-nss-sensitive.txt + jdk/test/sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec.java Changeset: 1cf3efb0 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2023-03-01 17:05:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1cf3efb037cb9056c53b3b9c65fb751dd13d3e12 8287404: Improve ping times Reviewed-by: andrew Backport-of: 5a054b372dbd751fe1b312375153f13e70d7131f ! jdk/src/solaris/native/java/net/Inet4AddressImpl.c ! jdk/src/solaris/native/java/net/Inet6AddressImpl.c Changeset: f7f19668 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2023-03-02 19:58:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f7f196685f60a74eaff87631591a17bbbaf7831b 8288436: Improve Xalan supports Reviewed-by: andrew Backport-of: 6899dff264c9030a3016e292c3f3f6738bde97cc ! jaxp/src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: 301c9adc Branch: master Author: Jamil Nimeh Committer: Andrew John Hughes Date: 2023-01-10 19:01:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/301c9adce1711d9eb3f663bef07bbb045b907332 8294474: Better AES support Reviewed-by: yan, andrew Backport-of: 0c534f3309a308e89363ec69dee74d95fd9647a4 ! jdk/src/share/classes/sun/security/ssl/KeyUpdate.java ! jdk/src/share/classes/sun/security/ssl/SSLEngineImpl.java ! jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java ! jdk/src/share/classes/sun/security/ssl/TransportContext.java Changeset: a7fbe33f Branch: master Author: Alexei Voitylov Committer: Andrew John Hughes Date: 2023-02-27 16:17:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a7fbe33ffece7c28c9808fcc631c2d4db4a59757 8295304: Runtime support improvements Reviewed-by: mbalao, andrew Backport-of: 9c31d51bd5fc17e3914142c2461f3abfe71651d0 ! jdk/src/share/classes/java/lang/ProcessBuilder.java Changeset: 07d29838 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2023-03-16 18:28:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/07d29838c820d629bef1da8bc6e1084f48e0a519 8296676: Improve String platform support Reviewed-by: avoitylov, andrew Backport-of: d083a3c21e8849ed2a8b79aba37b46d921886a05 ! jdk/src/share/classes/java/net/InetAddress.java ! jdk/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: a02c2bfb Branch: master Author: Olga Mikhaltsova Committer: Andrew John Hughes Date: 2023-03-13 02:31:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a02c2bfb23dec01c987af1859654f0e4b44d70c6 8296684: Improve String platform support Reviewed-by: mbalao, andrew Backport-of: 9ae682726873de27cef4d3bd5523713f4ff98266 ! jdk/src/aix/classes/sun/tools/attach/AixVirtualMachine.java ! jdk/src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java ! jdk/src/solaris/classes/sun/tools/attach/BsdVirtualMachine.java ! jdk/src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java ! jdk/src/solaris/classes/sun/tools/attach/SolarisVirtualMachine.java ! jdk/src/windows/classes/sun/tools/attach/WindowsVirtualMachine.java Changeset: 2a54b080 Branch: master Author: Ekaterina Vergizova Committer: Andrew John Hughes Date: 2023-01-20 15:18:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2a54b080ed565c1d1ddadad27d2e4b77058ef2c7 8296692: Improve String platform support Reviewed-by: mbalao, andrew Backport-of: ed8643947e21263588cb6e9202efb3a30f450c4e ! jdk/src/solaris/classes/sun/management/FileSystemImpl.java ! jdk/src/windows/classes/sun/management/FileSystemImpl.java Changeset: 17ba2dfb Branch: master Author: Andrew Brygin Committer: Andrew John Hughes Date: 2023-03-23 12:14:34 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/17ba2dfb47f22a6a89609c94be50cabc6df5c8c9 8296700: Improve String platform support Reviewed-by: phh, mbalao, andrew ! jdk/src/share/classes/java/util/zip/ZipFile.java Changeset: 6089a4fc Branch: master Author: Yuri Nesterenko Committer: Andrew John Hughes Date: 2023-03-03 11:32:12 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6089a4fcc583ab156c22eae8196ce5073bf90032 8296832: Improve Swing platform support Reviewed-by: mbalao, andrew Backport-of: a81c810a76d91b79917417ed22e5e5aa530690ca ! jdk/src/share/classes/javax/swing/plaf/basic/BasicHTML.java ! jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! jdk/src/share/classes/javax/swing/text/html/ObjectView.java ! jdk/src/share/classes/sun/swing/SwingAccessor.java Changeset: ed70f64a Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2023-03-03 14:50:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ed70f64af92da3994fd9164d454c5323fa56794b 8297371: Improve UTF8 representation redux Reviewed-by: yan, andrew Backport-of: a44eb133d3cdb190abb0210c201e315d94d09dc7 ! jdk/src/share/native/common/jni_util.c Changeset: 1a42e357 Branch: master Author: Andrew Brygin Committer: Andrew John Hughes Date: 2023-04-17 21:48:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1a42e35729d1a0b049a13b762b0cbb4f046081ea 8298191: Enhance object reclamation process Reviewed-by: phh Backport-of: 780327d1de4fee3e77c3e48018908bf0c3fcd55a ! hotspot/src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp ! hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! hotspot/src/share/vm/gc_implementation/g1/g1RemSet.cpp ! hotspot/src/share/vm/gc_implementation/g1/ptrQueue.hpp Changeset: 71bb00a5 Branch: master Author: Alexey Bakhtin Committer: Andrew John Hughes Date: 2023-04-12 18:30:15 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/71bb00a5d86affa8c2c8934ab892fe6c5191abdc 8298310: Enhance TLS session negotiation Reviewed-by: mbalao, andrew Backport-of: 9a14b363feaaa1a1831fcc8620d41b4db2e0110a ! jdk/src/share/classes/sun/security/provider/certpath/AdjacencyList.java ! jdk/src/share/classes/sun/security/provider/certpath/Builder.java ! jdk/src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! jdk/src/share/classes/sun/security/provider/certpath/ForwardState.java ! jdk/src/share/classes/sun/security/provider/certpath/State.java ! jdk/src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java Changeset: 33758aeb Branch: master Author: Alexei Voitylov Committer: Andrew John Hughes Date: 2023-02-27 16:17:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/33758aeb351a6d8e6bedc5457b501d1e6d471810 8298667: Improved path handling Reviewed-by: mbalao, andrew Backport-of: 900abc284669d1aadeac8026ad618c9f1dc553a6 ! jdk/src/solaris/classes/sun/nio/fs/UnixUriUtils.java Changeset: 74148f81 Branch: master Author: Alexei Voitylov Committer: Andrew John Hughes Date: 2023-02-27 16:17:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/74148f814267aec83e35f2664849570d8ea68826 8299129: Enhance NameService lookups Reviewed-by: mbalao, andrew Backport-of: 1aef50354aaa0831b58de81db3d6bf30b9a277d1 ! jdk/src/share/classes/java/net/InetAddress.java Changeset: 338acde3 Branch: master Author: Victor Rudometov Committer: Andrew John Hughes Date: 2023-04-17 15:47:04 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/338acde33061b8af9d30aa510d86ec8156009021 8305113: (tz) Update Timezone Data to 2023c Reviewed-by: andrew Backport-of: ed9592c6e81f82e2bf6508ce45ba15aad8232181 ! jdk/make/data/tzdata/VERSION ! jdk/make/data/tzdata/africa ! jdk/make/data/tzdata/antarctica ! jdk/make/data/tzdata/asia ! jdk/make/data/tzdata/australasia ! jdk/make/data/tzdata/backward ! jdk/make/data/tzdata/europe ! jdk/make/data/tzdata/iso3166.tab ! jdk/make/data/tzdata/leapseconds ! jdk/make/data/tzdata/northamerica ! jdk/make/data/tzdata/southamerica ! jdk/make/data/tzdata/zone.tab ! jdk/src/share/classes/sun/util/calendar/ZoneInfoFile.java ! jdk/test/java/util/TimeZone/TimeZoneData/VERSION ! jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt ! jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt ! jdk/test/java/util/TimeZone/TimeZoneTest.java ! jdk/test/sun/util/calendar/zi/tzdata/VERSION ! jdk/test/sun/util/calendar/zi/tzdata/africa ! jdk/test/sun/util/calendar/zi/tzdata/antarctica ! jdk/test/sun/util/calendar/zi/tzdata/asia ! jdk/test/sun/util/calendar/zi/tzdata/australasia ! jdk/test/sun/util/calendar/zi/tzdata/backward ! jdk/test/sun/util/calendar/zi/tzdata/europe ! jdk/test/sun/util/calendar/zi/tzdata/iso3166.tab ! jdk/test/sun/util/calendar/zi/tzdata/leapseconds ! jdk/test/sun/util/calendar/zi/tzdata/northamerica ! jdk/test/sun/util/calendar/zi/tzdata/southamerica ! jdk/test/sun/util/calendar/zi/tzdata/zone.tab Changeset: c2d68ead Branch: master Author: Andrew John Hughes Date: 2025-06-16 18:19:23 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c2d68ead49e357aa994f2ac9b6d0cb7abac90f5f Merge jdk8u372-b07 Added tag jdk8u372-b07 for changeset 338acde3306 From andrew at openjdk.org Mon Jun 16 19:09:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 19:09:52 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-b07 for changeset 338acde3 Message-ID: <387ec247-cbb6-4dd1-adde-93ce50c95642@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-04-18 06:20:23 +0000 Added tag jdk8u372-b07 for changeset 338acde3306 Changeset: 338acde3 Author: Victor Rudometov Committer: Andrew John Hughes Date: 2023-04-17 15:47:04 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/338acde33061b8af9d30aa510d86ec8156009021 From andrew at openjdk.org Mon Jun 16 19:09:56 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 19:09:56 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-b07 for changeset c2d68ead Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-16 20:01:47 +0000 Added tag shenandoah8u372-b07 for changeset c2d68ead49e Changeset: c2d68ead Author: Andrew John Hughes Date: 2025-06-16 18:19:23 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c2d68ead49e357aa994f2ac9b6d0cb7abac90f5f From andrew at openjdk.org Mon Jun 16 19:09:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 19:09:59 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u372-ga for changeset 338acde3 Message-ID: <376ebc69-352b-4e9f-bf39-f3a6752271f0@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-04-20 09:43:15 +0000 Added tag jdk8u372-ga for changeset 338acde3306 Changeset: 338acde3 Author: Victor Rudometov Committer: Andrew John Hughes Date: 2023-04-17 15:47:04 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/338acde33061b8af9d30aa510d86ec8156009021 From andrew at openjdk.org Mon Jun 16 19:10:05 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 19:10:05 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u372-ga for changeset c2d68ead Message-ID: <2676537a-6732-4725-a508-c82cf169110b@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-16 20:02:11 +0000 Added tag shenandoah8u372-ga for changeset c2d68ead49e Changeset: c2d68ead Author: Andrew John Hughes Date: 2025-06-16 18:19:23 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c2d68ead49e357aa994f2ac9b6d0cb7abac90f5f From wkemper at openjdk.org Mon Jun 16 20:46:28 2025 From: wkemper at openjdk.org (William Kemper) Date: Mon, 16 Jun 2025 20:46:28 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: <5VL86NUy8SQCA02KjzGeF74KhEC7b7uFcKqipeiSJuE=.cca1f9fe-f124-4e5f-bf12-a2a13335db89@github.com> References: <5VL86NUy8SQCA02KjzGeF74KhEC7b7uFcKqipeiSJuE=.cca1f9fe-f124-4e5f-bf12-a2a13335db89@github.com> Message-ID: On Mon, 16 Jun 2025 16:44:25 GMT, Xiaolong Peng wrote: >> @pengxiaolong - We don't want to clean the read table during init-mark because that's a safepoint. We can safely clean the read table concurrently because only the GC thread has access to it. >> >> @ysramakrishna - The refactoring you suggest is not so simple, alas. We have to be very careful about the ordering of cleaning the `read` table, resetting the mark bitmap and swapping the card tables. Genshen does not clean the `read` table at the end of a concurrent cycle (we _could_ do this, but we'd still need to do the same in a degenerated cycle). The complexity comes from swapping the card tables in a concurrent cycle. We must not let a subsequent degenerated cycle swap them a second time. The degenerated cycle can only clean the `read` table if there was no active concurrent cycle (lest it throw away critical remembered set data). >> >> However, the degenerated cycle must also clear the mark bitmaps if the concurrent cycle degenerated during the root scan (the degenerated cycle will rescan the roots). Of course, we cannot clear the mark bitmaps if the concurrent cycle degenerated during the mark phase. So, for the degenerated cycle, clearing the mark bitmaps and cleaning the read table need to happen in two different cases and it doesn't work if they're combined into the same method (and I don't think adding a method parameter to sometimes clear the mark bitmap and sometimes the read table will make the code any easier to understand). > >> We don't want to clean the read table during init-mark because that's a safepoint. We can safely clean the read table concurrently because only the GC thread has access to it. > > Thanks, we want to minimize the time at safepoint, I understand this part. My question was about swap_card_tables, I we don't have to do it at safepoint, we could move swap_card_tables out of the init-mark safepoint and move to close to mark_read_table_as_clean to make the code slight earlier to understand. @ysramakrishna also suggested this, I saw your attempt and rollback, thanks for the explanations. > > It looks good to me. @pengxiaolong - I think we _could_ swap card table pointers with a thread local handshake, but if we don't remove `init-mark` entirely, it would just mean stopping all the threads twice. I'm inclined to leave it on the safepoint for now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25735#issuecomment-2978071741 From andrew at openjdk.org Mon Jun 16 21:51:10 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 21:51:10 GMT Subject: RFR: Merge jdk8u:master Message-ID: <8QGJ4uHncrOw8kiROQLJR-eHoJSjOxn8jXU22GqoMzg=.78399e84-639c-46b9-a82c-1aaaeecf3a9a@github.com> Merge jdk8u382-b01 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u382-b01 - 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue - Merge - 8282345: handle latest VS2022 in abstract_vm_version - 8276841: Add support for Visual Studio 2022 - 8215105: java/awt/Robot/HiDPIScreenCapture/ScreenCaptureTest.java: Wrong Pixel Color - 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode - 8151460: Metaspace counters can have inconsistent values - 8305113: (tz) Update Timezone Data to 2023c - 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec - ... and 14 more: https://git.openjdk.org/shenandoah-jdk8u/compare/c2d68ead...e55aa4f7 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=47&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=47&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/47/files Stats: 12470 lines in 56 files changed: 10820 ins; 555 del; 1095 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/47.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/47/head:pull/47 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/47 From andrew at openjdk.org Mon Jun 16 22:45:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 22:45:50 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 24 new changesets Message-ID: <1271d5dc-b76c-4679-887d-e624996ff03f@openjdk.org> Changeset: 3d1fc4bf Branch: master Author: Andrew John Hughes Date: 2023-03-03 18:04:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3d1fc4bf31e7b4bc7f3d0627f7aee44fe48d414c 8303462: Bump update version of OpenJDK: 8u382 Reviewed-by: sgehwolf ! .jcheck/conf ! common/autoconf/version-numbers Changeset: eb2aee68 Branch: master Author: Dongbo He Committer: Roland Westrelin Date: 2023-03-06 14:56:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/eb2aee68eaff5d4880b52bc8c01967215dd6a741 8185736: missing default exception handler in calls to rethrow_Stub Reviewed-by: roland Backport-of: b97f668af3f55c0d67cdd7a4a191bd81cdc4aa78 ! hotspot/src/share/vm/opto/doCall.cpp ! hotspot/src/share/vm/opto/output.cpp Changeset: 7c5d77cb Branch: master Author: Andrew John Hughes Date: 2023-03-08 02:58:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7c5d77cbd2cf993643d48ded46342e01772a96cc Merge Changeset: a7fb08c2 Branch: master Author: Zdenek Zambersky Date: 2023-03-14 18:32:07 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a7fb08c286f0181a3bb725b88a7da8c651202be0 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation Backport-of: 80615a6f39bf8929908804ce3f9f5c6d4b3f2864 ! jdk/src/share/classes/sun/security/pkcs11/P11PSSSignature.java Changeset: d6f81510 Branch: master Author: Zdenek Zambersky Date: 2023-03-14 18:32:53 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d6f8151053f40ccd8c23b9f9eecb40c306a6253f 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary Backport-of: e80528bf2bd1c87fc1394dd32015281ac6652363 ! jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: ad41d908 Branch: master Author: Zdenek Zambersky Date: 2023-03-21 11:31:16 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ad41d908eb4655782eb85272d28ccad80fa648eb 8293232: Fix race condition in pkcs11 SessionManager Backport-of: 939741c0a0a4a5ce2c68d14b15e1f42563bc653d ! jdk/src/share/classes/sun/security/pkcs11/SessionManager.java Changeset: ae6405fe Branch: master Author: Zdenek Zambersky Date: 2023-03-21 11:31:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ae6405fe642c8b5092c82ed22b41a281f49961b5 8289301: P11Cipher should not throw out of bounds exception during padding Reviewed-by: phh Backport-of: 7d8991978bbe1cc03ba2386f5e699239ba47934c ! jdk/src/share/classes/sun/security/pkcs11/P11Cipher.java + jdk/test/sun/security/pkcs11/Cipher/TestPaddingOOB.java Changeset: de0e5a2d Branch: master Author: Zdenek Zambersky Date: 2023-03-21 11:32:39 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/de0e5a2dcb61d3827e38e56655f5263813bfcc0f 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode Reviewed-by: phh, sgehwolf Backport-of: 24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 ! hotspot/test/TEST.ROOT ! hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java ! hotspot/test/runtime/NMT/HugeArenaTracking.java ! hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java + test/jtreg-ext/requires/VMProps.java Changeset: ca1c3b1e Branch: master Author: Ravali Yatham Committer: Paul Hohensee Date: 2023-03-27 14:49:05 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ca1c3b1efd8fbe0716e2e6e3b287856299e9ceef 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Reviewed-by: phh Backport-of: 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae ! jdk/src/share/classes/java/lang/reflect/Proxy.java Changeset: 5dc33f2c Branch: master Author: Stewart X Addison Committer: Severin Gehwolf Date: 2023-03-27 15:49:33 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5dc33f2c9c4de56b76ee56a3526c2fa21394aea2 8295530: Update Zlib Data Compression Library to Version 1.2.13 Reviewed-by: andrew, sgehwolf Backport-of: 6042c6b9bbacbff1bd47f087f0f19646a20eef97 ! THIRD_PARTY_README ! jdk/src/share/native/java/util/zip/zlib/README ! jdk/src/share/native/java/util/zip/zlib/compress.c ! jdk/src/share/native/java/util/zip/zlib/crc32.h ! jdk/src/share/native/java/util/zip/zlib/deflate.c ! jdk/src/share/native/java/util/zip/zlib/deflate.h ! jdk/src/share/native/java/util/zip/zlib/gzguts.h ! jdk/src/share/native/java/util/zip/zlib/gzlib.c ! jdk/src/share/native/java/util/zip/zlib/gzread.c ! jdk/src/share/native/java/util/zip/zlib/gzwrite.c ! jdk/src/share/native/java/util/zip/zlib/infback.c ! jdk/src/share/native/java/util/zip/zlib/inffast.c ! jdk/src/share/native/java/util/zip/zlib/inflate.c ! jdk/src/share/native/java/util/zip/zlib/inflate.h ! jdk/src/share/native/java/util/zip/zlib/inftrees.c ! jdk/src/share/native/java/util/zip/zlib/inftrees.h ! jdk/src/share/native/java/util/zip/zlib/patches/ChangeLog_java ! jdk/src/share/native/java/util/zip/zlib/trees.c ! jdk/src/share/native/java/util/zip/zlib/uncompr.c ! jdk/src/share/native/java/util/zip/zlib/zconf.h ! jdk/src/share/native/java/util/zip/zlib/zcrc32.c ! jdk/src/share/native/java/util/zip/zlib/zlib.h ! jdk/src/share/native/java/util/zip/zlib/zutil.c ! jdk/src/share/native/java/util/zip/zlib/zutil.h Changeset: cd40350f Branch: master Author: Andrew John Hughes Date: 2023-03-28 18:24:15 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/cd40350f0e69faf4d9a4658408798eb6e389f573 Merge Reviewed-by: sgehwolf Changeset: d41618f3 Branch: master Author: Alexey Bakhtin Date: 2023-04-04 10:29:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/d41618f34f1d2f5416ec3c035f33dcb15cf5ab99 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key Reviewed-by: andrew, mbalao Backport-of: f6232982b91cb2314e96ddbde3984836a810a556 ! jdk/src/share/classes/sun/security/rsa/RSAPSSSignature.java ! jdk/src/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java Changeset: 1ee22a75 Branch: master Author: Andrew John Hughes Date: 2023-04-04 16:16:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1ee22a7584b79ca66e5dffa1276d55e385eb1909 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert Reviewed-by: sgehwolf Backport-of: 0d0aa7ce8116db959836d59477598a8427a4c16f ! jdk/test/security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java Changeset: f1c1f969 Branch: master Author: Severin Gehwolf Date: 2023-04-07 18:11:14 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f1c1f969a77c9841cf87b2434fa90dcf4002c6be 8278851: Correct signer logic for jars signed with multiple digest algorithms Reviewed-by: mbalao, andrew Backport-of: cbe497394786ff76a09f9743040e3ba96ee8298f ! jdk/src/share/classes/java/util/jar/JarVerifier.java ! jdk/src/share/classes/sun/security/util/ManifestEntryVerifier.java + jdk/test/sun/security/tools/jarsigner/disdigest/JarWithOneNonDisabledDigestAlg.java Changeset: 4445e5cc Branch: master Author: Paul Hohensee Date: 2023-04-13 18:24:54 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4445e5ccc86212c167a3af66ed6c4e6389905bef 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec Reviewed-by: simonis, mbalao, andrew Backport-of: a5d7de235101696463dba22792703c6809ff7fc4 ! jdk/src/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java ! jdk/src/share/classes/sun/security/rsa/RSAKeyFactory.java ! jdk/test/java/security/KeyFactory/KeyFactoryGetKeySpecForInvalidSpec.java + jdk/test/sun/security/pkcs11/nss/p11-nss-sensitive.txt + jdk/test/sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec.java Changeset: 721c0ee3 Branch: master Author: Victor Rudometov Committer: Paul Hohensee Date: 2023-04-17 15:47:04 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/721c0ee3d790b7dfbaa7b1018e4921a1d4751fd2 8305113: (tz) Update Timezone Data to 2023c Reviewed-by: andrew Backport-of: ed9592c6e81f82e2bf6508ce45ba15aad8232181 ! jdk/make/data/tzdata/VERSION ! jdk/make/data/tzdata/africa ! jdk/make/data/tzdata/antarctica ! jdk/make/data/tzdata/asia ! jdk/make/data/tzdata/australasia ! jdk/make/data/tzdata/backward ! jdk/make/data/tzdata/europe ! jdk/make/data/tzdata/iso3166.tab ! jdk/make/data/tzdata/leapseconds ! jdk/make/data/tzdata/northamerica ! jdk/make/data/tzdata/southamerica ! jdk/make/data/tzdata/zone.tab ! jdk/src/share/classes/sun/util/calendar/ZoneInfoFile.java ! jdk/test/java/util/TimeZone/TimeZoneData/VERSION ! jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt ! jdk/test/java/util/TimeZone/TimeZoneData/displaynames.txt ! jdk/test/java/util/TimeZone/TimeZoneTest.java ! jdk/test/sun/util/calendar/zi/tzdata/VERSION ! jdk/test/sun/util/calendar/zi/tzdata/africa ! jdk/test/sun/util/calendar/zi/tzdata/antarctica ! jdk/test/sun/util/calendar/zi/tzdata/asia ! jdk/test/sun/util/calendar/zi/tzdata/australasia ! jdk/test/sun/util/calendar/zi/tzdata/backward ! jdk/test/sun/util/calendar/zi/tzdata/europe ! jdk/test/sun/util/calendar/zi/tzdata/iso3166.tab ! jdk/test/sun/util/calendar/zi/tzdata/leapseconds ! jdk/test/sun/util/calendar/zi/tzdata/northamerica ! jdk/test/sun/util/calendar/zi/tzdata/southamerica ! jdk/test/sun/util/calendar/zi/tzdata/zone.tab Changeset: 43561ef4 Branch: master Author: Thomas Stuefe Date: 2023-04-19 11:37:40 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/43561ef435feae8d71913201dbb5e5503e1fc6f3 8151460: Metaspace counters can have inconsistent values Reviewed-by: phh, sgehwolf Backport-of: d30aeec30c3832b2514a6f06451897afdaf52fb3 ! hotspot/test/gc/metaspace/TestMetaspacePerfCounters.java ! hotspot/test/gc/metaspace/TestPerfCountersAndMemoryPools.java Changeset: b94b5684 Branch: master Author: Dan Lutker Committer: Paul Hohensee Date: 2023-04-19 16:43:36 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/b94b5684dcc98e880ab3ef5c343946b95ddf2702 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode Backport-of: 9d99a377bfb6ffa890db049aee575e97914fc2a1 ! jdk/src/share/classes/sun/security/ssl/ClientHello.java ! jdk/src/share/classes/sun/security/ssl/SSLConfiguration.java ! jdk/test/javax/net/ssl/SSLSession/ResumeTLS13withSNI.java Changeset: cfc654b0 Branch: master Author: Sergey Bylokhov Date: 2023-04-19 22:13:45 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/cfc654b01421b13dc6fe42783e6ae137e8b9e404 8215105: java/awt/Robot/HiDPIScreenCapture/ScreenCaptureTest.java: Wrong Pixel Color Reviewed-by: phh Backport-of: 5bffde3d4ff623283e342d902439b3ca5ebe81f5 ! jdk/src/macosx/native/sun/awt/CRobot.m + jdk/test/java/awt/Robot/CheckCommonColors/CheckCommonColors.java Changeset: 644e79d9 Branch: master Author: Alexander Scherbatiy Date: 2023-04-20 12:34:32 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/644e79d9440ea7ba08f25b762d3d739e511c8f40 8276841: Add support for Visual Studio 2022 Reviewed-by: sgehwolf Backport-of: 0ba5a81e7c0117855665a28a43f9589635e94222 ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 0e018191 Branch: master Author: Alexander Scherbatiy Date: 2023-04-20 12:42:38 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0e018191eb40beedfd8bdf70e6f1854e733dcb17 8282345: handle latest VS2022 in abstract_vm_version Reviewed-by: sgehwolf Backport-of: 1d9108f4f7d07e1be916bd0595ff4262c4e835c5 ! hotspot/src/share/vm/runtime/vm_version.cpp Changeset: 7878655e Branch: master Author: Andrew John Hughes Date: 2023-04-20 20:52:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/7878655eb64403ba7e84d1afe80cd8c00459535e Merge ! jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java ! jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 3147b1ba Branch: master Author: Joshua Zhu Committer: Paul Hohensee Date: 2023-04-25 19:51:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3147b1bafe12326a97269655de46f066931f3ee4 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue Reviewed-by: phh ! hotspot/src/share/vm/runtime/thread.hpp Changeset: e55aa4f7 Branch: master Author: Andrew John Hughes Date: 2025-06-16 20:13:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e55aa4f73f133627d05368ac52dd7e8a40c0f554 Merge jdk8u382-b01 Added tag jdk8u382-b01 for changeset 3147b1bafe1 ! .jcheck/conf ! THIRD_PARTY_README ! hotspot/src/share/vm/runtime/thread.hpp ! hotspot/test/gc/metaspace/TestMetaspacePerfCounters.java ! .jcheck/conf ! THIRD_PARTY_README ! hotspot/src/share/vm/runtime/thread.hpp ! hotspot/test/gc/metaspace/TestMetaspacePerfCounters.java From andrew at openjdk.org Mon Jun 16 22:46:05 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 22:46:05 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u382-b01 for changeset 3147b1ba Message-ID: Tagged by: Andrew John Hughes Date: 2023-04-29 21:04:03 +0000 Added tag jdk8u382-b01 for changeset 3147b1bafe1 Changeset: 3147b1ba Author: Joshua Zhu Committer: Paul Hohensee Date: 2023-04-25 19:51:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3147b1bafe12326a97269655de46f066931f3ee4 From andrew at openjdk.org Mon Jun 16 22:46:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 22:46:18 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u382-b01 for changeset e55aa4f7 Message-ID: <85da559f-709a-455a-90c6-39476e0964dd@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-16 22:44:04 +0000 Added tag shenandoah8u382-b01 for changeset e55aa4f73f1 Changeset: e55aa4f7 Author: Andrew John Hughes Date: 2025-06-16 20:13:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e55aa4f73f133627d05368ac52dd7e8a40c0f554 From andrew at openjdk.org Mon Jun 16 22:47:08 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 16 Jun 2025 22:47:08 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: <8QGJ4uHncrOw8kiROQLJR-eHoJSjOxn8jXU22GqoMzg=.78399e84-639c-46b9-a82c-1aaaeecf3a9a@github.com> References: <8QGJ4uHncrOw8kiROQLJR-eHoJSjOxn8jXU22GqoMzg=.78399e84-639c-46b9-a82c-1aaaeecf3a9a@github.com> Message-ID: > Merge jdk8u382-b01 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/47/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/47/files/e55aa4f7..e55aa4f7 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=47&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=47&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/47.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/47/head:pull/47 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/47 From iris at openjdk.org Mon Jun 16 22:47:08 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 16 Jun 2025 22:47:08 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: <8QGJ4uHncrOw8kiROQLJR-eHoJSjOxn8jXU22GqoMzg=.78399e84-639c-46b9-a82c-1aaaeecf3a9a@github.com> References: <8QGJ4uHncrOw8kiROQLJR-eHoJSjOxn8jXU22GqoMzg=.78399e84-639c-46b9-a82c-1aaaeecf3a9a@github.com> Message-ID: <6Hkbr4wGWND6LeHE8She0ky3OU1IYpAIuu2CDh5Z5OY=.2c76f8ed-d3a6-4f8d-8c07-32d064232808@github.com> On Mon, 16 Jun 2025 21:45:54 GMT, Andrew John Hughes wrote: > Merge jdk8u382-b01 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/47 From dlong at openjdk.org Mon Jun 16 23:34:43 2025 From: dlong at openjdk.org (Dean Long) Date: Mon, 16 Jun 2025 23:34:43 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v5] In-Reply-To: References: Message-ID: > This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. > > We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. > > The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. > > For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. > > This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. Dean Long has updated the pull request incrementally with one additional commit since the last revision: s390 fix courtesy of Amit Kumar ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25764/files - new: https://git.openjdk.org/jdk/pull/25764/files/c1ebde09..a7d784b2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=03-04 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From dlong at openjdk.org Mon Jun 16 23:34:43 2025 From: dlong at openjdk.org (Dean Long) Date: Mon, 16 Jun 2025 23:34:43 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 15:04:23 GMT, Amit Kumar wrote: >> Just FYI, s390 build is broken with this change: >> >> >> # >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error (/home/amit/jdk/src/hotspot/share/gc/shared/barrierSetNMethod.cpp:196), pid=1779086, tid=1779117 >> # assert(!nm->is_osr_method() || may_enter) failed: OSR nmethods should always be entrant after migration >> # >> # JRE version: OpenJDK Runtime Environment (26.0) (fastdebug build 26-internal-adhoc.amit.jdk) >> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 26-internal-adhoc.amit.jdk, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-s390x) >> # Problematic frame: >> # V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e >> # >> # Core dump will be written. Default location: Core dumps may be processed with "/lib/systemd/systemd-coredump %P %u %g %s %t 9223372036854775808 %h %d" (or dumping to /home/amit/jdk/make/core.1779086) >> # >> # If you would like to submit a bug report, please visit: >> # https://bugreport.java.com/bugreport/crash.jsp >> # >> >> >> stack trace: >> >> Stack: [0x000003ff9e580000,0x000003ff9e680000], sp=0x000003ff9e67b068, free space=1004k >> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) >> V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e (barrierSetNMethod.cpp:196) >> v ~StubRoutines::method_entry_barrier 0x000003ff9050cd18 >> J 282% c2 sun.nio.fs.UnixPath.initOffsets()V java.base (189 bytes) @ 0x000003ff90c4f0c8 [0x000003ff90c4f080+0x0000000000000048] >> j sun.nio.fs.UnixPath.getFileName()Lsun/nio/fs/UnixPath;+1 java.base >> j sun.nio.fs.UnixFileSystemProvider.isHidden(Ljava/nio/file/Path;)Z+6 java.base >> j java.nio.file.Files.isHidden(Ljava/nio/file/Path;)Z+5 java.base >> j jdk.internal.module.ModulePath.isHidden(Ljava/nio/file/Path;)Z+1 java.base >> j jdk.internal.module.ModulePath.lambda$explodedPackages$0(Ljava/nio/file/Path;Ljava/nio/file/attribute/BasicFileAttributes;)Z+11 java.base >> j jdk.internal.module.ModulePath$$Lambda+0x00000000a105cbe0.test(Ljava/lang/Object;Ljava/lang/Object;)Z+12 java.base >> j java.nio.file.Files.lambda$find$0(Ljava/util/function/BiPredicate;Ljava/nio/file/FileTreeWalker$Event;)Z+9 java.base >> j java.nio.file.Files$$Lambda+0x00000000a10646c0.test(Ljava/lang/Object;)Z+8 java.base >> .... > >> @offamitkumar: The problem is probably the initialization to -1: [`z_cfi(Z_R0_scratch, /* to be patched */ -1);`.](https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp#L183) Should be 0. > > Thank you Martin for the suggestion. > > @dean-long would you please add this diff, fixing s390x build. I ran tier1 test with fastdebug, test are clean; > > > diff --git a/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp b/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp > index e78906708af..2d663061aec 100644 > --- a/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp > +++ b/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp > @@ -180,7 +180,7 @@ void BarrierSetAssembler::nmethod_entry_barrier(MacroAssembler* masm) { > __ z_lg(Z_R0_scratch, in_bytes(bs_nm->thread_disarmed_guard_value_offset()), Z_thread); // 6 bytes > > // Compare to current patched value: > - __ z_cfi(Z_R0_scratch, /* to be patched */ -1); // 6 bytes (2 + 4 byte imm val) > + __ z_cfi(Z_R0_scratch, /* to be patched */ 0); // 6 bytes (2 + 4 byte imm val) > > // Conditional Jump > __ z_larl(Z_R14, (Assembler::instr_len((unsigned long)LARL_ZOPC) + Assembler::instr_len((unsigned long)BCR_ZOPC)) / 2); // 6 bytes > diff --git a/src/hotspot/cpu/s390/stubGenerator_s390.cpp b/src/hotspot/cpu/s390/stubGenerator_s390.cpp > index d3f6540a3ea..bb1d9ce6037 100644 > --- a/src/hotspot/cpu/s390/stubGenerator_s390.cpp > +++ b/src/hotspot/cpu/s390/stubGenerator_s390.cpp > @@ -3197,7 +3197,7 @@ class StubGenerator: public StubCodeGenerator { > > // VM-Call: BarrierSetNMethod::nmethod_stub_entry_barrier(address* return_address_ptr) > __ call_VM_leaf(CAST_FROM_FN_PTR(address, BarrierSetNMethod::nmethod_stub_entry_barrier)); > - __ z_ltr(Z_R0_scratch, Z_RET); > + __ z_ltr(Z_RET, Z_RET); > > // VM-Call Epilogue > __ restore_volatile_regs(Z_SP, frame::z_abi_160_size, true, false); Thanks @offamitkumar. Could you explain the `__ z_ltr(Z_R0_scratch, Z_RET);` change, for my curiosity? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2978470825 From dlong at openjdk.org Mon Jun 16 23:39:08 2025 From: dlong at openjdk.org (Dean Long) Date: Mon, 16 Jun 2025 23:39:08 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v6] In-Reply-To: References: Message-ID: > This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. > > We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. > > The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. > > For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. > > This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. Dean Long has updated the pull request incrementally with one additional commit since the last revision: arm32 fix ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25764/files - new: https://git.openjdk.org/jdk/pull/25764/files/a7d784b2..c98f3864 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From dlong at openjdk.org Mon Jun 16 23:39:08 2025 From: dlong at openjdk.org (Dean Long) Date: Mon, 16 Jun 2025 23:39:08 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: <-qfpN8-hyWv-QosNnOUvLaZtsI0Kr1vXsTIV6Tqvd-w=.badb50d8-3f05-41d1-bc90-d5939d6b571f@github.com> On Mon, 16 Jun 2025 13:56:30 GMT, Martin Doerr wrote: > Seems like arm32 has the same issue: > > https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/arm/gc/shared/barrierSetAssembler_arm.cpp#L199 > > The init value shouldn't have the sticky bit set. Thanks, I pushed a potential fix for that. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2978476161 From dlong at openjdk.org Mon Jun 16 23:45:57 2025 From: dlong at openjdk.org (Dean Long) Date: Mon, 16 Jun 2025 23:45:57 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v7] In-Reply-To: References: Message-ID: > This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. > > We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. > > The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. > > For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. > > This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. Dean Long has updated the pull request incrementally with one additional commit since the last revision: rename arm_with to guard_with ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25764/files - new: https://git.openjdk.org/jdk/pull/25764/files/c98f3864..3ac6dec0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=05-06 Stats: 9 lines in 6 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From dlong at openjdk.org Mon Jun 16 23:45:57 2025 From: dlong at openjdk.org (Dean Long) Date: Mon, 16 Jun 2025 23:45:57 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 00:48:40 GMT, Erik ?sterlund wrote: >> Dean Long has updated the pull request incrementally with one additional commit since the last revision: >> >> remove is_sigill_not_entrant > > src/hotspot/share/gc/z/zBarrierSetNMethod.cpp line 109: > >> 107: } >> 108: >> 109: void ZBarrierSetNMethod::arm_with(nmethod* nm, int value) { > > I don't usually comment on names, but could we call this guard_with instead? We tried to stop saying "arm" about things used also for disarming and we have (hopefully) been consistent about calling that "guard" instead. Good suggestion. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2151070290 From dlong at openjdk.org Tue Jun 17 00:05:30 2025 From: dlong at openjdk.org (Dean Long) Date: Tue, 17 Jun 2025 00:05:30 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Mon, 16 Jun 2025 00:54:48 GMT, Erik ?sterlund wrote: >> Dean Long has updated the pull request incrementally with one additional commit since the last revision: >> >> remove is_sigill_not_entrant > > src/hotspot/share/gc/z/zBarrierSetNMethod.cpp line 114: > >> 112: // Preserve the sticky bit >> 113: if (is_not_entrant(nm)) { >> 114: value |= not_entrant; > > Is it possible to have a race where another thread sets an nmethod to not entrant and the thread calling this making the nmethod entry barrier not entrant? > > If this was called to disarm a method and then enter it, it seems a bit sneaky in that case that we pass the nmethod entry barrier even though we under the lock see that it is not entrant. Probably okay but still feels like it might be more robust if the thread setting an nmethod to not entrant is always the one that arms the nmethod entry barrier. If I understand your concern correctly, there is no race. The only caller of BarrierSetNMethod::make_not_entrant() is nmethod::make_not_entrant(), and it is done inside a NMethodState_lock critical section. After a call to nmethod::make_not_entrant(), the nmethod entry barrier is armed and stays that way. And by design, a disarm only disarms at the inner nmethod_entry_barrier level, not the outer nmethod_stub_entry_barrier level. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2151084557 From dlong at openjdk.org Tue Jun 17 00:13:30 2025 From: dlong at openjdk.org (Dean Long) Date: Tue, 17 Jun 2025 00:13:30 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: <0-Re4fyQGaSyOl-bYm1h9LT5a0TKKrgJCHquooXOIkQ=.d6044248-6188-4705-b564-90fa3d2d7762@github.com> References: <0-Re4fyQGaSyOl-bYm1h9LT5a0TKKrgJCHquooXOIkQ=.d6044248-6188-4705-b564-90fa3d2d7762@github.com> Message-ID: On Sat, 14 Jun 2025 09:23:33 GMT, Martin Doerr wrote: > Tests look good on our side. I'm only a bit concerned that the lock may become a bottleneck when many Java threads need to patch all nmethods. Especially with ZGC which does that more often. I think we should check performance. For ZGC I am using a per-nmethod lock: ZLocker locker(ZNMethod::lock_for_nmethod(nm)); I don't know what benchmarks to run to check the performance for functions like Deoptimization::deoptimize_all_marked, so I welcome any help with this. One possible optimization that might help is skipping the lock if the make_not_entrant call is done during a safepoint. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2978525224 From ysr at openjdk.org Tue Jun 17 00:15:27 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Tue, 17 Jun 2025 00:15:27 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 22:10:12 GMT, William Kemper wrote: >> Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. > > William Kemper has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Consolidate read table cleaning" > > This reverts commit 9552021cbeec699e7b04db81fa68819c23b7dab7. Reviewed and approved; see previous comment. ? @earthling-amzn : > Genshen does not clean the read table at the end of a concurrent cycle (we could do this, but we'd still need to do the same in a degenerated cycle). Yes, and I am suggesting we do that to clean up and consolidate the cleaning along multiple paths into the same method that is invoked at an identical point in the Collector's state machine, irrespective of whether we arrived at that state via a concurrent collection or a degeneration. > The complexity comes from swapping the card tables in a concurrent cycle. We must not let a subsequent degenerated cycle swap them a second time. The degenerated cycle can only clean the read table if there was no active concurrent cycle (lest it throw away critical remembered set data). The swapping must happen at the start of the marking cycle. In similar fashion, the state of the Collector's state machine should indicate if the swap has already been done in this cycle or not. The specifics of wheher the swap was done by a degenerate or concurrent collection should then not matter? > However, the degenerated cycle must also clear the mark bitmaps if the concurrent cycle degenerated during the root scan (the degenerated cycle will rescan the roots). Of course, we cannot clear the mark bitmaps if the concurrent cycle degenerated during the mark phase. So, for the degenerated cycle, clearing the mark bitmaps and cleaning the read table need to happen in two different cases and it doesn't work if they're combined into the same method (and I don't think adding a method parameter to sometimes clear the mark bitmap and sometimes the read table will make the code any easier to understand). That's OK, they can be in two different methods, with the clearing of the marking bitmap done in one case and not in the other based on when the degeeration occurred. I think may be we don't have sufficiently refined Collector state machine at the moment which may be part of the problem here. That having been said, I can understand that: > The refactoring you suggest is not so simple, alas. In particular, if our eventual future plan is to do away with degeneration as we know it today, then the refactoring to achieve the clean up I suggest may be moot. With that in mind, I am going to approve the changes in their current form as they look right if somewhat difficult to maintain and prove the correctness of. (The more refined state machine approach would likely make it easier, but will be moot once degeneration is eliminated in the future.) ------------- Marked as reviewed by ysr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25735#pullrequestreview-2933812072 PR Comment: https://git.openjdk.org/jdk/pull/25735#issuecomment-2978526794 From amitkumar at openjdk.org Tue Jun 17 03:46:33 2025 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 17 Jun 2025 03:46:33 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: <-0Y5IM8MHOmPZpTHRGKK5hnBLA5TyRV871YLJ1XnSAI=.027d1976-faf5-40f7-a7d0-fa05d6b986b4@github.com> On Mon, 16 Jun 2025 15:04:23 GMT, Amit Kumar wrote: >> Just FYI, s390 build is broken with this change: >> >> >> # >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error (/home/amit/jdk/src/hotspot/share/gc/shared/barrierSetNMethod.cpp:196), pid=1779086, tid=1779117 >> # assert(!nm->is_osr_method() || may_enter) failed: OSR nmethods should always be entrant after migration >> # >> # JRE version: OpenJDK Runtime Environment (26.0) (fastdebug build 26-internal-adhoc.amit.jdk) >> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 26-internal-adhoc.amit.jdk, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-s390x) >> # Problematic frame: >> # V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e >> # >> # Core dump will be written. Default location: Core dumps may be processed with "/lib/systemd/systemd-coredump %P %u %g %s %t 9223372036854775808 %h %d" (or dumping to /home/amit/jdk/make/core.1779086) >> # >> # If you would like to submit a bug report, please visit: >> # https://bugreport.java.com/bugreport/crash.jsp >> # >> >> >> stack trace: >> >> Stack: [0x000003ff9e580000,0x000003ff9e680000], sp=0x000003ff9e67b068, free space=1004k >> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) >> V [libjvm.so+0x40b196] BarrierSetNMethod::nmethod_stub_entry_barrier(unsigned char**)+0x15e (barrierSetNMethod.cpp:196) >> v ~StubRoutines::method_entry_barrier 0x000003ff9050cd18 >> J 282% c2 sun.nio.fs.UnixPath.initOffsets()V java.base (189 bytes) @ 0x000003ff90c4f0c8 [0x000003ff90c4f080+0x0000000000000048] >> j sun.nio.fs.UnixPath.getFileName()Lsun/nio/fs/UnixPath;+1 java.base >> j sun.nio.fs.UnixFileSystemProvider.isHidden(Ljava/nio/file/Path;)Z+6 java.base >> j java.nio.file.Files.isHidden(Ljava/nio/file/Path;)Z+5 java.base >> j jdk.internal.module.ModulePath.isHidden(Ljava/nio/file/Path;)Z+1 java.base >> j jdk.internal.module.ModulePath.lambda$explodedPackages$0(Ljava/nio/file/Path;Ljava/nio/file/attribute/BasicFileAttributes;)Z+11 java.base >> j jdk.internal.module.ModulePath$$Lambda+0x00000000a105cbe0.test(Ljava/lang/Object;Ljava/lang/Object;)Z+12 java.base >> j java.nio.file.Files.lambda$find$0(Ljava/util/function/BiPredicate;Ljava/nio/file/FileTreeWalker$Event;)Z+9 java.base >> j java.nio.file.Files$$Lambda+0x00000000a10646c0.test(Ljava/lang/Object;)Z+8 java.base >> .... > >> @offamitkumar: The problem is probably the initialization to -1: [`z_cfi(Z_R0_scratch, /* to be patched */ -1);`.](https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp#L183) Should be 0. > > Thank you Martin for the suggestion. > > @dean-long would you please add this diff, fixing s390x build. I ran tier1 test with fastdebug, test are clean; > > > diff --git a/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp b/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp > index e78906708af..2d663061aec 100644 > --- a/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp > +++ b/src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp > @@ -180,7 +180,7 @@ void BarrierSetAssembler::nmethod_entry_barrier(MacroAssembler* masm) { > __ z_lg(Z_R0_scratch, in_bytes(bs_nm->thread_disarmed_guard_value_offset()), Z_thread); // 6 bytes > > // Compare to current patched value: > - __ z_cfi(Z_R0_scratch, /* to be patched */ -1); // 6 bytes (2 + 4 byte imm val) > + __ z_cfi(Z_R0_scratch, /* to be patched */ 0); // 6 bytes (2 + 4 byte imm val) > > // Conditional Jump > __ z_larl(Z_R14, (Assembler::instr_len((unsigned long)LARL_ZOPC) + Assembler::instr_len((unsigned long)BCR_ZOPC)) / 2); // 6 bytes > diff --git a/src/hotspot/cpu/s390/stubGenerator_s390.cpp b/src/hotspot/cpu/s390/stubGenerator_s390.cpp > index d3f6540a3ea..bb1d9ce6037 100644 > --- a/src/hotspot/cpu/s390/stubGenerator_s390.cpp > +++ b/src/hotspot/cpu/s390/stubGenerator_s390.cpp > @@ -3197,7 +3197,7 @@ class StubGenerator: public StubCodeGenerator { > > // VM-Call: BarrierSetNMethod::nmethod_stub_entry_barrier(address* return_address_ptr) > __ call_VM_leaf(CAST_FROM_FN_PTR(address, BarrierSetNMethod::nmethod_stub_entry_barrier)); > - __ z_ltr(Z_R0_scratch, Z_RET); > + __ z_ltr(Z_RET, Z_RET); > > // VM-Call Epilogue > __ restore_volatile_regs(Z_SP, frame::z_abi_160_size, true, false); > Thanks @offamitkumar. Could you explain the `__ z_ltr(Z_R0_scratch, Z_RET);` change, for my curiosity? Thanks. `ltr` instruction stands for "load and test" (32 bit). Initially we were loading the value from `Z_RET` to `Z_R0_scratch` and then it will be compared against 0. But in this case there is no requirement of loading the value in Z_R0, as it's not being used further. So we can load the value again in `Z_RET` and the compare it against 0. There is nothing wrong in previous solution, it's just killing Z_R0 for nothing. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2978824615 From roland at openjdk.org Tue Jun 17 07:52:16 2025 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 17 Jun 2025 07:52:16 GMT Subject: [jdk25] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe Message-ID: Hi all, This pull request contains a backport of commit [1fcede05](https://github.com/openjdk/jdk/commit/1fcede053cca360c96606c1034b2a365a4fada82) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Roland Westrelin on 12 Jun 2025 and was reviewed by William Kemper and Aleksey Shipilev. Backport applies cleanly. Thanks! ------------- Commit messages: - Backport 1fcede053cca360c96606c1034b2a365a4fada82 Changes: https://git.openjdk.org/jdk/pull/25845/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25845&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358334 Stats: 153 lines in 3 files changed: 117 ins; 26 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/25845.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25845/head:pull/25845 PR: https://git.openjdk.org/jdk/pull/25845 From thartmann at openjdk.org Tue Jun 17 08:10:36 2025 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 17 Jun 2025 08:10:36 GMT Subject: [jdk25] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: <6UlV04v4D-z9ERdvYjIR2h-hXICqfmUWuGX9UN6dIT8=.c1328dc8-66f1-4499-9f92-70a6e5efc305@github.com> On Tue, 17 Jun 2025 07:46:38 GMT, Roland Westrelin wrote: > Hi all, > > This pull request contains a backport of commit [1fcede05](https://github.com/openjdk/jdk/commit/1fcede053cca360c96606c1034b2a365a4fada82) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Roland Westrelin on 12 Jun 2025 and was reviewed by William Kemper and Aleksey Shipilev. > > Backport applies cleanly. > > Thanks! Looks good. ------------- Marked as reviewed by thartmann (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25845#pullrequestreview-2934573108 From roland at openjdk.org Tue Jun 17 08:10:36 2025 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 17 Jun 2025 08:10:36 GMT Subject: [jdk25] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: <6UlV04v4D-z9ERdvYjIR2h-hXICqfmUWuGX9UN6dIT8=.c1328dc8-66f1-4499-9f92-70a6e5efc305@github.com> References: <6UlV04v4D-z9ERdvYjIR2h-hXICqfmUWuGX9UN6dIT8=.c1328dc8-66f1-4499-9f92-70a6e5efc305@github.com> Message-ID: On Tue, 17 Jun 2025 08:04:55 GMT, Tobias Hartmann wrote: >> Hi all, >> >> This pull request contains a backport of commit [1fcede05](https://github.com/openjdk/jdk/commit/1fcede053cca360c96606c1034b2a365a4fada82) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Roland Westrelin on 12 Jun 2025 and was reviewed by William Kemper and Aleksey Shipilev. >> >> Backport applies cleanly. >> >> Thanks! > > Looks good. @TobiHartmann thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25845#issuecomment-2979354555 From roland at openjdk.org Tue Jun 17 08:10:37 2025 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 17 Jun 2025 08:10:37 GMT Subject: [jdk25] Integrated: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: <99u6nre3LDFGl1DSuXcnu0e17tg6WZmkZGhM5eB504c=.1db042da-6ec6-4726-a0ef-502e7716bc11@github.com> On Tue, 17 Jun 2025 07:46:38 GMT, Roland Westrelin wrote: > Hi all, > > This pull request contains a backport of commit [1fcede05](https://github.com/openjdk/jdk/commit/1fcede053cca360c96606c1034b2a365a4fada82) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Roland Westrelin on 12 Jun 2025 and was reviewed by William Kemper and Aleksey Shipilev. > > Backport applies cleanly. > > Thanks! This pull request has now been integrated. Changeset: 46cfc1e1 Author: Roland Westrelin URL: https://git.openjdk.org/jdk/commit/46cfc1e1940ff6b91c4f0cb0a9161fd0aef37c38 Stats: 153 lines in 3 files changed: 117 ins; 26 del; 10 mod 8358334: C2/Shenandoah: incorrect execution with Unsafe Reviewed-by: thartmann Backport-of: 1fcede053cca360c96606c1034b2a365a4fada82 ------------- PR: https://git.openjdk.org/jdk/pull/25845 From sroy at openjdk.org Tue Jun 17 08:14:47 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 17 Jun 2025 08:14:47 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v3] In-Reply-To: References: Message-ID: > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). > > > > Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision: - update capacity only for Generation counter - Revert "update_capacity exists" This reverts commit cf2d66d598d90f1343d1ad7a4f30607c3374a0f8. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25833/files - new: https://git.openjdk.org/jdk/pull/25833/files/419f3d5f..59839a66 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=01-02 Stats: 42 lines in 15 files changed: 0 ins; 0 del; 42 mod Patch: https://git.openjdk.org/jdk/pull/25833.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833 PR: https://git.openjdk.org/jdk/pull/25833 From sroy at openjdk.org Tue Jun 17 08:28:09 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 17 Jun 2025 08:28:09 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v4] In-Reply-To: References: Message-ID: > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). > > > > Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: psOldGen ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25833/files - new: https://git.openjdk.org/jdk/pull/25833/files/59839a66..88c41602 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25833.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833 PR: https://git.openjdk.org/jdk/pull/25833 From ayang at openjdk.org Tue Jun 17 08:28:09 2025 From: ayang at openjdk.org (Albert Mingkun Yang) Date: Tue, 17 Jun 2025 08:28:09 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v3] In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 08:14:47 GMT, Suchismith Roy wrote: >> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) >> >> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). >> >> >> >> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. > > Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision: > > - update capacity only for Generation counter > - Revert "update_capacity exists" > > This reverts commit cf2d66d598d90f1343d1ad7a4f30607c3374a0f8. Thanks for the revision. I believe the one in `ZGenerationCounters` can be removed now. void update_capacity(size_t capacity) { update_all(capacity); } ------------- PR Comment: https://git.openjdk.org/jdk/pull/25833#issuecomment-2979417249 From sroy at openjdk.org Tue Jun 17 08:34:47 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 17 Jun 2025 08:34:47 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v5] In-Reply-To: References: Message-ID: <7pVHTK4sJLrs6GITxmgux8MmQ8CRuwky6t-1d1HRrTU=.7fdd3896-158b-4c19-9180-3a20cc3d1c96@github.com> > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). > > > > Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: update zgenerationcounter ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25833/files - new: https://git.openjdk.org/jdk/pull/25833/files/88c41602..bd26817c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=03-04 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25833.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833 PR: https://git.openjdk.org/jdk/pull/25833 From mdoerr at openjdk.org Tue Jun 17 12:52:34 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 17 Jun 2025 12:52:34 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: <-qfpN8-hyWv-QosNnOUvLaZtsI0Kr1vXsTIV6Tqvd-w=.badb50d8-3f05-41d1-bc90-d5939d6b571f@github.com> References: <-qfpN8-hyWv-QosNnOUvLaZtsI0Kr1vXsTIV6Tqvd-w=.badb50d8-3f05-41d1-bc90-d5939d6b571f@github.com> Message-ID: On Mon, 16 Jun 2025 23:35:43 GMT, Dean Long wrote: > > Seems like arm32 has the same issue: > > https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/arm/gc/shared/barrierSetAssembler_arm.cpp#L199 > > > > The init value shouldn't have the sticky bit set. > > Thanks, I pushed a potential fix for that. Unfortunately, 0xBEAFDEAD also has the MSB set. Shouldn't we better use 0 like on all other platforms? ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2980261201 From sroy at openjdk.org Tue Jun 17 14:59:01 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 17 Jun 2025 14:59:01 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v6] In-Reply-To: References: Message-ID: > JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) > > we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). > > > > Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: g1Monitoring ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25833/files - new: https://git.openjdk.org/jdk/pull/25833/files/bd26817c..7bb69a1d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25833&range=04-05 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/25833.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833 PR: https://git.openjdk.org/jdk/pull/25833 From andrew at openjdk.org Tue Jun 17 16:36:51 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 16:36:51 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u382-b02 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u382-b02 - 8307531: [aarch64] JDK8 single-step debugging is extremely slow - 8303028: Update system property for Java SE specification maintenance version - 8305681: Allow additional characters for GB18030-2022 (Level 2) support - 8301400: Allow additional characters for GB18030-2022 support The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/48/files Stats: 135 lines in 10 files changed: 58 ins; 14 del; 63 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/48.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/48/head:pull/48 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/48 From andrew at openjdk.org Tue Jun 17 16:45:10 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 16:45:10 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 5 new changesets Message-ID: <81aafa53-9b34-40ca-8801-0361f08ada7b@openjdk.org> Changeset: 9740c243 Branch: master Author: Naoto Sato Date: 2023-05-10 17:02:09 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/9740c2434fa39a6fac800e87160af659f718362c 8301400: Allow additional characters for GB18030-2022 support Co-authored-by: Justin Lu Reviewed-by: lancea, iris, rriggs Backport-of: a039f39ee8486e990a4b4341c9e07fc49d3dac2d ! jdk/make/data/characterdata/CharacterData00.java.template ! jdk/make/data/unicodedata/UnicodeData.txt ! jdk/src/share/classes/java/lang/Character.java ! jdk/test/java/lang/Character/Scripts.txt ! jdk/test/java/lang/Character/TestIsJavaIdentifierMethods.java Changeset: 3d9e8d05 Branch: master Author: Naoto Sato Date: 2023-05-10 17:15:52 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3d9e8d05e053613afea1f4493121b5975a37ab2a 8305681: Allow additional characters for GB18030-2022 (Level 2) support Co-authored-by: Justin Lu Reviewed-by: lancea, iris, rriggs Backport-of: b08cddec8625424b1292051088513a60606ef1e9 ! jdk/make/data/characterdata/CharacterData02.java.template ! jdk/make/data/unicodedata/UnicodeData.txt ! jdk/src/share/classes/java/lang/Character.java ! jdk/test/java/lang/Character/CheckScript.java ! jdk/test/java/lang/Character/Scripts.txt ! jdk/test/java/lang/Character/TestIsJavaIdentifierMethods.java Changeset: 4328fec3 Branch: master Author: Justin Lu Committer: Naoto Sato Date: 2023-05-11 16:30:40 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4328fec3a75657f9923a9cfabe8eb6e1081a510d 8303028: Update system property for Java SE specification maintenance version Reviewed-by: rriggs, lancea, naoto, iris Backport-of: 9eb797dc6ac09f250b4e308abd43bffa6529c534 ! jdk/src/share/native/java/lang/System.c Changeset: 3e69b49f Branch: master Author: Sergey Nazarkin Committer: Yuri Nesterenko Date: 2023-05-12 10:32:15 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3e69b49f71e1c00a4761a9e63440cb7af1216389 8307531: [aarch64] JDK8 single-step debugging is extremely slow Reviewed-by: aph ! hotspot/src/share/vm/prims/jvmtiExport.cpp ! hotspot/src/share/vm/prims/jvmtiThreadState.cpp Changeset: c498dd52 Branch: master Author: Andrew John Hughes Date: 2025-06-17 12:41:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c498dd5204469e1b7d3ce078c36873226825e61a Merge jdk8u382-b02 Added tag jdk8u382-b02 for changeset 3e69b49f71e From andrew at openjdk.org Tue Jun 17 16:45:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 16:45:19 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u382-b02 for changeset 3e69b49f Message-ID: <772e9825-6b3f-4b2e-ab67-e1e6fe5476aa@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-05-16 18:31:25 +0000 Added tag jdk8u382-b02 for changeset 3e69b49f71e Changeset: 3e69b49f Author: Sergey Nazarkin Committer: Yuri Nesterenko Date: 2023-05-12 10:32:15 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3e69b49f71e1c00a4761a9e63440cb7af1216389 From andrew at openjdk.org Tue Jun 17 16:45:22 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 16:45:22 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u382-b02 for changeset c498dd52 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-17 16:51:18 +0000 Added tag shenandoah8u382-b02 for changeset c498dd52044 Changeset: c498dd52 Author: Andrew John Hughes Date: 2025-06-17 12:41:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c498dd5204469e1b7d3ce078c36873226825e61a From andrew at openjdk.org Tue Jun 17 16:45:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 16:45:26 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u382-b02 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/48/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/48/files/c498dd52..c498dd52 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=48&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=48&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/48.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/48/head:pull/48 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/48 From iris at openjdk.org Tue Jun 17 16:45:26 2025 From: iris at openjdk.org (Iris Clark) Date: Tue, 17 Jun 2025 16:45:26 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 16:32:59 GMT, Andrew John Hughes wrote: > Merge jdk8u382-b02 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/48 From andrew at openjdk.org Tue Jun 17 17:21:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 17:21:52 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u382-b03 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u382-b03 - 8307134: Add GTS root CAs - 8304760: Add 2 Microsoft TLS roots - 8298108: Add a regression test for JDK-8297684 - 8305975: Add TWCA Global Root CA - 8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace - 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8 - 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped - 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/49/files Stats: 1782 lines in 21 files changed: 1768 ins; 3 del; 11 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/49.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/49/head:pull/49 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/49 From andrew at openjdk.org Tue Jun 17 17:31:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 17:31:36 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 9 new changesets Message-ID: <629b632b-0792-4780-b33a-1bd341ef92c9@openjdk.org> Changeset: c7c080ad Branch: master Author: Ben Taylor Committer: Aleksey Shipilev Date: 2023-05-24 18:10:56 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c7c080ad9e0ec05ca09501f90ff4223183653534 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 Reviewed-by: phh, shade Backport-of: 269eae61894b6bd0a7512045a369b53df747f6e5 ! jdk/src/solaris/native/sun/nio/ch/DatagramChannelImpl.c ! jdk/test/java/nio/channels/DatagramChannel/Disconnect.java Changeset: 85622986 Branch: master Author: Sergey Bylokhov Date: 2023-05-24 22:30:07 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8562298613992526914416039f27c51e280703f7 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped Reviewed-by: phh Backport-of: 041ae20b10e11381415e8f61fd39e9e19aa8d4f2 ! jdk/test/sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec.java Changeset: 764dbd54 Branch: master Author: Sergey Bylokhov Date: 2023-05-24 22:38:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/764dbd54958f606475092d2ccc5f831d9ad5d7d5 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8 Reviewed-by: phh + jdk/test/java/awt/Color/LoadProfileWithSM.java + jdk/test/java/awt/Color/LoadStandardProfilesTest.java Changeset: 20b4c702 Branch: master Author: Sergey Bylokhov Date: 2023-05-25 00:23:35 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/20b4c702073a20e7809024277cb03317219c4264 8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace Backport-of: f4fa68a2a795ca073409b76332037cc601e66b13 ! jdk/src/share/classes/java/awt/color/ICC_ColorSpace.java + jdk/test/java/awt/Color/GetMinMaxValue_ICC_ColorSpace.java Changeset: 54208fcd Branch: master Author: Severin Gehwolf Date: 2023-05-25 16:59:43 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/54208fcd86ade96a286f58c533fd211085566dd1 8305975: Add TWCA Global Root CA Reviewed-by: andrew Backport-of: 093f02aadbeedb8f22db7512cb5555c4c890b0fc + jdk/make/data/cacerts/twcaglobalrootca + jdk/test/security/infra/java/security/cert/CertPathValidator/certification/TWCAGlobalCA.java ! jdk/test/sun/security/lib/cacerts/VerifyCACerts.java Changeset: 29ba98e5 Branch: master Author: Severin Gehwolf Date: 2023-05-25 17:30:08 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/29ba98e59b2df7fd85d3f0a000df0554fea845c2 8298108: Add a regression test for JDK-8297684 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows Reviewed-by: phh, andrew Backport-of: 4da8411674b7515310000bd8243860bc73f9a03d + jdk/test/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java + jdk/test/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.java + jdk/test/java/security/SignedJar/spi-calendar-provider/provider/meta/META-INF/services/java.util.spi.CalendarDataProvider Changeset: f5c2c39f Branch: master Author: Severin Gehwolf Date: 2023-05-26 08:16:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f5c2c39f665788bdcfdf915e5429032da9a675fd 8304760: Add 2 Microsoft TLS roots Reviewed-by: andrew Backport-of: f655ccd1c74bb18000ef2789d26952055c2deba1 + jdk/make/data/cacerts/microsoftecc2017 + jdk/make/data/cacerts/microsoftrsa2017 + jdk/test/security/infra/java/security/cert/CertPathValidator/certification/MicrosoftTLS.java ! jdk/test/sun/security/lib/cacerts/VerifyCACerts.java Changeset: 8efa32e5 Branch: master Author: Severin Gehwolf Date: 2023-05-26 12:05:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8efa32e54e23a0fb99cd7df697bec7e6c6baf8bf 8307134: Add GTS root CAs Reviewed-by: andrew Backport-of: 03030d47ebee5c20919fe0162ec86d3d400cd955 + jdk/make/data/cacerts/gtsrootcar1 + jdk/make/data/cacerts/gtsrootcar2 + jdk/make/data/cacerts/gtsrootecccar3 + jdk/make/data/cacerts/gtsrootecccar4 + jdk/test/security/infra/java/security/cert/CertPathValidator/certification/GoogleCA.java ! jdk/test/sun/security/lib/cacerts/VerifyCACerts.java Changeset: 392b5a98 Branch: master Author: Andrew John Hughes Date: 2025-06-17 17:48:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/392b5a98de148165dba0ed6d31eced9cfb8fea64 Merge jdk8u382-b03 Added tag jdk8u382-b03 for changeset 8efa32e54e2 From andrew at openjdk.org Tue Jun 17 17:31:46 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 17:31:46 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u392-b00 for changeset 8efa32e5 Message-ID: Tagged by: Andrew John Hughes Date: 2023-07-31 17:52:32 +0000 Added tag jdk8u392-b00 for changeset 8efa32e54e2 Changeset: 8efa32e5 Author: Severin Gehwolf Date: 2023-05-26 12:05:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8efa32e54e23a0fb99cd7df697bec7e6c6baf8bf From andrew at openjdk.org Tue Jun 17 17:31:51 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 17:31:51 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u392-b00 for changeset 392b5a98 Message-ID: <00f86774-3576-4ec5-ab58-76db0d7b51a0@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-17 18:15:48 +0000 Added tag shenandoah8u392-b00 for changeset 392b5a98de1 Changeset: 392b5a98 Author: Andrew John Hughes Date: 2025-06-17 17:48:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/392b5a98de148165dba0ed6d31eced9cfb8fea64 From andrew at openjdk.org Tue Jun 17 17:31:57 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 17:31:57 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u382-b03 for changeset 8efa32e5 Message-ID: <649dc052-03d6-4c2e-a6ac-495e09c171b0@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-05-30 20:06:45 +0000 Added tag jdk8u382-b03 for changeset 8efa32e54e2 Changeset: 8efa32e5 Author: Severin Gehwolf Date: 2023-05-26 12:05:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/8efa32e54e23a0fb99cd7df697bec7e6c6baf8bf From andrew at openjdk.org Tue Jun 17 17:32:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 17:32:03 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u382-b03 for changeset 392b5a98 Message-ID: <3385c1c2-7b8b-453d-bdb2-cf20fc1a1bbd@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-17 18:15:36 +0000 Added tag shenandoah8u382-b03 for changeset 392b5a98de1 Changeset: 392b5a98 Author: Andrew John Hughes Date: 2025-06-17 17:48:11 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/392b5a98de148165dba0ed6d31eced9cfb8fea64 From iris at openjdk.org Tue Jun 17 17:33:11 2025 From: iris at openjdk.org (Iris Clark) Date: Tue, 17 Jun 2025 17:33:11 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 17:18:10 GMT, Andrew John Hughes wrote: > Merge jdk8u382-b03 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/49 From andrew at openjdk.org Tue Jun 17 17:33:11 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 17:33:11 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u382-b03 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/49/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/49/files/392b5a98..392b5a98 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=49&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=49&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/49.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/49/head:pull/49 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/49 From andrew at openjdk.org Tue Jun 17 18:12:48 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 18:12:48 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u382-b04 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u382-b04 - 8241311: Move some charset mapping tests from closed to open - 8186801: Add regression test to test mapping based charsets (generated at build time) The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/50/files Stats: 887690 lines in 180 files changed: 887689 ins; 0 del; 1 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/50.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/50/head:pull/50 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/50 From andrew at openjdk.org Tue Jun 17 18:29:17 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 18:29:17 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 3 new changesets Message-ID: <598fd808-08ee-42f6-9086-387f3abcc676@openjdk.org> Changeset: 1818eaf7 Branch: master Author: Andrew John Hughes Date: 2023-06-23 09:50:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1818eaf77e9ca6478627ef9471cae4163d16329a 8186801: Add regression test to test mapping based charsets (generated at build time) Reviewed-by: stuefe, sgehwolf Backport-of: cfe34ed89c4f6ef9a49dceef30da1e43b418b152 = jdk/make/data/charsetmapping/Big5_HKSCS.c2b + jdk/make/data/charsetmapping/Big5_HKSCS.map + jdk/make/data/charsetmapping/Big5_HKSCS.nr = jdk/make/data/charsetmapping/Big5_Solaris.map + jdk/make/data/charsetmapping/EUC_JP.map + jdk/make/data/charsetmapping/EUC_JP_LINUX.map + jdk/make/data/charsetmapping/EUC_JP_Open.map = jdk/make/data/charsetmapping/EUC_TW.map + jdk/make/data/charsetmapping/EUC_TW.nr + jdk/make/data/charsetmapping/GB18030.map + jdk/make/data/charsetmapping/MS950_HKSCS_XP.map ! jdk/make/src/classes/build/tools/charsetmapping/EUC_TW.java + jdk/test/sun/nio/cs/TestCharsetMapping.java + jdk/test/sun/nio/cs/TestEBCDICLineFeed.java Changeset: 0bec498f Branch: master Author: Andrew John Hughes Date: 2023-06-23 12:20:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0bec498fc945a49f1134e02eb477e0af15db3b5b 8241311: Move some charset mapping tests from closed to open Reviewed-by: sgehwolf Backport-of: c809c9944400f7ee9bc296e40d6068273bde5912 + jdk/test/sun/nio/cs/mapping/Big5.b2c = jdk/test/sun/nio/cs/mapping/Big5.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Big5_HKSCS.b2c + jdk/test/sun/nio/cs/mapping/Big5_HKSCS.b2c-irreversible = jdk/test/sun/nio/cs/mapping/Big5_HKSCS.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Big5_HKSCS_2001.b2c + jdk/test/sun/nio/cs/mapping/Big5_HKSCS_2001.c2b-irreversible = jdk/test/sun/nio/cs/mapping/Big5_Solaris.b2c + jdk/test/sun/nio/cs/mapping/CoderTest.java + jdk/test/sun/nio/cs/mapping/ConverterTest.java + jdk/test/sun/nio/cs/mapping/Cp037.b2c + jdk/test/sun/nio/cs/mapping/Cp1006.b2c + jdk/test/sun/nio/cs/mapping/Cp1025.b2c + jdk/test/sun/nio/cs/mapping/Cp1026.b2c + jdk/test/sun/nio/cs/mapping/Cp1046.b2c + jdk/test/sun/nio/cs/mapping/Cp1047.b2c + jdk/test/sun/nio/cs/mapping/Cp1097.b2c + jdk/test/sun/nio/cs/mapping/Cp1098.b2c + jdk/test/sun/nio/cs/mapping/Cp1112.b2c + jdk/test/sun/nio/cs/mapping/Cp1122.b2c + jdk/test/sun/nio/cs/mapping/Cp1123.b2c + jdk/test/sun/nio/cs/mapping/Cp1124.b2c + jdk/test/sun/nio/cs/mapping/Cp1250.b2c + jdk/test/sun/nio/cs/mapping/Cp1251.b2c + jdk/test/sun/nio/cs/mapping/Cp1252.b2c + jdk/test/sun/nio/cs/mapping/Cp1253.b2c + jdk/test/sun/nio/cs/mapping/Cp1254.b2c + jdk/test/sun/nio/cs/mapping/Cp1255.b2c + jdk/test/sun/nio/cs/mapping/Cp1256.b2c + jdk/test/sun/nio/cs/mapping/Cp1257.b2c + jdk/test/sun/nio/cs/mapping/Cp1258.b2c + jdk/test/sun/nio/cs/mapping/Cp1364.b2c + jdk/test/sun/nio/cs/mapping/Cp1364.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp1381.b2c + jdk/test/sun/nio/cs/mapping/Cp1381.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp1383.b2c + jdk/test/sun/nio/cs/mapping/Cp1383.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Cp273.b2c + jdk/test/sun/nio/cs/mapping/Cp277.b2c + jdk/test/sun/nio/cs/mapping/Cp278.b2c + jdk/test/sun/nio/cs/mapping/Cp280.b2c + jdk/test/sun/nio/cs/mapping/Cp284.b2c + jdk/test/sun/nio/cs/mapping/Cp285.b2c + jdk/test/sun/nio/cs/mapping/Cp290.b2c + jdk/test/sun/nio/cs/mapping/Cp290.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp297.b2c + jdk/test/sun/nio/cs/mapping/Cp300.b2c = jdk/test/sun/nio/cs/mapping/Cp300.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp33722.b2c + jdk/test/sun/nio/cs/mapping/Cp420.b2c + jdk/test/sun/nio/cs/mapping/Cp420.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Cp420.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp424.b2c + jdk/test/sun/nio/cs/mapping/Cp437.b2c + jdk/test/sun/nio/cs/mapping/Cp500.b2c + jdk/test/sun/nio/cs/mapping/Cp737.b2c + jdk/test/sun/nio/cs/mapping/Cp775.b2c + jdk/test/sun/nio/cs/mapping/Cp833.b2c + jdk/test/sun/nio/cs/mapping/Cp833.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp834.b2c + jdk/test/sun/nio/cs/mapping/Cp834.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp838.b2c + jdk/test/sun/nio/cs/mapping/Cp850.b2c + jdk/test/sun/nio/cs/mapping/Cp852.b2c + jdk/test/sun/nio/cs/mapping/Cp855.b2c + jdk/test/sun/nio/cs/mapping/Cp856.b2c + jdk/test/sun/nio/cs/mapping/Cp857.b2c + jdk/test/sun/nio/cs/mapping/Cp860.b2c + jdk/test/sun/nio/cs/mapping/Cp861.b2c + jdk/test/sun/nio/cs/mapping/Cp862.b2c + jdk/test/sun/nio/cs/mapping/Cp863.b2c + jdk/test/sun/nio/cs/mapping/Cp864.b2c + jdk/test/sun/nio/cs/mapping/Cp865.b2c + jdk/test/sun/nio/cs/mapping/Cp866.b2c + jdk/test/sun/nio/cs/mapping/Cp868.b2c + jdk/test/sun/nio/cs/mapping/Cp869.b2c + jdk/test/sun/nio/cs/mapping/Cp870.b2c + jdk/test/sun/nio/cs/mapping/Cp871.b2c + jdk/test/sun/nio/cs/mapping/Cp874.b2c + jdk/test/sun/nio/cs/mapping/Cp874.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Cp875.b2c + jdk/test/sun/nio/cs/mapping/Cp918.b2c + jdk/test/sun/nio/cs/mapping/Cp921.b2c + jdk/test/sun/nio/cs/mapping/Cp922.b2c + jdk/test/sun/nio/cs/mapping/Cp930.b2c + jdk/test/sun/nio/cs/mapping/Cp933.b2c + jdk/test/sun/nio/cs/mapping/Cp935.b2c + jdk/test/sun/nio/cs/mapping/Cp937.b2c + jdk/test/sun/nio/cs/mapping/Cp937.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Cp939.b2c + jdk/test/sun/nio/cs/mapping/Cp942.b2c + jdk/test/sun/nio/cs/mapping/Cp943.b2c + jdk/test/sun/nio/cs/mapping/Cp948.b2c + jdk/test/sun/nio/cs/mapping/Cp948.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Cp948.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp949.b2c + jdk/test/sun/nio/cs/mapping/Cp950.b2c + jdk/test/sun/nio/cs/mapping/Cp950.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Cp950.c2b-irreversible + jdk/test/sun/nio/cs/mapping/Cp964.b2c + jdk/test/sun/nio/cs/mapping/Cp964.b2c-irreversible + jdk/test/sun/nio/cs/mapping/Cp970.b2c + jdk/test/sun/nio/cs/mapping/Cp970.c2b-irreversible + jdk/test/sun/nio/cs/mapping/EUC_CN.b2c + jdk/test/sun/nio/cs/mapping/EUC_JP.b2c + jdk/test/sun/nio/cs/mapping/EUC_JP_LINUX.b2c + jdk/test/sun/nio/cs/mapping/EUC_JP_Solaris.b2c + jdk/test/sun/nio/cs/mapping/EUC_KR.b2c + jdk/test/sun/nio/cs/mapping/EUC_TW.b2c + jdk/test/sun/nio/cs/mapping/GB18030.b2c + jdk/test/sun/nio/cs/mapping/GBK.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_11.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_2.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_3.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_4.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_5.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_6.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_7.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_8.b2c + jdk/test/sun/nio/cs/mapping/ISO8859_9.b2c + jdk/test/sun/nio/cs/mapping/JIS0201.b2c.private + jdk/test/sun/nio/cs/mapping/JIS0208.b2c.private + jdk/test/sun/nio/cs/mapping/JIS0212.b2c.private + jdk/test/sun/nio/cs/mapping/Johab.b2c + jdk/test/sun/nio/cs/mapping/KOI8_R.b2c + jdk/test/sun/nio/cs/mapping/KOI8_U.b2c + jdk/test/sun/nio/cs/mapping/MS50221_0208.b2c + jdk/test/sun/nio/cs/mapping/MS50221_0212.b2c + jdk/test/sun/nio/cs/mapping/MS874.b2c + jdk/test/sun/nio/cs/mapping/MS932.b2c.private + jdk/test/sun/nio/cs/mapping/MS932DB.b2c.private + jdk/test/sun/nio/cs/mapping/MS932DB.c2b.private + jdk/test/sun/nio/cs/mapping/MS932_0208.b2c + jdk/test/sun/nio/cs/mapping/MS936.b2c + jdk/test/sun/nio/cs/mapping/MS949.b2c + jdk/test/sun/nio/cs/mapping/MS950.b2c + jdk/test/sun/nio/cs/mapping/MS950.b2c-irreversible + jdk/test/sun/nio/cs/mapping/MS950.c2b-irreversible + jdk/test/sun/nio/cs/mapping/MS950_HKSCS.b2c + jdk/test/sun/nio/cs/mapping/MS950_HKSCS.c2b-irreversible + jdk/test/sun/nio/cs/mapping/MS950_HKSCS_XP.b2c + jdk/test/sun/nio/cs/mapping/MSCP932.b2c.abigail + jdk/test/sun/nio/cs/mapping/MacArabic.b2c + jdk/test/sun/nio/cs/mapping/MacCentralEurope.b2c + jdk/test/sun/nio/cs/mapping/MacCroatian.b2c + jdk/test/sun/nio/cs/mapping/MacCyrillic.b2c + jdk/test/sun/nio/cs/mapping/MacDingbat.b2c + jdk/test/sun/nio/cs/mapping/MacGreek.b2c + jdk/test/sun/nio/cs/mapping/MacHebrew.b2c + jdk/test/sun/nio/cs/mapping/MacIceland.b2c + jdk/test/sun/nio/cs/mapping/MacRoman.b2c + jdk/test/sun/nio/cs/mapping/MacRomania.b2c + jdk/test/sun/nio/cs/mapping/MacSymbol.b2c + jdk/test/sun/nio/cs/mapping/MacThai.b2c + jdk/test/sun/nio/cs/mapping/MacTurkish.b2c + jdk/test/sun/nio/cs/mapping/MacUkraine.b2c + jdk/test/sun/nio/cs/mapping/PCK.b2c + jdk/test/sun/nio/cs/mapping/PCK.b2c-irreversible + jdk/test/sun/nio/cs/mapping/SJIS.b2c + jdk/test/sun/nio/cs/mapping/SJIS_0213.b2c + jdk/test/sun/nio/cs/mapping/TIS620.b2c + jdk/test/sun/nio/cs/mapping/TestConv.java + jdk/test/sun/nio/cs/mapping/TestFmwk.java + jdk/test/sun/nio/cs/mapping/untested/X11SunUnicode_0.b2c + jdk/test/sun/nio/cs/mapping/untested/gb18030_0.b2c + jdk/test/sun/nio/cs/mapping/untested/gb18030_1.b2c Changeset: c433eac6 Branch: master Author: Andrew John Hughes Date: 2025-06-17 18:30:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c433eac6aaa9050507ed6fe374f0132a5614fc54 Merge jdk8u382-b04 Added tag jdk8u382-b04 for changeset 0bec498fc94 From andrew at openjdk.org Tue Jun 17 18:29:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 18:29:26 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u382-b04 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/50/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/50/files/c433eac6..c433eac6 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=50&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=50&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/50.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/50/head:pull/50 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/50 From iris at openjdk.org Tue Jun 17 18:29:27 2025 From: iris at openjdk.org (Iris Clark) Date: Tue, 17 Jun 2025 18:29:27 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 18:08:51 GMT, Andrew John Hughes wrote: > Merge jdk8u382-b04 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/50 From andrew at openjdk.org Tue Jun 17 18:29:28 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 18:29:28 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u382-b04 for changeset 0bec498f Message-ID: <1feaf7d3-74b7-453c-b12e-df450245752f@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-06-26 16:36:17 +0000 Added tag jdk8u382-b04 for changeset 0bec498fc94 Changeset: 0bec498f Author: Andrew John Hughes Date: 2023-06-23 12:20:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/0bec498fc945a49f1134e02eb477e0af15db3b5b From andrew at openjdk.org Tue Jun 17 18:29:33 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 17 Jun 2025 18:29:33 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u382-b04 for changeset c433eac6 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-17 19:02:38 +0000 Added tag shenandoah8u382-b04 for changeset c433eac6aaa Changeset: c433eac6 Author: Andrew John Hughes Date: 2025-06-17 18:30:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/c433eac6aaa9050507ed6fe374f0132a5614fc54 From dlong at openjdk.org Tue Jun 17 20:55:29 2025 From: dlong at openjdk.org (Dean Long) Date: Tue, 17 Jun 2025 20:55:29 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: <-qfpN8-hyWv-QosNnOUvLaZtsI0Kr1vXsTIV6Tqvd-w=.badb50d8-3f05-41d1-bc90-d5939d6b571f@github.com> Message-ID: <87D1GHpnuO66YKnlxRh6JOlp7AZoZxhLBDbCpUG230A=.9119d110-62ba-4083-9a85-9bf78f5b462b@github.com> On Tue, 17 Jun 2025 12:50:18 GMT, Martin Doerr wrote: > > > Seems like arm32 has the same issue: > > > https://github.com/openjdk/jdk/blob/9d060574e5dbd13e634f00d749d0108ceff1fae8/src/hotspot/cpu/arm/gc/shared/barrierSetAssembler_arm.cpp#L199 > > > > > > The init value shouldn't have the sticky bit set. > > > > > > Thanks, I pushed a potential fix for that. > > Unfortunately, 0xBEAFDEAD also has the MSB set. Shouldn't we better use 0 like on all other platforms? Oops, I was tripped up trying to be clever. Yes, I'm fine with using 0. I'll fix it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2981800170 From dlong at openjdk.org Tue Jun 17 20:59:46 2025 From: dlong at openjdk.org (Dean Long) Date: Tue, 17 Jun 2025 20:59:46 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v8] In-Reply-To: References: Message-ID: <2gdPUDg-i40xRoO8LZPWszL2-oa6s7GNZEDRfHfDk8s=.4dbfe74a-070b-46c1-b73d-0292824d02e9@github.com> > This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. > > We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. > > The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. > > For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. > > This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. Dean Long has updated the pull request incrementally with one additional commit since the last revision: 2nd try at arm fix ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25764/files - new: https://git.openjdk.org/jdk/pull/25764/files/3ac6dec0..3e306dde Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25764&range=06-07 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25764.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25764/head:pull/25764 PR: https://git.openjdk.org/jdk/pull/25764 From wkemper at openjdk.org Tue Jun 17 21:20:40 2025 From: wkemper at openjdk.org (William Kemper) Date: Tue, 17 Jun 2025 21:20:40 GMT Subject: RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3] In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 00:12:04 GMT, Y. Srinivas Ramakrishna wrote: >> William Kemper has updated the pull request incrementally with one additional commit since the last revision: >> >> Revert "Consolidate read table cleaning" >> >> This reverts commit 9552021cbeec699e7b04db81fa68819c23b7dab7. > > @earthling-amzn : > >> Genshen does not clean the read table at the end of a concurrent cycle (we could do this, but we'd still need to do the same in a degenerated cycle). > > Yes, and I am suggesting we do that to clean up and consolidate the cleaning along multiple paths into the same method that is invoked at an identical point in the Collector's state machine, irrespective of whether we arrived at that state via a concurrent collection or a degeneration. > >> The complexity comes from swapping the card tables in a concurrent cycle. We must not let a subsequent degenerated cycle swap them a second time. The degenerated cycle can only clean the read table if there was no active concurrent cycle (lest it throw away critical remembered set data). > > The swapping must happen at the start of the marking cycle. In similar fashion, the state of the Collector's state machine should indicate if the swap has already been done in this cycle or not. The specifics of wheher the swap was done by a degenerate or concurrent collection should then not matter? > >> However, the degenerated cycle must also clear the mark bitmaps if the concurrent cycle degenerated during the root scan (the degenerated cycle will rescan the roots). Of course, we cannot clear the mark bitmaps if the concurrent cycle degenerated during the mark phase. So, for the degenerated cycle, clearing the mark bitmaps and cleaning the read table need to happen in two different cases and it doesn't work if they're combined into the same method (and I don't think adding a method parameter to sometimes clear the mark bitmap and sometimes the read table will make the code any easier to understand). > > That's OK, they can be in two different methods, with the clearing of the marking bitmap done in one case and not in the other based on when the degeeration occurred. I think may be we don't have sufficiently refined Collector state machine at the moment which may be part of the problem here. > > That having been said, I can understand that: > >> The refactoring you suggest is not so simple, alas. > > In particular, if our eventual future plan is to do away with degeneration as we know it today, then the refactoring to achieve the clean up I suggest may be moot. > > With that in mind, I am going to approve the changes in their current form as they look right if somewhat difficult to maintain and prove the correctness of. (The more refined state machine approach would likely make it easier, but will be moot once degeneration is el... Thanks for the review @ysramakrishna . The plan is to get rid of degenerated cycles, but if the plan changes we certainly need to invest in a stronger state machine for the GC here. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25735#issuecomment-2981851757 From wkemper at openjdk.org Tue Jun 17 21:20:41 2025 From: wkemper at openjdk.org (William Kemper) Date: Tue, 17 Jun 2025 21:20:41 GMT Subject: Integrated: 8357976: GenShen crash in swap_card_tables: Should be clean In-Reply-To: References: Message-ID: On Tue, 10 Jun 2025 20:14:49 GMT, William Kemper wrote: > Degenerated cycles must also clean the `read` card table before swapping it with the `write` card table. This pull request has now been integrated. Changeset: 382f870c Author: William Kemper URL: https://git.openjdk.org/jdk/commit/382f870cd53d69dfc1d2b96150aa2c026e47f642 Stats: 17 lines in 2 files changed: 10 ins; 4 del; 3 mod 8357976: GenShen crash in swap_card_tables: Should be clean Reviewed-by: kdnilsen, cslucas, ysr, xpeng ------------- PR: https://git.openjdk.org/jdk/pull/25735 From mdoerr at openjdk.org Wed Jun 18 08:33:37 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 18 Jun 2025 08:33:37 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v8] In-Reply-To: <2gdPUDg-i40xRoO8LZPWszL2-oa6s7GNZEDRfHfDk8s=.4dbfe74a-070b-46c1-b73d-0292824d02e9@github.com> References: <2gdPUDg-i40xRoO8LZPWszL2-oa6s7GNZEDRfHfDk8s=.4dbfe74a-070b-46c1-b73d-0292824d02e9@github.com> Message-ID: On Tue, 17 Jun 2025 20:59:46 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > 2nd try at arm fix Recent changes look good. Thanks! ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25764#pullrequestreview-2938255719 From ayang at openjdk.org Wed Jun 18 09:03:28 2025 From: ayang at openjdk.org (Albert Mingkun Yang) Date: Wed, 18 Jun 2025 09:03:28 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v6] In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 14:59:01 GMT, Suchismith Roy wrote: >> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) >> >> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). >> >> >> >> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. > > Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: > > g1Monitoring Marked as reviewed by ayang (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/25833#pullrequestreview-2938359236 From stefank at openjdk.org Wed Jun 18 09:31:30 2025 From: stefank at openjdk.org (Stefan Karlsson) Date: Wed, 18 Jun 2025 09:31:30 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v6] In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 14:59:01 GMT, Suchismith Roy wrote: >> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077) >> >> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity). >> >> >> >> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method. > > Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: > > g1Monitoring src/hotspot/share/gc/z/zServiceability.cpp line 70: > 68: void update_capacity(size_t capacity) { > 69: update_all(capacity); > 70: } Could you also delete line 67. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25833#discussion_r2154104691 From stefank at openjdk.org Wed Jun 18 09:31:30 2025 From: stefank at openjdk.org (Stefan Karlsson) Date: Wed, 18 Jun 2025 09:31:30 GMT Subject: RFR: JDK-8349077 : Rename GenerationCounters::update_all [v6] In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 09:18:32 GMT, Stefan Karlsson wrote: >> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: >> >> g1Monitoring > > src/hotspot/share/gc/z/zServiceability.cpp line 70: > >> 68: void update_capacity(size_t capacity) { >> 69: update_all(capacity); >> 70: } > > Could you also delete line 67. Or maybe even better just entirely delete `ZGenerationCounters` and replace its usages with `GenerationCounters`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25833#discussion_r2154111929 From eosterlund at openjdk.org Wed Jun 18 11:36:30 2025 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 18 Jun 2025 11:36:30 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 00:02:29 GMT, Dean Long wrote: >> src/hotspot/share/gc/z/zBarrierSetNMethod.cpp line 114: >> >>> 112: // Preserve the sticky bit >>> 113: if (is_not_entrant(nm)) { >>> 114: value |= not_entrant; >> >> Is it possible to have a race where another thread sets an nmethod to not entrant and the thread calling this making the nmethod entry barrier not entrant? >> >> If this was called to disarm a method and then enter it, it seems a bit sneaky in that case that we pass the nmethod entry barrier even though we under the lock see that it is not entrant. Probably okay but still feels like it might be more robust if the thread setting an nmethod to not entrant is always the one that arms the nmethod entry barrier. > > If I understand your concern correctly, there is no race. The only caller of BarrierSetNMethod::make_not_entrant() is nmethod::make_not_entrant(), and it is done inside a NMethodState_lock critical section. After a call to nmethod::make_not_entrant(), the nmethod entry barrier is armed and stays that way. > And by design, a disarm only disarms at the inner nmethod_entry_barrier level, not the outer nmethod_stub_entry_barrier level. My concern is that while thread 1 calls nmethod::make_not_entrant(), thread 2 racingly performs nmethod entry barrier; it makes the is_not_entrant check before it gets updated, but then it gets updated as the per nmethod lock is taken. The GC code "disarms" the GC barrier but in doing so finds that "oh this should be not entrant", but that's sort of not reflected as thread 2 will then proceed with entering the nmethod it just armed as not entrant in the nmethod entry barrier code. Does that make sense? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2154370247 From andrew at openjdk.org Wed Jun 18 13:49:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 13:49:52 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u382-b05 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u382-b05 - 8305312: Enhanced path handling - 8304468: Better array usages - 8300596: Enhance Jar Signature validation - 8298676: Enhanced Look and Feel - 8301119: Support for GB18030-2022 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/51/files Stats: 1077 lines in 16 files changed: 939 ins; 22 del; 116 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/51.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/51/head:pull/51 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/51 From iris at openjdk.org Wed Jun 18 14:03:02 2025 From: iris at openjdk.org (Iris Clark) Date: Wed, 18 Jun 2025 14:03:02 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 13:46:05 GMT, Andrew John Hughes wrote: > Merge jdk8u382-b05 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/51 From andrew at openjdk.org Wed Jun 18 14:03:02 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 14:03:02 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u382-b05 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/51/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/51/files/2f3a3c16..2f3a3c16 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=51&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=51&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/51.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/51/head:pull/51 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/51 From andrew at openjdk.org Wed Jun 18 14:03:23 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 14:03:23 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u382-ga for changeset 2f3a3c16 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-18 14:44:51 +0000 Added tag shenandoah8u382-ga for changeset 2f3a3c16e71 Changeset: 2f3a3c16 Author: Andrew John Hughes Date: 2025-06-17 19:26:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2f3a3c16e715cf616b8ec3214f0695466b0b5ad4 From andrew at openjdk.org Wed Jun 18 14:03:00 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 14:03:00 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 6 new changesets Message-ID: Changeset: fc1b2b4e Branch: master Author: Andrew John Hughes Date: 2023-07-13 16:33:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/fc1b2b4e13a8c9f42a5eaba2e991b24463385989 8301119: Support for GB18030-2022 8310947: gb18030-2000 not selectable with LANG=zh_CN.GB18030 after JDK-8301119 Co-authored-by: Severin Gehwolf Reviewed-by: stuefe, sgehwolf Backport-of: 5c4e744dabcf7785c35168db5d0458ccebfd41e6 ! jdk/src/share/classes/sun/nio/cs/AbstractCharsetProvider.java ! jdk/src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! jdk/src/share/classes/sun/nio/cs/ext/GB18030.java ! jdk/test/java/nio/charset/Charset/RegisteredCharsets.java ! jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java ! jdk/test/sun/nio/cs/TestGB18030.java ! jdk/test/sun/nio/cs/mapping/CoderTest.java ! jdk/test/sun/nio/cs/mapping/GB18030.b2c = jdk/test/sun/nio/cs/mapping/GB18030_2000.b2c Changeset: 34c7b2a5 Branch: master Author: Sergey Bylokhov Committer: Andrew John Hughes Date: 2023-07-13 18:13:50 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/34c7b2a5f72189b3b2ddefd7e3948575c1161325 8298676: Enhanced Look and Feel Reviewed-by: mbalao, andrew Backport-of: 5962226cc33de047946aca6522f020c97d663d2f ! jdk/src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! jdk/src/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html Changeset: bd28f3dd Branch: master Author: Alexei Voitylov Committer: Andrew John Hughes Date: 2023-06-16 18:23:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/bd28f3dd3fc43c62c738f0f137df937fbacb1cdf 8300596: Enhance Jar Signature validation Reviewed-by: yan, mbalao, andrew Backport-of: a099d8bf015950db7f0b0ca792e4a9dc951a15cf ! jdk/src/share/classes/java/util/jar/JarFile.java ! jdk/src/share/classes/sun/security/tools/jarsigner/Main.java ! jdk/src/share/classes/sun/security/util/SignatureFileVerifier.java Changeset: ec0818ad Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2023-06-08 21:08:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ec0818add7069be2fe3854edd1f3d2d7c8e07746 8304468: Better array usages Reviewed-by: yan, andrew Backport-of: cb7cef2b85264c2bd2d00f1c0e5010969aa618d3 ! hotspot/src/share/vm/c1/c1_RangeCheckElimination.cpp Changeset: 50e903b6 Branch: master Author: Martin Balao Committer: Andrew John Hughes Date: 2023-04-17 13:37:42 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/50e903b61fadc20fc297aff2cc2295c35be0edde 8305312: Enhanced path handling Reviewed-by: yan, andrew Backport-of: cb7cef2b85264c2bd2d00f1c0e5010969aa618d3 ! jdk/src/solaris/classes/sun/nio/fs/UnixUriUtils.java Changeset: 2f3a3c16 Branch: master Author: Andrew John Hughes Date: 2025-06-17 19:26:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2f3a3c16e715cf616b8ec3214f0695466b0b5ad4 Merge jdk8u382-b05 Added tag jdk8u382-b05 for changeset 50e903b61fa From andrew at openjdk.org Wed Jun 18 14:03:17 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 14:03:17 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u382-ga for changeset 50e903b6 Message-ID: Tagged by: Andrew John Hughes Date: 2023-07-21 04:03:59 +0000 Added tag jdk8u382-ga for changeset 50e903b61fa Changeset: 50e903b6 Author: Martin Balao Committer: Andrew John Hughes Date: 2023-04-17 13:37:42 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/50e903b61fadc20fc297aff2cc2295c35be0edde From andrew at openjdk.org Wed Jun 18 14:03:09 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 14:03:09 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u382-b05 for changeset 50e903b6 Message-ID: Tagged by: Andrew John Hughes Date: 2023-07-14 07:33:51 +0000 Added tag jdk8u382-b05 for changeset 50e903b61fa Changeset: 50e903b6 Author: Martin Balao Committer: Andrew John Hughes Date: 2023-04-17 13:37:42 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/50e903b61fadc20fc297aff2cc2295c35be0edde From andrew at openjdk.org Wed Jun 18 14:03:12 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 14:03:12 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u382-b05 for changeset 2f3a3c16 Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-18 14:44:39 +0000 Added tag shenandoah8u382-b05 for changeset 2f3a3c16e71 Changeset: 2f3a3c16 Author: Andrew John Hughes Date: 2025-06-17 19:26:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/2f3a3c16e715cf616b8ec3214f0695466b0b5ad4 From andrew at openjdk.org Wed Jun 18 15:29:13 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 15:29:13 GMT Subject: RFR: Merge jdk8u:master Message-ID: <-tr9pQsKLoFzgxkA2bPu8cxbn9pYL_o1dGxTvf60I_8=.82c31f49-8c6e-4305-b1b8-64872287dcbd@github.com> Merge jdk8u392-b01 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u392-b01 - Merge - 8301119: Support for GB18030-2022 - Merge - 8310026: [8u] make java_lang_String::hash_code consistent across platforms - 8309143: [8u] fix archiving inconsistencies in GHA - 8205399: Set node color on pinned HashMap.TreeNode deletion - 8200468: Port the native GSS-API bridge to Windows - 8139348: Deprecate 3DES and RC4 in Kerberos - 8253269: The CheckCommonColors test should provide more info on failure - ... and 1 more: https://git.openjdk.org/shenandoah-jdk8u/compare/2f3a3c16...6d26613a The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=52&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=52&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/52/files Stats: 1056 lines in 27 files changed: 574 ins; 317 del; 165 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/52.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/52/head:pull/52 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/52 From andrew at openjdk.org Wed Jun 18 15:53:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 15:53:53 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u392-b01 for changeset 587090dd Message-ID: Tagged by: Andrew John Hughes Date: 2023-07-31 17:54:58 +0000 Added tag jdk8u392-b01 for changeset 587090ddc17 Changeset: 587090dd Author: Andrew John Hughes Date: 2023-07-19 11:51:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/587090ddc17c073d56f4d3f52b61f6477d6322b0 From andrew at openjdk.org Wed Jun 18 15:53:38 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 15:53:38 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 11 new changesets Message-ID: <1593b895-5900-41c5-aebe-671dec0f7460@openjdk.org> Changeset: 4923d46b Branch: master Author: Andrew John Hughes Date: 2023-05-31 14:58:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4923d46b6f43f98c9cdc133c7161ab3b629621b0 8309122: Bump update version of OpenJDK: 8u392 Reviewed-by: serb, sgehwolf ! .jcheck/conf ! common/autoconf/version-numbers Changeset: 1c802b2a Branch: master Author: Sergey Bylokhov Date: 2023-05-31 21:49:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1c802b2ae8d00bedf425a4fe94f510bd8a616589 8253269: The CheckCommonColors test should provide more info on failure Backport-of: 1c2754bfe3294fb3c80defe5479bdd85b0d07e29 ! jdk/test/java/awt/Robot/CheckCommonColors/CheckCommonColors.java Changeset: 6244292d Branch: master Author: Ekaterina Vergizova Committer: Andrew John Hughes Date: 2023-06-02 02:25:17 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6244292d28e1cddcc70bc4dbf98adad13fe1e3d7 8139348: Deprecate 3DES and RC4 in Kerberos Reviewed-by: andrew Backport-of: ded96ddcde1e9e8556a6ce8948acef27b6e192cc ! jdk/src/share/classes/sun/security/krb5/internal/crypto/EType.java ! jdk/test/sun/security/krb5/auto/NewSalt.java ! jdk/test/sun/security/krb5/auto/W83.java ! jdk/test/sun/security/krb5/etype/WeakCrypto.java - jdk/test/sun/security/krb5/etype/weakcrypto.conf ! jdk/test/sun/security/krb5/tools/ktcheck.sh ! jdk/test/sun/security/krb5/tools/onlythree.conf Changeset: 09443845 Branch: master Author: Alexey Bakhtin Date: 2023-07-03 21:03:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/09443845df2ae520e8a3000f889aecf8d621c52c 8200468: Port the native GSS-API bridge to Windows Reviewed-by: andrew Backport-of: 0b6fbf50d24438117c33fa1a7d3633b792c99983 ! jdk/make/lib/SecurityLibraries.gmk ! jdk/src/share/classes/sun/security/jgss/GSSManagerImpl.java ! jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c + jdk/src/share/native/sun/security/jgss/wrapper/NativeFunc.c = jdk/src/share/native/sun/security/jgss/wrapper/NativeFunc.h ! jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.c ! jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h ! jdk/src/share/native/sun/security/jgss/wrapper/gssapi.h - jdk/src/solaris/native/sun/security/jgss/wrapper/NativeFunc.c ! jdk/test/java/security/testlibrary/Proc.java ! jdk/test/sun/security/krb5/auto/BasicProc.java Changeset: a2a68737 Branch: master Author: Aleksey Shipilev Date: 2023-07-07 13:21:29 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a2a68737d927e7afa6e5c2d2642d8cb42f9d6be9 8205399: Set node color on pinned HashMap.TreeNode deletion Backport-of: 51d0a9e1223f218d10f8761e38cd2dd478607040 ! jdk/src/share/classes/java/util/HashMap.java + jdk/test/java/util/HashMap/TreeBinAssert.java Changeset: 108003eb Branch: master Author: Zdenek Zambersky Date: 2023-07-10 11:24:39 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/108003eb378c7b830119bb7ae41d3a40fcd0809e 8309143: [8u] fix archiving inconsistencies in GHA Reviewed-by: phh, sgehwolf ! .github/workflows/submit.yml Changeset: 15077ad1 Branch: master Author: Zdenek Zambersky Date: 2023-07-10 11:44:01 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/15077ad189dc24d7776998f63c2245c3c61ab2bb 8310026: [8u] make java_lang_String::hash_code consistent across platforms Reviewed-by: phh, adinn, stuefe ! hotspot/agent/src/share/classes/sun/jvm/hotspot/utilities/Hashtable.java ! hotspot/src/share/vm/classfile/javaClasses.hpp ! hotspot/src/share/vm/classfile/symbolTable.cpp Changeset: e575cb38 Branch: master Author: Andrew John Hughes Date: 2023-07-12 11:04:37 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/e575cb38f0ef175d953da19e4413db1926a7ca8f Merge Changeset: 4dc1305c Branch: master Author: Andrew John Hughes Date: 2023-07-13 16:33:19 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/4dc1305cafe7913b194e9a8ebc01c49e6dc14a6d 8301119: Support for GB18030-2022 8310947: gb18030-2000 not selectable with LANG=zh_CN.GB18030 after JDK-8301119 Co-authored-by: Severin Gehwolf Reviewed-by: stuefe, sgehwolf Backport-of: 5c4e744dabcf7785c35168db5d0458ccebfd41e6 ! jdk/src/share/classes/sun/nio/cs/AbstractCharsetProvider.java ! jdk/src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! jdk/src/share/classes/sun/nio/cs/ext/GB18030.java ! jdk/test/java/nio/charset/Charset/RegisteredCharsets.java ! jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java ! jdk/test/sun/nio/cs/TestGB18030.java ! jdk/test/sun/nio/cs/mapping/CoderTest.java ! jdk/test/sun/nio/cs/mapping/GB18030.b2c = jdk/test/sun/nio/cs/mapping/GB18030_2000.b2c Changeset: 587090dd Branch: master Author: Andrew John Hughes Date: 2023-07-19 11:51:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/587090ddc17c073d56f4d3f52b61f6477d6322b0 Merge Changeset: 6d26613a Branch: master Author: Andrew John Hughes Date: 2025-06-18 16:02:47 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6d26613a4a33331723cf2628c135aa90ede25f7a Merge jdk8u392-b01 Added tag jdk8u392-b01 for changeset 587090ddc17 ! .jcheck/conf ! hotspot/src/share/vm/classfile/symbolTable.cpp ! .jcheck/conf ! hotspot/src/share/vm/classfile/symbolTable.cpp From andrew at openjdk.org Wed Jun 18 15:54:02 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 15:54:02 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u392-b01 for changeset 6d26613a Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-18 16:05:57 +0000 Added tag shenandoah8u392-b01 for changeset 6d26613a4a3 Changeset: 6d26613a Author: Andrew John Hughes Date: 2025-06-18 16:02:47 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/6d26613a4a33331723cf2628c135aa90ede25f7a From andrew at openjdk.org Wed Jun 18 15:54:28 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 15:54:28 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: <-tr9pQsKLoFzgxkA2bPu8cxbn9pYL_o1dGxTvf60I_8=.82c31f49-8c6e-4305-b1b8-64872287dcbd@github.com> References: <-tr9pQsKLoFzgxkA2bPu8cxbn9pYL_o1dGxTvf60I_8=.82c31f49-8c6e-4305-b1b8-64872287dcbd@github.com> Message-ID: > Merge jdk8u392-b01 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/52/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/52/files/6d26613a..6d26613a Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=52&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=52&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/52.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/52/head:pull/52 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/52 From iris at openjdk.org Wed Jun 18 15:54:29 2025 From: iris at openjdk.org (Iris Clark) Date: Wed, 18 Jun 2025 15:54:29 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: <-tr9pQsKLoFzgxkA2bPu8cxbn9pYL_o1dGxTvf60I_8=.82c31f49-8c6e-4305-b1b8-64872287dcbd@github.com> References: <-tr9pQsKLoFzgxkA2bPu8cxbn9pYL_o1dGxTvf60I_8=.82c31f49-8c6e-4305-b1b8-64872287dcbd@github.com> Message-ID: On Wed, 18 Jun 2025 15:24:28 GMT, Andrew John Hughes wrote: > Merge jdk8u392-b01 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/52 From kdnilsen at openjdk.org Wed Jun 18 16:32:08 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Wed, 18 Jun 2025 16:32:08 GMT Subject: RFR: 8359947: GenShen: use smaller TLABs by default Message-ID: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> We have found with certain workloads that the initial and maximum tlab sizes result in very high latencies for the first few invocations of particular methods for certain threads. The root cause is that TLABs are too large. This is causing allocatable memory to be depleted too quickly. When large numbers of threads are trying to startup at the same time, some of the threads end up with no TLABs or very small TLABs and their efforts run hundreds of times slower than the threads that were able to grab very large TLABs. This PR reduces the maximum TLAB size and adjusts the initial TLAB size in order to reduce the impact of this problem. This PR also changes the value of TLABAllocationWeight from 90 to 35 when we are running in generational mode. 35 is the default value used for G1 GC, which is also generational. The default value of 90 was established years ago for non-generational Shenandoah because it tends to have less frequent GC cycles than generational collectors. We have exercised this PR with three different workloads, which we identify as small, medium, and huge. We have also exercised in two different configurations: with and without 30s warmup before latency measurements are taken. Finally, we have applied this PR to both tip and to a development branch identified as adaptive-evac-with-surge. The initial motivation for this PR was identified during testing of the adaptive-evac-with-surge branch. That branch runs more aggressive GCs (larger evacuation workloads, with delayed (slightly more risky) triggers. The objectives of this branch are to make GCs more efficient and to reduce CPU consumption. We report 6 results for each experiment. We sort these according to P100 latencies, and average results from the bottom four (best performing) samples, tossing out the two high outliers from the averages. Workload results are subject to noise from elastic computing and operating system interference. The benefits of this PR are most notable with the p99.999 and p100 small configuration of adaptive-evac-with-surge and the huge configuration of tip: ![image](https://github.com/user-attachments/assets/def49a3c-4142-48f7-a946-33527e6985d0) ![image](https://github.com/user-attachments/assets/b0df27b3-f7b0-4fd2-82c3-ac84b0ad380e) ![image](https://github.com/user-attachments/assets/471c1292-96dc-46c1-9bcc-b851be07867d) Note also the degradation in p50 and other lower percentile latencies. The effect of this PR is to require each mutator thread to make more frequent allocation of smaller TLABs. This results in higher contention for Shenandoah's global heap lock. A separate development effort is refactoring the slow allocation path to use a single CAS for the large majority of TLAB allocations rather than the current mechanism, which requires each TLAB allocation to contend for exclusive access to the global heap lock, then hold the global heap lock during the search for memory to be allocated. We expect this other mechanism will improve all latencies, and should reduce or eliminate the performance regressions introduced at certain percentiles by this PR. For full context, other performance comparisons are also provided here. In the following reports, it is usually the case that the affect of this PR is to reduce the total number of GCs and to reduce the CPU utilization. Depending on the experiment, low percentile or high percentile response times improve. We attribute these differences to contention for global heap lock. We observe also that sometimes warming up an experiment for 30 seconds before beginning to measure latency has a similar effect to improving the initial TLAB size, as the pre-existing shared heuristics for adaptive TLAB sizing seem to converge fairly quickly on improved behavior, at least for this workload which is fairly consistent. A more variable workload may struggle more to find the optimal TLAB size. For such workloads, having smaller default TLAB sizes seems to reduce the likelihood of occasional serious performance degradation. ![image](https://github.com/user-attachments/assets/33205ba0-2ebb-4cfa-96e9-8fecd52d07ab) ![image](https://github.com/user-attachments/assets/1bf49dfc-f673-4371-940f-af76496385fe) ![image](https://github.com/user-attachments/assets/a960d02b-87fe-42bd-9b6d-0232d80d1804) While both versions of code are clearly overwhelmed for this Medium workload, it is interesting to observe that the PR produces two results that are much better than all six of the control runs. Better performance and more meaningful comparisons are provided by the adaptive-old-evac-with-surge experiments, shown below. ![image](https://github.com/user-attachments/assets/da83f673-93f5-4712-becf-49c00f5ffe8c) ![image](https://github.com/user-attachments/assets/9f37dd0b-2fbf-4cc9-a1e5-e1b694f125ad) ![image](https://github.com/user-attachments/assets/858b556c-9a44-426e-927f-f6a8d2f249b0) ![image](https://github.com/user-attachments/assets/3e17f4c5-0c5d-4b47-b2ad-6d7504394e31) ![image](https://github.com/user-attachments/assets/2fc79194-244b-4e4d-8547-5fcd02811a69) The small workload is represented by the following execution script. Note that we override the default region size in order to avoid out-of-memory-during-evacuation failures that were occurring in the default configuration due to a large number of objects of approximate size 781 KB. ~/github/jdk.adjust-initial-tlab-size/build/linux-x86_64-server-release/images/jdk/bin/java \ -XX:ActiveProcessorCount=2 \ -XX:+UnlockExperimentalVMOptions \ -XX:-ShenandoahPacing \ -XX:+AlwaysPreTouch -XX:+DisableExplicitGC -Xms4g -Xmx4g \ -XX:+UseShenandoahGC -XX:ShenandoahGCMode=generational \ -XX:ShenandoahFullGCThreshold=1024 \ -XX:ShenandoahMinRegionSize=4M \ -Xlog:"gc*=info,ergo" \ -Xlog:safepoint=trace -Xlog:safepoint=debug -Xlog:safepoint=info \ -XX:+UnlockDiagnosticVMOptions \ -jar ~/github/heapothesys.fix-two-bugs/Extremem/src/main/java/extremem.jar \ -dDictionarySize=3000000 \ -dNumCustomers=30000 \ -dNumProducts=30000 \ -dCustomerThreads=500 \ -dCustomerPeriod=5s \ -dCustomerThinkTime=1s \ -dKeywordSearchCount=1 \ -dSelectionCriteriaCount=3 \ -dProductReviewLength=12 \ -dServerThreads=5 \ -dServerPeriod=10s \ -dProductNameLength=10 \ -dBrowsingHistoryQueueCount=5 \ -dSalesTransactionQueueCount=5 \ -dProductDescriptionLength=40 \ -dProductReplacementPeriod=60s \ -dProductReplacementCount=25 \ -dCustomerReplacementPeriod=60s \ -dCustomerReplacementCount=1500 \ -dBrowsingExpiration=1m \ -dPhasedUpdates=true \ -dPhasedUpdateInterval=180s \ -dSimulationDuration=25m \ -dResponseTimeMeasurements=100000 \ >$t.genshen.MaxRSWby8-TLABisRSBby128.small.overrides.out 2>$t.genshen.MaxRSWby8-TLABisRSBby128.small.overrides.err & job_pid=$! sleep 1500 cpu_percent=$(ps -o cputime -o etime -p $job_pid) rss_kb=$(ps -o rss= -p $job_pid) rss_mb=$((rss_kb / 1024)) wait $job_pid echo "RSS: $rss_mb MB" >>$t.genshen.MaxRSWby32-TLABisRSBby256.small.overrides.out 2>>$t.genshen.MaxRSWby32-TLABisRSBby256.small.overrides.err echo "$cpu_percent" >>$t.genshen.MaxRSWby32-TLABisRSBby256.small.overrides.out gzip $t.genshen.MaxRSWby32-TLABisRSBby256.small.overrides.out $t.genshen.MaxRSWby32-TLABisRSBby256.small.overrides.err The medium workload is represented by this execution script: ~/github/jdk.adaptive-evac-with-surge/build/linux-x86_64-server-release/images/jdk/bin/java \ -XX:+UnlockExperimentalVMOptions \ -XX:-ShenandoahPacing \ -XX:+AlwaysPreTouch -XX:+DisableExplicitGC -Xms31g -Xmx31g \ -XX:+UseShenandoahGC -XX:ShenandoahGCMode=generational \ -XX:ShenandoahFullGCThreshold=1024 \ -XX:ShenandoahGuaranteedOldGCInterval=0 \ -XX:ShenandoahGuaranteedYoungGCInterval=0 \ -Xlog:"gc*=info,ergo" \ -Xlog:safepoint=trace -Xlog:safepoint=debug -Xlog:safepoint=info \ -XX:+UnlockDiagnosticVMOptions \ -jar ~/github/heapothesys/Extremem/src/main/java/extremem.jar \ -dDictionarySize=3000000 \ -dNumCustomers=3600000 \ -dNumProducts=320000 \ -dCustomerThreads=500 \ -dAllowAnyMatch=false \ -dCustomerPeriod=5s \ -dCustomerThinkTime=1s \ -dKeywordSearchCount=2 \ -dSelectionCriteriaCount=2 \ -dProductReviewLength=12 \ -dServerThreads=5 \ -dServerPeriod=10s \ -dProductNameLength=10 \ -dBrowsingHistoryQueueCount=5 \ -dSalesTransactionQueueCount=5 \ -dProductDescriptionLength=512 \ -dProductReplacementPeriod=60s \ -dProductReplacementCount=25 \ -dCustomerReplacementPeriod=60s \ -dCustomerReplacementCount=1500 \ -dBrowsingExpiration=1m \ -dPhasedUpdates=true \ -dPhasedUpdateInterval=180s \ -dSimulationDuration=25m \ -dResponseTimeMeasurements=100000 \ >$t.retry.genshen.medium.adaptive-evac-with-surge.control.out 2>$t.retry.genshen.medium.adaptive-evac-with-surge.control.err & job_pid=$! sleep 1500 cpu_percent=$(ps -o cputime -o etime -p $job_pid) rss_kb=$(ps -o rss= -p $job_pid) rss_mb=$((rss_kb / 1024)) wait $job_pid echo "RSS: $rss_mb MB" >>$t.retry.genshen.medium.adaptive-evac-with-surge.control.out echo "$cpu_percent" >>$t.retry.genshen.medium.adaptive-evac-with-surge.control.out gzip $t.retry.genshen.medium.adaptive-evac-with-surge.control.out $t.retry.genshen.medium.adaptive-evac-with-surge.control.err An additional parameter was added to the adaptive-evac-with-surge configurations, to make the adaptive old GC trigger slightly more sensitive: -XX:ShenandoahMinOldGenGrowthHeapPercent=2 \ The huge workload is represented by this execution script: ~/github/jdk.adjust-initial-tlab-size/build/linux-x86_64-server-release/images/jdk/bin/java \ -XX:ActiveProcessorCount=16 \ -XX:+UnlockExperimentalVMOptions \ -XX:-ShenandoahPacing \ -XX:+AlwaysPreTouch -XX:+DisableExplicitGC -Xms512g -Xmx512g \ -XX:+UseShenandoahGC -XX:ShenandoahGCMode=generational \ -XX:ShenandoahFullGCThreshold=1024 \ -XX:ShenandoahGuaranteedGCInterval=0 \ -XX:ShenandoahGuaranteedOldGCInterval=0 \ -XX:ShenandoahGuaranteedYoungGCInterval=0 \ -Xlog:"gc*=info,ergo" \ -Xlog:safepoint=trace -Xlog:safepoint=debug -Xlog:safepoint=info \ -XX:+UnlockDiagnosticVMOptions \ -jar ~/github/heapothesys/Extremem/src/main/java/extremem.jar \ -dDictionarySize=3000000 \ -dNumCustomers=210000000 \ -dNumProducts=18000000 \ -dCustomerThreads=2000 \ -dCustomerPeriod=2000ms \ -dCustomerThinkTime=300ms \ -dKeywordSearchCount=2 \ -dAllowAnyMatch=false \ -dSelectionCriteriaCount=3 \ -dProductReviewLength=96 \ -dBuyThreshold=0.5 \ -dSaveForLaterThreshold=0.15 \ -dBrowsingExpiration=5m \ -dServerThreads=20 \ -dServerPeriod=10s \ -dProductNameLength=6 \ -dProductDescriptionLength=70 \ -dBrowsingHistoryQueueCount=1 \ -dSalesTransactionQueueCount=1 \ -dProductReplacementPeriod=60s \ -dProductReplacementCount=25 \ -dCustomerReplacementPeriod=60s \ -dCustomerReplacementCount=150 \ -dBrowsingExpiration=1m \ -dSimulationDuration=25m \ -dResponseTimeMeasurements=100000 \ -dPhasedUpdates=true \ -dPhasedUpdateInterval=180s \ >$t.genshen.huge.MaxTLABisRSWby32-TLABisRSBisRSBby256.out 2>$t.genshen.huge.MaxTLABisRSWby32-TLABisRSBisRSBby256.err & job_pid=$! sleep 3000 cpu_percent=$(ps -o cputime -o etime -p $job_pid) rss_kb=$(ps -o rss= -p $job_pid) rss_mb=$((rss_kb / 1024)) wait $job_pid echo "RSS: $rss_kb KB" >>$t.genshen.huge.MaxTLABisRSWby32-TLABisRSBisRSBby256.out echo "RSS: $rss_mb MB" >>$t.genshen.huge.MaxTLABisRSWby32-TLABisRSBisRSBby256.out echo "$cpu_percent" >>$t.genshen.huge.MaxTLABisRSWby32-TLABisRSBisRSBby256.out gzip $t.genshen.huge.MaxTLABisRSWby32-TLABisRSBisRSBby256.out $t.genshen.huge.MaxTLABisRSWby32-TLABisRSBisRSBby256.err ------------- Commit messages: - Fix white space - Shrink default TLABSize in half - MaxRSWby32-TLABisRSBby128 - Tidy up for review - Merge branch 'adjust-initial-tlab-size' of https://github.com/kdnilsen/jdk into adjust-initial-tlab-size - MaxTLABisRSWby1 TLABSisRSBby128 TLABAllocationWeight=35 - Add constraints for very large heap sizes with MaxTLABisRSWby8 TLABisRSBby128 - MaxTLABisRSWby1 TLABSisDefault TLABAllocationWeight=90 - MaxTLABisRSWby1-TLABisDefault - MaxTLABisRSWby2 TLABisDefault - ... and 40 more: https://git.openjdk.org/jdk/compare/92730945...e8b35937 Changes: https://git.openjdk.org/jdk/pull/25423/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25423&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359947 Stats: 18 lines in 3 files changed: 12 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/25423.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25423/head:pull/25423 PR: https://git.openjdk.org/jdk/pull/25423 From kdnilsen at openjdk.org Wed Jun 18 16:32:08 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Wed, 18 Jun 2025 16:32:08 GMT Subject: RFR: 8359947: GenShen: use smaller TLABs by default In-Reply-To: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> References: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> Message-ID: On Fri, 23 May 2025 20:13:21 GMT, Kelvin Nilsen wrote: > We have found with certain workloads that the initial and maximum tlab sizes result in very high latencies for the first few invocations of particular methods for certain threads. The root cause is that TLABs are too large. This is causing allocatable memory to be depleted too quickly. When large numbers of threads are trying to startup at the same time, some of the threads end up with no TLABs or very small TLABs and their efforts run hundreds of times slower than the threads that were able to grab very large TLABs. > > This PR reduces the maximum TLAB size and adjusts the initial TLAB size in order to reduce the impact of this problem. > > This PR also changes the value of TLABAllocationWeight from 90 to 35 when we are running in generational mode. 35 is the default value used for G1 GC, which is also generational. The default value of 90 was established years ago for non-generational Shenandoah because it tends to have less frequent GC cycles than generational collectors. > > We have exercised this PR with three different workloads, which we identify as small, medium, and huge. We have also exercised in two different configurations: with and without 30s warmup before latency measurements are taken. Finally, we have applied this PR to both tip and to a development branch identified as adaptive-evac-with-surge. > > The initial motivation for this PR was identified during testing of the adaptive-evac-with-surge branch. That branch runs more aggressive GCs (larger evacuation workloads, with delayed (slightly more risky) triggers. The objectives of this branch are to make GCs more efficient and to reduce CPU consumption. > > We report 6 results for each experiment. We sort these according to P100 latencies, and average results from the bottom four (best performing) samples, tossing out the two high outliers from the averages. Workload results are subject to noise from elastic computing and operating system interference. > > The benefits of this PR are most notable with the p99.999 and p100 small configuration of adaptive-evac-with-surge and the huge configuration of tip: > > ![image](https://github.com/user-attachments/assets/def49a3c-4142-48f7-a946-33527e6985d0) > > ![image](https://github.com/user-attachments/assets/b0df27b3-f7b0-4fd2-82c3-ac84b0ad380e) > > ![image](https://github.com/user-attachments/assets/471c1292-96dc-46c1-9bcc-b851be07867d) > > Note also the degradation in p50 and other lower percentile latencies. The effect of this PR is to require each mutator threa... Leaving this in draft while I prepare details for review. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25423#issuecomment-2905742286 From kdnilsen at openjdk.org Wed Jun 18 16:38:45 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Wed, 18 Jun 2025 16:38:45 GMT Subject: RFR: 8359947: GenShen: use smaller TLABs by default [v2] In-Reply-To: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> References: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> Message-ID: > We have found with certain workloads that the initial and maximum tlab sizes result in very high latencies for the first few invocations of particular methods for certain threads. The root cause is that TLABs are too large. This is causing allocatable memory to be depleted too quickly. When large numbers of threads are trying to startup at the same time, some of the threads end up with no TLABs or very small TLABs and their efforts run hundreds of times slower than the threads that were able to grab very large TLABs. > > This PR reduces the maximum TLAB size and adjusts the initial TLAB size in order to reduce the impact of this problem. > > This PR also changes the value of TLABAllocationWeight from 90 to 35 when we are running in generational mode. 35 is the default value used for G1 GC, which is also generational. The default value of 90 was established years ago for non-generational Shenandoah because it tends to have less frequent GC cycles than generational collectors. > > We have exercised this PR with three different workloads, which we identify as small, medium, and huge. We have also exercised in two different configurations: with and without 30s warmup before latency measurements are taken. Finally, we have applied this PR to both tip and to a development branch identified as adaptive-evac-with-surge. > > The initial motivation for this PR was identified during testing of the adaptive-evac-with-surge branch. That branch runs more aggressive GCs (larger evacuation workloads, with delayed (slightly more risky) triggers. The objectives of this branch are to make GCs more efficient and to reduce CPU consumption. > > We report 6 results for each experiment. We sort these according to P100 latencies, and average results from the bottom four (best performing) samples, tossing out the two high outliers from the averages. Workload results are subject to noise from elastic computing and operating system interference. > > The benefits of this PR are most notable with the p99.999 and p100 small configuration of adaptive-evac-with-surge and the huge configuration of tip: > > ![image](https://github.com/user-attachments/assets/def49a3c-4142-48f7-a946-33527e6985d0) > > ![image](https://github.com/user-attachments/assets/b0df27b3-f7b0-4fd2-82c3-ac84b0ad380e) > > ![image](https://github.com/user-attachments/assets/471c1292-96dc-46c1-9bcc-b851be07867d) > > Note also the degradation in p50 and other lower percentile latencies. The effect of this PR is to require each mutator threa... Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision: Remove debug instrumentation ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25423/files - new: https://git.openjdk.org/jdk/pull/25423/files/e8b35937..456ee6e3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25423&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25423&range=00-01 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25423.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25423/head:pull/25423 PR: https://git.openjdk.org/jdk/pull/25423 From phh at openjdk.org Wed Jun 18 16:42:32 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 18 Jun 2025 16:42:32 GMT Subject: RFR: 8359947: GenShen: use smaller TLABs by default [v2] In-Reply-To: References: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> Message-ID: On Wed, 18 Jun 2025 16:38:45 GMT, Kelvin Nilsen wrote: >> We have found with certain workloads that the initial and maximum tlab sizes result in very high latencies for the first few invocations of particular methods for certain threads. The root cause is that TLABs are too large. This is causing allocatable memory to be depleted too quickly. When large numbers of threads are trying to startup at the same time, some of the threads end up with no TLABs or very small TLABs and their efforts run hundreds of times slower than the threads that were able to grab very large TLABs. >> >> This PR reduces the maximum TLAB size and adjusts the initial TLAB size in order to reduce the impact of this problem. >> >> This PR also changes the value of TLABAllocationWeight from 90 to 35 when we are running in generational mode. 35 is the default value used for G1 GC, which is also generational. The default value of 90 was established years ago for non-generational Shenandoah because it tends to have less frequent GC cycles than generational collectors. >> >> We have exercised this PR with three different workloads, which we identify as small, medium, and huge. We have also exercised in two different configurations: with and without 30s warmup before latency measurements are taken. Finally, we have applied this PR to both tip and to a development branch identified as adaptive-evac-with-surge. >> >> The initial motivation for this PR was identified during testing of the adaptive-evac-with-surge branch. That branch runs more aggressive GCs (larger evacuation workloads, with delayed (slightly more risky) triggers. The objectives of this branch are to make GCs more efficient and to reduce CPU consumption. >> >> We report 6 results for each experiment. We sort these according to P100 latencies, and average results from the bottom four (best performing) samples, tossing out the two high outliers from the averages. Workload results are subject to noise from elastic computing and operating system interference. >> >> The benefits of this PR are most notable with the p99.999 and p100 small configuration of adaptive-evac-with-surge and the huge configuration of tip: >> >> ![image](https://github.com/user-attachments/assets/def49a3c-4142-48f7-a946-33527e6985d0) >> >> ![image](https://github.com/user-attachments/assets/b0df27b3-f7b0-4fd2-82c3-ac84b0ad380e) >> >> ![image](https://github.com/user-attachments/assets/471c1292-96dc-46c1-9bcc-b851be07867d) >> >> Note also the degradation in p50 and other lower percentile latencies. The effect o... > > Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision: > > Remove debug instrumentation What's the rationale for using a fraction of the region size as a possible maximum TLAB size? Region size seems unrelated to thread object allocation demand. ------------- PR Review: https://git.openjdk.org/jdk/pull/25423#pullrequestreview-2939988648 From andrew at openjdk.org Wed Jun 18 16:43:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jun 2025 16:43:53 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u392-b02 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u392-b02 - 6722928: Provide a default native GSS-API library on Windows - 8287073: NPE from CgroupV2Subsystem.getInstance() - 8308788: [8u] Remove duplicate HaricaCA.java test - 8232225: Rework the fix for JDK-8071483 - 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException - 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java - 8214046: [macosx] Undecorated Frame does not Iconify when set to The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/53/files Stats: 2280 lines in 20 files changed: 1646 ins; 526 del; 108 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/53.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/53/head:pull/53 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/53 From kdnilsen at openjdk.org Wed Jun 18 16:52:33 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Wed, 18 Jun 2025 16:52:33 GMT Subject: RFR: 8359947: GenShen: use smaller TLABs by default [v2] In-Reply-To: References: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> Message-ID: On Wed, 18 Jun 2025 16:39:42 GMT, Paul Hohensee wrote: > What's the rationale for using a fraction of the region size as a possible maximum TLAB size? Region size seems unrelated to thread object allocation demand. Region size is generally proportional to total heap size. If we have larger heap sizes, we have more abundant memory, and can generally afford to be "slightly" more generous in apportionment of memory between threads. But we do this within limits. The initial TLAB size is never made smaller than 32KB and the max TLAB size is never made larger than 256KB. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25423#issuecomment-2985016769 From phh at openjdk.org Wed Jun 18 17:58:33 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 18 Jun 2025 17:58:33 GMT Subject: RFR: 8359947: GenShen: use smaller TLABs by default [v2] In-Reply-To: References: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> Message-ID: On Wed, 18 Jun 2025 16:38:45 GMT, Kelvin Nilsen wrote: >> We have found with certain workloads that the initial and maximum tlab sizes result in very high latencies for the first few invocations of particular methods for certain threads. The root cause is that TLABs are too large. This is causing allocatable memory to be depleted too quickly. When large numbers of threads are trying to startup at the same time, some of the threads end up with no TLABs or very small TLABs and their efforts run hundreds of times slower than the threads that were able to grab very large TLABs. >> >> This PR reduces the maximum TLAB size and adjusts the initial TLAB size in order to reduce the impact of this problem. >> >> This PR also changes the value of TLABAllocationWeight from 90 to 35 when we are running in generational mode. 35 is the default value used for G1 GC, which is also generational. The default value of 90 was established years ago for non-generational Shenandoah because it tends to have less frequent GC cycles than generational collectors. >> >> We have exercised this PR with three different workloads, which we identify as small, medium, and huge. We have also exercised in two different configurations: with and without 30s warmup before latency measurements are taken. Finally, we have applied this PR to both tip and to a development branch identified as adaptive-evac-with-surge. >> >> The initial motivation for this PR was identified during testing of the adaptive-evac-with-surge branch. That branch runs more aggressive GCs (larger evacuation workloads, with delayed (slightly more risky) triggers). The objectives of this branch are to make GCs more efficient and to reduce CPU consumption. >> >> We report 6 results for each experiment. We sort these according to P100 latencies, and average results from the bottom four (best performing) samples, tossing out the two high outliers from the averages. Workload results are subject to noise from elastic computing and operating system interference. >> >> The benefits of this PR are most notable with the p99.999 and p100 small configuration of adaptive-evac-with-surge and the huge configuration of tip: >> >> ![image](https://github.com/user-attachments/assets/def49a3c-4142-48f7-a946-33527e6985d0) >> >> ![image](https://github.com/user-attachments/assets/b0df27b3-f7b0-4fd2-82c3-ac84b0ad380e) >> >> ![image](https://github.com/user-attachments/assets/471c1292-96dc-46c1-9bcc-b851be07867d) >> >> Note also the degradation in p50 and other lower percentile latencies. The effect ... > > Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision: > > Remove debug instrumentation Ok, makes sense. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25423#pullrequestreview-2940191050 From xpeng at openjdk.org Wed Jun 18 18:46:40 2025 From: xpeng at openjdk.org (Xiaolong Peng) Date: Wed, 18 Jun 2025 18:46:40 GMT Subject: RFR: 8359947: GenShen: use smaller TLABs by default [v2] In-Reply-To: References: <1072g2RnSN--eWgcAOHvElE0OI03fCdGJNGIgFNDnOQ=.21aca821-59c9-47b5-b1a2-6214f85dd5d3@github.com> Message-ID: On Wed, 18 Jun 2025 16:38:45 GMT, Kelvin Nilsen wrote: >> We have found with certain workloads that the initial and maximum tlab sizes result in very high latencies for the first few invocations of particular methods for certain threads. The root cause is that TLABs are too large. This is causing allocatable memory to be depleted too quickly. When large numbers of threads are trying to startup at the same time, some of the threads end up with no TLABs or very small TLABs and their efforts run hundreds of times slower than the threads that were able to grab very large TLABs. >> >> This PR reduces the maximum TLAB size and adjusts the initial TLAB size in order to reduce the impact of this problem. >> >> This PR also changes the value of TLABAllocationWeight from 90 to 35 when we are running in generational mode. 35 is the default value used for G1 GC, which is also generational. The default value of 90 was established years ago for non-generational Shenandoah because it tends to have less frequent GC cycles than generational collectors. >> >> We have exercised this PR with three different workloads, which we identify as small, medium, and huge. We have also exercised in two different configurations: with and without 30s warmup before latency measurements are taken. Finally, we have applied this PR to both tip and to a development branch identified as adaptive-evac-with-surge. >> >> The initial motivation for this PR was identified during testing of the adaptive-evac-with-surge branch. That branch runs more aggressive GCs (larger evacuation workloads, with delayed (slightly more risky) triggers). The objectives of this branch are to make GCs more efficient and to reduce CPU consumption. >> >> We report 6 results for each experiment. We sort these according to P100 latencies, and average results from the bottom four (best performing) samples, tossing out the two high outliers from the averages. Workload results are subject to noise from elastic computing and operating system interference. >> >> The benefits of this PR are most notable with the p99.999 and p100 small configuration of adaptive-evac-with-surge and the huge configuration of tip: >> >> ![image](https://github.com/user-attachments/assets/def49a3c-4142-48f7-a946-33527e6985d0) >> >> ![image](https://github.com/user-attachments/assets/b0df27b3-f7b0-4fd2-82c3-ac84b0ad380e) >> >> ![image](https://github.com/user-attachments/assets/471c1292-96dc-46c1-9bcc-b851be07867d) >> >> Note also the degradation in p50 and other lower percentile latencies. The effect ... > > Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision: > > Remove debug instrumentation Looks good to me! Smaller tlab will result more contention on heap lock in the slow path to allocate tlab, the task I am working on to use CAS may help to mitigate. ------------- Marked as reviewed by xpeng (Committer). PR Review: https://git.openjdk.org/jdk/pull/25423#pullrequestreview-2940310161 From mdoerr at openjdk.org Wed Jun 18 19:59:29 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 18 Jun 2025 19:59:29 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v8] In-Reply-To: <2gdPUDg-i40xRoO8LZPWszL2-oa6s7GNZEDRfHfDk8s=.4dbfe74a-070b-46c1-b73d-0292824d02e9@github.com> References: <2gdPUDg-i40xRoO8LZPWszL2-oa6s7GNZEDRfHfDk8s=.4dbfe74a-070b-46c1-b73d-0292824d02e9@github.com> Message-ID: <7dqmRsrYN1O1zVQSYvFbVpmjSSABHnw7dL8QXSkrOtE=.eceed621-7482-436e-a999-73b6d2611616@github.com> On Tue, 17 Jun 2025 20:59:46 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > 2nd try at arm fix Unfortunately, there's a merge conflict, now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2985526434 From mdoerr at openjdk.org Wed Jun 18 19:59:30 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 18 Jun 2025 19:59:30 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 11:34:02 GMT, Erik ?sterlund wrote: >> If I understand your concern correctly, there is no race. The only caller of BarrierSetNMethod::make_not_entrant() is nmethod::make_not_entrant(), and it is done inside a NMethodState_lock critical section. After a call to nmethod::make_not_entrant(), the nmethod entry barrier is armed and stays that way. >> And by design, a disarm only disarms at the inner nmethod_entry_barrier level, not the outer nmethod_stub_entry_barrier level. > > My concern is that while thread 1 calls nmethod::make_not_entrant(), thread 2 racingly performs nmethod entry barrier; it makes the is_not_entrant check before it gets updated, but then it gets updated as the per nmethod lock is taken. The GC code "disarms" the GC barrier but in doing so finds that "oh this should be not entrant", but that's sort of not reflected as thread 2 will then proceed with entering the nmethod it just armed as not entrant in the nmethod entry barrier code. > Does that make sense? Doesn't the old code have the same limitation? If thread 1 patches the entry point after thread 2 has executed the first instruction, thread 2 will be inside the nmethod if GC has disarmed the nmethod entry barrier. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2155390909 From eosterlund at openjdk.org Wed Jun 18 20:28:29 2025 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 18 Jun 2025 20:28:29 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 19:56:27 GMT, Martin Doerr wrote: >> My concern is that while thread 1 calls nmethod::make_not_entrant(), thread 2 racingly performs nmethod entry barrier; it makes the is_not_entrant check before it gets updated, but then it gets updated as the per nmethod lock is taken. The GC code "disarms" the GC barrier but in doing so finds that "oh this should be not entrant", but that's sort of not reflected as thread 2 will then proceed with entering the nmethod it just armed as not entrant in the nmethod entry barrier code. >> Does that make sense? > > Doesn't the old code have the same limitation? If thread 1 patches the entry point after thread 2 has executed the first instruction, thread 2 will be inside the nmethod if GC has disarmed the nmethod entry barrier. Well, yeah sort of. And hence the comment that it's probably fine in terms of correctness. They were also a bit more independent systems then though. Just thought that if we now take the step to merge compiler and GC entry trap mechanisms into the nmethod entry barrier, that we could seemingly also make it a bit less slippery here and establish some sort of invariant that if we while holding the lock protecting the entry barrier find that the nmethod entry barrier is not entrant, for whatever reason, we should not enter it. Would make it easier to understand the code I suspect. What do you think? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2155434971 From dlong at openjdk.org Thu Jun 19 00:22:30 2025 From: dlong at openjdk.org (Dean Long) Date: Thu, 19 Jun 2025 00:22:30 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4] In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 20:25:44 GMT, Erik ?sterlund wrote: >> Doesn't the old code have the same limitation? If thread 1 patches the entry point after thread 2 has executed the first instruction, thread 2 will be inside the nmethod if GC has disarmed the nmethod entry barrier. > > Well, yeah sort of. And hence the comment that it's probably fine in terms of correctness. They were also a bit more independent systems then though. Just thought that if we now take the step to merge compiler and GC entry trap mechanisms into the nmethod entry barrier, that we could seemingly also make it a bit less slippery here and establish some sort of invariant that if we while holding the lock protecting the entry barrier find that the nmethod entry barrier is not entrant, for whatever reason, we should not enter it. Would make it easier to understand the code I suspect. What do you think? I think making it less slippery in one place but still leaving other races gives a false sense of security and makes the code harder to understand. Arming the barrier is not guaranteed to be visible until there is a safepoint. Note that AArch64 and RISCV only call increment_patching_epoch() when the guard value is set to the disarmed value, so there is no invalidation of the CPU pipeline or instruction buffer (cross modification fence) when arming. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2155757120 From wkemper at openjdk.org Thu Jun 19 14:29:38 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 19 Jun 2025 14:29:38 GMT Subject: RFR: Merge openjdk/jdk21u:master Message-ID: Merges tag jdk-21.0.8+7 ------------- Commit messages: - 8359170: Add 2 TLS and 2 CS Sectigo roots The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk21u/pull/199/files Stats: 479 lines in 7 files changed: 475 ins; 0 del; 4 mod Patch: https://git.openjdk.org/shenandoah-jdk21u/pull/199.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/199/head:pull/199 PR: https://git.openjdk.org/shenandoah-jdk21u/pull/199 From wkemper at openjdk.org Thu Jun 19 18:32:41 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 19 Jun 2025 18:32:41 GMT Subject: RFR: Merge openjdk/jdk21u:master [v2] In-Reply-To: References: Message-ID: > Merges tag jdk-21.0.8+7 William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk21u/pull/199/files - new: https://git.openjdk.org/shenandoah-jdk21u/pull/199/files/f4b3a70f..f4b3a70f Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk21u&pr=199&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk21u&pr=199&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk21u/pull/199.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/199/head:pull/199 PR: https://git.openjdk.org/shenandoah-jdk21u/pull/199 From wkemper at openjdk.org Thu Jun 19 18:32:42 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 19 Jun 2025 18:32:42 GMT Subject: Integrated: Merge openjdk/jdk21u:master In-Reply-To: References: Message-ID: On Thu, 19 Jun 2025 14:23:15 GMT, William Kemper wrote: > Merges tag jdk-21.0.8+7 This pull request has now been integrated. Changeset: 707e2b95 Author: William Kemper URL: https://git.openjdk.org/shenandoah-jdk21u/commit/707e2b95c3be8e9ba5ce28784ec4ec40969fce5b Stats: 479 lines in 7 files changed: 475 ins; 0 del; 4 mod Merge ------------- PR: https://git.openjdk.org/shenandoah-jdk21u/pull/199 From shade at openjdk.org Thu Jun 19 18:39:29 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 19 Jun 2025 18:39:29 GMT Subject: RFR: 8359394: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > Remove `GCCause::_no_cause_specified` (only referenced by Shenandoah) and add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string` and the `SA` analog. Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2943805126 From wkemper at openjdk.org Thu Jun 19 18:43:33 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 19 Jun 2025 18:43:33 GMT Subject: Integrated: 8359394: GC cause cleanup In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > Remove `GCCause::_no_cause_specified` (only referenced by Shenandoah) and add a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string` and the `SA` analog. This pull request has now been integrated. Changeset: dec42beb Author: William Kemper URL: https://git.openjdk.org/jdk/commit/dec42bebb836b2ea244dc19a5964dac828791135 Stats: 18 lines in 5 files changed: 5 ins; 6 del; 7 mod 8359394: GC cause cleanup Reviewed-by: shade, ysr, stefank ------------- PR: https://git.openjdk.org/jdk/pull/25789 From wkemper at openjdk.org Thu Jun 19 20:27:23 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 19 Jun 2025 20:27:23 GMT Subject: RFR: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed Message-ID: Shenandoah captures a preliminary top-at-mark-start (TAMS) concurrently. Once concurrent marking has begun, any object beneath TAMS requires a barrier when accessed. The implementation of `ShenandoahHeap::requires_barrier` does not distinguish between _old_ and _young_ marking. This could lead to a race between freezing the stack and capturing TAMS: 1. Collector is marking old 2. Allocate stack chunk in young 3. Barrier is not needed, begin fast freeze path 4. Collector concurrently updates TAMS (young marking will start once init-mark safepoint is reached) 5. ShenandoahHeap now thinks the barrier is needed (because TAMS changed, and we are marking old) 6. Fast freeze asserts out This fix has the generational mode check the appropriate generation and its marking state. It also enforces barriers for stackChunks in the old generation (for card marking). ------------- Commit messages: - override requires_barriers for generational mode Changes: https://git.openjdk.org/jdk/pull/25905/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25905&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357550 Stats: 25 lines in 2 files changed: 25 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25905.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25905/head:pull/25905 PR: https://git.openjdk.org/jdk/pull/25905 From kdnilsen at openjdk.org Thu Jun 19 20:57:37 2025 From: kdnilsen at openjdk.org (Kelvin Nilsen) Date: Thu, 19 Jun 2025 20:57:37 GMT Subject: RFR: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed In-Reply-To: References: Message-ID: On Thu, 19 Jun 2025 20:21:35 GMT, William Kemper wrote: > Shenandoah captures a preliminary top-at-mark-start (TAMS) concurrently. Once concurrent marking has begun, any object beneath TAMS requires a barrier when accessed. The implementation of `ShenandoahHeap::requires_barrier` does not distinguish between _old_ and _young_ marking. This could lead to a race between freezing the stack and capturing TAMS: > > 1. Collector is marking old > 2. Allocate stack chunk in young > 3. Barrier is not needed, begin fast freeze path > 4. Collector concurrently updates TAMS (young marking will start once init-mark safepoint is reached) > 5. ShenandoahHeap now thinks the barrier is needed (because TAMS changed, and we are marking old) > 6. Fast freeze asserts out > > This fix has the generational mode check the appropriate generation and its marking state. It also enforces barriers for stackChunks in the old generation (for card marking). Marked as reviewed by kdnilsen (Committer). src/hotspot/share/gc/shenandoah/shenandoahGenerationalHeap.cpp line 191: > 189: } > 190: > 191: if (is_concurrent_young_mark_in_progress() && is_in_young(obj) && !marking_context()->allocated_after_mark_start(obj)) { Just so I understand (and maybe this deserves a clarifying comment to help others understand): The barrier we are concerned about here is SATB. If obj is above TAMS, there's no need to enforce a SATB barrier. Any reference residing above TAMS which is overwritten will have been marked already, or is about to be marked. Either the value is already "presumed marked" because it also resides above TAMS, or its value was assigned from a root (in which case root scanning marked it), or it was copied from a pre-existing object (in which case it will be marked by scanning of that pre-existing object or by SATB). ------------- PR Review: https://git.openjdk.org/jdk/pull/25905#pullrequestreview-2944013440 PR Review Comment: https://git.openjdk.org/jdk/pull/25905#discussion_r2157651598 From wkemper at openjdk.org Thu Jun 19 21:32:28 2025 From: wkemper at openjdk.org (William Kemper) Date: Thu, 19 Jun 2025 21:32:28 GMT Subject: RFR: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed In-Reply-To: References: Message-ID: On Thu, 19 Jun 2025 20:55:03 GMT, Kelvin Nilsen wrote: >> Shenandoah captures a preliminary top-at-mark-start (TAMS) concurrently. Once concurrent marking has begun, any object beneath TAMS requires a barrier when accessed. The implementation of `ShenandoahHeap::requires_barrier` does not distinguish between _old_ and _young_ marking. This could lead to a race between freezing the stack and capturing TAMS: >> >> 1. Collector is marking old >> 2. Allocate stack chunk in young >> 3. Barrier is not needed, begin fast freeze path >> 4. Collector concurrently updates TAMS (young marking will start once init-mark safepoint is reached) >> 5. ShenandoahHeap now thinks the barrier is needed (because TAMS changed, and we are marking old) >> 6. Fast freeze asserts out >> >> This fix has the generational mode check the appropriate generation and its marking state. It also enforces barriers for stackChunks in the old generation (for card marking). > > src/hotspot/share/gc/shenandoah/shenandoahGenerationalHeap.cpp line 191: > >> 189: } >> 190: >> 191: if (is_concurrent_young_mark_in_progress() && is_in_young(obj) && !marking_context()->allocated_after_mark_start(obj)) { > > Just so I understand (and maybe this deserves a clarifying comment to help others understand): > The barrier we are concerned about here is SATB. If obj is above TAMS, there's no need to enforce a SATB barrier. Any reference residing above TAMS which is overwritten will have been marked already, or is about to be marked. Either the value is already "presumed marked" because it also resides above TAMS, or its value was assigned from a root (in which case root scanning marked it), or it was copied from a pre-existing object (in which case it will be marked by scanning of that pre-existing object or by SATB). Yes, concerned about SATB here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25905#discussion_r2157677596 From andrew at openjdk.org Thu Jun 19 23:13:27 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 19 Jun 2025 23:13:27 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 8 new changesets Message-ID: Changeset: a039c8a5 Branch: master Author: Tobias Gesellchen Committer: Paul Hohensee Date: 2023-08-07 17:55:48 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/a039c8a5d98abb2223a02a9591e805891259221f 8214046: [macosx] Undecorated Frame does not Iconify when set to Reviewed-by: phh, serb Backport-of: ab97f65242dad6ad1a7bfb8284954f202eb37369 ! jdk/src/macosx/native/sun/awt/AWTWindow.m ! jdk/test/java/awt/Frame/NormalToIconified/NormalToIconifiedTest.java Changeset: 893340a7 Branch: master Author: Ben Taylor Committer: Paul Hohensee Date: 2023-08-09 16:13:49 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/893340a78b23b6dd6086a79d4d07cf220caaedc4 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java Removed test/runtime/6925573/SortMethodsTest.java Reviewed-by: phh Backport-of: db9dcbd63b412cbc9cbbf537585b63a5ccbe8d46 - hotspot/test/runtime/6925573/SortMethodsTest.java Changeset: 710481f9 Branch: master Author: sendaoYan Committer: Paul Hohensee Date: 2023-08-09 16:15:58 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/710481f9da9ed5253ed8db02320bd38e551caf46 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException Reviewed-by: phh Backport-of: eccfec498d4062b582282f3b73bba84206a36046 ! jdk/test/java/net/MulticastSocket/Promiscuous.java Changeset: ab2d4274 Branch: master Author: Sergey Bylokhov Date: 2023-08-09 16:47:05 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/ab2d4274459fe503bded639de5e8b80aca056454 8232225: Rework the fix for JDK-8071483 Reviewed-by: phh Backport-of: e4b73897adf47467461634ceb786540f46aa9eb7 = jdk/test/java/awt/ColorClass/HeadlessColor.java = jdk/test/java/awt/ColorClass/OpacityChange/OpacityChange.java = jdk/test/java/awt/color/GetMinMaxValue_ICC_ColorSpace.java = jdk/test/java/awt/color/ICC_Profile/GetInstanceBrokenStream.java = jdk/test/java/awt/color/LoadProfileWithSM.java = jdk/test/java/awt/color/LoadStandardProfilesTest.java Changeset: 86ea3f25 Branch: master Author: Severin Gehwolf Date: 2023-08-11 08:50:49 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/86ea3f25b6b288919788d4ec99ff4cc0bab81413 8308788: [8u] Remove duplicate HaricaCA.java test Reviewed-by: phh, andrew - jdk/test/jdk/security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java Changeset: 949d8e77 Branch: master Author: Severin Gehwolf Date: 2023-08-11 08:57:39 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/949d8e7783112977b644294620585513b7d63ae7 8287073: NPE from CgroupV2Subsystem.getInstance() Reviewed-by: andrew Backport-of: 744b822ab194a0f7ef4e7a4053be32c6a0889efc ! jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java Changeset: 5f62e559 Branch: master Author: Alexey Bakhtin Date: 2023-08-11 23:01:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5f62e559fb5040c5d0021de4c3ee49e6fca6b087 6722928: Provide a default native GSS-API library on Windows Reviewed-by: phh, andrew Backport-of: 475996adc2aaa7af920f2e9711d0ace2ddd2430e ! jdk/make/lib/SecurityLibraries.gmk ! jdk/src/share/classes/sun/security/jgss/spnego/NegTokenTarg.java ! jdk/src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c ! jdk/src/share/native/sun/security/jgss/wrapper/NativeFunc.h ! jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h ! jdk/src/share/native/sun/security/jgss/wrapper/gssapi.h + jdk/src/windows/native/sun/security/jgss/sspi_bridge/sspi.cpp Changeset: 04f09bc9 Branch: master Author: Andrew John Hughes Date: 2025-06-18 16:52:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/04f09bc94d3784a1a45ba2cdae6a399384690a5b Merge jdk8u392-b02 Added tag jdk8u392-b02 for changeset 5f62e559fb5040c5d0021de4c3ee49e6fca6b087 From andrew at openjdk.org Thu Jun 19 23:13:39 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 19 Jun 2025 23:13:39 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u392-b02 for changeset 04f09bc9 Message-ID: <25e07d2e-701e-4e26-b343-2d2e39afb3a7@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-18 17:37:21 +0000 Added tag shenandoah8u392-b02 for changeset 04f09bc94d3 Changeset: 04f09bc9 Author: Andrew John Hughes Date: 2025-06-18 16:52:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/04f09bc94d3784a1a45ba2cdae6a399384690a5b From andrew at openjdk.org Thu Jun 19 23:13:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 19 Jun 2025 23:13:36 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u392-b02 for changeset 5f62e559 Message-ID: <8cca7071-2046-4108-b7ed-ff488429e6bd@openjdk.org> Tagged by: Andrew John Hughes Date: 2023-08-14 14:21:48 +0000 Added tag jdk8u392-b02 for changeset 5f62e559fb5040c5d0021de4c3ee49e6fca6b087 Changeset: 5f62e559 Author: Alexey Bakhtin Date: 2023-08-11 23:01:00 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/5f62e559fb5040c5d0021de4c3ee49e6fca6b087 From andrew at openjdk.org Thu Jun 19 23:15:30 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 19 Jun 2025 23:15:30 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u392-b02 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/53/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/53/files/04f09bc9..04f09bc9 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=53&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=53&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/53.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/53/head:pull/53 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/53 From iris at openjdk.org Thu Jun 19 23:15:31 2025 From: iris at openjdk.org (Iris Clark) Date: Thu, 19 Jun 2025 23:15:31 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 16:39:38 GMT, Andrew John Hughes wrote: > Merge jdk8u392-b02 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/53 From andrew at openjdk.org Fri Jun 20 00:23:24 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 00:23:24 GMT Subject: RFR: Merge jdk8u:master Message-ID: <87rnRh5R5GLkgdcsg_HTXZIp1BW09MGQcqCviUPkHbE=.9607c45f-a52a-4cb9-9f85-383f2bd9cace@github.com> Merge jdk8u392-b03 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u392-b03 - 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal - 8287663: Add a regression test for JDK-8287073 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=54&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=54&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/54/files Stats: 37 lines in 3 files changed: 35 ins; 1 del; 1 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/54.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/54/head:pull/54 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/54 From andrew at openjdk.org Fri Jun 20 00:26:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 00:26:45 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 3 new changesets Message-ID: <06f6e57d-c4a1-4ef8-be44-73dfc3c0a639@openjdk.org> Changeset: fc379423 Branch: master Author: Severin Gehwolf Date: 2023-08-14 07:23:21 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/fc379423b48eef9d6aee2a0cda7c87353dd31f71 8287663: Add a regression test for JDK-8287073 Reviewed-by: phh, andrew Backport-of: 2d8c6490540e3ccea23b81129b2e4073915071e0 ! jdk/src/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java ! jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java Changeset: 32324003 Branch: master Author: Ben Taylor Committer: Paul Hohensee Date: 2023-08-16 18:14:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3232400385ca3797247bfba20a54616cf893c50f 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal Removed runtime/6925573/SortMethodsTest.java from TEST.groups Reviewed-by: sgehwolf Backport-of: 3e6986fb58400193cf02ce4566afcf8bd24b92de ! hotspot/test/TEST.groups Changeset: 1e655291 Branch: master Author: Andrew John Hughes Date: 2025-06-20 00:12:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1e6552911d470f18352461612fb03f1f5ea946e5 Merge jdk8u392-b03 Added tag jdk8u392-b03 for changeset 3232400385c ! hotspot/test/TEST.groups ! hotspot/test/TEST.groups From andrew at openjdk.org Fri Jun 20 00:26:54 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 00:26:54 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u392-b03 for changeset 32324003 Message-ID: Tagged by: Andrew John Hughes Date: 2023-08-23 04:34:15 +0000 Added tag jdk8u392-b03 for changeset 3232400385c Changeset: 32324003 Author: Ben Taylor Committer: Paul Hohensee Date: 2023-08-16 18:14:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/3232400385ca3797247bfba20a54616cf893c50f From andrew at openjdk.org Fri Jun 20 00:26:57 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 00:26:57 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u392-b03 for changeset 1e655291 Message-ID: <77f217d2-3c7e-4cd1-8469-b7ddcc70af3a@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-20 01:17:38 +0000 Added tag shenandoah8u392-b03 for changeset 1e6552911d4 Changeset: 1e655291 Author: Andrew John Hughes Date: 2025-06-20 00:12:44 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/1e6552911d470f18352461612fb03f1f5ea946e5 From andrew at openjdk.org Fri Jun 20 00:27:55 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 00:27:55 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: <87rnRh5R5GLkgdcsg_HTXZIp1BW09MGQcqCviUPkHbE=.9607c45f-a52a-4cb9-9f85-383f2bd9cace@github.com> References: <87rnRh5R5GLkgdcsg_HTXZIp1BW09MGQcqCviUPkHbE=.9607c45f-a52a-4cb9-9f85-383f2bd9cace@github.com> Message-ID: > Merge jdk8u392-b03 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/54/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/54/files/1e655291..1e655291 Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=54&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=54&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/54.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/54/head:pull/54 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/54 From iris at openjdk.org Fri Jun 20 00:27:55 2025 From: iris at openjdk.org (Iris Clark) Date: Fri, 20 Jun 2025 00:27:55 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: <87rnRh5R5GLkgdcsg_HTXZIp1BW09MGQcqCviUPkHbE=.9607c45f-a52a-4cb9-9f85-383f2bd9cace@github.com> References: <87rnRh5R5GLkgdcsg_HTXZIp1BW09MGQcqCviUPkHbE=.9607c45f-a52a-4cb9-9f85-383f2bd9cace@github.com> Message-ID: On Fri, 20 Jun 2025 00:18:21 GMT, Andrew John Hughes wrote: > Merge jdk8u392-b03 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/54 From shade at openjdk.org Fri Jun 20 08:50:29 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 20 Jun 2025 08:50:29 GMT Subject: RFR: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed In-Reply-To: References: Message-ID: <0L1NcCsN1AEMFQspK2dasofKoZ24YaP12PIgjxO9lHg=.ef2e6083-db79-47c7-8684-98204d9a270f@github.com> On Thu, 19 Jun 2025 20:21:35 GMT, William Kemper wrote: > Shenandoah captures a preliminary top-at-mark-start (TAMS) concurrently. Once concurrent marking has begun, any object beneath TAMS requires a barrier when accessed. The implementation of `ShenandoahHeap::requires_barrier` does not distinguish between _old_ and _young_ marking. This could lead to a race between freezing the stack and capturing TAMS: > > 1. Collector is marking old > 2. Allocate stack chunk in young > 3. Barrier is not needed, begin fast freeze path > 4. Collector concurrently updates TAMS (young marking will start once init-mark safepoint is reached) > 5. ShenandoahHeap now thinks the barrier is needed (because TAMS changed, and we are marking old) > 6. Fast freeze asserts out > > This fix has the generational mode check the appropriate generation and its marking state. It also enforces barriers for stackChunks in the old generation (for card marking). This makes sense. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25905#pullrequestreview-2945074807 From mdoerr at openjdk.org Fri Jun 20 09:01:29 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 20 Jun 2025 09:01:29 GMT Subject: RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v8] In-Reply-To: <2gdPUDg-i40xRoO8LZPWszL2-oa6s7GNZEDRfHfDk8s=.4dbfe74a-070b-46c1-b73d-0292824d02e9@github.com> References: <2gdPUDg-i40xRoO8LZPWszL2-oa6s7GNZEDRfHfDk8s=.4dbfe74a-070b-46c1-b73d-0292824d02e9@github.com> Message-ID: On Tue, 17 Jun 2025 20:59:46 GMT, Dean Long wrote: >> This PR removes patching of the verified entry point and related code, and replaces it by refactoring the existing nmethod entry barrier. >> >> We used to patch the verified entry point to make sure it was not_entrant. The patched entry point then redirected to SharedRuntime::handle_wrong_method(), either directly with a jump to a stub, or indirectly with an illegal instruction and the help of the signal handler. The not_entrant state is a final state, so once an nmethod becomes not_entrant, it stays not_entrant. We can do the same thing with a permanently armed nmethod entry barrier. >> >> The solution I went with reserves one bit of the entry barrier guard value. This bit must remain set, so I call it a "sticky" bit. Setting the guard value now is effectively like setting a bitfield, so I needed to add a lock around it. The alternative would be to change the platform-specific code to do compare-and-swap. >> >> For the lock, I introduced a new NMethodEntryBarrier_lock, whose only purpose is to make the update to the guard value atomic. For ZGC, I decided to use the existing per-nmethod lock ZNMethod::lock_for_nmethod(). I suspect we could do the same for Shenandoah, if needed for performance. >> >> This change also makes it a bit clearer that the nmethod entry barrier effectively has two levels. Level 0 is the outer level or layer controlled by BarrierSetNMethod::nmethod_stub_entry_barrier(), and the inner layer controlled by BarrierSetNMethod::nmethod_entry_barrier(). This could be generalized if we decide we need more flavors of entry barriers. The inner barrier is mostly ignorant of the fact that the outer guard is multiplexing for both levels. > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > 2nd try at arm fix > > Tests look good on our side. I'm only a bit concerned that the lock may become a bottleneck when many Java threads need to patch all nmethods. Especially with ZGC which does that more often. I think we should check performance. > > For ZGC I am using a per-nmethod lock: ZLocker locker(ZNMethod::lock_for_nmethod(nm)); Ah, right. So, ZGC should be fine. > I don't know what benchmarks to run to check the performance for functions like Deoptimization::deoptimize_all_marked, so I welcome any help with this. I have tried some SPEC benchmarks with G1 on PPC64, but couldn't observe a regression. (If there is one, it was below noise.) > One possible optimization that might help is skipping the lock if the make_not_entrant call is done during a safepoint. I guess the most critical scenario is when many Java threads need to disarm a large number of nmethod entry barriers. That doesn't happen at a safepoint. Not sure if other scenarios are worth optimizing by this idea. I guess this PR is ok as it is. Maybe other reviewers have more comments. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25764#issuecomment-2990348628 From andrew at openjdk.org Fri Jun 20 11:48:32 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 11:48:32 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u392-b04 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u392-b04 - 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" - 8202952: C2: Unexpected dead nodes after matching The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=55&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=55&range=00.1 Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/55/files Stats: 72 lines in 3 files changed: 69 ins; 0 del; 3 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/55.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/55/head:pull/55 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/55 From andrew at openjdk.org Fri Jun 20 11:59:41 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 11:59:41 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 3 new changesets Message-ID: <01d58a99-62e5-4829-b0ca-609b7d594106@openjdk.org> Changeset: aa3e9dda Branch: master Author: Dongbo He Committer: Severin Gehwolf Date: 2023-08-24 12:47:59 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/aa3e9dda3d733508ad8bcd6e290f716b189141d4 8202952: C2: Unexpected dead nodes after matching Reviewed-by: roland, andrew Backport-of: 50e3aa4150dc1dd18870c5725666188ab38ab7d5 ! hotspot/src/share/vm/opto/matcher.cpp + hotspot/test/compiler/c2/TestMatcherLargeOffset.java Changeset: f9292695 Branch: master Author: Xin Liu Committer: Paul Hohensee Date: 2023-08-24 17:49:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f92926955791c810469e412927f58f2ca634fe4b 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" Reviewed-by: phh, serb, andrew Backport-of: 248778d27a5f8a16e4c90a4f5a6632a7ca8e9a89 ! jdk/src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java Changeset: 45b730ed Branch: master Author: Andrew John Hughes Date: 2025-06-20 01:38:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/45b730ed92a45af360cfbaf1742bf21723157d63 Merge jdk8u392-b04 Added tag jdk8u392-b04 for changeset f92926955791c810469e412927f58f2ca634fe4b ! hotspot/src/share/vm/opto/matcher.cpp ! hotspot/src/share/vm/opto/matcher.cpp From andrew at openjdk.org Fri Jun 20 11:59:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 11:59:50 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u402-b00 for changeset f9292695 Message-ID: Tagged by: Andrew John Hughes Date: 2023-10-31 18:48:18 +0000 Added tag jdk8u402-b00 for changeset f9292695579 Changeset: f9292695 Author: Xin Liu Committer: Paul Hohensee Date: 2023-08-24 17:49:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f92926955791c810469e412927f58f2ca634fe4b From andrew at openjdk.org Fri Jun 20 11:59:54 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 11:59:54 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u402-b00 for changeset 45b730ed Message-ID: Tagged by: Andrew John Hughes Date: 2025-06-20 12:41:30 +0000 Added tag shenandoah8u402-b00 for changeset 45b730ed92a Changeset: 45b730ed Author: Andrew John Hughes Date: 2025-06-20 01:38:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/45b730ed92a45af360cfbaf1742bf21723157d63 From andrew at openjdk.org Fri Jun 20 11:59:58 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 11:59:58 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag jdk8u392-b04 for changeset f9292695 Message-ID: Tagged by: Andrew John Hughes Date: 2023-08-30 01:10:17 +0000 Added tag jdk8u392-b04 for changeset f92926955791c810469e412927f58f2ca634fe4b Changeset: f9292695 Author: Xin Liu Committer: Paul Hohensee Date: 2023-08-24 17:49:18 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/f92926955791c810469e412927f58f2ca634fe4b From andrew at openjdk.org Fri Jun 20 12:00:04 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 12:00:04 GMT Subject: git: openjdk/shenandoah-jdk8u: Added tag shenandoah8u392-b04 for changeset 45b730ed Message-ID: <6da83c15-4deb-4547-ab02-bbb6d9db1544@openjdk.org> Tagged by: Andrew John Hughes Date: 2025-06-20 12:41:10 +0000 Added tag shenandoah8u392-b04 for changeset 45b730ed92a Changeset: 45b730ed Author: Andrew John Hughes Date: 2025-06-20 01:38:02 +0000 URL: https://git.openjdk.org/shenandoah-jdk8u/commit/45b730ed92a45af360cfbaf1742bf21723157d63 From andrew at openjdk.org Fri Jun 20 12:02:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 12:02:19 GMT Subject: RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge jdk8u392-b04 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/shenandoah-jdk8u/pull/55/files - new: https://git.openjdk.org/shenandoah-jdk8u/pull/55/files/45b730ed..45b730ed Webrevs: - full: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=55&range=01 - incr: https://webrevs.openjdk.org/?repo=shenandoah-jdk8u&pr=55&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/55.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/55/head:pull/55 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/55 From iris at openjdk.org Fri Jun 20 12:02:19 2025 From: iris at openjdk.org (Iris Clark) Date: Fri, 20 Jun 2025 12:02:19 GMT Subject: Withdrawn: Merge jdk8u:master In-Reply-To: References: Message-ID: On Fri, 20 Jun 2025 11:43:11 GMT, Andrew John Hughes wrote: > Merge jdk8u392-b04 > > GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/shenandoah-jdk8u/pull/55 From wkemper at openjdk.org Fri Jun 20 17:10:34 2025 From: wkemper at openjdk.org (William Kemper) Date: Fri, 20 Jun 2025 17:10:34 GMT Subject: Integrated: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed In-Reply-To: References: Message-ID: On Thu, 19 Jun 2025 20:21:35 GMT, William Kemper wrote: > Shenandoah captures a preliminary top-at-mark-start (TAMS) concurrently. Once concurrent marking has begun, any object beneath TAMS requires a barrier when accessed. The implementation of `ShenandoahHeap::requires_barrier` does not distinguish between _old_ and _young_ marking. This could lead to a race between freezing the stack and capturing TAMS: > > 1. Collector is marking old > 2. Allocate stack chunk in young > 3. Barrier is not needed, begin fast freeze path > 4. Collector concurrently updates TAMS (young marking will start once init-mark safepoint is reached) > 5. ShenandoahHeap now thinks the barrier is needed (because TAMS changed, and we are marking old) > 6. Fast freeze asserts out > > This fix has the generational mode check the appropriate generation and its marking state. It also enforces barriers for stackChunks in the old generation (for card marking). This pull request has now been integrated. Changeset: 17cf4974 Author: William Kemper URL: https://git.openjdk.org/jdk/commit/17cf49746d0c289bdf779c974cdc84a3ab32ab4b Stats: 25 lines in 2 files changed: 25 ins; 0 del; 0 mod 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed Reviewed-by: kdnilsen, shade ------------- PR: https://git.openjdk.org/jdk/pull/25905 From wkemper at openjdk.org Fri Jun 20 18:52:39 2025 From: wkemper at openjdk.org (William Kemper) Date: Fri, 20 Jun 2025 18:52:39 GMT Subject: [jdk25] RFR: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed Message-ID: This is a low risk change that addresses an assertion failure when Shenandoah's generational mode is used with virtual threads. ------------- Commit messages: - Backport 17cf49746d0c289bdf779c974cdc84a3ab32ab4b Changes: https://git.openjdk.org/jdk/pull/25918/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25918&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357550 Stats: 25 lines in 2 files changed: 25 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25918.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25918/head:pull/25918 PR: https://git.openjdk.org/jdk/pull/25918 From wkemper at openjdk.org Fri Jun 20 21:03:24 2025 From: wkemper at openjdk.org (William Kemper) Date: Fri, 20 Jun 2025 21:03:24 GMT Subject: RFR: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed Message-ID: <6CpS7paFc6rwPgO3w-mYjZFyIt65qqqnHPLvomKt9qc=.903ed120-c65c-400f-918b-e9509dc1e083@github.com> Clean backport, low risk. ------------- Commit messages: - Backport 17cf49746d0c289bdf779c974cdc84a3ab32ab4b Changes: https://git.openjdk.org/shenandoah-jdk21u/pull/200/files Webrev: https://webrevs.openjdk.org/?repo=shenandoah-jdk21u&pr=200&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357550 Stats: 25 lines in 2 files changed: 25 ins; 0 del; 0 mod Patch: https://git.openjdk.org/shenandoah-jdk21u/pull/200.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/200/head:pull/200 PR: https://git.openjdk.org/shenandoah-jdk21u/pull/200 From wkemper at openjdk.org Fri Jun 20 21:10:03 2025 From: wkemper at openjdk.org (William Kemper) Date: Fri, 20 Jun 2025 21:10:03 GMT Subject: Integrated: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed In-Reply-To: <6CpS7paFc6rwPgO3w-mYjZFyIt65qqqnHPLvomKt9qc=.903ed120-c65c-400f-918b-e9509dc1e083@github.com> References: <6CpS7paFc6rwPgO3w-mYjZFyIt65qqqnHPLvomKt9qc=.903ed120-c65c-400f-918b-e9509dc1e083@github.com> Message-ID: On Fri, 20 Jun 2025 20:56:53 GMT, William Kemper wrote: > Clean backport, low risk. This pull request has now been integrated. Changeset: f5884b3a Author: William Kemper URL: https://git.openjdk.org/shenandoah-jdk21u/commit/f5884b3a5dcc921e83ac241b1fb5b91e5988af00 Stats: 25 lines in 2 files changed: 25 ins; 0 del; 0 mod 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed Backport-of: 17cf49746d0c289bdf779c974cdc84a3ab32ab4b ------------- PR: https://git.openjdk.org/shenandoah-jdk21u/pull/200 From andrew at openjdk.org Fri Jun 20 21:28:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Jun 2025 21:28:52 GMT Subject: RFR: Merge jdk8u:master Message-ID: Merge jdk8u392-b05 GHA builds will not work until [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) is merged in 8u462-b01 ------------- Commit messages: - Merge jdk8u392-b05 - Merge - 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/shenandoah-jdk8u/pull/56/files Stats: 127 lines in 3 files changed: 42 ins; 1 del; 84 mod Patch: https://git.openjdk.org/shenandoah-jdk8u/pull/56.diff Fetch: git fetch https://git.openjdk.org/shenandoah-jdk8u.git pull/56/head:pull/56 PR: https://git.openjdk.org/shenandoah-jdk8u/pull/56