RFR: 8357976: GenShen crash in swap_card_tables: Should be clean [v3]
Xiaolong Peng
xpeng at openjdk.org
Mon Jun 16 16:47:30 UTC 2025
On Thu, 12 Jun 2025 22:44:44 GMT, William Kemper <wkemper at openjdk.org> wrote:
> We don't want to clean the read table during init-mark because that's a safepoint. We can safely clean the read table concurrently because only the GC thread has access to it.
Thanks, we want to minimize the time at safepoint, I understand this part. My question was about swap_card_tables, I we don't have to do it at safepoint, we could move swap_card_tables out of the init-mark safepoint and move to close to mark_read_table_as_clean to make the code slight earlier to understand. @ysramakrishna also suggested this, I saw your attempt and rollback, thanks for the explanations.
It looks good to me.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25735#issuecomment-2977329569
More information about the shenandoah-dev
mailing list