RFR: JDK-8349077 : Rename GenerationCounters::update_all [v3]
Albert Mingkun Yang
ayang at openjdk.org
Tue Jun 17 08:28:09 UTC 2025
On Tue, 17 Jun 2025 08:14:47 GMT, Suchismith Roy <sroy at openjdk.org> wrote:
>> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077)
>>
>> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).
>>
>>
>>
>> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method.
>
> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
>
> - update capacity only for Generation counter
> - Revert "update_capacity exists"
>
> This reverts commit cf2d66d598d90f1343d1ad7a4f30607c3374a0f8.
Thanks for the revision.
I believe the one in `ZGenerationCounters` can be removed now.
void update_capacity(size_t capacity) {
update_all(capacity);
}
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25833#issuecomment-2979417249
More information about the shenandoah-dev
mailing list