RFR: JDK-8349077 : Rename GenerationCounters::update_all [v6]

Stefan Karlsson stefank at openjdk.org
Wed Jun 18 09:31:30 UTC 2025


On Tue, 17 Jun 2025 14:59:01 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077)
>> 
>> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).
>> 
>> 
>> 
>> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method.
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   g1Monitoring

src/hotspot/share/gc/z/zServiceability.cpp line 70:

> 68:   void update_capacity(size_t capacity) {
> 69:     update_all(capacity);
> 70:   }

Could you also delete line 67.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25833#discussion_r2154104691


More information about the shenandoah-dev mailing list