RFR: 8360707: Globally enumerate all blobs, stubs and entries
Vladimir Kozlov
kvn at openjdk.org
Mon Jun 30 20:49:39 UTC 2025
On Thu, 26 Jun 2025 15:58:31 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
> Use the blob, stub and entry declarations to generate a single global enumeration for all blobs, likewise for all stubs and all entries. Modify stub generators in shared runtime, c1 runtime, c2 runtime and stub generator subsystems and their clients to use those enumerations consistently.
src/hotspot/share/runtime/stubCodeGenerator.hpp line 109:
> 107: bool _print_code;
> 108: BlobId _blob_id;
> 109: protected:
Please return spacing for `protected:` line.
src/hotspot/share/runtime/stubCodeGenerator.hpp line 118:
> 116:
> 117: MacroAssembler* assembler() const { return _masm; }
> 118: BlobId blob_id() { return _blob_id; }
Align body of methods. May be move them to the left - I don't see why we have such big spacing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2175890898
PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2175887035
More information about the shenandoah-dev
mailing list