RFR: 8360707: Globally enumerate all blobs, stubs and entries
Vladimir Kozlov
kvn at openjdk.org
Mon Jun 30 21:01:41 UTC 2025
On Thu, 26 Jun 2025 15:58:31 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
> Use the blob, stub and entry declarations to generate a single global enumeration for all blobs, likewise for all stubs and all entries. Modify stub generators in shared runtime, c1 runtime, c2 runtime and stub generator subsystems and their clients to use those enumerations consistently.
I have few comments.
src/hotspot/share/runtime/stubRoutines.cpp line 235:
> 233: SharedRuntime::_jbyte_array_copy_ctr++; // Slow-path byte array copy
> 234: #endif // !PRODUCT
> 235: Copy::conjoint_jbytes_atomic(src, dest, count);
Why you removed leading spaces here and in the following methods?
src/hotspot/share/runtime/stubRoutines.cpp line 378:
> 376: #define RETURN_STUB_PARM(xxx_arraycopy, parm) { \
> 377: name = parm ? #xxx_arraycopy "_uninit": #xxx_arraycopy; \
> 378: return StubRoutines::xxx_arraycopy(parm); }
No need these spacing changes - it was fine.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26004#pullrequestreview-2972679521
PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2175920811
PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2175923345
More information about the shenandoah-dev
mailing list