RFR: 8351077: Shenandoah: Update comments in ShenandoahConcurrentGC::op_reset_after_collect
Y. Srinivas Ramakrishna
ysr at openjdk.org
Tue Mar 4 00:12:52 UTC 2025
On Mon, 3 Mar 2025 20:12:34 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:
> This is a trivial PR to update the code comments in ShenandoahConcurrentGC::op_reset_after_collect.
>
> After doing more test and analysis, we have a better understanding why reset bitmap of young gen after concurrent cycle may cause crash if there is pending old GC cycle to execute: When there is soft reference in old gen, but the referent is in young, reseting bitmap of young will cause wrong state of the soft reference, which may lead to expected cashes.
🚢
small suggested rewording, although what you have also works.
(I'll think some more about this to fully understand the context. Thanks.)
-------------
Marked as reviewed by ysr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23872#pullrequestreview-2655609678
More information about the shenandoah-dev
mailing list