RFR: 8350605: assert(!heap->is_uncommit_in_progress()) failed: Cannot uncommit bitmaps while resetting them [v3]

[William Kemper]

On Mon, 3 Mar 2025 23:40:25 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment tweak
>
> src/hotspot/share/gc/shenandoah/shenandoahUncommitThread.hpp line 65:
> 
>> 63:   // Iterate and uncommit eligible regions. Return the number of regions uncommitted.
>> 64:   // This operation may be interrupted if the GC calls `forbid_uncommit`.
>> 65:   size_t do_uncommit_work(double shrink_before, size_t shrink_until) const;
> 
> I'd document the semantics of the parameters too:
> 
> // Iterate over and uncommit eligible regions unless committed heap would fall below `shrink_until` <units: bytes?>.
> // A region is eligible if it's been empty for at least `shrink_before` <units: seconds?>
> // Returns the number of regions uncommitted. May be interrupted by `forbid_uncommit`.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23760#discussion_r1978440214