RFR: 8350898: Shenandoah: Eliminate final roots safepoint [v2]

[William Kemper]

On Tue, 4 Mar 2025 14:52:23 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Merge remote-tracking branch 'jdk/master' into eliminate-final-roots
>>  - Fix comments
>>  - Add whitespace at end of file
>>  - More detail for init update refs event message
>>  - Use timing tracker for timing verification
>>  - Merge remote-tracking branch 'jdk/master' into eliminate-final-roots
>>  - WIP: Fix up phase timings for newly concurrent final roots and init update refs
>>  - WIP: Combine satb transfer with state propagation, restore phase timing data
>>  - WIP: Transfer pointers out of SATB with a handshake
>>  - WIP: Clear weak roots flag concurrently
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGeneration.cpp line 458:
> 
>> 456: 
>> 457:   // Step 1. All threads need to 'complete' partially filled, thread local buffers. This
>> 458:   // is accomplished in ShenandoahConcurrentGC::complete_abbreviated_cycle using a Handshake
> 
> I think we're talking about "complete processing" of thread-local satb buffers.  To avoid confusion with tlab, maybe add satb to this comment.

Yes, good point.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23830#discussion_r1979884800