RFR: 8350566: NMT: add size parameter to MemTracker::record_virtual_memory_tag [v2]

[Afshin Zafari]

On Thu, 6 Mar 2025 10:23:54 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/cds/metaspaceShared.cpp line 1475:
>> 
>>> 1473:              (address)archive_space_rs.base() == base_address, "Sanity");
>>> 1474:       // Register archive space with NMT.
>>> 1475:       MemTracker::record_virtual_memory_tag(archive_space_rs.base(), archive_space_rs.size(), mtClassShared);
>> 
>> The pattern here is:
>> 
>> `something.base(), something.base.size()`
>> 
>> instead of doing this over and over again, why can't we just pass `something` to MemTracker::record_virtual_memory_tag() and let it figure out `base` and `size` itself?
>
> We could have an overload for `ReservedSpace`.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23770#discussion_r1983441505