RFR: 8350566: NMT: add size parameter to MemTracker::record_virtual_memory_tag [v2]

[Afshin Zafari]

On Thu, 6 Mar 2025 15:24:49 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ReservedSpace is accepted as param.
>
> Need to fix the build errors:
> 
> /home/runner/work/jdk/jdk/src/hotspot/share/nmt/memTracker.hpp:224:31: error: invalid use of incomplete type ‘const class ReservedSpace’
>   224 |     record_virtual_memory_tag(rs.base(), rs.size(), mem_tag);
>       |                               ^~
> In file included from /home/runner/work/jdk/jdk/src/hotspot/share/memory/allocation.cpp:28:
> /home/runner/work/jdk/jdk/src/hotspot/share/memory/metaspace.hpp:38:7: note: forward declaration of ‘class ReservedSpace’
>    38 | class ReservedSpace;
>       |       ^~~~~~~~~~~~~
> In file included from /home/runner/work/jdk/jdk/src/hotspot/share/memory/allocation.cpp:30:
> /home/runner/work/jdk/jdk/src/hotspot/share/nmt/memTracker.hpp:224:42: error: invalid use of incomplete type ‘const class ReservedSpace’
>   224 |     record_virtual_memory_tag(rs.base(), rs.size(), mem_tag);
>       |                                          ^~
> In file included from /home/runner/work/jdk/jdk/src/hotspot/share/memory/allocation.cpp:28:
> /home/runner/work/jdk/jdk/src/hotspot/share/memory/metaspace.hpp:38:7: note: forward declaration of ‘class ReservedSpace’
>    ... (rest of output omitted)

@gerard-ziemski and @jdksjolen, new reviews are needed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23770#issuecomment-2707346222