RFR: 8351444: Shenandoah: Class Unloading may encounter recycled oops [v2]

[Aleksey Shipilev]

On Mon, 10 Mar 2025 16:34:22 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 153:
>> 
>>> 151:   }
>>> 152: 
>>> 153:   assert(heap->is_concurrent_weak_root_in_progress(), "Must be doing weak roots now");
>> 
>> This does not ring true when final mark is cancelled, or am I missing something?
>
> There is a cancellation check just above this line.

Ah. Back when we wrote this code originally, we used GC state flags to figure out whether we really need to go into particular phases. But I guess cancellation check is OK too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23951#discussion_r1987909613