RFR: 8350898: Shenandoah: Eliminate final roots safepoint [v5]

[William Kemper]

On Tue, 18 Mar 2025 17:19:56 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment explaining use of _trashed_oops
>
> src/hotspot/share/gc/shenandoah/shenandoahClosures.hpp line 59:
> 
>> 57: //
>> 58: 
>> 59: class ShenandoahFlushSATBHandshakeClosure : public HandshakeClosure {
> 
> Maybe place the closure somewhere in shenandoahConcurrentGC.cpp, where it is used? Or is there a need to expose it on shenandoahClosures.hpp?

Ah, it is also used in `shenandoahConcurrentMark.cpp`: https://github.com/openjdk/jdk/pull/23830/files#diff-d5228ec0709dbd663da93db4cf13eac3b28015d90d0c4ef206a68b008dc1d429L215 (in fact, this is where I took it from 😉).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23830#discussion_r2001949346