RFR: 8352588: GenShen: Enabling JFR asserts when getting GCId

[Xiaolong Peng]

On Fri, 21 Mar 2025 19:09:46 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

> ### Root cause
> Shenandoah has its own way to generate gc id([link](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp#L234), [link](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/shenandoah/shenandoahController.hpp#L43)), but when it runs a specific GC cycle, it still use the default GCIdMark([link](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp#L389)) to generate a gc id and set it to NamedThread::_gc_id. Once the specific GC cycle finishes, the NamedThread::_gc_id is restored to the original value which is `undefined`, which causes the asserts when Enabling JFR, in release build it should cause invalid GC id in JFR.
> 
> ### Solution
> it is confusing that Shenandoah generates its own gc id but not use it for GC logging and JFR, the solution is fairly simple, the control thread just need inject gc id with GCIdMark(gc_id) it generates in `ShenandoahControlThread::run_service` and `ShenandoahGenerationalControlThread::run_gc_cycle`
> 
> In the test, I also noticed the value of gc_id generated by Shenandoah control thread starts from 1, which is different from the default behavior of GCIdMark which generates id starting from 0, this PR will also fix it.  
> 
> ### Test
> - [x] TEST=gc/shenandoah/TestWithLogLevel.java TEST_VM_OPTS="-XX:StartFlightRecording"
> - [ ] TEST=hotspot_gc_shenandoah

src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 137:

> 135:       // GC is starting, bump the internal gc count and set GCIdMark
> 136:       update_gc_count();
> 137:       GCIdMark gc_id_mark(static_cast<uint>(get_gc_id()));

static cast from size_t to uint here since GCIdMark use uint. 
If needed, I can change the data type of gc id and count in ShenandoahController to uint, but need to update more files.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24166#discussion_r2008389233