RFR: 8352588: GenShen: Enabling JFR asserts when getting GCId [v4]

[Xiaolong Peng]

On Mon, 24 Mar 2025 18:29:27 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   No need to calculate gc_id using gc_count
>
> src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp line 576:
> 
>> 574:             "At end of Concurrent Young GC";
>> 575:       if (_heap->collection_set()->has_old_regions()) {
>> 576:         mmu_tracker->record_mixed(gc_id());
> 
> Should these be `get_gc_count` now?

Shouldn't we always use gc id for  MMUTracker? Although the internal gc counter of Shenandoah is also fine here.

I'm ok to change it back to get_gc_count, but will also update the declaration of the relevant methods like below to make them consistent:


void record_global(size_t gc_count)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24166#discussion_r2010754634