RFR: 8352588: GenShen: Enabling JFR asserts when getting GCId [v4]

[Y. Srinivas Ramakrishna]

On Tue, 25 Mar 2025 23:20:28 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> @earthling-amzn : Is your concern that GC count is incremented concurrently by two different callers? If so, I'd have the atomic increment return the pre- or post-increment value as the case may be and have the caller use that in their mark label. (Question: do we have different Id's for young and a concurrent/interrupted old? -- I would imagine so, with the old carrying an older id, and each subsequent young getting a newer id).
>
> My concern was more that `ShenandoahController::_gc_id` hides a field in its base class `NamedThread::_gc_id`, but `ShenandoahController::_gc_id` starts from `1`, while `NamedThread::_gc_id` starts from `0`. I think this will be addressed in a separate PR. This PR has been simplified to only fix the root cause of the assertion failure.

ah, i see. Good point.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24166#discussion_r2013067152