RFR: 8356075: Support Shenandoah GC in JVMCI [v3]
Aleksey Shipilev
shade at openjdk.org
Mon May 5 17:03:47 UTC 2025
On Mon, 5 May 2025 16:55:36 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Graal does not need the Thread* argument, but the runtime code behind write_ref_pre() currently uses it. I agree, it does not look performance critical to pass it through. However, getting rid of it seems to blow the scope of this PR. I'd rather do this as a follow-up.
>
> Actually, I'd probably add the new entry for Graal without the Thread* argument now, and fix the others in a follow-up. Otherwise we need to deal with it on the Graal side again later once we change the entry points.
OK, but that follow-up risks changing the JVMCI interface _again_? How about we introduce:
static void write_barrier_pre(oopDesc* pre_val) {
write_ref_field_pre(pre_val, JavaThread::current());
}
...and then the follow-up purges the old `write_ref_field_pre`? The implementation might need to be in `.cpp`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25001#discussion_r2073820137
More information about the shenandoah-dev
mailing list