RFR: 8372566: Genshen: crash at ShenandoahScanRemembered::process_clusters after JDK-8371667
Xiaolong Peng
xpeng at openjdk.org
Fri Nov 28 16:59:51 UTC 2025
On Fri, 28 Nov 2025 16:54:14 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:
>> Maybe a comment would be helpful.
>
> Yes, you are right. With the refactor, the equivalent writing should be `req.type() == _alloc_shared_gc_old || req.type() == _alloc_shared_gc_promotion`, the new way is just bit more cleaner and slightly more efficient.
May be I should change it `if(!req.is_lab_alloc())`, we don't even need to use the type directly here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28521#discussion_r2572158823
More information about the shenandoah-dev
mailing list