RFR: 8370220: C2: rename methods and improve documentation around get_ctrl and idom lazy updating/forwarding of ctrl and idom via dead ctrl nodes [v9]

Emanuel Peter epeter at openjdk.org
Wed Oct 22 06:33:54 UTC 2025


> When working on https://github.com/openjdk/jdk/pull/27889, I was irritated by the lack of documentation and suboptimal naming.
> 
> Here, I'm doing the following:
> - Add more documentation, and improve it in other cases.
> - Rename "lazy" methods: "lazy" could indicate that we delay it somehow until later, but it is unclear what is delayed.
>   - `lazy_replace` -> `replace_ctrl_node_and_forward_ctrl_and_idom`
>   - `lazy_update` -> `install_lazy_ctrl_and_idom_forwarding`
> - Made some methods private, and added some additional asserts.
> 
> I'd be more than happy for even better names, and suggestions how to improve the documentation further :)
> 
> Related issues:
> https://github.com/openjdk/jdk/pull/27889
> https://github.com/openjdk/jdk/pull/15720

Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:

 - Merge branch 'JDK-8370220-get-ctrl-documentation' of https://github.com/eme64/jdk into JDK-8370220-get-ctrl-documentation
 - fix shenandoah replace for phis

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27892/files
  - new: https://git.openjdk.org/jdk/pull/27892/files/ac057395..44e808bb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27892&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27892&range=07-08

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/27892.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27892/head:pull/27892

PR: https://git.openjdk.org/jdk/pull/27892


More information about the shenandoah-dev mailing list