RFR: 8369068: GenShen: Generations still aren't reconciled assertion failure [v2]

[William Kemper]

On Wed, 22 Oct 2025 01:43:50 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
>> 
>>  - Merge remote-tracking branch 'jdk/master' into reduce-gc_generation-usage
>>  - Merge remote-tracking branch 'jdk/master' into reduce-gc_generation-usage
>>  - Remove _gc_generation from ShenandoahHeap
>>  - Little cleanup, remove one active generation usage
>>  - Merge remote-tracking branch 'jdk/master' into reduce-gc_generation-usage
>>  - Finish removing usages of gc_generation, start on reducing usages of active_generation
>>  - Fix build
>>  - Use existing _generation field instead of Heap::_gc_generation where possible
>>  - Only shenandoah vm operations participate in active/gc generation scheme
>
> src/hotspot/share/gc/shenandoah/shenandoahSTWMark.cpp line 152:
> 
>> 150:   StringDedup::Requests requests;
>> 151: 
>> 152:   // TODO: Why are we passing our own fields to our own method?
> 
> It's a method on our parent class which doesn't have a Terminator object handy.

I think it's mostly because other uses of this (public) method are from `MarkingTasks` which have a `Terminator` but not a `ShenandoahGeneration`. I deleted the TODO.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27703#discussion_r2453568818