RFR: 8377048: Shenandoah: shenandoahLock related improvments [v2]

Xiaolong Peng xpeng at openjdk.org
Wed Feb 4 00:31:09 UTC 2026


On Tue, 3 Feb 2026 18:38:31 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 912:
>> 
>>> 910: void ShenandoahRegionPartitions::assert_bounds() {
>>> 911:   shenandoah_assert_heaplocked();
>>> 912:   ShenandoahRebuildLocker locker(_free_set->rebuild_lock());
>> 
>> assert_bounds() often happens when we are not rebuilding the free set.  Not clear why you need to add this lock here.
>
> For this change, it is not needed, I peel the PR from the change to defer heap usage accounting re-computation in which the same lock is used when update&read heap usage  accounting data, this one is untented, I'll remove it.

I have removed it from the PR, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29543#discussion_r2761624262


More information about the shenandoah-dev mailing list