RFR: 8373595: A new ObjectMonitorTable implementation [v2]

Fredrik Bredberg fbredberg at openjdk.org
Wed Feb 4 15:00:39 UTC 2026


On Tue, 27 Jan 2026 06:33:46 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated all platforms after review comments
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 229:
> 
>> 227: 
>> 228:       // Save the mark, we might need it to extract the hash.
>> 229:       mov(rscratch2, t1_mark);
> 
> Using `rscratch2` here is a little bit scary as we call other MacroAssembler functions with the expectation of it being live. 
> 
> Guessing the `ldr`, `lea` and `increment` implementations are not likely to change anytime soon, but maybe it is worth a comment saying that we do not expect these to modify the state of `rscratch2`

Rewrote the code. Don't use `rscratch2` anymore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2764450323


More information about the shenandoah-dev mailing list