RFR: 8312116: GenShen: make instantaneous allocation rate triggers more timely [v29]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Feb 18 22:23:11 UTC 2026
On Tue, 17 Feb 2026 23:37:55 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve comments
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 138:
>
>> 136: }
>> 137:
>> 138: void ShenandoahAdaptiveHeuristics::compute_headroom_adjustment(size_t mutator_available) {
>
> No need for mutator_available as an argument and no need to compute byte_allocated_at_start_of_idle.
>
> Comment: if someone changes soft_max_capacity(), this should be called to recompute.
I've simplified implementation of compute_headroom_adjustment() and removed unnecessary argument.
I've added a call to compute_headroom_adjustment() when soft_max_capacity is changed.
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp line 123:
>
>> 121: void start_idle_span() override;
>> 122:
>> 123: // If old-generation marking finishes during an idle span and immediate old-generation garbage is identified, we will rebuild
>
> Maybe this is redundant with start_idle_span or not even necessary (since start_idle_span doesn't need bytes_available.
I've removed resume_idle_span().
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29039#discussion_r2824734749
PR Review Comment: https://git.openjdk.org/jdk/pull/29039#discussion_r2824735599
More information about the shenandoah-dev
mailing list