RFR: 8373595: A new ObjectMonitorTable implementation [v9]

Fredrik Bredberg fbredberg at openjdk.org
Sat Feb 21 20:29:43 UTC 2026


On Fri, 20 Feb 2026 12:45:42 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated for Erik
>
> src/hotspot/share/runtime/objectMonitorTable.cpp line 34:
> 
>> 32: #include "runtime/timerTrace.hpp"
>> 33: #include "runtime/trimNativeHeap.hpp"
>> 34: #include "utilities/concurrentHashTableTasks.inline.hpp"
> 
> I think you don't need to include this anymore.

True, I deleted it.

> src/hotspot/share/runtime/objectMonitorTable.cpp line 120:
> 
>> 118: 
>> 119: // -----------------------------------------------------------------------------
>> 120: // ConcurrentHashTable storing links from objects to ObjectMonitors
> 
> This ConcurrentHashTable is now not used , so this comment should be removed or rewritten to not have the name ConcurrentHashTable.
> 
> You say that it's concurrent in the big paragraph above so this comment is extra.

Deleted the comment.

> src/hotspot/share/runtime/synchronizer.hpp line 33:
> 
>> 31: #include "runtime/handles.hpp"
>> 32: #include "runtime/javaThread.hpp"
>> 33: #include "runtime/objectMonitorTable.hpp"
> 
> Small comment.  Why do you have to include objectMonitorTable.hpp here?

We don't. I moved this include line to all the platform files instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2836583237
PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2836582747
PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2836582366


More information about the shenandoah-dev mailing list