RFR: 8374789: C2: refactor GraphKit code that create AddP nodes for raw memory to use helper method [v7]

Guanqiang Han ghan at openjdk.org
Mon Feb 23 11:07:36 UTC 2026


On Thu, 19 Feb 2026 10:30:23 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Guanqiang Han has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust code style again
>
> src/hotspot/share/opto/memnode.cpp line 4937:
> 
>> 4935:     Compile* C = phase->C;
>> 4936:     addr = phase->transform(AddPNode::make_off_heap(addr,
>> 4937:                                                  phase->MakeConX(offset)) );
> 
> Could probably put on the same line:
> 
> Suggestion:
> 
>     addr = phase->transform(AddPNode::make_off_heap(addr, phase->MakeConX(offset)));

Hi @chhagedorn, I’ve made the change to combine the two lines. Please take a look. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29666#discussion_r2840256231


More information about the shenandoah-dev mailing list