RFR: 8374789: C2: refactor GraphKit code that create AddP nodes for raw memory to use helper method [v8]

Christian Hagedorn chagedorn at openjdk.org
Mon Feb 23 12:40:25 UTC 2026


On Mon, 23 Feb 2026 07:54:49 GMT, Guanqiang Han <ghan at openjdk.org> wrote:

>> This PR refactors GraphKit code that creates AddP nodes for raw memory to use a dedicated helper method. This avoids passing top() explicitly at call sites and improves readability.
>> 
>> Please review this change. Thanks!
>> 
>> **Test:** GHA
>
> Guanqiang Han has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8374789
>  - Merge two lines into one
>  - Adjust code style again
>  - Adjust code style
>  - Merge remote-tracking branch 'upstream/master' into 8374789
>  - adjust code style
>  - adjust code style
>  - Merge remote-tracking branch 'upstream/master' into 8374789
>  - Align properly
>  - Replace AddPNode constructor calls with static func
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/ea7b4dfe...3d07f2fe

Looks good, thanks for all the updates!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29666#pullrequestreview-3840831438


More information about the shenandoah-dev mailing list