RFR: 8377011: Shenandoah: assert_bounds should be only called when boundaries have changed [v2]
Kelvin Nilsen
kdnilsen at openjdk.org
Tue Feb 24 00:35:12 UTC 2026
On Tue, 10 Feb 2026 20:40:50 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> In the existing assert_bounds() implementation, I note that we assert the following:
>> 1. The left-most found empty region is >= _leftmosts_empty[]
>> 2. The right-most found empty region is <= _righmosts_empty[]
>
> We're trying to avoid the costs of "finding" the left-most and right-most empty regions, so that assert won't work here.
Sorry for the confusion here. I think we can still have these statements enforced here:
assert(leftmost(partition) == _max || membership(leftmost(partition)) == partition, "Left most boundry must be sane");
assert(rightmost(partition) == -1 || membership(rightmost(partition)) == partition, "Right most boundry must be sane");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29537#discussion_r2843788523
More information about the shenandoah-dev
mailing list