RFR: 8357471: GenShen: Share collector reserves between young and old [v25]

Kelvin Nilsen kdnilsen at openjdk.org
Thu Jan 8 16:02:47 UTC 2026


On Wed, 7 Jan 2026 22:14:15 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix confusing comment
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahGenerationalHeuristics.cpp line 178:
> 
>> 176:     bool need_to_finalize_mixed = false;
>> 177:     if (_generation->is_young()) {
>> 178:       need_to_finalize_mixed = heap->old_generation()->heuristics()->prime_collection_set(collection_set);
> 
> We could push this logic for young collections down into `ShenandoahYoungHeuristics::choose_collection_set_from_regiondata` where `_generation` is always `ShenandoahYoungGeneration`.

Good catch.  Thanks for this suggestion.  Much cleaner.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25357#discussion_r2672932077


More information about the shenandoah-dev mailing list