RFR: 8369048: GenShen: Defer ShenFreeSet::available() during rebuild [v5]

William Kemper wkemper at openjdk.org
Tue Jan 13 22:21:02 UTC 2026


On Mon, 12 Jan 2026 21:43:57 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> This code introduces a new rebuild-freeset lock for purposes of coordinating the freeset rebuild activities and queries as to memory available for allocation in the mutator partition.
>> 
>> This addresses a problem that results if available memory is probed while we are rebuilding the freeset.
>> 
>> Rather than using the existing global heap lock to synchronize these activities, a new more narrowly scoped lock is introduced.  This allows the available memory to be probed even when other activities hold the global heap lock for reasons other than rebuilding the freeset, such as when they are allocating memory.  It is known that the global heap lock is heavily contended for certain workloads, and using this new lock avoids adding to contention for the global heap lock.
>
> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Use appropriate locks for ShenFreeSet used() and capacity()
>  - Revert "Add rebuild synchronization to capacity() and used()"
>    
>    This reverts commit 3c29dc10b17f1856203135a31b75c3afea16ba50.

GHA failure looks unrelated to these changes. Internal tests are succeeding.

-------------

Marked as reviewed by wkemper (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27612#pullrequestreview-3658154746


More information about the shenandoah-dev mailing list