RFR: 8312116: GenShen: make instantaneous allocation rate triggers more timely [v4]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jan 14 22:36:53 UTC 2026


On Thu, 8 Jan 2026 21:27:57 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 65 commits:
>> 
>>  - Fix comment
>>  - Use PROPERFMT macros
>>  - Simplify code flow: reviewer suggestion
>>  - Merge remote-tracking branch 'jdk/master' into accelerated-triggers
>>  - Remove develop/debug instrumentation
>>  - add another override
>>  - Change type of command-line args
>>  - fix white space
>>  - Add override to virtual methods
>>  - Fix race between allocation reporting and querying
>>  - ... and 55 more: https://git.openjdk.org/jdk/compare/dd20e915...7f3a6d1e
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 134:
> 
>> 132:   if (_is_generational) {
>> 133:     _regulator_thread = ShenandoahGenerationalHeap::heap()->regulator_thread();
>> 134:     size_t young_available = ShenandoahGenerationalHeap::heap()->young_generation()->max_capacity() -
> 
> Consider pushing this down into `ShenandoahGenerationalHeuristics`

Most recent commit has this change.  It's a bit clumsy.  Feel free to guide further.  (I'm not real happy with making direct call to super of super class from ShenandoahGenerationalHeuristics.  What do you think?)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29039#discussion_r2692303227


More information about the shenandoah-dev mailing list