RFR: 8353115: GenShen: mixed evacuation candidate regions need accurate live_data (Original revision)
William Kemper
wkemper at openjdk.org
Fri Jan 16 21:00:35 UTC 2026
On Thu, 8 Jan 2026 21:05:36 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
> This is the originally proposed PR to address https://bugs.openjdk.org/browse/JDK-8353115
> At the time this proposed PR was reviewed, a suggestion for refactoring was proposed and explored, resulting in https://github.com/openjdk/jdk/pull/24319
>
> Though the refactored implementation may have some desirable characteristics, this original implementation appears to have better performance.
>
> The existing implementation of get_live_data_bytes() and git_live_data_words() does not always behave as might be expected. In particular, the value returned ignores any allocations that occur subsequent to the most recent mark effort that identified live data within the region. This is typically ok for young regions, where the amount of live data determines whether a region should be added to the collection set during the final-mark safepoint.
>
> However, old-gen regions that are placed into the set of candidates for mixed evacuation are more complicated. In particular, by the time the old-gen region is added to a mixed evacuation, its live data may be much larger than at the time concurrent old marking ended.
>
> This PR provides comments to clarify the shortcomings of the existing functions, and adds new functions that provide more accurate accountings of live data for mixed-evacuation candidate regions.
LGTM, sorry for the churn.
-------------
Marked as reviewed by wkemper (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29127#pullrequestreview-3672702229
More information about the shenandoah-dev
mailing list