Additional use of the exclude/package list for Jakarta EE TCK signature checking...

Scott Marlow smarlow at redhat.com
Thu Jan 28 19:25:56 UTC 2021


Hi,

I would like to make additional use of the exclude/package list (via 
SigTest#isPackageMember check or something like that) in the 
SignatureTest (or optionally add JakartaSignatureTest class).  I would 
also like to make additional use of the exclude/package list in classes 
{ ClassHierarchyImpl, MemberCollectionBuilder } as shown in sigtest pull 
request [1].

As mentioned my previous (newbie) email thread, this is to help the 
Jakarta EE Platform TCKs to be able to pass on newer Java SE versions 
than the base Java SE version that a Jakarta EE release is targeted 
for.  This issue is described in more detail of the jakartaee-tck issue 
156 [2].

Questions:

 1. Could the JDK SigTest project still work correctly (for JDK project
    use) if SigTest#isPackageMember is called from
    ClassHierarchyImpl#findSuperclasses,
    MemberCollectionBuilder#addInherited,
    MemberCollectionBuilder#addInheritedFromInterfaces in the same
    places you can see the "java" + "javax" package checks hacked in [1]?
 2. Would it make sense to add a new (Package) interface that implements
    SigTest#isPackageMember that an instance of could be made available
    to the above mentioned calls in #1?
 3. Would it make sense to add a new option to enable the changes
    mentioned in #1 and such option would be disabled by default?

Scott

[1] https://github.com/openjdk/sigtest/pull/2
[2] https://github.com/eclipse-ee4j/jakartaee-tck/issues/156



More information about the sigtest-dev mailing list