Proposed revised format for JDK commit messages

Erik Helin erik.helin at oracle.com
Mon Sep 17 13:33:24 UTC 2018


On 9/17/18 6:27 AM, joe darcy wrote:
> One possibility is:
> 
>    ProposedJdkGitCommitMessage : BugIdLine+ BlankLine SummaryLine? 
> ReviewersLine CoAuthorsLine+
> 
>    BugIdLine : /[0-9]{8}/ ": " Text
> 
>    SummaryLine : "Summary: " Text

This is actually SummaryLines, you can have as many summary lines as you 
want :) Furthermore, the "Summary:" prefix is not needed, the summary 
lines will always be surrounded by blank lines. My EBNF is a bit rusty, 
but I think the above paragraph would be expressed as:

SummaryLines: (Text)+ "\n"

>    ReviewersLine : "Reviewed-by: " Username (", " Username)* "\n"
> 
>    ContributedByLine : "Contributed-by: " Text
> 
>    BlankLine = "\n"
> 
>    Username : /[a-z]+/
> 
>    Text : /[^\n]+/ "\n"

Thanks,
Erik


More information about the skara-dev mailing list