Proposed revised format for JDK commit messages

Erik Helin erik.helin at
Wed Sep 19 13:11:41 UTC 2018

On 09/19/2018 10:30 AM, Alan Bateman wrote:
> On 19/09/2018 08:20, Per Liden wrote:
>> It would feel natural to have all *-by lines follow the same syntax. 
>> The Reviewed-by line sticks out in this regard. Is there a reason why 
>> we don't just do:
>> Reviewed-by: Some Name < at>
>> Reviewed-by: Some Other Name < at>
>> ... and so on?
> I assume the names specified to the Reviewed-by line(s) will need to be 
> checked against the set of members of the project and their roles. I 
> don't know the details of the validation that is done today but it might 
> be less reliable to try to map anything other than their OpenJDK user name.

I don't have any strong opinion on whether to go with with one 
"Reviewed-by" line or multiple, I just want to point out that we _can_ 
go with multiple "Reviewed-by" lines if we want to. We can utilize what 
we already have done for the author field:

   "Real Name <username at>"

For an example have a look at [0], which has
"Per Liden <pliden at>" as the author. This way you know 
that this commit was done by an OpenJDK author and you also get their 
real name (please note that GitHub will not show the email address). 
Personally I also think it reads nicely, the commit was done by "Per 
Liden" who is also known as "pliden" on

The motivation for going with one line was because it is more concise 
and because reviewers must always be OpenJDK authors (every reviewer 
must have an OpenJDK username). For shorter commit messages, with a 
single author and one to two reviewers, this becomes nice and succinct:

     8210283: Support git as an SCM alternative in the build

     Reviewed-by: ihse, ehelin

On the other hand I can see where Per is coming from for larger commits 
with multiple authors and potentially many reviewers. For those commits, 
having multiple "Reviewed-by" lines fit in well:

     8167108: inconsistent handling of SR_lock can lead to crashes

     Add Thread Safe Memory Reclamation (Thread-SMR) mechanism.

     Reviewed-by: Coleen Phillimore <coleenp at>
     Reviewed-by: Daniel Daugherty <dcubed at>
     Reviewed-by: David Holmes <dholmes at>
     Reviewed-by: Erik Osterlund <eosterlund at>
     Reviewed-by: Gerald Thornbrugh <gthornbr at>
     Reviewed-by: Kim Barrett <kbarrett at>
     Reviewed-by: Robbin Ehn <rehn at>
     Reviewed-by: Serguei Spitsyn <sspitsyn at>
     Reviewed-by: Stefan Karlsson <stefank at>
     Co-authored-by: Erik Osterlund <erik.osterlund at>
     Co-authored-by: Robbin Ehn <robbin.ehn at>
     Co-authored-by: Igor Ignatyev <igor.ignatyev at>

With these many reviewers, another benefit is that each individual line 
becomes shorter (even though there are more of them).

For making a decision here, it might be worthwhile to keep in mind that 
the vast majority of commits in jdk/jdk have a single author and one to 
two reviewers, that is by far the most common case.

Again, I don't have strong preference here, I just want to highlight 
what can be done.



More information about the skara-dev mailing list