RFR: Use the web url in the displayed fetch command

Erik Duveblad via github.com duke at openjdk.java.net
Wed Aug 7 09:40:54 UTC 2019


On Wed, 7 Aug 2019 07:40:00 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> Please review this small change that uses the already-filtered web url instead of the possibly-credentials-containing regular url in the fetch command shown in mails.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - ed5d6fc3:	Use the web url instead as it works fine for fetching as well, and is already correctly filtered
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/38
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/38/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/38.diff
> 
> Fetch command:
> git fetch https://github.com/openjdk/skara.git pull/38/head:pull/38

This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:

Looks good, thanks for fixing!

PR: https://git.openjdk.java.net/skara/pull/38


More information about the skara-dev mailing list