RFR: 22: Wrong lines for comments

Erik Duveblad via github.com duke at openjdk.java.net
Wed Aug 7 10:08:06 UTC 2019


On Wed, 7 Aug 2019 06:53:01 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> Please review the following change that translates the position field in a GitHub review comment into the actual line number, which is expected in our common API.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 967bd1b0:	Fix position mapping
>  - 01178ecb:	wip
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/37
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/37/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/37.diff
> 
> Fetch command:
> git fetch https://github.com/openjdk/skara.git pull/37/head:pull/37

This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:

Thanks for taking care of this issue, pretty cumbersome API from GitHub :disappointed: Ship it!

PR: https://git.openjdk.java.net/skara/pull/37


More information about the skara-dev mailing list