RFR: Improve testing of GitHub PositionMapper
Erik Duveblad via github.com
duke at openjdk.java.net
Wed Aug 14 15:20:49 UTC 2019
On Wed, 14 Aug 2019 08:42:55 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> Please review this test of the GitHub PositionMapper (which also found an off-by-one bug).
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - 760fd776: Improve testing of GitHub PositionMapper
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/43
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/43/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/43.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/43/head:pull/43
This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:
Looks good!
PR: https://git.openjdk.java.net/skara/pull/43
More information about the skara-dev
mailing list