RFR: Use ZonedDateTime for date in Commit

Robin Westberg via github.com duke at openjdk.java.net
Fri Aug 16 11:14:59 UTC 2019


On Fri, 16 Aug 2019 11:13:42 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi,
> 
> this patch changes from `Instant` to `ZonedDateTime` in `CommitMetadata`. This is done to preserve the time zone recorded in the underlying VCS commit (both git and hg store the time zone of the developer's machine in the commit).
> 
> # Testing
> - [x] `sh gradlew test` passes on Linux x86_64
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - 1d5b3cc7:	Use ZonedDateTime for date in Commit
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/48
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/48/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/48.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/48/head:pull/48

This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:

Looks good

PR: https://git.openjdk.java.net/skara/pull/48


More information about the skara-dev mailing list