RFR: Proper parsing of git diff --raw lines
Robin Westberg via github.com
duke at openjdk.java.net
Fri Aug 16 11:47:38 UTC 2019
On Fri, 16 Aug 2019 11:45:34 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
> On Fri, 16 Aug 2019 11:26:53 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
>
>> Hi,
>>
>> this patch introduces stricter (and more correct) parsing of the output from `git diff --raw`. The previous parsing code could not handle spaces in file names.
>>
>> ## Testing
>> - [x] `sh gradlew test`
>>
>> ----------------
>>
>> Commits:
>> - e95a4ccd: Proper parsing of git diff --raw lines
>>
>> Pull request:
>> https://git.openjdk.java.net/skara/pull/49
>>
>> Webrev:
>> https://webrevs.openjdk.java.net/skara/49/webrev.00
>>
>> Patch:
>> https://git.openjdk.java.net/skara/pull/49.diff
>>
>> Fetch command:
>> git fetch https://git.openjdk.java.net/skara pull/49/head:pull/49
>
> Robin only says "Ship it" to be polite, he did tell me to add a test, and so I did! Thanks @rwestberg for enforcing regression tests :+1:
>
> PR: https://git.openjdk.java.net/skara/pull/49
Even better!
PR: https://git.openjdk.java.net/skara/pull/49
More information about the skara-dev
mailing list