RFR: Fix webrev generation issue when a source hunk is empty
Erik Duveblad via github.com
duke at openjdk.java.net
Fri Aug 16 13:24:24 UTC 2019
On Fri, 16 Aug 2019 13:17:21 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> Please review this fix for an index-out-of-bounds when generating a webrev containing an empty source hunk.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - 7b7cfaf4: Fix webrev generation issue when a source hunk is empty, add a reproducing test
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/51
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/51/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/51.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/51/head:pull/51
This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:
Looks good, reviewed!
PR: https://git.openjdk.java.net/skara/pull/51
More information about the skara-dev
mailing list