RFR: git combined diffs suffer from underflow

Robin Westberg via github.com duke at openjdk.java.net
Fri Aug 16 14:15:41 UTC 2019


On Fri, 16 Aug 2019 14:12:18 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> seems like `git diff -c --unified=0` also suffers from underflow, but _not_ the off-by-one bug for empty hunks that `git diff --unified=0` suffers from. I updated the code to work around this issue.
> 
> ## Testing
> - [x] `sh gradlew test` passes on Linux x86_64
> 
> ----------------
> 
> Commits:
>  - 1a1813f7:	git combined diffs suffer from underflow
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/53
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/53/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/53.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/53/head:pull/53

This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:

Good stuff

PR: https://git.openjdk.java.net/skara/pull/53


More information about the skara-dev mailing list